Debian Bug report logs - #833472
aghermann: please make BUILT_BY reproducible (username, hostname)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Daniel Shahaf <danielsh@apache.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: aghermann: please make BUILT_BY reproducible (username, hostname)

Date: Thu, 04 Aug 2016 20:58:45 +0000

Source: aghermann
Version: 1.1.0-1
Severity: wishlist
Tags: upstream patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: username hostname

Dear Maintainer,

While working on the “reproducible builds” effort [1], we have noticed
that aghermann could not be built reproducibly:

    https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/aghermann.html
    │   │   │   │   │    0x004c5e00 41676865 726d616e 6e20312e 312e3020 Aghermann 1.1.0 
    │   │   │   │   │    0x004c5e10 6275696c 74204a75 6e203236 20323031 built Jun 26 201
    │   │   │   │   │    0x004c5e20 36203232 3a31323a 30302062 79207062 6 22:12:00 by pb
    │   │   │   │   │ -  0x004c5e30 75696c64 65723140 70726f66 69746272 uilder1@profitbr
    │   │   │   │   │ -  0x004c5e40 69636b73 2d627569 6c64312d 616d6436 icks-build1-amd6
    │   │   │   │   │ -  0x004c5e50 340a00                              4..
    │   │   │   │   │ +  0x004c5e30 75696c64 65723240 692d6361 70747572 uilder2@i-captur
    │   │   │   │   │ +  0x004c5e40 652d7468 652d686f 73746e61 6d650a00 e-the-hostname..

Following up on #828008, a second patch is attached to make BUILT_BY
deterministic.  It's written to accomodate vendor names having embedded
spaces, since deb-origin(5) implies such names are valid.

Cheers,

Daniel


diff --git a/debian/patches/reproducible.patch b/debian/patches/reproducible.patch
new file mode 100644
index 0000000..09f93e6
--- /dev/null
+++ b/debian/patches/reproducible.patch
@@ -0,0 +1,19 @@
+Description: Make the build reproducible
+  Eliminate needless, variable information.
+Author: Daniel Shahaf <danielsh@apache.org>
+Bug-Debian: https://bugs.debian.org/-1
+Last-Update: 2016-08-04
+Forwarded: not-needed
+
+--- a/configure.ac
++++ b/configure.ac
+@@ -190,7 +190,8 @@
+ fi
+ 
+ dnl Any private defines
+-AC_SUBST(user, [`whoami`@`hostname`])
++BUILT_BY="\"`dpkg-vendor --query vendor`\""
++AC_SUBST(user, [$BUILT_BY])
+ AC_SUBST(build_date, [`date --utc --date=@${SOURCE_DATE_EPOCH:-$(date +%s)} +"%F"`])
+ AC_SUBST(build_datetime, [`date --utc --date=@${SOURCE_DATE_EPOCH:-$(date +%s)}`])
+ 
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..038ee28
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+reproducible.patch

Message #10 received at 833472@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 833472@bugs.debian.org, 833472-submitter@bugs.debian.org

Subject: Re: aghermann: please make BUILT_BY reproducible (username, hostname)

Date: Thu, 04 Aug 2016 23:25:04 +0200

Hey,

  +-AC_SUBST(user, [`whoami`@`hostname`])
  ++BUILT_BY="\"`dpkg-vendor --query vendor`\""
  ++AC_SUBST(user, [$BUILT_BY])

TIL about dpkg-vendor, thanks! But alas, this means it cannot go upstream as it assumes dpkg, etc. Did you consider something like:

  --- a/debian/rules	2016-08-04 20:04:58.393277517 +0100
  --- b/debian/rules	2016-08-04 22:14:14.065476092 +0100
  @@ -2,6 +2,8 @@
   # -*- makefile -*-
 
   DPKG_EXPORT_BUILDFLAGS = 1
  +DEB_CXXFLAGS_MAINT_APPEND = -DBUILT_BY=\\\"aghermann@packages.debian.org\\\"
  +
   include /usr/share/dpkg/buildflags.mk
 
   %:


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #18 received at 833472@bugs.debian.org (full text, mbox, reply):

From: andrei zavada <johnhommer@gmail.com>

To: 833472@bugs.debian.org, Chris Lamb <lamby@debian.org>

Cc: 833472-submitter@bugs.debian.org

Subject: Re: Bug#833472: aghermann: please make BUILT_BY reproducible (username, hostname)

Date: Fri, 5 Aug 2016 00:31:58 +0300

[Message part 1 (text/plain, inline)]

I think I'd better rip these defines outright. Will push 1.1.1 in a few
days.

On 5 Aug 2016 00:27, "Chris Lamb" <lamby@debian.org> wrote:

> Hey,
>
>   +-AC_SUBST(user, [`whoami`@`hostname`])
>   ++BUILT_BY="\"`dpkg-vendor --query vendor`\""
>   ++AC_SUBST(user, [$BUILT_BY])
>
> TIL about dpkg-vendor, thanks! But alas, this means it cannot go upstream
> as it assumes dpkg, etc. Did you consider something like:
>
>   --- a/debian/rules    2016-08-04 20:04:58.393277517 +0100
>   --- b/debian/rules    2016-08-04 22:14:14.065476092 +0100
>   @@ -2,6 +2,8 @@
>    # -*- makefile -*-
>
>    DPKG_EXPORT_BUILDFLAGS = 1
>   +DEB_CXXFLAGS_MAINT_APPEND = -DBUILT_BY=\\\"aghermann@
> packages.debian.org\\\"
>   +
>    include /usr/share/dpkg/buildflags.mk
>
>    %:
>
>
> Regards,
>
> --
>       ,''`.
>      : :'  :     Chris Lamb
>      `. `'`      lamby@debian.org / chris-lamb.co.uk
>        `-
>

[Message part 2 (text/html, inline)]

Message #26 received at 833472@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: andrei zavada <johnhommer@gmail.com>, 833472@bugs.debian.org

Cc: 833472-submitter@bugs.debian.org

Subject: Re: Bug#833472: aghermann: please make BUILT_BY reproducible (username, hostname)

Date: Thu, 04 Aug 2016 23:54:32 +0200

andrei zavada wrote:

> I think I'd better rip these defines outright

Perfect :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #34 received at 833472@bugs.debian.org (full text, mbox, reply):

From: andrei zavada <johnhommer@gmail.com>

To: Yaroslav Halchenko <debian@onerussian.com>

Cc: 833472@bugs.debian.org

Subject: Re: upload aghermann-1.1.0, fix #824574 and #828008

Date: Fri, 5 Aug 2016 01:57:44 +0300

Hi Yaroslav,

It's me again, with aghermann Anniversary Edition (1.1.1) to finally
put to rest that reproducible build bug:
http://johnhommer.com/academic/code/aghermann/source/deb/aghermann_1.1.1-1.dsc.

Cheers,
Andrei

On 1 July 2016 at 20:35, Yaroslav Halchenko <debian@onerussian.com> wrote:
> Still enroute just on the phone... cheers
>
> On July 1, 2016 9:27:26 AM EDT, andrei zavada <johnhommer@gmail.com> wrote:
>>I am an reminder bot. Beep-beep!
>>
>>On 27 June 2016 at 14:35, Yaroslav Halchenko <debian@onerussian.com>
>>wrote:
>>> Will look into it in the evening (at ohbm atm)... if you don't hear
>>from me in 2 days - buzz plz
>>>
>>> On June 27, 2016 12:20:57 PM GMT+02:00, andrei zavada
>><johnhommer@gmail.com> wrote:
>>>>Hey Yaroslav,
>>>>
>>>>Here's a new version of aghermann (1.1.0), with fixes for #824574
>>>>(drop deprecated dependency on libunique) and #828008 (reproducible
>>>>builds done right), which I have posted here:
>>>>http://johnhommer.com/academic/code/aghermann/source/deb/aghermann_1.1.0-1.dsc.
>>>>
>>>>Cheers,
>>>>Andrei
>>>
>

Message #39 received at 833472-close@bugs.debian.org (full text, mbox, reply):

From: Andrei Zavada <johnhommer@gmail.com>

To: 833472-close@bugs.debian.org

Subject: Bug#833472: fixed in aghermann 1.1.1-1

Date: Thu, 25 Aug 2016 22:19:54 +0000

Source: aghermann
Source-Version: 1.1.1-1

We believe that the bug you reported is fixed in the latest version of
aghermann, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 833472@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andrei Zavada <johnhommer@gmail.com> (supplier of updated aghermann package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri,  5 Aug 2016 00:35:00 +0200
Source: aghermann
Binary: aghermann
Architecture: source amd64
Version: 1.1.1-1
Distribution: unstable
Urgency: low
Maintainer: Andrei Zavada <johnhommer@gmail.com>
Changed-By: Andrei Zavada <johnhommer@gmail.com>
Description:
 aghermann  - Sleep-research experiment manager
Closes: 833472
Changes:
 aghermann (1.1.1-1) unstable; urgency=low
 .
   * New upstream version (Closes: #833472).
Checksums-Sha1:
 c650400ae7cc182777d08fae6b2a5d27acec6eb9 2062 aghermann_1.1.1-1.dsc
 1c60e34500292656beb17e67b3dc8d7bbac2ce88 278612 aghermann_1.1.1.orig.tar.xz
 8a0f354ce77bde91b2444d45dae963858caf2707 4072 aghermann_1.1.1-1.debian.tar.xz
 c9ead3a1cfc4e3891bd15aafecc273b27528a230 11668384 aghermann-dbgsym_1.1.1-1_amd64.deb
 5b892eac05255dfefb7456848cd019e68fa97595 525434 aghermann_1.1.1-1_amd64.deb
Checksums-Sha256:
 9cbb4c3af2625130520a4dff6848f8ec160603c9b41d502236dca1fbd94980b1 2062 aghermann_1.1.1-1.dsc
 217d2b2d5db136a662bebbe58d712fe375556462ab4314625b4f58ed9deec657 278612 aghermann_1.1.1.orig.tar.xz
 07ad5df213c033f7c267cfa61daa51be916e61c347a085b5b55fca8dda7af22b 4072 aghermann_1.1.1-1.debian.tar.xz
 7676eb0bd76aa3e184f9fbfe4ea18b17b09c19a658b6426e3088eb705076ffa9 11668384 aghermann-dbgsym_1.1.1-1_amd64.deb
 46431fd2d4df599e0077cd46006c7e6a9e85ff96e92c2a985981cab4e54605ee 525434 aghermann_1.1.1-1_amd64.deb
Files:
 d6440590bf388660baad54dca11dff28 2062 science optional aghermann_1.1.1-1.dsc
 9627aea95b3fa746b1bbb71e86ce9cd6 278612 science optional aghermann_1.1.1.orig.tar.xz
 0169e26eb22fc5f1d731c67d6f65ab86 4072 science optional aghermann_1.1.1-1.debian.tar.xz
 1da9ddc87a982c743e020f161977d884 11668384 debug extra aghermann-dbgsym_1.1.1-1_amd64.deb
 a125322c8116105313991cd21e2b146d 525434 science optional aghermann_1.1.1-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXv23VAAoJEKLeI1Bi2jP6uVcP/AwwNgYO8fW6+6vjCJ+8t40p
wdCP+0A+zjEFBQ04UxoD/bVLBTb4O8gIqHLiZQQDK26UHH7G9r49CIEN4xQtqYKW
HEQ5j0xOihc8g/Vsr5jZYqHS2NHbUjsOE/HaayY9pN16Dy2hwuHTN+NjzBn3jz9O
6Jbd6IJH86YgFxt6ufIDFSiOptJZkQG1AhI4hSdiIyhG0cgm5M0KL4WnwWHFbp6D
Y0IW/ETU4TINzy05G1SwiqKwfGFqm/jZQj0NMTwCsbJ1V8HtUc+2RbYtQ4ew0Ju1
CJD20Q3xHDpmW0h6h+u79OdmO93AGKBgfgwbxurbt4wo6neAPhTtLXJeJYb0gWWv
49+2RWbNXmtCtyjhi31JjUIdAoKxvXHJCQDVeEw3j9Y6/epreNg+pSNN8gk4Wqk/
AKI3dbMMcIl3gsrn9Qad3wLpXL776X2/hAdcFZzIqasz9jkL2t6Nlfs0uJEAhFRf
nT9/uuPkAKDJvXOZI4Wh7ccSOgkiootVi07YcJo0hPSQHaHuhT6XCLAjeIbJN8bm
MLJzdj3dSyvPwCNmSTNaRR7zj3VDQAyojz/SgGCHJbZzHnJZtvfVF4Ks42+vgaIq
5jeuQQ4EhK88EbSSKPnc5rO2mTxLLPQ7772T/0Pw5pJBOXdr78wZbK7jTm1KK9T0
IWBq/nDqW+Ux4/pOM3GM
=68tv
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.