Debian Bug report logs - #833437
mp4h: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: mp4h: please make the build reproducible

Date: Thu, 04 Aug 2016 14:20:45 +0200

[Message part 1 (text/plain, inline)]

Source: mp4h
Version: 1.3.1-15
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

Whilst working on the "reproducible builds" effort [0], we noticed
that mp4h could not be built reproducibly.

Patch attached.

 [0] https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[mp4h.diff.txt (text/plain, attachment)]

Message #10 received at 833437@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: Chris Lamb <lamby@debian.org>, 833437@bugs.debian.org

Cc: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org>

Subject: Re: [pkg-wml] Bug#833437: mp4h: please make the build reproducible

Date: Thu, 4 Aug 2016 17:15:41 +0200

Control: tag -1 -patch +confirmed

Hi Chris,

Chris Lamb wrote:
> Whilst working on the "reproducible builds" effort [0], we noticed
> that mp4h could not be built reproducibly.

Yeah, that's well known -- at least to me. :-)

> Patch attached.

Thanks. Despite hours of work I haven't managed to get it building
completely reproducibly yet.

> -@@ -1958,7 +1958,7 @@
> +@@ -1958,7 +1958,7 @@ This is similar to using the &m4; undive

I'd really appreciate if unnecessary clutter like this would not be
part of submitted patches. Had to remove many of them to get to the
essence of your patch.

> --- a/doc/mp4h.mp4h	2016-08-04 09:30:01.438012891 +0100
> --- b/doc/mp4h.mp4h	2016-08-04 09:37:42.517347692 +0100
> @@ -2260,13 +2260,6 @@
>  is the number of clock ticks, and so is dependent of your CPU.
>  </para>
>  
> -<example>
> -<timer/>
> -The number of clock ticks since the beginning of the parsing of
> -this example by &mp4h; is:
> -<timer/>
> -</example>
> -
>  <tag:description mp4h-l10n>
>  <var name />=<var value />
>  </tag:description>

This hunk did not apply:

→ GET https://bugs.debian.org/cgi-bin/bugreport.cgi\?att\=1\;bug\=833437\;filename\=mp4h.diff.txt\;msg\=5 | patch -p1
patching file debian/patches/reproducible-build.diff
patching file doc/mp4h.mp4h
Reversed (or previously applied) patch detected!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file doc/mp4h.mp4h.rej

It seems that's a leftover of what you've added to
debian/patches/reproducible-build.diff, namely the essence of your
patch.

So your whole patch is to just remove one code example from the
documentation?!?

That's cheating! :-(

If I would have gone that way I wouldn't have needed that many
iterations to get as far as I am now with making mp4h building
reproducibly.

Actually I'm fully aware of that <timer/> is the last reason (or at
least one of the last reasons) why mp4h doesn't build reproducibly.
But so far I didn't have an idea how to make that value reproducible.

Just removing the example is IMHO definitely _not_ how reproducible
builds should work, so I refuse to apply your patch.

I'd rather hack something that <timer/> generates a reproducible value
if $SOURCE_DATE_EPOCH is set. Like the last two digits of it or so.

(So your bug report at least triggered an idea on how to be able to
get <timer/> to reproducibly return the same value. :-)

Note to myself: A nice test which often different values is this:

$ perl -E 'say "<timer/>"x150000' | nice -n 20 mp4h | tail -3

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Message #21 received at 833437-close@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: 833437-close@bugs.debian.org

Subject: Bug#833437: fixed in mp4h 1.3.1-16

Date: Fri, 12 Aug 2016 23:23:21 +0000

Source: mp4h
Source-Version: 1.3.1-16

We believe that the bug you reported is fixed in the latest version of
mp4h, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 833437@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Axel Beckert <abe@debian.org> (supplier of updated mp4h package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 13 Aug 2016 00:17:10 +0200
Source: mp4h
Binary: mp4h
Architecture: source amd64
Version: 1.3.1-16
Distribution: unstable
Urgency: medium
Maintainer: Debian WML Packaging Team <pkg-wml-maintainers@lists.alioth.debian.org>
Changed-By: Axel Beckert <abe@debian.org>
Description:
 mp4h       - Macro processor for HTML documents
Closes: 833437
Changes:
 mp4h (1.3.1-16) unstable; urgency=medium
 .
   * Finetune regular expression for replacing <timer/> output in HTML
     documentation to gain reproducibility. (Hopefully closes: #833437)
   * Make all patch headers DEP-3 compatible and switch remaining
     bugs.debian.org URLs to https://.
   * Add lintian override for spelling-error-in-* since "substract" is a
     command of mp4h and cannot be changed.
Checksums-Sha1:
 2af9fbba3a9a28bdb98d7b748b26dc300e78014c 2028 mp4h_1.3.1-16.dsc
 3032872487c959d299c701b36e989ff3f8fef2ea 15952 mp4h_1.3.1-16.debian.tar.xz
 0fbf181bc1652f8395324e815b85ccc13a71e116 154302 mp4h-dbgsym_1.3.1-16_amd64.deb
 94da62396efeddd82efff2c6adef60a4da3fe278 262610 mp4h_1.3.1-16_amd64.deb
Checksums-Sha256:
 31b7c38b84a1ef10eda91c5189ce30c8a1c3f8a5ec01c398cef2543309fdc9ab 2028 mp4h_1.3.1-16.dsc
 f870a109db0a2b9918a712540a98e50bf9c6104dd613b99ab1b35b9494e39d88 15952 mp4h_1.3.1-16.debian.tar.xz
 14cf7d701d62a5eebf3d4d0cef62b6c929354f166a8fb2a6b1a6df2043f36610 154302 mp4h-dbgsym_1.3.1-16_amd64.deb
 fbd97ff181eaab185cc3eaee5c29fd010500fe1b53f54447e1db9e5149369b76 262610 mp4h_1.3.1-16_amd64.deb
Files:
 513fe2578959a630c35d3207fad852a2 2028 web optional mp4h_1.3.1-16.dsc
 987937b8dbc1a1adb800128031774be4 15952 web optional mp4h_1.3.1-16.debian.tar.xz
 abfa375125c135d0918447adc27e1bc7 154302 debug extra mp4h-dbgsym_1.3.1-16_amd64.deb
 243d287d48f0bf9676b4098d461ace2f 262610 web optional mp4h_1.3.1-16_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXrks5AAoJEC/5zVlhJha1HqoQAMxcmk4m/GfOzUNxp/qFD6d1
LglFS92r1TCs0c5LDYsQjTXZYQI6ta2ID8FOfJABnpOyl29Z84/3uOG/vcqN98n7
RECSc/Zb1wJ2zuPhWbIeihcw9OELVyfFkLcwdzHV90grTWsV4eecEZrFyp5Q5eBy
+e5b3eNYzL7lFiVgWVdN6I2SOHButdN8hjnyitJPbmh0AhGxj9awZ7+YnMpGM6xC
so9HCYrN5auY4ZnUxv4GDvxw5dhoRzaNTf0thkRrEIiAxsoyZWc+V8svQXIgI0mq
eNtAYI2VgVJrxh37Br+lYPZSx5N69NHxjbxuybWdd49pnG9PBtaxz/vAYg1vDm09
eS7GEP2KVxUOiA+RUa9xX6KWsqRpr2Tw8tSpcQNTgYlpuzeIQ7Kp53JKIm7vUedt
Le85JAUZVJ09/irKGOTEj/dlTCbo867e9IOTDzr8SE30LDuplTn0v/jSmg26EzRq
/NAYpUEK9WIDk8XhpgFGzhe/HMGyA2HI/UfOyKIJQBS2qauQtu6OEQJW4I8b/uO5
RpTBtWEb5gmJQz7jFpwjwlxW8bqzJJUvmBRKfWefVgoMdIxomgBDqtzWJZSDA7aF
Cbh8AFf0YEpA3SY+u3zb2dOAKjvKsuy6m5kq3uJveTAUwJxkLpMh9rPIVZ7OhsTO
KhYyWuf83tcy/a4n4vQY
=77t9
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.