Debian Bug report logs - #833097
flash-kernel: should exit when DTB doesn't exist

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Michlmayr <tbm@cyrius.com>

To: submit@bugs.debian.org

Subject: flash-kernel: should exist when DTB doesn't exist

Date: Sun, 31 Jul 2016 13:16:59 -0700

Package: flash-kernel
Version: 3.68

At the moment, flash-kernel doesn't exit when the DTB doesn't exist.
It will print the DTB to be used but then not copy it.  That will
result in devices not being able to boot.

Ian, is there a reason why we *don't* want to exit?

Right now we have:

get_dtb_name() prints "DTB: $dtb_name"

handle_dtb() returns if there's no DTB.

If there's a DTB, handle_dtb() will call
        local dtb=$(find_dtb_file)

But then it only copies the DTB if the file exists:
        if [ -e "$dtb" ]; then
and there's no "else".

Surely if a DTB is specified ($dtb_name is not empty) we need the DTB
so there should be an

else
        error "Cannot find DTB file $dtb"
fi

Is there a situation where we want to continue without the DTB file?

-- 
Martin Michlmayr
http://www.cyrius.com/

Message #10 received at 833097@bugs.debian.org (full text, mbox, reply):

From: Ian Campbell <ijc@debian.org>

To: Martin Michlmayr <tbm@cyrius.com>, 833097@bugs.debian.org

Subject: Re: Bug#833097: flash-kernel: should exist when DTB doesn't exist

Date: Mon, 01 Aug 2016 07:32:57 +0100

On Sun, 2016-07-31 at 13:16 -0700, Martin Michlmayr wrote:
> Package: flash-kernel
> Version: 3.68
> 
> At the moment, flash-kernel doesn't exit when the DTB doesn't exist.
> It will print the DTB to be used but then not copy it.  That will
> result in devices not being able to boot.
> 
> Ian, is there a reason why we *don't* want to exit?

Not that I can think of right now.

Message #15 received at 833097@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: 833097@bugs.debian.org

Subject: Re: Bug#833097: flash-kernel: should exist when DTB doesn't exist

Date: Mon, 1 Aug 2016 17:29:20 +0200

[Message part 1 (text/plain, inline)]

Control: retitle -1 flash-kernel: should exit when DTB doesn't exist

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 833097-close@bugs.debian.org (full text, mbox, reply):

From: Christian Perrier <bubulle@debian.org>

To: 833097-close@bugs.debian.org

Subject: Bug#833097: fixed in flash-kernel 3.68

Date: Mon, 08 Aug 2016 06:33:46 +0000

Source: flash-kernel
Source-Version: 3.68

We believe that the bug you reported is fixed in the latest version of
flash-kernel, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 833097@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated flash-kernel package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 08 Aug 2016 07:33:38 +0200
Source: flash-kernel
Binary: flash-kernel flash-kernel-installer
Architecture: source armel
Version: 3.68
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description:
 flash-kernel - utility to make certain embedded devices bootable
 flash-kernel-installer - Make the system bootable (udeb)
Closes: 833097
Changes:
 flash-kernel (3.68) unstable; urgency=medium
 .
   [ Karsten Merker ]
   * Add machine db entries for various sunxi-based systems that are
     (at least partially) supported in kernel 4.7 and u-boot v2016.07:
     - Colorfly E708 Q1 tablet
     - Difrnce DIT4350
     - Dserve DSRV9703C
     - Polaroid MID2809PXE04 tablet
     - Xunlong Orange Pi One
     - Xunlong Orange Pi PC
     - Xunlong Orange Pi 2
   * Fix the DTB-ID for generic Allwinner-A13-based Q8-form-factor tablets.
 .
   [ Martin Michlmayr ]
   * Handle DTBs in vendor subdirectories (as found on arm64 kernels).
   * Add uboot-generic boot script for arm64: based on the armhf version
     but with booti.
   * Produce an error when the DTB cannot be found. (Closes: #833097)
   * Add a machine db entry for NVIDIA Jetson TX1 Developer Kit.
   * Add a machine db entry for DragonBoard 410c.
   * Fix typos in README.
Checksums-Sha1:
 30432fb5e272f354b5c401cf5f73cb65147cebb1 1859 flash-kernel_3.68.dsc
 a6be2d45739e928041b74e8725f95307f66dfb1e 68016 flash-kernel_3.68.tar.xz
 ac79fa2f8e44c94e0e07953024fe061cd2da1588 25290 flash-kernel-installer_3.68_armel.udeb
 9cfb308796c4ad87eff01ce7b6cac271f4b74c26 44384 flash-kernel_3.68_armel.deb
Checksums-Sha256:
 853ec6275eb31311913244a700251efd423871701160269c5bfe60e82e4f1262 1859 flash-kernel_3.68.dsc
 693e3ee90bd75babe329de5e93c2a245d815bf8152d3633b15d79f2de185c29d 68016 flash-kernel_3.68.tar.xz
 185a6e3cd539c95b56b7de75902b3abc40ceab3b117814022e4a332375e902a3 25290 flash-kernel-installer_3.68_armel.udeb
 2e9e6c811807b6d6911a4b42abf9a2f0dd7ed3e1f0c317105294c99a93f38837 44384 flash-kernel_3.68_armel.deb
Files:
 dadea02e377e37c32e662be46db4f280 1859 utils optional flash-kernel_3.68.dsc
 5b9f184ae164845c72cd935926218427 68016 utils optional flash-kernel_3.68.tar.xz
 fb60c234eea70f021e57fb1d9b513874 25290 debian-installer standard flash-kernel-installer_3.68_armel.udeb
 90007d9ac3d8e82b212544bfb9d27895 44384 utils optional flash-kernel_3.68_armel.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXqCNYAAoJEIcvcCxNbiWoL4MP/0mwDTtsvL6C6BJA7RApMSVz
hgVheQ9VrHqChgvvIj+Fcc1YjXgOgvHQu8nuQ/Sd1mu3TN0MCSItPEO2fNapVsir
sILwZCBVxw+UsjLqtsdOOaRBAk98b85s4m+wtaSNDTq8Rc2sE/44AxCm9GuOTlv/
Hsw04hg7kvZlu3znI72GID/fB4FEfrd/t+zKIg8Jy1TgfFjEukQ2vAxoDdGtpYuY
AKlVypalP4XNqJgJi5FdmRKOr9Xezc+faGObKl8Pp59F2ljnLS4BOqQlnFfH5NyJ
KKgN7RLZr5MGzOgBopeEehvTrG+pqC5op3kS0pKAnKJ1b6e+Wc2RB8iKhv64HNsO
bxZPJ2zJPZ3g3SLAS4ay2tlI11v2/uBbQz8RNwOyKICtrbz+GUtVkGwhm5wwsISd
Swi5MLEDM2mNjATD6pveVJwZxSh+YGCWBeO+2XjYOJ50uF8owEV+p8sH0QP6qgFL
ZXvajhB4emBz6iF6NFA94IvyitHwmW3WOEby3HgyGZgQaXVwwUUbiSZh1GdgRdyx
5G1UKlBe2WoS/TZLnIG9nl8u6KLxWxfIacVydjxMLUePZHU3jCQc7CzyUea92smO
Q2D5i+jHeMAPQ16laF096VW4h9QOxac26d8BcxhSJmbgEa7dXH7NrN+vK2bm/lDH
J8LuX9PNflx8wOnX+Tz/
=fyJr
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.