Debian Bug report logs - #832938
zfs-linux: ZFS ARC python scripts location and scripts policy

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Eric Desrochers <eric.desrochers@canonical.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: zfs-linux: ZFS ARC python scripts location and scripts policy

Date: Fri, 29 Jul 2016 14:48:11 -0400

Package: zfs-linux
Version: 0.6.5.7-1
Severity: minor

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?
     Bug (LP: #1574342) in Ubuntu where ARC scripts (arcstat.py, arc_summary.py & dbufstat.py) weren't part of the build
   * What exactly did you do (or not do) that was effective (or
     ineffective)?
     We think theses scripts should be in /usr/bin (or /usr/sbin), but not /bin. Additionnally, according to script policy (10.4) : "When scripts are installed into a directory in the system PATH, 
     the script name should not include an extension such as .sh or .pl that denotes the scripting language currently used to implement it." which means that we should probably consider renaming the script to arcstat, arc_summary & dbfustat
     without the .py extension.
  * What was the outcome of this action?
  * What outcome did you expect instead?

*** End of the template - remove these template lines ***


-- System Information:
Debian Release: 8.4
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.2.0-17-generic (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Message #10 received at 832938@bugs.debian.org (full text, mbox, reply):

From: Eric Desrochers <eric.desrochers@canonical.com>

To: 832938@bugs.debian.org

Subject: zfs-linux: ZFS ARC python scripts location and scripts policy

Date: Fri, 29 Jul 2016 16:31:36 -0400

[Message part 1 (text/plain, inline)]

Looking further, it seems like ZoL provide their own Debian package that uses /usr/sbin for the location.

Reference:
---
https://github.com/zfsonlinux/zfs/wiki/Debian <https://github.com/zfsonlinux/zfs/wiki/Debian>

"Although ZFS On Linux is now officially in the Debian GNU/Linux repository, we will continue to provide packages for Wheezy and Jessie (but only in the amd64 architecture). The ZoL packages differ slightly compared to the official Debian GNU/Linux packages, mostly in that it provides new, improved sharenfs, sharesmb and shareiscsi options."


Confirmation:
---
$ dpkg -c zfsutils_0.6.5.7-8-jessie_amd64.deb | egrep -i "arc|dbufstat"
-rwxr-xr-x root/root 40751 2016-05-19 18:59 ./usr/sbin/arc_summary.py
-rwxr-xr-x root/root 13057 2016-05-19 18:59 ./usr/sbin/arcstat.py
-rwxr-xr-x root/root 18718 2016-05-19 18:59 ./usr/sbin/dbufstat.py

Regards,
Eric

[Message part 2 (text/html, inline)]

Message #15 received at 832938@bugs.debian.org (full text, mbox, reply):

From: Eric Desrochers <eric.desrochers@canonical.com>

To: 832938@bugs.debian.org

Subject: zfs-linux: ZFS ARC python scripts location and scripts policy

Date: Fri, 29 Jul 2016 17:00:10 -0400

[Message part 1 (text/plain, inline)]

# zfs-linux version 0.6.5.7-1 in Debian "unstable"

Package: zfsutils-linux
Source: zfs-linux
Version: 0.6.5.7-1
Architecture: amd64
Maintainer: Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>
...

# List contents of a deb package
$ dpkg -c zfsutils-linux_0.6.5.7-1_amd64.deb | egrep -i "arc|dbufstat"
-rwxr-xr-x root/root 40751 2016-05-31 03:40 ./bin/arc_summary.py
-rwxr-xr-x root/root 13057 2016-05-31 03:40 ./bin/arcstat.py
-rwxr-xr-x root/root 18718 2016-05-31 03:40 ./bin/dbufstat.py

[Message part 2 (text/html, inline)]

Message #20 received at 832938@bugs.debian.org (full text, mbox, reply):

From: Eric Desrochers <eric.desrochers@canonical.com>

To: 832938@bugs.debian.org

Subject: zfs-linux: ZFS ARC python scripts location and scripts policy

Date: Mon, 1 Aug 2016 10:37:15 -0400

Following my discussion with a ZFS debian maintainer (Aron Xu)....

Aron confirmed that he is going to put the python scripts into /usr/sbin and remove the .py suffix in the Debian package.

Regards,
Eric

Message #25 received at 832938@bugs.debian.org (full text, mbox, reply):

From: Eric Desrochers <eric.desrochers@canonical.com>

To: 832938@bugs.debian.org

Subject: zfs-linux: ZFS ARC python scripts location and scripts policy

Date: Mon, 1 Aug 2016 11:07:44 -0400

[Message part 1 (text/plain, inline)]

Suggested PATCH for the utilities bindir location change

[0001-Change-utilities-path-bindir-to-usr-sbin.patch (text/x-patch, attachment)]

Message #30 received at 832938@bugs.debian.org (full text, mbox, reply):

From: Eric Desrochers <eric.desrochers@canonical.com>

To: 832938@bugs.debian.org

Subject: zfs-linux: ZFS ARC python scripts location and scripts policy

Date: Mon, 1 Aug 2016 15:59:48 -0400

[Message part 1 (text/plain, inline)]

I re-did my suggested patch to clean the bin/ entry in zfsutils-linux.install, which is no longer needed.

You can find the amended patch in : 0001-Change-utilities-path-bindir-to-usr-sbin-V2.patch

Thanks

[0001-Change-utilities-path-bindir-to-usr-sbin-V2.patch (text/x-patch, attachment)]

Message #35 received at 832938-close@bugs.debian.org (full text, mbox, reply):

From: Carlos Alberto Lopez Perez <clopez@igalia.com>

To: 832938-close@bugs.debian.org

Subject: Bug#832938: fixed in zfs-linux 0.6.5.7-2

Date: Wed, 17 Aug 2016 05:48:50 +0000

Source: zfs-linux
Source-Version: 0.6.5.7-2

We believe that the bug you reported is fixed in the latest version of
zfs-linux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 832938@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Carlos Alberto Lopez Perez <clopez@igalia.com> (supplier of updated zfs-linux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 16 Aug 2016 17:43:48 +0200
Source: zfs-linux
Binary: libnvpair1linux libuutil1linux libzfslinux-dev libzfs2linux libzpool2linux zfs-dkms zfs-initramfs zfs-dracut zfsutils-linux zfs-zed zfs-dbg
Architecture: source
Version: 0.6.5.7-2
Distribution: unstable
Urgency: medium
Maintainer: Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>
Changed-By: Carlos Alberto Lopez Perez <clopez@igalia.com>
Description:
 libnvpair1linux - Solaris name-value library for Linux
 libuutil1linux - Solaris userland utility library for Linux
 libzfs2linux - OpenZFS filesystem library for Linux
 libzfslinux-dev - OpenZFS filesystem development files for Linux
 libzpool2linux - OpenZFS pool library for Linux
 zfs-dbg    - Debugging symbols for OpenZFS userland libraries and tools
 zfs-dkms   - OpenZFS filesystem kernel modules for Linux
 zfs-dracut - OpenZFS root filesystem capabilities for Linux - dracut
 zfs-initramfs - OpenZFS root filesystem capabilities for Linux - initramfs
 zfs-zed    - OpenZFS Event Daemon
 zfsutils-linux - command-line tools to manage OpenZFS filesystems
Closes: 824976 830652 830824 832280 832938
Changes:
 zfs-linux (0.6.5.7-2) unstable; urgency=medium
 .
   [ Aron Xu ]
   * Add busybox to zfs-initramfs list of dependencies. (Closes: #824976)
 .
   [ Petter Reinholdtsen ]
   * Updated Danish debconf translation by Joe Hansen. (Closes: #830652)
   * Added Dutch (nl) debconf translation by Frans Spiesschaert. (Closes: #832280)
   * Norwegian Bokmål (nb) debconf template translation by Petter Reinholdtsen.
 .
   [ Eric Desrochers ]
   * Change utilities path (bindir) to /usr/sbin. (Closes: #832938)
 .
   [ Carlos Alberto Lopez Perez]
   * Add tunable to ignore hole_birth, and enable it by default. (Closes: #830824)
Checksums-Sha1:
 a546eb573432ecbaf1cccc82c86deb575698b681 2905 zfs-linux_0.6.5.7-2.dsc
 1e807e20538ceeb567027b983dc1304a5b450f9d 38084 zfs-linux_0.6.5.7-2.debian.tar.xz
Checksums-Sha256:
 16a13982308c7b121ec3a6a12d64fa8a548d12e9516e5d39070ffd2f98f5ae35 2905 zfs-linux_0.6.5.7-2.dsc
 093534501c86189694d37c49c5f22c769c8bcb338a267785e8ec6ca8ebff25c1 38084 zfs-linux_0.6.5.7-2.debian.tar.xz
Files:
 cbebc1112ec5b56ca962aeb217ec306a 2905 contrib/kernel optional zfs-linux_0.6.5.7-2.dsc
 faba598924297c41510acb44d0855bb8 38084 contrib/kernel optional zfs-linux_0.6.5.7-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJXs/fjAAoJEIEoCqCHuvsOX5IP/2BDZMpm/rn+OrDHufe5OZfT
27dgoPX4D6kwd2UcxvJ7cpgm97DIbN2hJCL8vRYfAQrfYaXYFdaDziiCLAdVgfk9
WXygCdzkKvTC+q1kIBYlNs3l0yzF7bI8mKEfxClSqKyX8KMOtF3gA2mMiNqR6qXK
0LS0moxie6DVsRnUCZ/dMfbhBerL0z1FgZcubpKGj6wdw4HNmVCnMkk333zNlDIy
sAK4UxNowUSQ8dBg+3SyCxIyEQ5gfn38QcT4zAyFSMtNui34+LGOsHfzVv2SEUuM
3MTIzsoBaLzaOLveC/d1PQ4nUQEYYdcoHHctslU+gQq3D5LRuF7tUXA7q9t5cGWr
WZ8IW24thMsn7AwDZzjTjsGsafFuketxCSLrRgGrHpitkKu426kP6X2RHQIj9vSV
ICcz6QO14i9Z9NPaxGdJvXW05nDIP5MZtkphk80l1gu0SyS6L8XMEExhPatcEaWq
Tw8xIMMVUwS4XxO+Ph3KHQR2AjPd0j36ijwgTXClxhEyKED0PZ3ovIoxQi/d+eSd
kM5+9GQ6WA0AE+IgsfDsLwODik8nsBzC33sePNXuIalHZ61L9F8wwpMIyLS1fPWO
KIpKe+0DQlDUI2bMu7NRQ4h0vgrxt4vFoq3QgvzGEU0/PoW4wPomfeIeCol6pgIG
nGb5NcvOuy4gCLDNfP4a
=ch+A
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.