Debian Bug report logs - #832179
dpkg-buildflags: please enable reproducible/fixdebugpath by default

version graph

Package: dpkg-dev; Maintainer for dpkg-dev is Dpkg Developers <debian-dpkg@lists.debian.org>; Source for dpkg-dev is src:dpkg (PTS, buildd, popcon).

Reported by: Mattia Rizzolo <mattia@debian.org>

Date: Sat, 23 Jul 2016 10:30:02 UTC

Severity: wishlist

Found in version dpkg/1.18.9

Fixed in version dpkg/1.18.10

Done: Guillem Jover <guillem@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-builds@lists.alioth.debian.org, Dpkg Developers <debian-dpkg@lists.debian.org>:
Bug#832179; Package dpkg-dev. (Sat, 23 Jul 2016 10:30:05 GMT) (full text, mbox, link).


Message #3 received at submit@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>
To: submit@bugs.debian.org
Subject: dpkg-buildflags: please enable reproducible/fixdebugpath by default
Date: Sat, 23 Jul 2016 10:28:36 +0000
[Message part 1 (text/plain, inline)]
Package: dpkg-dev
Version: 1.18.9
Severity: wishlist
User: reproducible-builds@lists.alioth.debian.org
Usertags: toolchain buildpath
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Dear dpkg maintainers,

Over the past month we've been rebuilding the debian archive with
'-fdebug-prefix-map' (also known as 'reproducible/fixdebugpath' within
dpkg-buildflags) enabled.

Following the dpkg team's instructions [0] about how to add a new
buildflag to the default set we wrote to debian-devel [1][2] exposing
our findings and our believes.

Summing up, according to our tests enabling this build flags is going to
cause 4 FTBFS in unstable:
 - afl #828178
 - libblocksruntime #832015
 - libclc # 832014
 - ncl #832011

Is my personal opinion that none of these packages warrant delaying the
introduction of this build flag in the default set.
Besides, nobody raised any concern after those emails to d-d.

Therefore, we'd like to proceed.  Attached you can find a patch enabling
the buildflags set reproducible/fixdebugpath by default.

Thanks in advance.


[0] https://wiki.debian.org/Teams/Dpkg/FAQ#Q:_Can_we_add_support_for_new_default_build_flags_to_dpkg-buildflags.3F
[1] https://lists.debian.org/msgid-search/20160718085659.GI7462@chase.mapreri.org
[2] https://lists.debian.org/msgid-search/20160721110631.GE26853@chase.mapreri.org

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
[0001-enable-reproducible-fixdebugpath-build-flag-by-defau.patch (text/x-diff, attachment)]
[signature.asc (application/pgp-signature, inline)]

Message sent on to Mattia Rizzolo <mattia@debian.org>:
Bug#832179. (Sun, 31 Jul 2016 14:39:16 GMT) (full text, mbox, link).


Message #6 received at 832179-submitter@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>
To: 832179-submitter@bugs.debian.org
Subject: Bug#832179 in package dpkg marked as pending
Date: Sun, 31 Jul 2016 14:34:24 +0000
Control: tag 832179 pending

Hi!

Bug #832179 in package dpkg reported by you has been fixed in
the dpkg/dpkg.git Git repository. You can see the changelog below, and
you can check the diff of the fix at:

    https://anonscm.debian.org/cgit/dpkg/dpkg.git/diff/?id=94852b0

---
commit 94852b0e8973d2f9878dc93794346d8670c0720e
Author: Mattia Rizzolo <mattia@debian.org>
Date:   Thu Jul 28 10:55:31 2016 +0200

    Dpkg::Vendor::Debian: Enable fixdebugpath build flag feature by default
    
    Closes: #832179
    Signed-off-by: Guillem Jover <guillem@debian.org>

diff --git a/debian/changelog b/debian/changelog
index 0267379..191e827 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -12,6 +12,8 @@ dpkg (1.18.10) UNRELEASED; urgency=medium
     - Generate reproducible source tarballs by using the new GNU tar
       --clamp-mtime option in Dpkg::Source::Archive, to make sure no file
       in source packages has an mtime later than the changelog entry time.
+    - Enable fixdebugpath build flag feature by default.
+      Thanks to Mattia Rizzolo <mattia@debian.org>. Closes: #832179
   * Documentation:
     - Document Testsuite-Triggers in dsc(5).
     - Fix deb-changes(5) description to talk about .changes instead of .dsc.



Added tag(s) pending. Request was from Guillem Jover <guillem@debian.org> to 832179-submitter@bugs.debian.org. (Sun, 31 Jul 2016 14:39:16 GMT) (full text, mbox, link).


Reply sent to Guillem Jover <guillem@debian.org>:
You have taken responsibility. (Sun, 31 Jul 2016 16:39:18 GMT) (full text, mbox, link).


Notification sent to Mattia Rizzolo <mattia@debian.org>:
Bug acknowledged by developer. (Sun, 31 Jul 2016 16:39:18 GMT) (full text, mbox, link).


Message #13 received at 832179-close@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>
To: 832179-close@bugs.debian.org
Subject: Bug#832179: fixed in dpkg 1.18.10
Date: Sun, 31 Jul 2016 16:34:22 +0000
Source: dpkg
Source-Version: 1.18.10

We believe that the bug you reported is fixed in the latest version of
dpkg, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 832179@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guillem Jover <guillem@debian.org> (supplier of updated dpkg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 31 Jul 2016 12:57:02 +0200
Source: dpkg
Binary: libdpkg-dev dpkg dpkg-dev libdpkg-perl dselect
Architecture: source
Version: 1.18.10
Distribution: unstable
Urgency: medium
Maintainer: Dpkg Developers <debian-dpkg@lists.debian.org>
Changed-By: Guillem Jover <guillem@debian.org>
Description:
 dpkg       - Debian package management system
 dpkg-dev   - Debian package development tools
 dselect    - Debian package management front-end
 libdpkg-dev - Debian package management static library
 libdpkg-perl - Dpkg perl modules
Closes: 830267 832070 832179 832434
Changes:
 dpkg (1.18.10) unstable; urgency=medium
 .
   [ Guillem Jover ]
   * Fix a short-lived memory leak in dpkg archive argument parsing.
   * When activating file triggers on conffile purge, use the conffile name
     instead of the real pathname it might refer to. This fixes a segfault
     when using --instdir, or when the conffile has been moved around and
     replaced with a symlink to the target.
     Regression introduced in dpkg 1.18.8. Closes: #830267
   * Perl modules:
     - Disable fixdebugpath feature on unsafe characters in the path.
     - Generate reproducible source tarballs by using the new GNU tar
       --clamp-mtime option in Dpkg::Source::Archive, to make sure no file
       in source packages has an mtime later than the changelog entry time.
     - Enable fixdebugpath build flag feature by default.
       Thanks to Mattia Rizzolo <mattia@debian.org>. Closes: #832179
     - Rename various private methods and functions with an underscore prefix
       and unified names.
     - Refactor perl modules directory list into a new function in Test::Dpkg.
   * Test suite:
     - Add new POD coverage author test for public perl modules.
   * Documentation:
     - Document Testsuite-Triggers in dsc(5).
     - Fix deb-changes(5) description to talk about .changes instead of .dsc.
       Reported by HW42 <hw42@ipsumj.de>.
     - Use debian/control as the SYNOPSIS in deb-src-control(5).
     - Add new deb-conffiles(5) man page.
     - Add references to deb-control(5) and deb-triggers(5) in dpkg(1).
     - Fix typos for repeated “the” word.
       Prompted by Valentin Samir <valentin.samir@crans.org> in #830989.
     - Fix misspelled -fdebug-prefix-map flag in dpkg-buildflags(1).
       Reported by Mattia Rizzolo <mattia@debian.org>.
     - Remove mention of source format 1.0 supporting building with upstream
       tarball signatures from dpkg-source(1), as this was disabled in 1.18.8.
     - Document all public methods in Dpkg::Changelog::Entry::Debian.
     - Escape dashes in deb-changes(5) and dsc(5) man pages.
     - Fix typos in dpkg-shlibdeps(1). Closes: #832434
       Thanks to Carsten Leonhardt <leo@debian.org>.
 .
   [ Updated programs translations ]
   * German (Sven Joachim).
   * Turkish (Mert Dirik). Closes: #832070
 .
   [ Updated scripts translations ]
   * German (Helge Kreutzmann).
 .
   [ Updated manpages translations ]
   * German (Helge Kreutzmann).
Checksums-Sha1:
 344be66d01da2200efca4079f08e9594fc7dcc8e 2030 dpkg_1.18.10.dsc
 10ce6a921ba577c01b4ff094122b5386886acf2f 4645448 dpkg_1.18.10.tar.xz
Checksums-Sha256:
 c80b88e0b0293f0524978dc4526927b5e68bc0636c260c594ed1fb8c41859d91 2030 dpkg_1.18.10.dsc
 025524da41ba18b183ff11e388eb8686f7cc58ee835ed7d48bd159c46a8b6dc5 4645448 dpkg_1.18.10.tar.xz
Files:
 dc71ef66d980b71c9caf0de3618741e0 2030 admin required dpkg_1.18.10.dsc
 ccff17730c0964428fc186ded2f2f401 4645448 admin required dpkg_1.18.10.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJXngx2AAoJELlyvz6krlejM44P/3PiN6cgBeTZ9pN9tEFrvIZd
6A/UFYc8FyjHfDl6f7BQIymhwxaganI5kTs0PLrjRxi3+IiLIca7GJVvyCgbkbaK
RQ8E2tTYs6AJLc/OlWfm9IgL+p/+/UkhUSRpnvL9F4hT8T+IckHLl4OxZ3dEA9dm
XVhNLGegrBHDJSZPQWIRANQj10T1pL/j+OpfEorDgKQC6Kwihr3alkNErbS/z6aW
lPryPo0QtLhjhwzaJYWAdv9KvHWFWGSoq9ShDVPni+8SWjGE1cdDXbO3le6zgcta
+yX634PDaM+NErnmzlZIshB2bz/2HCIOkofLnql+sCSZllo+/wREBKA+43+3Zt2e
C1dDPGNF44+iI8VSl8bsJAg2lsoZ3LmWwMvp+OvJwzBhKp3ohhUBD3N1igPuOhB9
qoYfmjdh0bgw7fTs5y/iLMrY1lW18XAP9vnfJC3gF1BPxoFWcn7ePuXHsJpJE3YC
fpFRTzPHDyesgmK6qNkG+G6SpPBqZge4YZR8zPjgxZk5dgyaHpBiifmMQ/9RcsTg
HMrbMB5WGJE4fzs+ATi1N6U6CcrXs/WAPx4beVUgZ4RgpgkrmmpV18EEMMdVN3Hb
miZON1E/2SnHaZJWZDeiHxTC9q9x9FKT6czyLCXVIkNqw29BrzelOlt8VWsXkhvv
ZLsTYEBEk8uKNo4KHqpP
=eYqb
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sat, 03 Sep 2016 07:31:26 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 14:07:20 2023; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.