Debian Bug report logs - #831587
stressapptest: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: stressapptest: please make the build reproducible

Date: Sun, 17 Jul 2016 15:57:55 +0200

[Message part 1 (text/plain, inline)]

Source: stressapptest
Version: 1.0.6-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

Whilst working on the "reproducible builds" effort [0], we noticed
that stressapptest could not be built reproducibly.

Patch attached.

 [0] https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[stressapptest.diff.txt (text/plain, attachment)]

Message #10 received at 831587@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 831587@bugs.debian.org

Subject: Re: Bug#831587: stressapptest: please make the build reproducible

Date: Tue, 20 Sep 2016 12:38:12 +0100

Dear Maintainer,

> Source: stressapptest
> Version: 1.0.6-2
> Tags: patch

There hasn't seem to be any update on this bug in 64 days, in which
time the Reproducible Builds effort has come on a long way. :)

Would you consider applying this patch and uploading?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #15 received at 831587@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Blanc Pierre <pierreblanc75@gmail.com>

Cc: 831587@bugs.debian.org

Subject: Re: Bug#831587: stressapptest: please make the build reproducible

Date: Sun, 25 Sep 2016 09:40:13 +0100

Hi Blanc,

> I will check and update this bug during this week.
> I'm late, sorry. I'll do my best.

No problem; did you get a chance to have a look at this yet? :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #20 received at 831587@bugs.debian.org (full text, mbox, reply):

From: Blanc Pierre <pierreblanc75@gmail.com>

To: Chris Lamb <lamby@debian.org>

Cc: 831587@bugs.debian.org

Subject: Re: Bug#831587: stressapptest: please make the build reproducible

Date: Sun, 25 Sep 2016 19:33:20 -0400

Hi Chris,

> No problem; did you get a chance to have a look at this yet? :)

First, I am sincerely sorry for the delay.

I checked your patch, are you sure that the fault is the timestamp ?

The error on Jenkins is
"user_hostname_manually_added_requiring_further_investigation"
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/stressapptest.html

So, I have created this patch to fix the issue :
https://anonscm.debian.org/git/collab-maint/stressapptest.git/commit/?id=3be7d9f2c4d434ad412838d764b104fa659212b6

I also built it on mentors
https://mentors.debian.net/package/stressapptest

What is your opinion ?

-- 
Cordialement,
Blanc Pierre

Message #25 received at 831587@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Blanc Pierre <pierreblanc75@gmail.com>

Cc: 831587@bugs.debian.org

Subject: Re: Bug#831587: stressapptest: please make the build reproducible

Date: Mon, 26 Sep 2016 08:11:24 +0100

Hi Blanc,

> I checked your patch, are you sure that the fault is the timestamp ?

Well, it was some time ago so I'm looking into it again now...

> So, I have created this patch to fix the issue :
> https://anonscm.debian.org/git/collab-maint/stressapptest.git/commit/?id=3be7d9f2c4d434ad412838d764b104fa659212b6

Well, I am 100% certain you do not want to be patching the generated
./configure file so I would not upload this.

Not only is this very ugly, the changes would simply be overwritten
automatically and silently on an autoreconf as that happens after the
patch phase.

Also, this still leaves the timestamp.

I suggest we patch this:

  AC_DEFINE_UNQUOTED([STRESSAPPTEST_TIMESTAMP],
                     "$username @ $hostname on $timestamp",
                     [Timestamp when ./configure was executed])

.. in configure.ac for the case when SOURCE_DATE_EPOCH is set.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #30 received at 831587@bugs.debian.org (full text, mbox, reply):

From: Blanc Pierre <pierreblanc75@gmail.com>

To: Chris Lamb <lamby@debian.org>

Cc: 831587@bugs.debian.org

Subject: Re: Bug#831587: stressapptest: please make the build reproducible

Date: Mon, 26 Sep 2016 17:28:47 -0400

Hi Chris,

> Well, I am 100% certain you do not want to be patching the generated
> ./configure file so I would not upload this.
You have totally right.

I used you previous patch.
https://anonscm.debian.org/git/collab-maint/stressapptest.git/commit/?id=57885d7144ac4eb9d3861cbf579a0b45a07f9ca3

And this is the package uploaded on mentors:
https://mentors.debian.net/package/stressapptest

Best regards

Message #35 received at 831587@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Blanc Pierre <pierreblanc75@gmail.com>

Cc: 831587@bugs.debian.org

Subject: Re: Bug#831587: stressapptest: please make the build reproducible

Date: Mon, 26 Sep 2016 22:34:06 +0100

> https://anonscm.debian.org/git/collab-maint/stressapptest.git/commit/?id=57885d7144ac4eb9d3861cbf579a0b45a07f9ca3

- This won't be reproducible as $username is not fixed too. 

- I don't think always setting "hostname" to "localhost" is right.
  Feels wrong.

- Using "Author: [me]" when I did not write the patch is... strange.

Why not follow my previous suggestion of wrapping the:

     AC_DEFINE_UNQUOTED([STRESSAPPTEST_TIMESTAMP],

when SOURCE_DATE_EPOCH is set?

:)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #40 received at 831587@bugs.debian.org (full text, mbox, reply):

From: Blanc Pierre <pierreblanc75@gmail.com>

To: Chris Lamb <lamby@debian.org>

Cc: 831587@bugs.debian.org

Subject: Re: Bug#831587: stressapptest: please make the build reproducible

Date: Mon, 26 Sep 2016 21:13:55 -0400

Hello,

> - This won't be reproducible as $username is not fixed too.
Right.

> - I don't think always setting "hostname" to "localhost" is right.
>   Feels wrong.
Ok, you right. The better is to remove information

>
> Why not follow my previous suggestion of wrapping the:
>
>      AC_DEFINE_UNQUOTED([STRESSAPPTEST_TIMESTAMP],
>
> when SOURCE_DATE_EPOCH is set?
Something like that:

-AC_DEFINE_UNQUOTED([STRESSAPPTEST_TIMESTAMP],
+if test -n "$SOURCE_DATE_EPOCH"; then
+  AC_DEFINE(STRESSAPPTEST_TIMESTAMP,"")
+else
+  AC_DEFINE_UNQUOTED([STRESSAPPTEST_TIMESTAMP],
                    "$username @ $hostname on $timestamp",
                    [Timestamp when ./configure was executed])
+fi
+

Regards

Message #45 received at 831587@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Blanc Pierre <pierreblanc75@gmail.com>

Cc: 831587@bugs.debian.org

Subject: Re: Bug#831587: stressapptest: please make the build reproducible

Date: Tue, 27 Sep 2016 09:10:46 +0100

> -AC_DEFINE_UNQUOTED([STRESSAPPTEST_TIMESTAMP],
> +if test -n "$SOURCE_DATE_EPOCH"; then
> +  AC_DEFINE(STRESSAPPTEST_TIMESTAMP,"")

I would set it to *something*, not an empty string otherwise wherever
that string is used in the program itself it will look broken.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #50 received at 831587@bugs.debian.org (full text, mbox, reply):

From: Blanc Pierre <pierreblanc75@gmail.com>

To: Chris Lamb <lamby@debian.org>

Cc: 831587@bugs.debian.org

Subject: Re: Bug#831587: stressapptest: please make the build reproducible

Date: Tue, 27 Sep 2016 14:14:27 -0400

Hello,

> I would set it to *something*, not an empty string otherwise wherever
> that string is used in the program itself it will look broken.
I have just updated the package.
https://anonscm.debian.org/git/collab-maint/stressapptest.git/tree/debian/patches/reproducible_build

It has built on mentor:
https://mentors.debian.net/package/stressapptest

The respective dsc file can be found at:
https://mentors.debian.net/debian/pool/main/s/stressapptest/stressapptest_1.0.6-3.dsc

Thank you for your patience.

-- 
Cordialement,
Blanc Pierre

Message #55 received at 831587@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Blanc Pierre <pierreblanc75@gmail.com>

Cc: 831587@bugs.debian.org

Subject: Re: Bug#831587: stressapptest: please make the build reproducible

Date: Tue, 27 Sep 2016 21:15:55 +0100

Blanc Pierre wrote:

> The respective dsc file can be found at:
> https://mentors.debian.net/debian/pool/main/s/stressapptest/stressapptest_1.0.6-3.dsc

Uploaded.

In ideal world you would have used the value of SOURCE_DATE_EPOCH in
some way that makes sense when displayed in the application. (I don't
actually know where this timestamp is used).

Seeing "SOURCE_DATE_EPOCH set" is unlikely to be very informative to
end users. Please consider this for your next upload. :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #60 received at 831587@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 831587@bugs.debian.org

Subject: Re: Bug#831587: stressapptest: please make the build reproducible

Date: Sun, 05 Mar 2017 09:24:42 +0000

> Would you consider applying this patch and uploading?

Friendly ping on this :)


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #65 received at 831587@bugs.debian.org (full text, mbox, reply):

From: "Bernhard M. Wiedemann" <bwiedemann+out@suse.de>

To: 831587@bugs.debian.org

Subject: filed upstream

Date: Sun, 9 Sep 2018 05:45:34 +0200

submitted my patch at https://github.com/stressapptest/stressapptest/pull/65

-- 
Bernhard M. Wiedemann
openSUSE Developer and Cloud Software Developer and Sysadmin
SUSE LINUX GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) 
Maxfeldstraße 5                         
90409 Nürnberg 
Germany 

Message #70 received at 831587@bugs.debian.org (full text, mbox, reply):

From: "Bernhard M. Wiedemann" <bwiedemann@suse.de>

To: 831587@bugs.debian.org

Subject: merged upstream

Date: Wed, 10 Jun 2020 08:11:21 +0200

https://github.com/stressapptest/stressapptest/pull/65 was merged yesterday

Message #75 received at 831587@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 831587@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org

Subject: Re: Bug#831587: stressapptest: please make the build reproducible

Date: Sun, 13 Sep 2020 08:13:03 -0000

Chris Lamb wrote:

> [..]

Friendly ping on this?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #80 received at 831587@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 831587@bugs.debian.org, 986653@bugs.debian.org

Subject: NMU for reproducible builds and cross building fixes

Date: Thu, 17 Nov 2022 14:18:01 -0800

[Message part 1 (text/plain, inline)]

Control: tags 831587 pending
Control: tags 986653 pending

Uploaded an NMU to DELAYED/10 fixing these reproducible builds and
cross-building issues:

diff -Nru stressapptest-1.0.6/debian/changelog stressapptest-1.0.6/debian/changelog
--- stressapptest-1.0.6/debian/changelog	2022-09-04 14:42:31.000000000 -0700
+++ stressapptest-1.0.6/debian/changelog	2022-11-17 14:06:40.000000000 -0800
@@ -1,3 +1,15 @@
+stressapptest (1.0.6-2.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Bernhard M. Wiedemann ]
+  * Allow to override build date with SOURCE_DATE_EPOCH (Closes: #831587)
+
+  [ Helmut Grohne ]
+  * Fix FTCBFS. (Closes: #986653)
+
+ -- Vagrant Cascadian <vagrant@debian.org>  Thu, 17 Nov 2022 14:06:40 -0800
+
 stressapptest (1.0.6-2.1) unstable; urgency=low
 
   * Non-maintainer upload.
diff -Nru stressapptest-1.0.6/debian/patches/allow-to-override-build-date-with-source.patch stressapptest-1.0.6/debian/patches/allow-to-override-build-date-with-source.patch
--- stressapptest-1.0.6/debian/patches/allow-to-override-build-date-with-source.patch	1969-12-31 16:00:00.000000000 -0800
+++ stressapptest-1.0.6/debian/patches/allow-to-override-build-date-with-source.patch	2022-11-17 14:06:40.000000000 -0800
@@ -0,0 +1,36 @@
+From: Bernhard M. Wiedemann <bwiedemann@suse.de>
+Date: Sun, 9 Sep 2018 05:34:37 +0200
+X-Dgit-Generated: 1.0.6-2.2 5763ff92141056c712e2f63a5c1363090e2581aa
+Subject: Allow to override build date with SOURCE_DATE_EPOCH
+
+(Closes: #831587)
+
+in order to make builds reproducible.
+See https://reproducible-builds.org/ for why this is good
+and https://reproducible-builds.org/specs/source-date-epoch/
+for the definition of this variable.
+This date call works with all variants of date (GNU,BSD,Solaris).
+
+Also do not capture build user+host in this case
+to allow to get the same build results anywhere and anytime.
+
+---
+
+diff --git a/configure.ac b/configure.ac
+index 603ba73..818d357 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -99,6 +99,13 @@ timestamp=$(date)
+ AC_MSG_CHECKING([current timestamp])
+ AC_MSG_RESULT([$timestamp])
+ 
++if test -n "$SOURCE_DATE_EPOCH"
++then
++  timestamp=$(date -u -d "@$SOURCE_DATE_EPOCH" 2>/dev/null || date -u -r "$SOURCE_DATE_EPOCH" 2>/dev/null || date -u)
++  username=reproducible
++  hostname=reproducible
++fi
++
+ AC_DEFINE_UNQUOTED([STRESSAPPTEST_TIMESTAMP],
+                    "$username @ $hostname on $timestamp",
+                    [Timestamp when ./configure was executed])
diff -Nru stressapptest-1.0.6/debian/patches/fix-ftcbfs.-closes-986653.patch stressapptest-1.0.6/debian/patches/fix-ftcbfs.-closes-986653.patch
--- stressapptest-1.0.6/debian/patches/fix-ftcbfs.-closes-986653.patch	1969-12-31 16:00:00.000000000 -0800
+++ stressapptest-1.0.6/debian/patches/fix-ftcbfs.-closes-986653.patch	2022-11-17 14:06:40.000000000 -0800
@@ -0,0 +1,41 @@
+From: Helmut Grohne <helmut@subdivi.de>
+Date: Thu, 8 Apr 2021 20:38:30 +0200
+X-Dgit-Generated: 1.0.6-2.2 3b999e567fe8d9786f08825a389114ddf6e6cf15
+Subject: Fix FTCBFS. (Closes: #986653)
+
+
+---
+
+diff --git a/configure.ac b/configure.ac
+index 818d357..82de856 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -127,26 +127,9 @@ AC_SEARCH_LIBS([io_setup], [aio])
+ AC_CHECK_HEADERS([sys/shm.h])
+ AC_SEARCH_LIBS([shm_open], [rt])
+ 
+-AC_MSG_CHECKING(for pthread_barrier)
+-AC_CACHE_VAL(
+-  ac_cv_func_pthread_barrier,
+-  AC_TRY_RUN(
+-    [
+-      #include <pthread.h>
+-      int main(void)
+-      {
+-        pthread_barrier_t t;
+-        return 0;
+-      }
+-    ],
+-    ac_cv_func_pthread_barrier=yes,
+-    ac_cv_func_pthread_barrier=no
+-  )
+-)
+-AC_MSG_RESULT($ac_cv_func_pthread_barrier)
+-if test "$ac_cv_func_pthread_barrier" = "yes"; then
++AC_CHECK_TYPE([pthread_barrier_t],[
+   AC_DEFINE(HAVE_PTHREAD_BARRIER, [1], [Define to 1 if the system has `pthread_barrier'.])
+-fi
++],[],[#include <pthread.h>])
+ 
+ # Checks for typedefs, structures, and compiler characteristics.
+ AC_HEADER_STDBOOL
diff -Nru stressapptest-1.0.6/debian/patches/series stressapptest-1.0.6/debian/patches/series
--- stressapptest-1.0.6/debian/patches/series	2022-09-04 14:42:31.000000000 -0700
+++ stressapptest-1.0.6/debian/patches/series	2022-11-17 14:06:40.000000000 -0800
@@ -2,3 +2,5 @@
 support_i486_builds
 support_i586_builds
 gcc-12
+allow-to-override-build-date-with-source.patch
+fix-ftcbfs.-closes-986653.patch


The reproducible builds patch was pulled from upstream git, which was
similar to the patch originally submitted.


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #87 received at 831587-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 831587-close@bugs.debian.org

Subject: Bug#831587: fixed in stressapptest 1.0.6-2.2

Date: Sun, 27 Nov 2022 23:12:03 +0000

Source: stressapptest
Source-Version: 1.0.6-2.2
Done: Vagrant Cascadian <vagrant@debian.org>

We believe that the bug you reported is fixed in the latest version of
stressapptest, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 831587@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@debian.org> (supplier of updated stressapptest package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 17 Nov 2022 14:06:40 -0800
Source: stressapptest
Architecture: source
Version: 1.0.6-2.2
Distribution: unstable
Urgency: medium
Maintainer: Pierre Blanc <pierreblanc75@gmail.com>
Changed-By: Vagrant Cascadian <vagrant@debian.org>
Closes: 831587 986653
Changes:
 stressapptest (1.0.6-2.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Bernhard M. Wiedemann ]
   * Allow to override build date with SOURCE_DATE_EPOCH (Closes: #831587)
 .
   [ Helmut Grohne ]
   * Fix FTCBFS. (Closes: #986653)
Checksums-Sha1:
 d8f7854b24cf7295732f696c39344614d3aed828 1519 stressapptest_1.0.6-2.2.dsc
 9cfaa2610a27909e4c92f02f1f547a06ad870ce0 4712 stressapptest_1.0.6-2.2.debian.tar.xz
Checksums-Sha256:
 37d5c48a90511621ea602a96e922f164ce03645e76aa4164588aaef29c2ad352 1519 stressapptest_1.0.6-2.2.dsc
 efc6168eb49845346c2751ec12cdde450fdfdf43c6bacd6ddf313bc41a26b287 4712 stressapptest_1.0.6-2.2.debian.tar.xz
Files:
 2dd05759b9b2338e815c4642041de0a8 1519 utils extra stressapptest_1.0.6-2.2.dsc
 85a272879fdb84aad59c7302a6d55f8a 4712 utils extra stressapptest_1.0.6-2.2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iIkEARYKADEWIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY3axuBMcdmFncmFudEBk
ZWJpYW4ub3JnAAoJENxRj8h/lxaq9dkBANvv/vgTRBu0wMMDAz9ZxUW390ZadYqY
14NBKj2sDGF9AP4zDJhXnvHvZZKwgDttOjh5Q8BzGVIfDIJkRUhv8DB4BA==
=3Td7
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.