Debian Bug report logs - #831585
tcpreen: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: tcpreen: please make the build reproducible

Date: Sun, 17 Jul 2016 15:56:24 +0200

[Message part 1 (text/plain, inline)]

Source: tcpreen
Version: 1.4.4-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

Whilst working on the "reproducible builds" effort [0], we noticed
that tcpreen could not be built reproducibly.

Patch attached.

 [0] https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[tcpreen.diff.txt (text/plain, attachment)]

Message #10 received at 831585@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 831585@bugs.debian.org

Subject: Re: Bug#831585: tcpreen: please make the build reproducible

Date: Tue, 20 Sep 2016 12:38:11 +0100

Dear Maintainer,

> Source: tcpreen
> Version: 1.4.4-2ubuntu1
> Tags: patch

There hasn't seem to be any update on this bug in 64 days, in which
time the Reproducible Builds effort has come on a long way. :)

Would you consider applying this patch and uploading?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #15 received at 831585@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 831585@bugs.debian.org

Subject: Re: Bug#831585: tcpreen: please make the build reproducible

Date: Sun, 19 Feb 2017 11:05:43 +1300

> Would you consider applying this patch and uploading?

Friendly ping on this :)


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #20 received at 831585@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@debian.org>

To: Chris Lamb <lamby@debian.org>, 831585@bugs.debian.org

Subject: Re: Bug#831585: tcpreen: please make the build reproducible

Date: Sun, 5 Mar 2017 23:52:15 +0200

On Sun, Jul 17, 2016 at 03:56:24PM +0200, Chris Lamb wrote:
>...
> +--- tcpreen-1.4.4.orig/m4/hostname.m4
> ++++ tcpreen-1.4.4/m4/hostname.m4
> +@@ -5,7 +5,7 @@ dnl From Remi Denis-Courmont
> + AC_DEFUN([RDC_BUILD_HOSTNAME],
> + [AC_CACHE_CHECK([for build hostname],
> + rdc_cv_build_hostname,
> +-[rdc_cv_build_hostname=`hostname -f 2>/dev/null || uname -n 2>/dev/null || hostname 2>/dev/null || echo "unknown"`
> ++[rdc_cv_build_hostname=`lsb_release --short --description`
> + ])
> + AC_DEFINE_UNQUOTED(PACKAGE_BUILD_HOSTNAME, "$rdc_cv_build_hostname",
> + 		[Define to the hostname of the host who builds the package.])
>...

$ lsb_release --short --description
Debian GNU/Linux 9.0 (stretch)
$ 

This does not at all look like a hostname, so if anything actually 
parses this as a hostname there might be trouble ahead.

Assuming nothing parses the version output, in this specific case
it looks more correct to remove the PACKAGE_BUILD_HOSTNAME usage
in src/main.cpp (the __DATE__ usage in the same line could then
also be removed).

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Message #25 received at 831585@bugs.debian.org (full text, mbox, reply):

From: Daniel Shahaf <danielsh@apache.org>

To: 831585@bugs.debian.org

Cc: Chris Lamb <lamby@debian.org>, Adrian Bunk <bunk@debian.org>

Subject: Re: Bug#831585: tcpreen: please make the build reproducible

Date: Sun, 5 Mar 2017 22:47:31 +0000

Adrian Bunk wrote on Sun, Mar 05, 2017 at 23:52:15 +0200:
> On Sun, Jul 17, 2016 at 03:56:24PM +0200, Chris Lamb wrote:
> >...
> > +--- tcpreen-1.4.4.orig/m4/hostname.m4
> > ++++ tcpreen-1.4.4/m4/hostname.m4
> > +@@ -5,7 +5,7 @@ dnl From Remi Denis-Courmont
> > + AC_DEFUN([RDC_BUILD_HOSTNAME],
> > + [AC_CACHE_CHECK([for build hostname],
> > + rdc_cv_build_hostname,
> > +-[rdc_cv_build_hostname=`hostname -f 2>/dev/null || uname -n 2>/dev/null || hostname 2>/dev/null || echo "unknown"`

Tangentially, the original line seems unportable: on Solaris, 'hostname
-f' sets the hostname to "-f" and succeeds (without trying the three
other alternatives).

Cheers,

Daniel

Message #30 received at 831585@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Adrian Bunk <bunk@debian.org>, 831585@bugs.debian.org

Subject: Re: Bug#831585: tcpreen: please make the build reproducible

Date: Mon, 06 Mar 2017 08:11:13 +0000

Hi Adrian,

> > +-[rdc_cv_build_hostname=`hostname -f 2>/dev/null || uname -n 2>/dev/null || hostname 2>/dev/null || echo "unknown"`
> > ++[rdc_cv_build_hostname=`lsb_release --short --description`
[…]
> $ lsb_release --short --description
> Debian GNU/Linux 9.0 (stretch)

> This does not at all look like a hostname, so if anything actually 
> parses this as a hostname there might be trouble ahead.

Great point and well-spotted; I wonder what I was thinking...
 
> Assuming nothing parses the version output, in this specific case
> it looks more correct to remove the PACKAGE_BUILD_HOSTNAME usage
> in src/main.cpp.

Yes. These are typically harder to upstream, hence why I default to
simply "fixing" the hostname rather than removing them entirely when
I send patches. Maintainers can probably gauge this better; I'll
leave this to your judgement.

:)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #35 received at 831585@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 831585@bugs.debian.org, reproducible-bugs@lists.alioth.debian.org

Subject: Re: Bug#831585: tcpreen: please make the build reproducible

Date: Wed, 09 Sep 2020 22:51:03 -0000

Chris Lamb wrote:

> [..]

Gentle ping on this?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #40 received at 831585@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 831585@bugs.debian.org

Subject: Re: Bug#831585: tcpreen: please make the build reproducible

Date: Thu, 10 Nov 2022 13:14:26 -0800

[Message part 1 (text/plain, inline)]

I have uploaded an NMU fixing this issue:

diff -Nru tcpreen-1.4.4/debian/changelog tcpreen-1.4.4/debian/changelog
--- tcpreen-1.4.4/debian/changelog	2012-01-11 10:06:17.000000000 -0800
+++ tcpreen-1.4.4/debian/changelog	2022-11-10 13:00:17.000000000 -0800
@@ -1,3 +1,13 @@
+tcpreen (1.4.4-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Chris Lamb ]
+  * reproducible builds: Use lsb_release short description instead of
+    hostname (Closes: #831585)
+
+ -- Vagrant Cascadian <vagrant@debian.org>  Thu, 10 Nov 2022 13:00:17 -0800
+
 tcpreen (1.4.4-2) unstable; urgency=low
 
   * Enable hardened build flags. Closes: #655250.
diff -Nru tcpreen-1.4.4/debian/control tcpreen-1.4.4/debian/control
--- tcpreen-1.4.4/debian/control	2012-01-11 18:22:36.000000000 -0800
+++ tcpreen-1.4.4/debian/control	2022-11-10 13:00:17.000000000 -0800
@@ -6,7 +6,9 @@
 Build-Depends: 
  debhelper (>= 9), 
  gettext, 
- autotools-dev
+ autotools-dev,
+ lsb-release,
+ dh-autoreconf
 Standards-Version: 3.9.2
 Homepage: http://www.remlab.net/tcpreen/
 
diff -Nru tcpreen-1.4.4/debian/patches/reproducible_build.patch tcpreen-1.4.4/debian/patches/reproducible_build.patch
--- tcpreen-1.4.4/debian/patches/reproducible_build.patch	1969-12-31 16:00:00.000000000 -0800
+++ tcpreen-1.4.4/debian/patches/reproducible_build.patch	2022-11-10 13:00:17.000000000 -0800
@@ -0,0 +1,14 @@
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2016-07-17
+
+--- tcpreen-1.4.4.orig/m4/hostname.m4
++++ tcpreen-1.4.4/m4/hostname.m4
+@@ -5,7 +5,7 @@ dnl From Remi Denis-Courmont
+ AC_DEFUN([RDC_BUILD_HOSTNAME],
+ [AC_CACHE_CHECK([for build hostname],
+ rdc_cv_build_hostname,
+-[rdc_cv_build_hostname=`hostname -f 2>/dev/null || uname -n 2>/dev/null || hostname 2>/dev/null || echo "unknown"`
++[rdc_cv_build_hostname=`lsb_release --short --description`
+ ])
+ AC_DEFINE_UNQUOTED(PACKAGE_BUILD_HOSTNAME, "$rdc_cv_build_hostname",
+ 		[Define to the hostname of the host who builds the package.])
diff -Nru tcpreen-1.4.4/debian/patches/series tcpreen-1.4.4/debian/patches/series
--- tcpreen-1.4.4/debian/patches/series	1969-12-31 16:00:00.000000000 -0800
+++ tcpreen-1.4.4/debian/patches/series	2022-11-10 13:00:17.000000000 -0800
@@ -0,0 +1 @@
+reproducible_build.patch
diff -Nru tcpreen-1.4.4/debian/rules tcpreen-1.4.4/debian/rules
--- tcpreen-1.4.4/debian/rules	2010-08-27 06:49:10.000000000 -0700
+++ tcpreen-1.4.4/debian/rules	2022-11-10 13:00:17.000000000 -0800
@@ -1,3 +1,3 @@
 #!/usr/bin/make -f
 %:
-	dh $@
+	dh $@ --with autoreconf

[signature.asc (application/pgp-signature, inline)]

Message #45 received at 831585-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 831585-close@bugs.debian.org

Subject: Bug#831585: fixed in tcpreen 1.4.4-2.1

Date: Thu, 10 Nov 2022 21:35:39 +0000

Source: tcpreen
Source-Version: 1.4.4-2.1
Done: Vagrant Cascadian <vagrant@debian.org>

We believe that the bug you reported is fixed in the latest version of
tcpreen, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 831585@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@debian.org> (supplier of updated tcpreen package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 10 Nov 2022 13:00:17 -0800
Source: tcpreen
Architecture: source
Version: 1.4.4-2.1
Distribution: unstable
Urgency: medium
Maintainer: Alberto Capella Silva <alberkman@gmail.com>
Changed-By: Vagrant Cascadian <vagrant@debian.org>
Closes: 831585
Changes:
 tcpreen (1.4.4-2.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Chris Lamb ]
   * reproducible builds: Use lsb_release short description instead of
     hostname (Closes: #831585)
Checksums-Sha1:
 aafc3e37f34d67d28ac1ce090609172c22055c64 1303 tcpreen_1.4.4-2.1.dsc
 c292d4aaa1fbb94bbe5aa795679cfe85d0371cab 5768 tcpreen_1.4.4-2.1.debian.tar.xz
Checksums-Sha256:
 22691b00a2bfea64788b4ffd56acc36f9f76f2460fdd96370d0ea9aa169f4718 1303 tcpreen_1.4.4-2.1.dsc
 2eac0bc7dff284139518364e6e891aa8141f3c37cb0e78fdf35f4e6652baceb4 5768 tcpreen_1.4.4-2.1.debian.tar.xz
Files:
 8c8c152a16d2b153115505d4301f3300 1303 net optional tcpreen_1.4.4-2.1.dsc
 f277c18e8e07e9a1908609195ccd9bb3 5768 net optional tcpreen_1.4.4-2.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iIkEARYKADEWIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY21oxRMcdmFncmFudEBk
ZWJpYW4ub3JnAAoJENxRj8h/lxaqZe8BAN6J+aESiN5z7b/CukItepKN8j9GfRiv
BjfBzBvQO7dgAP4tf1u2QLIrJYGs6809s+9c1NUwQKV5xubIBBmsHHJHDg==
=916I
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.