Debian Bug report logs - #830869
debootstrap: script fails first stage due to missing devices.tar.gz despite no longer being used

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Alex Bennée <alex.bennee@linaro.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: debhelper: script fails first stage due to missing devices.tar.gz despite no longer being used

Date: Tue, 12 Jul 2016 13:00:53 +0100

Package: debhelper
Severity: normal

Since bug #571136 was fixed we no longer actually need a devices.tar.gz
to build our tarball. However we can't just checkout the debootstrap
script and call directly because it still requires the tarball. One
possible fix is attached bellow, although a more thorough cleaning could
be done:

---
Subject: [PATCH] debootstrap: fail gracefully copying devices.tgar.gz

The devices tarball only exists if you build the source code (as root)
before invoking the script. Since bug #571136 was fixed the
--second-stage doesn't even use the devices tarball so we can afford to
fail gracefully when it doesn't exist. In addition this allows us to
call the script under -e conditions from a straight checkout which is
useful in other cases.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 debootstrap | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debootstrap b/debootstrap
index 2a959bb..4027a5d 100755
--- a/debootstrap
+++ b/debootstrap
@@ -635,7 +635,7 @@ if am_doing_phase first_stage; then
        if ! am_doing_phase second_stage; then
                cp "$0"				 "$TARGET/debootstrap/debootstrap"
                cp $DEBOOTSTRAP_DIR/functions	 "$TARGET/debootstrap/functions"
-		cp $DEBOOTSTRAP_DIR/devices.tar.gz	 "$TARGET/debootstrap/devices.tar.gz"
+		cp $DEBOOTSTRAP_DIR/devices.tar.gz	 "$TARGET/debootstrap/devices.tar.gz" || true
                cp $SCRIPT			 "$TARGET/debootstrap/suite-script"
                echo "$ARCH"			>"$TARGET/debootstrap/arch"
                echo "$SUITE"			>"$TARGET/debootstrap/suite"
--
2.7.4

--
Alex Bennée

Message #10 received at submit@bugs.debian.org (full text, mbox, reply):

From: Alex Bennée <alex.bennee@linaro.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Re: Bug#830869: debhelper: script fails first stage due to missing devices.tar.gz despite no longer being used

Date: Tue, 12 Jul 2016 13:38:27 +0100

Alex Bennée <alex.bennee@linaro.org> writes:

> Package: debhelper
> Severity: normal
>
> Since bug #571136 was fixed we no longer actually need a devices.tar.gz
> to build our tarball. However we can't just checkout the debootstrap
> script and call directly because it still requires the tarball. One
> possible fix is attached bellow, although a more thorough cleaning could
> be done:
<snip>

I missed this when checking BTS for existing bugs but #770217 is
related. It seems even the Make instruction rely on Debian-isms which
isn't helpful for a script that should be platform agnostic.

I suspect this means all the devices.tar.gz gubbins should be removed.

--
Alex Bennée

Message #15 received at 830869@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: Alex Bennée <alex.bennee@linaro.org>, 830869@bugs.debian.org

Subject: Re: [debhelper-devel] Bug#830869: debhelper: script fails first stage due to missing devices.tar.gz despite no longer being used

Date: Tue, 12 Jul 2016 16:35:00 +0000

Alex Bennée:
> Package: debhelper
> Severity: normal
> 

Hi Alex,

I am a bit confused by this bug. Did you perhaps intend to submit it
against debootstrap instead of debhelper?

> Since bug #571136 was fixed we no longer actually need a devices.tar.gz
> to build our tarball. However we can't just checkout the debootstrap
> script and call directly because it still requires the tarball. One
> possible fix is attached bellow, although a more thorough cleaning could
> be done:
> 
> ---
> Subject: [PATCH] debootstrap: fail gracefully copying devices.tgar.gz
> 
> The devices tarball only exists if you build the source code (as root)
> before invoking the script. Since bug #571136 was fixed the
> --second-stage doesn't even use the devices tarball so we can afford to
> fail gracefully when it doesn't exist. In addition this allows us to
> call the script under -e conditions from a straight checkout which is
> useful in other cases.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  debootstrap | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/debootstrap b/debootstrap
> index 2a959bb..4027a5d 100755
> --- a/debootstrap
> +++ b/debootstrap
> @@ -635,7 +635,7 @@ if am_doing_phase first_stage; then
>         if ! am_doing_phase second_stage; then
>                 cp "$0"				 "$TARGET/debootstrap/debootstrap"
>                 cp $DEBOOTSTRAP_DIR/functions	 "$TARGET/debootstrap/functions"
> -		cp $DEBOOTSTRAP_DIR/devices.tar.gz	 "$TARGET/debootstrap/devices.tar.gz"
> +		cp $DEBOOTSTRAP_DIR/devices.tar.gz	 "$TARGET/debootstrap/devices.tar.gz" || true
>                 cp $SCRIPT			 "$TARGET/debootstrap/suite-script"
>                 echo "$ARCH"			>"$TARGET/debootstrap/arch"
>                 echo "$SUITE"			>"$TARGET/debootstrap/suite"
> --
> 2.7.4
> 
> --
> Alex Bennée
> 
> 
> _______________________________________________
> debhelper-devel mailing list
> debhelper-devel@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debhelper-devel
> 

Message #22 received at 830869@bugs.debian.org (full text, mbox, reply):

From: Alex Bennée <alex.bennee@linaro.org>

To: Niels Thykier <niels@thykier.net>

Cc: 830869@bugs.debian.org

Subject: Re: [debhelper-devel] Bug#830869: debhelper: script fails first stage due to missing devices.tar.gz despite no longer being used

Date: Tue, 12 Jul 2016 18:32:03 +0100

Niels Thykier <niels@thykier.net> writes:

> Alex Bennée:
>> Package: debhelper
>> Severity: normal
>>
>
> Hi Alex,
>
> I am a bit confused by this bug. Did you perhaps intend to submit it
> against debootstrap instead of debhelper?

Apologies, completion fail. I was fighting M-x debian-bug which took
several attempts to send the email.

Yes it should be against debootstrap. Can I reassign it in BTS?

>
>> Since bug #571136 was fixed we no longer actually need a devices.tar.gz
>> to build our tarball. However we can't just checkout the debootstrap
>> script and call directly because it still requires the tarball. One
>> possible fix is attached bellow, although a more thorough cleaning could
>> be done:
>>
>> ---
>> Subject: [PATCH] debootstrap: fail gracefully copying devices.tgar.gz
>>
>> The devices tarball only exists if you build the source code (as root)
>> before invoking the script. Since bug #571136 was fixed the
>> --second-stage doesn't even use the devices tarball so we can afford to
>> fail gracefully when it doesn't exist. In addition this allows us to
>> call the script under -e conditions from a straight checkout which is
>> useful in other cases.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  debootstrap | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/debootstrap b/debootstrap
>> index 2a959bb..4027a5d 100755
>> --- a/debootstrap
>> +++ b/debootstrap
>> @@ -635,7 +635,7 @@ if am_doing_phase first_stage; then
>>         if ! am_doing_phase second_stage; then
>>                 cp "$0"				 "$TARGET/debootstrap/debootstrap"
>>                 cp $DEBOOTSTRAP_DIR/functions	 "$TARGET/debootstrap/functions"
>> -		cp $DEBOOTSTRAP_DIR/devices.tar.gz	 "$TARGET/debootstrap/devices.tar.gz"
>> +		cp $DEBOOTSTRAP_DIR/devices.tar.gz	 "$TARGET/debootstrap/devices.tar.gz" || true
>>                 cp $SCRIPT			 "$TARGET/debootstrap/suite-script"
>>                 echo "$ARCH"			>"$TARGET/debootstrap/arch"
>>                 echo "$SUITE"			>"$TARGET/debootstrap/suite"
>> --
>> 2.7.4
>>
>> --
>> Alex Bennée
>>
>>
>> _______________________________________________
>> debhelper-devel mailing list
>> debhelper-devel@lists.alioth.debian.org
>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debhelper-devel
>>


--
Alex Bennée

Message #31 received at 830869@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: Alex Bennée <alex.bennee@linaro.org>

Cc: 830869@bugs.debian.org

Subject: Re: [debhelper-devel] Bug#830869: debhelper: script fails first stage due to missing devices.tar.gz despite no longer being used

Date: Tue, 12 Jul 2016 18:04:00 +0000

Alex Bennée:
> 
> Niels Thykier <niels@thykier.net> writes:
> 
>> Alex Bennée:
>>> Package: debhelper
>>> Severity: normal
>>>
>>
>> Hi Alex,
>>
>> I am a bit confused by this bug. Did you perhaps intend to submit it
>> against debootstrap instead of debhelper?
> 
> Apologies, completion fail. I was fighting M-x debian-bug which took
> several attempts to send the email.
> 
> Yes it should be against debootstrap. Can I reassign it in BTS?
> 
>>
>>[...]

Yes you can. :)

Please see [1] for the how to do it.  You may also want to retitle[2]
the bug while you are at it (as it says debhelper). :)  Finally, you
should remove the "moreinfo" tag I added.
  Do keep in mind that the maintainers will just see the reassign, but
*not* anything useful beyond that.  I would personally recommend that
you CC the debootstrap maintainers (debian-boot@lists.debian.org) on the
bug with a summary of the bug information, so they know what the bug is
about (or resend the original mail to the above list).

If you have issues with the reassign/retitle/tagging, then let me know
and I will gladly help you out. :)

~Niels

[1] https://www.debian.org/Bugs/server-control

[2] Same URL, but caveat: The retitle command easily break if you mail
agent wraps long lines for you!

Message #36 received at 830869@bugs.debian.org (full text, mbox, reply):

From: Alex Bennée <alex.bennee@linaro.org>

To: Niels Thykier <niels@thykier.net>

Cc: 830869@bugs.debian.org

Subject: Re: [debhelper-devel] Bug#830869: debhelper: script fails first stage due to missing devices.tar.gz despite no longer being used

Date: Tue, 12 Jul 2016 19:47:52 +0100

Niels Thykier <niels@thykier.net> writes:

> Alex Bennée:
>>
>> Niels Thykier <niels@thykier.net> writes:
>>
>>> Alex Bennée:
>>>> Package: debhelper
>>>> Severity: normal
>>>>
>>>
>>> Hi Alex,
>>>
>>> I am a bit confused by this bug. Did you perhaps intend to submit it
>>> against debootstrap instead of debhelper?
>>
>> Apologies, completion fail. I was fighting M-x debian-bug which took
>> several attempts to send the email.
>>
>> Yes it should be against debootstrap. Can I reassign it in BTS?
>>
>>>
>>>[...]
>
> Yes you can. :)
>
> Please see [1] for the how to do it.  You may also want to retitle[2]
> the bug while you are at it (as it says debhelper). :)  Finally, you
> should remove the "moreinfo" tag I added.

OK Thanks, I think I have it figured out now. Sorry for the noise on
your list ;-)

--
Alex Bennée

Message #43 received at 830869@bugs.debian.org (full text, mbox, reply):

From: Alex Bennée <alex.bennee@linaro.org>

To: debian-boot@lists.debian.org

Cc: 830869@bugs.debian.org

Subject: debootstrap: script fails first stage due to missing devices.tar.gz despite no longer being used

Date: Tue, 12 Jul 2016 19:59:58 +0100

Hi,

Sorry I misfiled this bug against debhelper, this has now been fixed.

In short there seems to be a bunch of cruft associated with the
devices.tar.gz file which used to be used by the second stage to set up
devices in the bootstrapped chroot. This manifests itself if you run the
script from a SCM checkout without first doing a root based build (which
only works on Debian anyway).

In my case I fixed this by simply making cp || true although I guess
there is a bigger argument for properly excising the code as it is now
longer used AFAICT, see the main script:

                if true; then
                        setup_devices_simple
                elif [ -e "$DEVICES_TARGZ" ]; then
                        zcat "$DEVICES_TARGZ" | (cd "$TARGET"; tar -xf -)
                else
                        error 1 NODEVTGZ "no %s. cannot create devices" "$DEVICES_TARGZ"
                fi

Sorry for the additional bug noise.

--
Alex Bennée

Message #48 received at 830869@bugs.debian.org (full text, mbox, reply):

From: Alex Bennée <alex.bennee@linaro.org>

To: 830869@bugs.debian.org

Cc: Alex Bennée <alex.bennee@linaro.org>

Subject: [PATCH] debootstrap: excise all devices.tar.gz code

Date: Tue, 6 Sep 2016 14:05:51 +0100

Since bug #571136 was fixed the --second-stage doesn't even use the
devices tarball so we can remove all its related cruft. The README has
been updated to show when real root access is required and give an
example of a foreign debootstrap which works with fakeroot.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .gitignore  |  1 -
 Makefile    | 25 -------------------------
 README      | 18 ++++++++++++++----
 debootstrap |  3 ---
 functions   |  8 +-------
 5 files changed, 15 insertions(+), 40 deletions(-)

diff --git a/.gitignore b/.gitignore
index 8b3512f..8b13789 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1 @@
-devices.tar.gz
 
diff --git a/Makefile b/Makefile
index 1020cbc..55f229d 100644
--- a/Makefile
+++ b/Makefile
@@ -2,17 +2,9 @@
 VERSION := $(shell sed 's/.*(\(.*\)).*/\1/; q' debian/changelog)
 DATE := $(shell sed -n '/^ -- /{s/.*> \(.*\)/\1/p;q;}' debian/changelog)
 
-MAKEDEV ?= /sbin/MAKEDEV
-
-ifeq ($(shell uname),Linux)
-all: devices.tar.gz
-else
 all:
-endif
 
 clean:
-	rm -f devices.tar.gz
-	rm -rf dev
 
 DSDIR=$(DESTDIR)/usr/share/debootstrap
 install:
@@ -25,20 +17,3 @@ install:
 	sed 's/@VERSION@/$(VERSION)/g' debootstrap >$(DESTDIR)/usr/sbin/debootstrap
 	chown root:root $(DESTDIR)/usr/sbin/debootstrap
 	chmod 0755 $(DESTDIR)/usr/sbin/debootstrap
-
-ifeq ($(shell uname),Linux)
-	install -o root -g root -m 0644 devices.tar.gz $(DSDIR)/
-endif
-
-devices.tar.gz:
-	rm -rf dev
-	mkdir -p dev
-	chown 0:0 dev
-	chmod 755 dev
-	(cd dev && $(MAKEDEV) std ptmx fd consoleonly)
-	tar --mtime="$(DATE)" -cf - dev | gzip -9n >devices.tar.gz
-	@if [ "$$(tar tvf devices.tar.gz | wc -l)" -lt 2 ]; then \
-		echo " ** devices.tar.gz is empty!" >&2; \
-		exit 1; \
-	fi
-	rm -rf dev
diff --git a/README b/README
index 5c08e15..af30a75 100644
--- a/README
+++ b/README
@@ -18,11 +18,21 @@ First, get the source.
 * Or by visiting <http://packages.debian.org/source/sid/debootstrap>
   and downloading the tar.gz file
 
-Then as root, in the debootstrap source directory:
+Then in the debootstrap source directory:
 
-make devices.tar.gz
-export DEBOOTSTRAP_DIR=`pwd`
-debootstrap sid sid
+    export DEBOOTSTRAP_DIR=`pwd`
+    sudo ./debootstrap stable my-stable-dir
+
+If you are running a multi-stage boot strap (for example for a QEMU
+rootfs) you don't even need root:
+
+    export DEBOOTSTRAP_DIR=`pwd`
+    fakeroot ./debootstrap --foreign --arch=armhf testing my-testing-dir http://httpredir.debian.org/debian
+
+Of course you will need to execute the second stage as root to finish the bootstrap:
+
+   (on foreign hardware)
+   /debootstrap/debootstrap --second-stage
 
 
 Future
diff --git a/debootstrap b/debootstrap
index 2a959bb..4cea268 100755
--- a/debootstrap
+++ b/debootstrap
@@ -18,8 +18,6 @@ if [ -z "$DEBOOTSTRAP_DIR" ]; then
 	fi
 fi
 
-DEVICES_TARGZ=$DEBOOTSTRAP_DIR/devices.tar.gz
-
 . $DEBOOTSTRAP_DIR/functions
 exec 4>&1
 
@@ -635,7 +633,6 @@ if am_doing_phase first_stage; then
 	if ! am_doing_phase second_stage; then
 		cp "$0"				 "$TARGET/debootstrap/debootstrap"
 		cp $DEBOOTSTRAP_DIR/functions	 "$TARGET/debootstrap/functions"
-		cp $DEBOOTSTRAP_DIR/devices.tar.gz	 "$TARGET/debootstrap/devices.tar.gz"
 		cp $SCRIPT			 "$TARGET/debootstrap/suite-script"
 		echo "$ARCH"			>"$TARGET/debootstrap/arch"
 		echo "$SUITE"			>"$TARGET/debootstrap/suite"
diff --git a/functions b/functions
index 031721f..67701ee 100644
--- a/functions
+++ b/functions
@@ -1065,13 +1065,7 @@ setup_devices () {
 	    hurd*)
 		;;
 	    *)
-		if true; then
-			setup_devices_simple
-		elif [ -e "$DEVICES_TARGZ" ]; then
-			zcat "$DEVICES_TARGZ" | (cd "$TARGET"; tar -xf -)
-		else
-			error 1 NODEVTGZ "no %s. cannot create devices" "$DEVICES_TARGZ"
-		fi
+		setup_devices_simple
 		;;
 	esac
 }
-- 
2.9.3

Message #53 received at 830869@bugs.debian.org (full text, mbox, reply):

From: Steve McIntyre <steve@einval.com>

To: Alex Bennée <alex.bennee@linaro.org>, 830869@bugs.debian.org

Subject: Re: Bug#830869: [PATCH] debootstrap: excise all devices.tar.gz code

Date: Tue, 6 Sep 2016 14:35:07 +0100

On Tue, Sep 06, 2016 at 02:05:51PM +0100, Alex Bennée wrote:
>Since bug #571136 was fixed the --second-stage doesn't even use the
>devices tarball so we can remove all its related cruft. The README has
>been updated to show when real root access is required and give an
>example of a foreign debootstrap which works with fakeroot.

Cool, thanks for the patch. Just pushed to git now.

-- 
Steve McIntyre, Cambridge, UK.                                steve@einval.com
You raise the blade, you make the change... You re-arrange me 'til I'm sane...

Message #58 received at 830869-close@bugs.debian.org (full text, mbox, reply):

From: Christian Perrier <bubulle@debian.org>

To: 830869-close@bugs.debian.org

Subject: Bug#830869: fixed in debootstrap 1.0.82

Date: Thu, 08 Sep 2016 07:18:35 +0000

Source: debootstrap
Source-Version: 1.0.82

We believe that the bug you reported is fixed in the latest version of
debootstrap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 830869@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated debootstrap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 08 Sep 2016 07:09:56 +0200
Source: debootstrap
Binary: debootstrap debootstrap-udeb
Architecture: source all
Version: 1.0.82
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description:
 debootstrap - Bootstrap a basic Debian system
 debootstrap-udeb - Bootstrap the Debian system (udeb)
Closes: 830869
Changes:
 debootstrap (1.0.82) unstable; urgency=medium
 .
   [ Alex Bennée ]
   * Excise all devices.tar.gz code. Closes: #830869
Checksums-Sha1:
 991d6f3909133e031d4a2136b99f005a1ae1eb56 1812 debootstrap_1.0.82.dsc
 cfd4dc164bf72e913d8c217f721ac2e30750d8ad 64344 debootstrap_1.0.82.tar.gz
 32514c78f552db0fd70d746690ea297cf0f3e3be 17998 debootstrap-udeb_1.0.82_all.udeb
 2e681f318f7fee9f9702c4c7d39d09a86fd1d35d 64122 debootstrap_1.0.82_all.deb
Checksums-Sha256:
 bbaaf1211ef87f8a81cfccd886ebaac6183d759961f8203cc012ff1de82b57c0 1812 debootstrap_1.0.82.dsc
 db0dfad15d5338a8cdbcc3bbfda8dc59c58edf07511303f31746ef6fcc733835 64344 debootstrap_1.0.82.tar.gz
 a6f8ad08a86a872805c8c253110657a750ff72cd7aa2c1bae14633ef94673c1b 17998 debootstrap-udeb_1.0.82_all.udeb
 ca32de028f055f7839b18f42d0d95b8ccc6c5607cdc2cd7b6e363ad854f5689e 64122 debootstrap_1.0.82_all.deb
Files:
 a37bfb5290c0ecf891c75bc03c3f857c 1812 admin extra debootstrap_1.0.82.dsc
 224887f2d815431df3e4c56c24789b8d 64344 admin extra debootstrap_1.0.82.tar.gz
 2958e0ac08192656d95979c25979aad4 17998 debian-installer extra debootstrap-udeb_1.0.82_all.udeb
 be3fdc86fed805f095eca6af18ea840f 64122 admin extra debootstrap_1.0.82_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJX0Q7lAAoJEIcvcCxNbiWoIfMP/ibTyw+znCZndHGR45gsC3+P
mCz3ENe7HBDvtlEAP6RU6raK62FN8J9a/2/W/GItEvZDdgHHocN9v3g91OQHkk9P
rjfmfRu7Vyi6xrYEPLTFnvflT6ujKsEb/+JYY8Vbe2YE7zKxuuLZBIq51jKMIUze
FhO4ONaeg8gYaJuNdv4s+bd60EZHK6ySy7Wj5RT0wgcgCYWTTp5FDSnFSg1x9i1Q
yRXZ37InwCE4hFZOPoQoS9Xv6GrbzfdOKzN54HbW35jTe4HINVJZnC+VzFLuCfQ0
24EKWIxS+xgvay8eBp8R8hVpM0gRF1+LwLf2eHoSDA969EuyMjYblLJZuCiV3OUM
+mZSx+jNuHuIaUF/H15DfAtL2ah//SLhi4aWyxF19SAqALOQh+hwUdKWOE9C/sJR
Vpq6lLGxv9q/z1bBZKlIrmdZGmXyCkWLNTF3O739HacCKvX31PhfswTN9Xzd1IE0
mvuciqsxmItxXbC3dJkDr661VE2Gq6YPHBi3WDxOXuhGLSY+lsnKkb0naPNkESM9
AOXcmKbclvWo2TpkI6b05NC+IF7Jg86ECbtYutIGtfltOZofP9jBL5UDG7uoK+8n
aaJmjGpn/sjT40cu4+898e+7EwsvgHIfeju2HArU0vSBVFQCt56qchdUM+sUC+yg
tolvPJtWMxBbK1A1Zt61
=S74w
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.