Debian Bug report logs - #830824
[zfs-linux] Silently corrupted file in snapshots after send/receive

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Antonio Russo <antonio.e.russo@gmail.com>

To: submit@bugs.debian.org

Subject: [zfs-linux] Silently corrupted file in snapshots after send/receive

Date: Mon, 11 Jul 2016 15:23:25 -0700

Package: zfs-dkms
Version: 0.6.5.7-1
Severity: grave

--- Please enter the report below this line. ---

See ZoL bug report.

https://github.com/zfsonlinux/zfs/issues/4809

aka Illumos 6513

Short summary: Pools with hole_birth feature enabled are susceptible to
irreversible damage interfering with, in particular, proper zfs send/receive
behavior. The bug fix is in 0.6.5.8, but does not repair damage already
inflicted to the pool.

From the ZoL bugreport, user pcd1193182:

 > The fix for illumos 6513 will solve this problem, but not retroactively.
 > In other words, any pools that already have this state will not be fixed;
 > on such pools, the hole BPs already have their birth times set to zero,
 > and zfs has no way of telling which ones are bugged and which are right.
 > Any new pools, created after the fix has been applied, will work.

Message #10 received at 830824@bugs.debian.org (full text, mbox, reply):

From: Antonio Russo <antonio.e.russo@gmail.com>

To: 830824@bugs.debian.org

Date: Mon, 11 Jul 2016 15:54:46 -0700

Sorry, there is no 0.6.5.8 release. The fix does exist in the master branch, however.
(bc77ba7: OpenZFS 6513 - partially filled holes lose birth time)

Message #15 received at 830824@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: Antonio Russo <antonio.e.russo@gmail.com>, 830824@bugs.debian.org

Subject: Re: Silently corrupted file in snapshots after send/receive

Date: Tue, 9 Aug 2016 16:35:21 +0200

[ Antonio Russo 2016-07-11 ]
> Sorry, there is no 0.6.5.8 release. The fix does exist in the master branch,
> however.  (bc77ba7: OpenZFS 6513 - partially filled holes lose birth time)

As far as I can see from <URL: https://github.com/zfsonlinux/zfs/issues/4809 >,
the issue is still unsolved upstream.

Are you sure that commit is enough to solve the problem?  There are others
mentioned in issue #4809.

See also <URL: https://www.illumos.org/issues/6370 >,
<URL: https://www.illumos.org/issues/6513 > and
<URL: https://www.illumos.org/issues/6844 >.

-- 
Happy hacking
Petter Reinholdtsen

Message #20 received at 830824@bugs.debian.org (full text, mbox, reply):

From: Carlos Alberto Lopez Perez <clopez@igalia.com>

To: Petter Reinholdtsen <pere@hungry.com>, 830824@bugs.debian.org, Antonio Russo <antonio.e.russo@gmail.com>

Subject: Re: [Pkg-zfsonlinux-devel] Bug#830824: Silently corrupted file in snapshots after send/receive

Date: Thu, 11 Aug 2016 17:51:39 +0200

[Message part 1 (text/plain, inline)]

On 09/08/16 16:35, Petter Reinholdtsen wrote:
> [ Antonio Russo 2016-07-11 ]
>> Sorry, there is no 0.6.5.8 release. The fix does exist in the master branch,
>> however.  (bc77ba7: OpenZFS 6513 - partially filled holes lose birth time)
> 
> As far as I can see from <URL: https://github.com/zfsonlinux/zfs/issues/4809 >,
> the issue is still unsolved upstream.
> 
> Are you sure that commit is enough to solve the problem?  There are others
> mentioned in issue #4809.
> 
> See also <URL: https://www.illumos.org/issues/6370 >,
> <URL: https://www.illumos.org/issues/6513 > and
> <URL: https://www.illumos.org/issues/6844 >.
> 

It seems there are several issues affecting zfs send/receive when the
hole_birth feature is enabled.

Commit bc77ba7 fixes one of this issues, but not the others.

The best fix right now seems to completely ignore hole_birth. A patch
was proposed here that ignores it, and adds a module parameter to enable
it back [1].

Options I see going forward:

1) Wait for the patch on PR #4833 to be merged, then import it
defaulting to ignore hole_birth until the issue is fixed.

2) If we don't want to wait for the patch to be merged, we can import it
anyway but removing the part that adds a kernel module parameter tunable
to avoid adding any option that is still not upstreamed. So just disable
hole_birth always.

3) Do nothing and wait for upstream to fix this issues with hole_birth
and zfs send/receive.


Right now, I'm inclined to proceed with option #2 and disable hole_birth
until the issues with it are 100% fixed upstream and a new major release
is made.

Opinions?


PS: There is still an user reporting some problems observed even with
ignore_hole_birth=1, but is still not 100% clear if in this case the
problem is the same. Let's wait some days to see how this evolves [2].


BTW: I'm a bit surprised that this has been raised to RC bug on Debian
unstable, but on Ubuntu LTS nobody cares about it. [3]
Or I'm missing something?


[1] https://github.com/zfsonlinux/zfs/pull/4833
[2] https://github.com/zfsonlinux/zfs/issues/4809#issuecomment-238503468
[3] https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1600060

[signature.asc (application/pgp-signature, attachment)]

Message #25 received at 830824@bugs.debian.org (full text, mbox, reply):

From: Carlos Alberto Lopez Perez <clopez@igalia.com>

To: Petter Reinholdtsen <pere@hungry.com>, 830824@bugs.debian.org, Antonio Russo <antonio.e.russo@gmail.com>, rlaager@wiktel.com

Subject: Re: [Pkg-zfsonlinux-devel] Bug#830824: Bug#830824: Silently corrupted file in snapshots after send/receive

Date: Tue, 16 Aug 2016 15:33:37 +0200

[Message part 1 (text/plain, inline)]

Control: tag -1 +pending
On 11/08/16 17:51, Carlos Alberto Lopez Perez wrote:
> 1) Wait for the patch on PR #4833 to be merged, then import it
> defaulting to ignore hole_birth until the issue is fixed.

This patch was finally merged on ZoL/master but with the option set to
false by default.

I have cherry-picked it and then added another patch defaulting it to true.

On the PR #4833 [1], Brian Behlendorf comments he is also thinking in
defaulting this to true for the upcoming 0.8.5

Regards.

[1] https://github.com/zfsonlinux/zfs/pull/4833

[signature.asc (application/pgp-signature, attachment)]

Message #32 received at 830824-close@bugs.debian.org (full text, mbox, reply):

From: Carlos Alberto Lopez Perez <clopez@igalia.com>

To: 830824-close@bugs.debian.org

Subject: Bug#830824: fixed in zfs-linux 0.6.5.7-2

Date: Wed, 17 Aug 2016 05:48:50 +0000

Source: zfs-linux
Source-Version: 0.6.5.7-2

We believe that the bug you reported is fixed in the latest version of
zfs-linux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 830824@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Carlos Alberto Lopez Perez <clopez@igalia.com> (supplier of updated zfs-linux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 16 Aug 2016 17:43:48 +0200
Source: zfs-linux
Binary: libnvpair1linux libuutil1linux libzfslinux-dev libzfs2linux libzpool2linux zfs-dkms zfs-initramfs zfs-dracut zfsutils-linux zfs-zed zfs-dbg
Architecture: source
Version: 0.6.5.7-2
Distribution: unstable
Urgency: medium
Maintainer: Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>
Changed-By: Carlos Alberto Lopez Perez <clopez@igalia.com>
Description:
 libnvpair1linux - Solaris name-value library for Linux
 libuutil1linux - Solaris userland utility library for Linux
 libzfs2linux - OpenZFS filesystem library for Linux
 libzfslinux-dev - OpenZFS filesystem development files for Linux
 libzpool2linux - OpenZFS pool library for Linux
 zfs-dbg    - Debugging symbols for OpenZFS userland libraries and tools
 zfs-dkms   - OpenZFS filesystem kernel modules for Linux
 zfs-dracut - OpenZFS root filesystem capabilities for Linux - dracut
 zfs-initramfs - OpenZFS root filesystem capabilities for Linux - initramfs
 zfs-zed    - OpenZFS Event Daemon
 zfsutils-linux - command-line tools to manage OpenZFS filesystems
Closes: 824976 830652 830824 832280 832938
Changes:
 zfs-linux (0.6.5.7-2) unstable; urgency=medium
 .
   [ Aron Xu ]
   * Add busybox to zfs-initramfs list of dependencies. (Closes: #824976)
 .
   [ Petter Reinholdtsen ]
   * Updated Danish debconf translation by Joe Hansen. (Closes: #830652)
   * Added Dutch (nl) debconf translation by Frans Spiesschaert. (Closes: #832280)
   * Norwegian Bokmål (nb) debconf template translation by Petter Reinholdtsen.
 .
   [ Eric Desrochers ]
   * Change utilities path (bindir) to /usr/sbin. (Closes: #832938)
 .
   [ Carlos Alberto Lopez Perez]
   * Add tunable to ignore hole_birth, and enable it by default. (Closes: #830824)
Checksums-Sha1:
 a546eb573432ecbaf1cccc82c86deb575698b681 2905 zfs-linux_0.6.5.7-2.dsc
 1e807e20538ceeb567027b983dc1304a5b450f9d 38084 zfs-linux_0.6.5.7-2.debian.tar.xz
Checksums-Sha256:
 16a13982308c7b121ec3a6a12d64fa8a548d12e9516e5d39070ffd2f98f5ae35 2905 zfs-linux_0.6.5.7-2.dsc
 093534501c86189694d37c49c5f22c769c8bcb338a267785e8ec6ca8ebff25c1 38084 zfs-linux_0.6.5.7-2.debian.tar.xz
Files:
 cbebc1112ec5b56ca962aeb217ec306a 2905 contrib/kernel optional zfs-linux_0.6.5.7-2.dsc
 faba598924297c41510acb44d0855bb8 38084 contrib/kernel optional zfs-linux_0.6.5.7-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJXs/fjAAoJEIEoCqCHuvsOX5IP/2BDZMpm/rn+OrDHufe5OZfT
27dgoPX4D6kwd2UcxvJ7cpgm97DIbN2hJCL8vRYfAQrfYaXYFdaDziiCLAdVgfk9
WXygCdzkKvTC+q1kIBYlNs3l0yzF7bI8mKEfxClSqKyX8KMOtF3gA2mMiNqR6qXK
0LS0moxie6DVsRnUCZ/dMfbhBerL0z1FgZcubpKGj6wdw4HNmVCnMkk333zNlDIy
sAK4UxNowUSQ8dBg+3SyCxIyEQ5gfn38QcT4zAyFSMtNui34+LGOsHfzVv2SEUuM
3MTIzsoBaLzaOLveC/d1PQ4nUQEYYdcoHHctslU+gQq3D5LRuF7tUXA7q9t5cGWr
WZ8IW24thMsn7AwDZzjTjsGsafFuketxCSLrRgGrHpitkKu426kP6X2RHQIj9vSV
ICcz6QO14i9Z9NPaxGdJvXW05nDIP5MZtkphk80l1gu0SyS6L8XMEExhPatcEaWq
Tw8xIMMVUwS4XxO+Ph3KHQR2AjPd0j36ijwgTXClxhEyKED0PZ3ovIoxQi/d+eSd
kM5+9GQ6WA0AE+IgsfDsLwODik8nsBzC33sePNXuIalHZ61L9F8wwpMIyLS1fPWO
KIpKe+0DQlDUI2bMu7NRQ4h0vgrxt4vFoq3QgvzGEU0/PoW4wPomfeIeCol6pgIG
nGb5NcvOuy4gCLDNfP4a
=ch+A
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.