Debian Bug report logs - #830748
supertuxkart: FTBFS on arm64, mips/mips64/mipsel, ppc64el, s390x

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vincent Cheng <vcheng@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: supertuxkart: FTBFS on arm64, mips/mips64/mipsel, ppc64el, s390x

Date: Sun, 10 Jul 2016 21:28:19 -0700

Package: supertuxkart
Version: 0.9.2-1
Severity: serious
Justification: fails to build from source (but built successfully in the past)

supertuxkart/0.9.2-1 FTBFS on arm64, mips/mips64/mipsel, ppc64el, and
s390x; full build log at [1], and here's the relevant part of the log:

[  9%] Building CXX object
lib/irrlicht/CMakeFiles/stkirrlicht.dir/source/Irrlicht/CGUIMeshViewer.cpp.o
cd /«PKGBUILDDIR»/obj-aarch64-linux-gnu/lib/irrlicht && /usr/bin/c++
-DGLEW_NO_GLU -DIRRLICHT_EXPORTS=1 -DNDEBUG=1
-DNO_IRR_LINUX_X11_VIDMODE_ -DPNG_NO_MMX_CODE -DPNG_NO_MNG_FEATURES
-DPNG_THREAD_UNSAFE_OK -D_IRR_LINUX_X11_RANDR_
-I/«PKGBUILDDIR»/lib/bullet/src -I/«PKGBUILDDIR»/lib/glew/include
-I/«PKGBUILDDIR»/lib/irrlicht/include  -g -O2 -fstack-protector-strong
-Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2
-Wall -pipe -O3  -fno-exceptions  -fstrict-aliasing
-I/usr/X11R6/include -Wall -pipe -O3  -fno-exceptions
-fstrict-aliasing -I/usr/X11R6/include -fexpensive-optimizations -O2
-DNDEBUG   -o CMakeFiles/stkirrlicht.dir/source/Irrlicht/CGUIMeshViewer.cpp.o
-c /«PKGBUILDDIR»/lib/irrlicht/source/Irrlicht/CGUIMeshViewer.cpp
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp: In
function 'asQWORD X64_CallFunction(const asQWORD*, int, funcptr_t,
asQWORD&, bool)':
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%rcx' in 'asm'
     "%rdi", "%rsi", "%rax", "%rdx", "%rcx", "%r8", "%r9", "%r10",
"%r11", "%r15");

           ^
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%rdx' in 'asm'
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%rax' in 'asm'
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%rsi' in 'asm'
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%rdi' in 'asm'
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%xmm7' in 'asm'
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%xmm6' in 'asm'
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%xmm5' in 'asm'
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%xmm4' in 'asm'
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%xmm3' in 'asm'
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%xmm2' in 'asm'
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%xmm1' in 'asm'
/«PKGBUILDDIR»/lib/angelscript/source/as_callfunc_x64_gcc.cpp:162:82:
error: unknown register name '%xmm0' in 'asm'


It looks like angelscript is misdetecting certain architectures as x86
and hence applying the wrong assembly directives. It's worth checking
first to see if there's a fix for this in upstream angelscript before
fixing it in supertuxkart. I'll take a look at this when I have time,
but help is greatly appreciated if someone has a chance to tackle this
before I do.

Regards,
Vincent

[1] https://buildd.debian.org/status/package.php?p=supertuxkart&suite=unstable

Message #14 received at 830748@bugs.debian.org (full text, mbox, reply):

From: Adrian Bunk <bunk@stusta.de>

To: 830748@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Causes of the supertuxkart FTBFS

Date: Thu, 18 Aug 2016 13:17:48 +0300

tags 830748 -help
thanks

There seem to be at least two different bugs causing these FTBFS issues.

Below are (untested) explanations which changes between 0.9.1 and 0.9.2 
caused them, and suggestions how fixes might look like.


The FTBFS on 64bit platforms is caused by the following change in 
lib/angelscript/source/as_config.h:

@@ -835,7 +844,7 @@
                        #define THISCALL_PASS_OBJECT_POINTER_ON_THE_STACK
                        #define AS_X86
                        #undef AS_NO_THISCALL_FUNCTOR_METHOD
-               #elif defined(__x86_64__)
+               #elif defined(__LP64__) && !defined(__arm64__)
                        #define AS_X64_GCC
                        #undef AS_NO_THISCALL_FUNCTOR_METHOD
                        #define HAS_128_BIT_PRIMITIVES

This nicely explains the 64bit build failures.

A second bug here is that the actual define is __aarch64__ and not 
__arm64__ (so even the aarch64 build got broken).
That explains why the aarch64 build also got broken.

This change went from doing the right thing (only use the x86_64 code
on x86_64) to something worse (use the x86_64 code on all 64bit platforms 
except ones explicitely excluded).

I would suggest to simply revert this change, but upstream should be 
asked why this change was done in the first place.


32bit mips build failures are a separate issue, caused by another change 
in lib/angelscript/source/as_config.h:

-                       // Native calling conventions for Linux/Mips do not work yet.
-                       #define AS_MAX_PORTABILITY
+                       #ifdef _ABIO32
+                               #define AS_MIPS
+
+                               // All structures are returned in memory regardless of size or complexity
+                               #define THISCALL_RETURN_SIMPLE_IN_MEMORY
+                               #define THISCALL_RETURN_SIMPLE_IN_MEMORY_MIN_SIZE 0
+                               #define CDECL_RETURN_SIMPLE_IN_MEMORY
+                               #define CDECL_RETURN_SIMPLE_IN_MEMORY_MIN_SIZE 0
+                               #define STDCALL_RETURN_SIMPLE_IN_MEMORY
+                               #define CDECL_RETURN_SIMPLE_IN_MEMORY_MIN_SIZE 0
+                               #undef AS_NO_THISCALL_FUNCTOR_METHOD
+                       #else
+                               // For other ABIs the native calling convention is not available (yet)
+                               #define AS_MAX_PORTABILITY
+                       #endif

No longer defining AS_MAX_PORTABILITY in O32 builds makes 
lib/angelscript/source/as_callfunc.cpp call code from
lib/angelscript/source/as_callfunc_mips.cpp, but this file
is not compiled since it was not added to 
lib/angelscript/projects/cmake/CMakeLists.txt

Adding it to CMakeLists.txt should fix the 32bit mips build.


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Message #21 received at 830748@bugs.debian.org (full text, mbox, reply):

From: Radovan Birdic <Radovan.Birdic@imgtec.com>

To: "830748@bugs.debian.org" <830748@bugs.debian.org>

Subject: Bug#830748: supertuxkart: FTBFS on arm64, mips/mips64/mipsel, ppc64el, s390x

Date: Thu, 29 Sep 2016 09:52:03 +0000

[Message part 1 (text/plain, inline)]

Hello,

I have tried changes that you have suggested, with them, supertuxkart was building successfully on mips, mipsel, mips64el, i386 and amd64.

add-as_callfunc_mips-to-CMakeLists.patch - adds as_callfunc_mips.cpp file into CMakeLists.txt
fix-non-x86-arches-build.patch - fix angelscript build on non-x86 64-bits arches.

The patches that contains mentioned changes are attached.

[add-as_callfunc_mips-to-CMakeLists.patch (text/x-patch, attachment)]

[fix-non-x86-arches-build.patch (text/x-patch, attachment)]

Message #26 received at 830748@bugs.debian.org (full text, mbox, reply):

From: Radovan Birdic <Radovan.Birdic@imgtec.com>

To: "830748@bugs.debian.org" <830748@bugs.debian.org>

Subject: Re: supertuxkart: FTBFS on arm64, mips/mips64/mipsel, ppc64el, s390x

Date: Thu, 29 Sep 2016 09:41:51 +0000

[Message part 1 (text/plain, inline)]

Hello,

I have tried changes that you have suggested, with them, supertuxkart was building successfully on mips, mipsel, mips64el, i386 and amd64.

add-as_callfunc_mips-to-CMakeLists.patch - adds as_callfunc_mips.cpp file into CMakeLists.txt
fix-non-x86-arches-build.patch - fix angelscript build on non-x86 64-bits arches.

The patches that contains mentioned changes are attached.

[fix-non-x86-arches-build.patch (text/x-patch, attachment)]

[add-as_callfunc_mips-to-CMakeLists.patch (text/x-patch, attachment)]

Message #31 received at 830748@bugs.debian.org (full text, mbox, reply):

From: Deve <deveee@gmail.com>

To: 830748@bugs.debian.org

Subject: supertuxkart: FTBFS on arm64, mips/mips64/mipsel, ppc64el, s390x

Date: Mon, 3 Oct 2016 23:52:16 +0200

[Message part 1 (text/plain, inline)]

Hi,

It should be fixed in this commit:
https://github.com/supertuxkart/stk-code/commit/5e05f1178ce6bc5f3a653b55ab3dc6d016196341

This modification is already applied in upstream angelscript:
https://sourceforge.net/p/angelscript/code/2353/

Vincent Cheng confirmed that it works in this comment:
https://github.com/supertuxkart/stk-code/issues/2569#issuecomment-250677264

I attached the patch.

Regards,
Deve

[0001-Fixed-compiler-error-on-Linux-with-non-x86-64bit-pla.patch (text/x-patch, attachment)]

Message #38 received at 830748-close@bugs.debian.org (full text, mbox, reply):

From: Vincent Cheng <vcheng@debian.org>

To: 830748-close@bugs.debian.org

Subject: Bug#830748: fixed in supertuxkart 0.9.2+dfsg-2

Date: Sun, 04 Dec 2016 05:04:35 +0000

Source: supertuxkart
Source-Version: 0.9.2+dfsg-2

We believe that the bug you reported is fixed in the latest version of
supertuxkart, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 830748@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vincent Cheng <vcheng@debian.org> (supplier of updated supertuxkart package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat,  3 Dec 2016 19:39:13 PST
Source: supertuxkart
Binary: supertuxkart supertuxkart-data supertuxkart-dbg
Architecture: source all
Version: 0.9.2+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Vincent Cheng <vcheng@debian.org>
Description: 
 supertuxkart - 3D kart racing game
 supertuxkart-data - 3D kart racing game (data)
 supertuxkart-dbg - 3D kart racing game (debug)
Closes: 830748 830751 832062
Changes:
 supertuxkart (0.9.2+dfsg-2) unstable; urgency=medium
 .
   * Fix FTBFS on arm64, mips/mips64/mipsel, ppc64el, s390x. (Closes: #830748)
     - Add debian/patches/fix_angelscript_ftbfs.patch.
   * Remove non-free Ubuntu Font Family fonts, replaced with Cantarell.
     (Closes: #830751)
     - Add new dependency on fonts-cantarell.
     - Add debian/patches/replace-fonts-ubuntu-with-cantarell.patch to replace
       references to Ubuntu Font Family fonts.
   * Clarify licensing for Boom_boom_boom.ogg and add source mod files to
     tarball. (Closes: #832062)
     - Add debian/patches/update_boom_boom_boom_license.patch.
Checksums-Sha256: 
 15c48d2c264dea6d6f61d851e331e91ded4b7d83b30b483bb69553b7de9b53b0 2516 supertuxkart_0.9.2+dfsg-2.dsc
 1a888927283761010c57072f494ade2f4c9394867b5a894a08043839355ca4d5 501311920 supertuxkart_0.9.2+dfsg.orig.tar.xz
 e177ee6dc8af535e9a19ca87c3325653f53aab58e526c81a7c8f158b3d9fd174 2499604 supertuxkart_0.9.2+dfsg-2.debian.tar.xz
 49e095db2fc2822fea63ae011e2b98faaeb8c959fae0aadeb82770124ccc72fa 487066874 supertuxkart-data_0.9.2+dfsg-2_all.deb
Checksums-Sha1: 
 241b7835121e64635af1f296b6f37daf7d7f99a6 2516 supertuxkart_0.9.2+dfsg-2.dsc
 ce17c8e83dd53b78c3b06982b19b6933ec87aad1 501311920 supertuxkart_0.9.2+dfsg.orig.tar.xz
 abe5d0d3c6c27ec6c467be33b6cffa25d5473bd0 2499604 supertuxkart_0.9.2+dfsg-2.debian.tar.xz
 867cd98f732990fdce1dac9dc68577ed06201981 487066874 supertuxkart-data_0.9.2+dfsg-2_all.deb
Files: 
 10d3148550786c3b7200283e9e1137d1 2516 games optional supertuxkart_0.9.2+dfsg-2.dsc
 ccad08c877fb79606c60d92a2acb69d3 501311920 games optional supertuxkart_0.9.2+dfsg.orig.tar.xz
 fe838082180802f2815d82cf58445bf2 2499604 games optional supertuxkart_0.9.2+dfsg-2.debian.tar.xz
 81823cca1b231147dcebddfd8d578aa6 487066874 games optional supertuxkart-data_0.9.2+dfsg-2_all.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE1TqBWjy3ZZr4guOVju3MG6ofMv8FAlhDj/gACgkQju3MG6of
Mv9Rfw//Qn0Gr9ZJQM6VzYoOYZ+QibveBy9eESv5OnbKMk9D189eF3sVVyXv0Jd7
P3Ij0UBkUB5+OJWBIPm89GJld+VZaLN3gYkEOk9vgp0DiXijsvkYuB2h0S1ZKsXd
ixp8zZDFL7UrL3BaYMyxj4V0SeetqA1dkwMfPDB/r0vm3VjjIu4CJGzzS1Gm8LhC
TZpvGEu8960mfsr9ubZg5CPXIiW/d0rewXPixLtE4y9heV45s7se4+qJr2xUjatR
BPQBPajD4mF5yvlvSeLvvy0vKd2qcHeQ9teJgPF5TW9aIukvZIjPA0PBE071cLng
1e4IHr8R+zyOVHPLLmWjMfasdTM1A52EOh3jpJUoiDl1BVoCUaAPNYJB07OvfwJU
PwmULA2NaQtnE+Gzs4iWKNeC1Ai34CFfCBxElPExhrNT+3A8D0F41QKjkTjQYHyW
QTatNP7sWspYX5VGyWSkiSXXiXaWINpX5R+zgGeXQ+KqgNcd6kxhUKLIAF6jM5RN
E9PjXWF+8wN5UA6UC+sAjtoWnxUqlK4N72byNtPJmUpUr6AX/chLjaRLDB/2mL9u
87Adrm6KdNwbg5kzbhK/p36waFjBbWEMD+PVlCGrHi2Rn/dd+HpOosOc0eroOI3I
ClOAkJvst6fLKN9vNA6zzmeRK6H5YdDtvzkgzwPbiJca39/b5NE=
=XEIx
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.