Debian Bug report logs - #829123
dkms: dh_dkms name and version parsing can fail silently

version graph

Package: dkms; Maintainer for dkms is Dynamic Kernel Module System Team <dkms@packages.debian.org>; Source for dkms is src:dkms (PTS, buildd, popcon).

Reported by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

Date: Thu, 30 Jun 2016 18:21:01 UTC

Severity: normal

Tags: patch

Found in version dkms/2.2.0.3-4

Fixed in version dkms/2.2.0.3-5

Done: Aron Xu <aron@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, dkg@fifthhorseman.net, Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>:
Bug#829123; Package dkms. (Thu, 30 Jun 2016 18:21:06 GMT) (full text, mbox, link).


Acknowledgement sent to Daniel Kahn Gillmor <dkg@fifthhorseman.net>:
New Bug report received and forwarded. Copy sent to dkg@fifthhorseman.net, Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>. (Thu, 30 Jun 2016 18:21:06 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: dkms: dh_dkms name and version parsing can fail silently
Date: Thu, 30 Jun 2016 14:16:17 -0400
[Message part 1 (text/plain, inline)]
Package: dkms
Version: 2.2.0.3-4
Severity: normal
Tags: patch

In some cases, the dkms file is mis-written, or the dh_dkms file
parsing is too brittle to find the package name or version.

This pair of patches should:

 (a) make dh_dkms fail explicitly when the file is unparseable, and

 (b) make the parsing slightly less brittle in cases where
     PACKAGE_VERSION and PACKAGE_NAME are unquoted.

Thanks for dh_dkms!

Regards,

       --dkg


-- System Information:
Debian Release: stretch/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing'), (200, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages dkms depends on:
ii  build-essential  11.7
ii  coreutils        8.25-2
ii  dpkg-dev         1.18.7
ii  gcc              4:5.3.1-3
ii  kmod             22-1.1
ii  make             4.1-9
ii  patch            2.7.5-1

Versions of packages dkms recommends:
ii  fakeroot             1.20.2-2
ii  linux-headers-amd64  4.6+74
pn  linux-image          <none>
ii  menu                 2.1.47

dkms suggests no packages.

-- debconf-show failed
[0001-dh_dkms-should-fail-cleanly-with-unknown-package-ver.patch (text/x-diff, attachment)]
[0002-handle-dkms-conf-files-where-PACKAGE_VERSION-or-PACK.patch (text/x-diff, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>:
Bug#829123; Package dkms. (Sun, 03 Jul 2016 16:03:07 GMT) (full text, mbox, link).


Acknowledgement sent to Daniel Kahn Gillmor <dkg@fifthhorseman.net>:
Extra info received and forwarded to list. Copy sent to Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>. (Sun, 03 Jul 2016 16:03:07 GMT) (full text, mbox, link).


Message #10 received at 829123@bugs.debian.org (full text, mbox, reply):

From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: 829123@bugs.debian.org,control@bugs.debian.org,829123-submitter@bugs.debian.org
Subject: [7b89c30] Fix for Bug#829123 committed to git
Date: Sun, 03 Jul 2016 16:01:46 +0000
tags 829123 + pending
thanks

Hello,

     The following change has been committed for this bug by
 Daniel Kahn Gillmor <dkg@fifthhorseman.net> on Sun, 3 Jul 2016 23:47:33 +0800.
 The fix will be in the next upload. 
=========================================================================
Make dh_dkms name and version parsing more proper (Closes: #829123)


=========================================================================

You can check the diff of the fix at:

    ;a=commitdiff;h=7b89c30





Added tag(s) pending. Request was from Daniel Kahn Gillmor <dkg@fifthhorseman.net> to control@bugs.debian.org. (Sun, 03 Jul 2016 16:03:09 GMT) (full text, mbox, link).


Message sent on to Daniel Kahn Gillmor <dkg@fifthhorseman.net>:
Bug#829123. (Sun, 03 Jul 2016 16:03:18 GMT) (full text, mbox, link).


Reply sent to Aron Xu <aron@debian.org>:
You have taken responsibility. (Tue, 05 Jul 2016 22:30:14 GMT) (full text, mbox, link).


Notification sent to Daniel Kahn Gillmor <dkg@fifthhorseman.net>:
Bug acknowledged by developer. (Tue, 05 Jul 2016 22:30:14 GMT) (full text, mbox, link).


Message #20 received at 829123-close@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <aron@debian.org>
To: 829123-close@bugs.debian.org
Subject: Bug#829123: fixed in dkms 2.2.0.3-5
Date: Tue, 05 Jul 2016 22:26:59 +0000
Source: dkms
Source-Version: 2.2.0.3-5

We believe that the bug you reported is fixed in the latest version of
dkms, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 829123@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aron Xu <aron@debian.org> (supplier of updated dkms package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 06 Jul 2016 05:51:37 +0800
Source: dkms
Binary: dkms
Architecture: source
Version: 2.2.0.3-5
Distribution: unstable
Urgency: medium
Maintainer: Dynamic Kernel Modules Support Team <pkg-dkms-maint@lists.alioth.debian.org>
Changed-By: Aron Xu <aron@debian.org>
Description:
 dkms       - Dynamic Kernel Module Support Framework
Closes: 554843 653176 707008 724566 829123
Changes:
 dkms (2.2.0.3-5) unstable; urgency=medium
 .
   [ Aron Xu ]
   * Remove obsolete virtual package 'linux-image' from Recommends (Closes: #724566)
   * Do not ignore --kernelsourcedir (Closes: #653176)
   * Update upstream link to github
   * Use gbp-pq to manage patches
 .
   [ Daniel Kahn Gillmor ]
   * Make dh_dkms name and version parsing more proper (Closes: #829123)
 .
   [ Dirk Griesbach ]
   * Port apport hook to python3 and add python3-apport to Suggests (Closes: #707008)
 .
   [ Thijs Kinkhorst ]
   * mkbmdeb: support for lean binary package with only the built modules (Closes: #554843)
Checksums-Sha1:
 ed439bed3ca7f4cdc5653f570b759ad261cd8629 1676 dkms_2.2.0.3-5.dsc
 53c8fd66fbd8ed40d44fbcdca222b3bb0a6d6869 23848 dkms_2.2.0.3-5.debian.tar.xz
Checksums-Sha256:
 eccc5d46ed251ba9686dd42f2810134c5ff5343b614439d6836e979d36476d68 1676 dkms_2.2.0.3-5.dsc
 fb76dd4d2bf0b4e7d4e75891ef2b07e2ae0723d90f8956a433ce69777b3b947f 23848 dkms_2.2.0.3-5.debian.tar.xz
Files:
 6caaffd34bf026deee7120be0854aa43 1676 kernel optional dkms_2.2.0.3-5.dsc
 5ec647de561c069540acc83bc384aaa8 23848 kernel optional dkms_2.2.0.3-5.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJXfCxMAAoJEPbsVcVkKA0egdgH/06hahFV/RhM/yk4VxiM7XVm
Cs+SRbOJr7jCJRf4Z9VeKiOVHsRbLZu1G77KaxesN/wpREDnbHhUPIVhzSK3/6Yc
rIQHZvf4UcJFif6lO8Yvr+JoWwiwdCLzfTobKd4g7vU8uP+BNYoc/wqKWF4u0WNf
/vzN+ctC5jVLyi018wf77zAoxv2PKJHinJFLLeW54jj1E8VWQ3bGP1A9M2RyNFZJ
QTucN40Y+WpvNH8YcxenrPpzwT+WKJyBu4xPxqyn2VV3PukkI5Q4A9PqhlPZBTZj
nPm1S4dO0YvfqZ6EcolRABvFqJMp1up2wfaaMeSB35vC4iDmbmJwU3J66qhsh78=
=UWnA
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Tue, 09 Aug 2016 07:29:35 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Jul 2 06:31:46 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.