Debian Bug report logs - #828993
openttd: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: submit@bugs.debian.org

Subject: openttd: please make the build reproducible

Date: Wed, 29 Jun 2016 17:05:18 +0200

[Message part 1 (text/plain, inline)]

Source: openttd
Version: 1.6.0-1
Severity: wishlist
Tags: patch upstream
User: reproducible-builds@lists.alioth.debian.org
Usertags: locale
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that openttd could not be built reproducibly.
A list of source files is sorted without considering locales, so it
will be different under differing locales.

The attached patch fixes this.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

[openttd.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 828993@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: Matthijs Kooijman <matthijs@stdin.nl>, 828993@bugs.debian.org

Subject: Re: Bug#828993: openttd: please make the build reproducible

Date: Wed, 29 Jun 2016 18:02:31 +0200

[Message part 1 (text/plain, inline)]

On Wed, Jun 29, 2016 at 05:52:32PM +0200, Matthijs Kooijman wrote:
> Hi Reiner,
> 
> > While working on the "reproducible builds" effort [1], we have noticed
> > that openttd could not be built reproducibly.
> > A list of source files is sorted without considering locales, so it
> > will be different under differing locales.
> Right. Together with upstream we previously fixed some similar issues,
> but AFAIU it's not so easy to check the reproducibility of builds
> manually.
> 
> > The attached patch fixes this.
> Thanks for that, I'll forward it upstream.
> 
> Could you confirm the build becomes reproducible with this patch, or
> could more turn up after applying this one?

I have confirmed it with our prebuilder script [1], which does most of
the variations that are also run on jenkins (tests.reproducible-buids.org).
With the current variations we do there it is reproducible.

The diff on jenkins also hints at a locale sorting variation:

> -   387: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS autoreplace.cpp
> -   391: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS autoreplace_cmd.cpp
> +   387: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS autoreplace_cmd.cpp
> +   397: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS autoreplace.cpp

Kind regards,
  Reiner

[1]: https://anonscm.debian.org/cgit/reproducible/misc.git/tree/prebuilder

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 828993@bugs.debian.org (full text, mbox, reply):

From: Matthijs Kooijman <matthijs@stdin.nl>

To: Reiner Herrmann <reiner@reiner-h.de>, 828993@bugs.debian.org

Subject: Re: Bug#828993: openttd: please make the build reproducible

Date: Wed, 29 Jun 2016 17:52:32 +0200

[Message part 1 (text/plain, inline)]

Hi Reiner,

> While working on the "reproducible builds" effort [1], we have noticed
> that openttd could not be built reproducibly.
> A list of source files is sorted without considering locales, so it
> will be different under differing locales.
Right. Together with upstream we previously fixed some similar issues,
but AFAIU it's not so easy to check the reproducibility of builds
manually.

> The attached patch fixes this.
Thanks for that, I'll forward it upstream.

Could you confirm the build becomes reproducible with this patch, or
could more turn up after applying this one?

Gr.

Matthijs

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 828993@bugs.debian.org (full text, mbox, reply):

From: Matthijs Kooijman <matthijs@stdin.nl>

To: Reiner Herrmann <reiner@reiner-h.de>, 828993@bugs.debian.org

Subject: Re: Bug#828993: openttd: please make the build reproducible

Date: Thu, 30 Jun 2016 08:45:29 +0200

[Message part 1 (text/plain, inline)]

Hey Reiner,

> The attached patch fixes this.
Turns out upstream already has this exact same patch committed last
month, so it should appear in the next upstream release 1.6.1 (which
shouldn't be too far ahead).

Good to know your testing confirms it actually helps!

Gr.

Matthijs

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 828993@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: Matthijs Kooijman <matthijs@stdin.nl>, 828993@bugs.debian.org

Subject: Re: Bug#828993: openttd: please make the build reproducible

Date: Thu, 30 Jun 2016 17:40:55 +0200

[Message part 1 (text/plain, inline)]

On Thu, Jun 30, 2016 at 08:45:29AM +0200, Matthijs Kooijman wrote:
> > The attached patch fixes this.
> Turns out upstream already has this exact same patch committed last
> month, so it should appear in the next upstream release 1.6.1 (which
> shouldn't be too far ahead).

Okay, nice! Thanks for contacting upstream about it!

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 828993-close@bugs.debian.org (full text, mbox, reply):

From: Matthijs Kooijman <matthijs@stdin.nl>

To: 828993-close@bugs.debian.org

Subject: Bug#828993: fixed in openttd 1.6.1-1

Date: Sun, 03 Jul 2016 11:31:46 +0000

Source: openttd
Source-Version: 1.6.1-1

We believe that the bug you reported is fixed in the latest version of
openttd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 828993@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Matthijs Kooijman <matthijs@stdin.nl> (supplier of updated openttd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 03 Jul 2016 10:37:08 +0200
Source: openttd
Binary: openttd openttd-dbg openttd-data
Architecture: source all amd64
Version: 1.6.1-1
Distribution: unstable
Urgency: medium
Maintainer: Matthijs Kooijman <matthijs@stdin.nl>
Changed-By: Matthijs Kooijman <matthijs@stdin.nl>
Description:
 openttd    - reimplementation of Transport Tycoon Deluxe with enhancements
 openttd-data - common data files for the OpenTTD game
 openttd-dbg - debugging symbols for openttd
Closes: 825681 828993
Changes:
 openttd (1.6.1-1) unstable; urgency=medium
 .
   * [8cb8348] New upstream release 1.6.1.
     - Fix arbitrary compilation order, to improve build reproducibility.
       (Closes: #828993)
   * [eeb1139] Add openttd to the StrategyGame menu category. (Closes:
     #825681)
   * [9270dc2] Remove patches for reproducibility that are contained
     upstream.
Checksums-Sha1:
 5441de4d98f0243f8249932ca5eb893e12a2fed9 2165 openttd_1.6.1-1.dsc
 c6495ba80f67269940cb4aa8832fdd25a14a91c3 10157130 openttd_1.6.1.orig.tar.gz
 8bc2ba1bb36b00d1c2931f59d852fda732d96de3 11908 openttd_1.6.1-1.debian.tar.xz
 a65dcee69ea75e8fbb657c3b763b70c8c9357ed0 2748172 openttd-data_1.6.1-1_all.deb
 30e94d66b3f2d3618f295f7119fb1139b028f422 22677436 openttd-dbg_1.6.1-1_amd64.deb
 e569259ea5ce2b434585d4f2c92af0b87329983f 2147732 openttd_1.6.1-1_amd64.deb
Checksums-Sha256:
 e56611a65a7700da46004bf86840c2f4257fb7261bc46656ad8134fe7d08acb4 2165 openttd_1.6.1-1.dsc
 c7bd713377f08d5b63d703e3b8b8eff3bb4ec7042ad13511575fff4640cbc78f 10157130 openttd_1.6.1.orig.tar.gz
 a9f8ea85520830441cd1d81ed01fba10db457a4ae995251e1352a48b4de75a39 11908 openttd_1.6.1-1.debian.tar.xz
 e7d8642578af69998320134c915cfb18b0d687a9559e23b2a80e08184cf2a088 2748172 openttd-data_1.6.1-1_all.deb
 f99bd51ab51540014885ed102dddd8d4bcfbff742b63e60dc5fb954fc060d44a 22677436 openttd-dbg_1.6.1-1_amd64.deb
 af4b8a5950617bd96598fd4b4b6816e351764436cfece874af2f29ec241f37dc 2147732 openttd_1.6.1-1_amd64.deb
Files:
 4691018be113a1d8b2d66fe2616b5094 2165 games optional openttd_1.6.1-1.dsc
 624ef4aa08dc5cb055772b05ea5d3562 10157130 games optional openttd_1.6.1.orig.tar.gz
 6abb4261e7a634a94851ba448984e21d 11908 games optional openttd_1.6.1-1.debian.tar.xz
 2c5b68cc2df9463990a807fa2b285bde 2748172 games optional openttd-data_1.6.1-1_all.deb
 4e918fca65fb0202f1401df2d55f3ac3 22677436 debug extra openttd-dbg_1.6.1-1_amd64.deb
 03f626073a38e68eea9f691b69e65750 2147732 games optional openttd_1.6.1-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXePFqAAoJENWTmrfwcjyD/e0QALDm72Eqv95X/TosAuZz/G8N
Hn3X4GCwkX0jeNMdm8FTdDwIToRUpSk65OigP/GP9iUdC9cAtO3cjc1c1tDKKuxb
mZ+ADZ1yfOdmSRowAPHMH4URjnkdRLQt6befj7afv3fuHX7hkghQDfrK4+dh0iQ5
LMecMDhHKkHtWWhMuGOHV5EzS3f0UI0UlFj1Z4NQ99Ljo1L/kol86+5eXTK4bRDi
p6ZFdeQwDusvrS1Iu4Tyl4/3mtP4a/Z/kaGTg9e81z8KVZgPoLm6cbwy3D5zqmrI
wmYaO8LRTUyftlhE5IRQotWOfHFQLRxIkwVxhun9LBZhGIUZNGqMnaDqXKmMxGcW
aKfhALQ7R9iZEh7SBTaw1lCwoPQQWPXMogHOHfzqV5aaQwNr8ghoGsNxw/G83eD8
UBlipvj2GfQf1RYmHVAgq5Un0RcgMYNKnmRZ9uTsPF+hZ0HDJ7HuWOBFEcdkpRzE
S33aA6An7IJQQSSNgao2vSGt35qe6Ylbyjmn78STu/PaY/iXd65goSLWSIFKfLCP
biWZVYI84ODocMZSewiyI9SFpuszFdpVZkqhSZ9KgCY+s/PUn0tNEKn+1681hB2n
BJUus/V7GxqGSDLOMH+tFT7nOC7ANBn74poCC0IIyj8N/VYJ/CpDjOdIMYNGBllI
ux9dUfyBnzzzFAdls/bl
=pY0R
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.