Debian Bug report logs - #828876
ario: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: submit@bugs.debian.org

Subject: ario: please make the build reproducible

Date: Tue, 28 Jun 2016 20:57:58 +0200

[Message part 1 (text/plain, inline)]

Source: ario
Version: 1.5.1-1.3
Severity: wishlist
Tags: patch upstream
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that ario could not be built reproducibly.
It embeds the current year into the binary.

The attached patch replaces it with a static value.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

[ario.patch (text/x-diff, attachment)]

Message #10 received at 828876@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Reiner Herrmann <reiner@reiner-h.de>, 828876@bugs.debian.org

Subject: Re: Bug#828876: ario: please make the build reproducible

Date: Thu, 06 Oct 2022 10:55:10 -0700

[Message part 1 (text/plain, inline)]

On 2016-06-28, Reiner Herrmann wrote:
> While working on the "reproducible builds" effort [1], we have noticed
> that ario could not be built reproducibly.
> It embeds the current year into the binary.
>
> The attached patch replaces it with a static value.

I can confirm this patch is still needed, but when I tried applying this
patch, it fails to build asking for automake-1.15 (which is no longer in
debian, but automake-1.16 is):

  Making all in src
  make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
  cd .. && /bin/bash /<<PKGBUILDDIR>>/missing automake-1.15 --foreign src/Makefile
  /<<PKGBUILDDIR>>/missing: line 81: automake-1.15: command not found
  WARNING: 'automake-1.15' is missing on your system.
  You should only need it if you modified 'Makefile.am' or
  'configure.ac' or m4 files included by 'configure.ac'.

Struggling to figure out how to get cdbs to actually regenerate the
files with a newer automake...

live well,
  vagrant


> [1]: https://wiki.debian.org/ReproducibleBuilds
> diff --git a/debian/patches/reproducible-build.patch b/debian/patches/reproducible-build.patch
> new file mode 100644
> index 0000000..9377027
> --- /dev/null
> +++ b/debian/patches/reproducible-build.patch
> @@ -0,0 +1,26 @@
> +Author: Reiner Herrmann <reiner@reiner-h.de>
> +Description: Replace current year with static value to get reproducible build
> +
> +--- a/src/Makefile.am
> ++++ b/src/Makefile.am
> +@@ -214,8 +214,7 @@
> +                 -DDATA_PATH=\""$(pkgdatadir)/data/"\"\
> +                 -DUI_PATH=\""$(pkgdatadir)/ui/"\"\
> +         	-DARIO_PLUGIN_DIR=\"$(PLUGINDIR)\"\
> +-        	-DARIO_PLUGIN_DATA_DIR=\"$(PLUGIN_DATA_DIR)\"\
> +-		-DCURRENT_DATE="\"`date +%G`\""
> ++        	-DARIO_PLUGIN_DATA_DIR=\"$(PLUGIN_DATA_DIR)\"
> + 
> + if MPD_GLIB
> + AM_CPPFLAGS += -DMPD_GLIB
> +--- a/src/shell/ario-shell.c
> ++++ b/src/shell/ario-shell.c
> +@@ -821,7 +821,7 @@
> +                                "name", "Ario",
> +                                "program-name", "Ario",
> +                                "version", PACKAGE_VERSION,
> +-                               "copyright", "Copyright \xc2\xa9 2005-" CURRENT_DATE " Marc Pavot",
> ++                               "copyright", "Copyright \xc2\xa9 2005-2011 Marc Pavot",
> +                                "comments", _("GTK client for MPD"),
> +                                "translator-credits", _("translator-credits"),
> +                                "authors", (const char **) authors,
> diff --git a/debian/patches/series b/debian/patches/series
> index 7e66345..60ef58f 100644
> --- a/debian/patches/series
> +++ b/debian/patches/series
> @@ -1 +1,2 @@
>  glib-single-include.patch
> +reproducible-build.patch

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 828876@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Reiner Herrmann <reiner@reiner-h.de>, 828876@bugs.debian.org

Subject: Re: Bug#828876: ario: please make the build reproducible

Date: Thu, 22 Dec 2022 11:18:43 -0800

[Message part 1 (text/plain, inline)]

Control: tags 828876 pending

On 2022-10-06, Vagrant Cascadian wrote:
> On 2016-06-28, Reiner Herrmann wrote:
>> While working on the "reproducible builds" effort [1], we have noticed
>> that ario could not be built reproducibly.
>> It embeds the current year into the binary.
>>
>> The attached patch replaces it with a static value.
>
> I can confirm this patch is still needed, but when I tried applying this
> patch, it fails to build asking for automake-1.15 (which is no longer in
> debian, but automake-1.16 is):
>
>   Making all in src
>   make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
>   cd .. && /bin/bash /<<PKGBUILDDIR>>/missing automake-1.15 --foreign src/Makefile
>   /<<PKGBUILDDIR>>/missing: line 81: automake-1.15: command not found
>   WARNING: 'automake-1.15' is missing on your system.
>   You should only need it if you modified 'Makefile.am' or
>   'configure.ac' or m4 files included by 'configure.ac'.
>
> Struggling to figure out how to get cdbs to actually regenerate the
> files with a newer automake...

Fixed this by adding support for dh-autoreconf.

Uploaded an NMU fixing this to DELAYED/10:

diff -Nru ario-1.6/debian/changelog ario-1.6/debian/changelog
--- ario-1.6/debian/changelog	2021-01-02 09:54:20.000000000 -0800
+++ ario-1.6/debian/changelog	2022-12-22 10:45:30.000000000 -0800
@@ -1,3 +1,16 @@
+ario (1.6-1.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  [ Reiner Herrmann ]
+  * Replace current year with static value to get reproducible build
+    (Closes: #828876)
+
+  [ Vagrant Cascadian ]
+  * Use dh-autoreconf.
+
+ -- Vagrant Cascadian <vagrant@debian.org>  Thu, 22 Dec 2022 10:45:30 -0800
+
 ario (1.6-1.1) unstable; urgency=medium
 
   * Non maintainer upload by the Reproducible Builds team.
diff -Nru ario-1.6/debian/control ario-1.6/debian/control
--- ario-1.6/debian/control	2018-01-14 14:06:03.000000000 -0800
+++ ario-1.6/debian/control	2022-12-22 10:45:30.000000000 -0800
@@ -2,7 +2,7 @@
 Section: sound
 Priority: optional
 Maintainer: Marc Pavot <marc.pavot@gmail.com>
-Build-Depends: debhelper (>=9), cdbs, autotools-dev, libgtk-3-dev, libglib2.0-dev, libxml2-dev, libcurl4-gnutls-dev, intltool, libavahi-client-dev, libavahi-glib-dev, libdbus-glib-1-dev, libtagc0-dev, libmpdclient-dev, 
+Build-Depends: debhelper (>=9), dh-autoreconf, cdbs, autotools-dev, libgtk-3-dev, libglib2.0-dev, libxml2-dev, libcurl4-gnutls-dev, intltool, libavahi-client-dev, libavahi-glib-dev, libdbus-glib-1-dev, libtagc0-dev, libmpdclient-dev, 
 Standards-Version: 4.1.3
 Homepage: http://ario-player.sourceforge.net/
 
diff -Nru ario-1.6/debian/patches/replace-current-year-with-static-value-t.patch ario-1.6/debian/patches/replace-current-year-with-static-value-t.patch
--- ario-1.6/debian/patches/replace-current-year-with-static-value-t.patch	1969-12-31 16:00:00.000000000 -0800
+++ ario-1.6/debian/patches/replace-current-year-with-static-value-t.patch	2022-12-22 10:45:30.000000000 -0800
@@ -0,0 +1,36 @@
+From: Reiner Herrmann <reiner@reiner-h.de>
+Date: Tue, 28 Jun 2016 20:57:58 +0200
+X-Dgit-Generated: 1.6-1.2 ee49d4c2ad945b1ccb14656dba223bd01cc15557
+Subject: Replace current year with static value to get reproducible build
+
+(Closes: #828876)
+
+---
+
+diff --git a/src/Makefile.am b/src/Makefile.am
+index 64f2fef..c6a855e 100644
+--- a/src/Makefile.am
++++ b/src/Makefile.am
+@@ -206,8 +206,7 @@ AM_CPPFLAGS = \
+                 -DDATA_PATH=\""$(pkgdatadir)/data/"\"\
+                 -DUI_PATH=\""$(pkgdatadir)/ui/"\"\
+         	-DARIO_PLUGIN_DIR=\"$(PLUGINDIR)\"\
+-        	-DARIO_PLUGIN_DATA_DIR=\"$(PLUGIN_DATA_DIR)\"\
+-		-DCURRENT_DATE="\"`date +%G`\""
++        	-DARIO_PLUGIN_DATA_DIR=\"$(PLUGIN_DATA_DIR)\"
+ 
+ if MPD_GLIB
+ AM_CPPFLAGS += -DMPD_GLIB
+diff --git a/src/shell/ario-shell.c b/src/shell/ario-shell.c
+index a9cb4fa..b6422e7 100644
+--- a/src/shell/ario-shell.c
++++ b/src/shell/ario-shell.c
+@@ -665,7 +665,7 @@ ario_shell_cmd_about (GSimpleAction *action,
+                                "name", "Ario",
+                                "program-name", "Ario",
+                                "version", PACKAGE_VERSION,
+-                               "copyright", "Copyright \xc2\xa9 2005-" CURRENT_DATE " Marc Pavot",
++                               "copyright", "Copyright \xc2\xa9 2005-2011 Marc Pavot",
+                                "comments", _("GTK client for MPD"),
+                                "translator-credits", _("translator-credits"),
+                                "authors", (const char **) authors,
diff -Nru ario-1.6/debian/patches/series ario-1.6/debian/patches/series
--- ario-1.6/debian/patches/series	2018-01-14 14:06:03.000000000 -0800
+++ ario-1.6/debian/patches/series	2022-12-22 10:45:30.000000000 -0800
@@ -0,0 +1 @@
+replace-current-year-with-static-value-t.patch
diff -Nru ario-1.6/debian/rules ario-1.6/debian/rules
--- ario-1.6/debian/rules	2013-05-18 10:26:19.000000000 -0700
+++ ario-1.6/debian/rules	2022-12-22 10:45:30.000000000 -0800
@@ -2,6 +2,7 @@
   
 include /usr/share/cdbs/1/rules/debhelper.mk
 include /usr/share/cdbs/1/class/autotools.mk
+include /usr/share/cdbs/1/rules/autoreconf.mk
 include /usr/share/cdbs/1/class/gnome.mk
 
 # exclude plugins from shlibs generation

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 828876-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 828876-close@bugs.debian.org

Subject: Bug#828876: fixed in ario 1.6-1.2

Date: Sun, 01 Jan 2023 20:49:21 +0000

Source: ario
Source-Version: 1.6-1.2
Done: Vagrant Cascadian <vagrant@debian.org>

We believe that the bug you reported is fixed in the latest version of
ario, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 828876@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@debian.org> (supplier of updated ario package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 22 Dec 2022 10:45:30 -0800
Source: ario
Architecture: source
Version: 1.6-1.2
Distribution: unstable
Urgency: medium
Maintainer: Marc Pavot <marc.pavot@gmail.com>
Changed-By: Vagrant Cascadian <vagrant@debian.org>
Closes: 828876
Changes:
 ario (1.6-1.2) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   [ Reiner Herrmann ]
   * Replace current year with static value to get reproducible build
     (Closes: #828876)
 .
   [ Vagrant Cascadian ]
   * Use dh-autoreconf.
Checksums-Sha1:
 b31fdb71e3197582335dad4cb0c40c1c4aa6c50f 1462 ario_1.6-1.2.dsc
 4e3760ba7b16ef84995b3f41a04e3906c4d865ac 7628 ario_1.6-1.2.debian.tar.xz
Checksums-Sha256:
 7579e720161dd0c9d164f292326e643b0e5bc6121095b0430749507e8ae56c80 1462 ario_1.6-1.2.dsc
 801c3f75bea424198dcba31c1c07778bea5981456d9396b4ca7329f298ffed70 7628 ario_1.6-1.2.debian.tar.xz
Files:
 595090d045dcd707b63c987f7e24b9b7 1462 sound optional ario_1.6-1.2.dsc
 2bf22ff5db1dfd83a76612101dee7ea1 7628 sound optional ario_1.6-1.2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iIkEARYKADEWIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCY6Ss6hMcdmFncmFudEBk
ZWJpYW4ub3JnAAoJENxRj8h/lxaq0GwBAP00qqhmaqcHMJKn/tl9DaX/spSQcSFA
D6DXuxaxZNa+AQCqE5BC0OQTAxQWNC7P4JBMmpEDc2XhB7fT3iZUkE2wCw==
=Bpqa
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.