Debian Bug report logs - #828766
liblucy-perl: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: submit@bugs.debian.org

Subject: liblucy-perl: please make the build reproducible

Date: Mon, 27 Jun 2016 17:56:54 +0200

[Message part 1 (text/plain, inline)]

Source: liblucy-perl
Version: 0.3.3-6
Severity: wishlist
Tags: patch fileordering
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that liblucy-perl could not be built reproducibly.
The class hierarchy in Autobinding.pm is not sorted, which also causes
generated C files to be unreproducible.

The attached patch fixes this by sorting the file list retrieved by the
S_find_cfh function.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

[liblucy-perl.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 828766@bugs.debian.org (full text, mbox, reply):

From: Dominique Dumont <dod@debian.org>

To: 828766@bugs.debian.org

Cc: 828766-submitter@bugs.debian.org

Subject: Re: Bug#828766: liblucy-perl: please make the build reproducible

Date: Tue, 05 Jul 2016 14:15:32 +0200

My C is quite rusted, but, for what it's worth, I've looked at the patch.

As far as I understand qsort doc, you call this function with a array of 
strings (char *), i.e. a char**.

cmpstringp is called with an object from the array, i.e. a void pointer to a 
char *. I don't think dereferecing the pointer is safe.

I think you should call strcmp with :

strcmp( (const char *) p1, (const char *) p2);

I'll let you test this

HTH


-- 
 https://github.com/dod38fr/   -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/  -o-   irc: dod at irc.debian.org

Message #18 received at 828766@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: dod@debian.org, 828766-quiet@bugs.debian.org

Cc: 828766@bugs.debian.org, 828766-submitter@bugs.debian.org

Subject: Re: Bug#828766: liblucy-perl: please make the build reproducible

Date: Tue, 5 Jul 2016 14:40:06 +0200

[Message part 1 (text/plain, inline)]

On Tue, Jul 05, 2016 at 02:15:32PM +0200, Dominique Dumont wrote:
> As far as I understand qsort doc, you call this function with a array of 
> strings (char *), i.e. a char**.
> 
> cmpstringp is called with an object from the array, i.e. a void pointer to a 
> char *. I don't think dereferecing the pointer is safe.

The arguments to the comparison function are pointers to char* (i.e.
char**), so dereferencing them will pass the char* pointers from the
char **cfh_list list to strcmp.
It's passing pointers to the compared objects to the comparison function
as the objects don't necessarily need to be pointers.

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 828766-submitter@bugs.debian.org (full text, mbox, reply):

From: Dominique Dumont <dod@debian.org>

To: Reiner Herrmann <reiner@reiner-h.de>, 828766-submitter@bugs.debian.org

Cc: 828766@bugs.debian.org

Subject: Re: Bug#828766: liblucy-perl: please make the build reproducible

Date: Wed, 06 Jul 2016 08:59:13 +0200

On Tuesday 05 July 2016 14:40:06 Reiner Herrmann wrote:
> It's passing pointers to the compared objects to the comparison function
> as the objects don't necessarily need to be pointers.

Ah, that's the point I missed. Thanks for the explanation..

All the best

-- 
 https://github.com/dod38fr/   -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/  -o-   irc: dod at irc.debian.org

Message #37 received at 828766@bugs.debian.org (full text, mbox, reply):

From: pkg-perl-maintainers@lists.alioth.debian.org

To: 828766@bugs.debian.org, 828766-submitter@bugs.debian.org

Subject: Pending fixes for bugs in the liblucy-perl package

Date: Thu, 07 Jul 2016 15:38:28 +0000

tag 828766 + pending
thanks

Some bugs in the liblucy-perl package are closed in revision
d78678fe181f5f91719ccb6b5b42e8090cea9ddd in branch 'master' by
intrigeri

The full diff can be seen at
https://anonscm.debian.org/cgit/pkg-perl/packages/liblucy-perl.git/commit/?id=d78678f

Commit message:

    reproducible2.patch: added. Thanks to Reiner Herrmann <reiner@reiner-h.de> for the patch! Closes: #828766

Message #47 received at 828766-close@bugs.debian.org (full text, mbox, reply):

From: intrigeri <intrigeri@debian.org>

To: 828766-close@bugs.debian.org

Subject: Bug#828766: fixed in liblucy-perl 0.3.3-7

Date: Thu, 07 Jul 2016 17:09:07 +0000

Source: liblucy-perl
Source-Version: 0.3.3-7

We believe that the bug you reported is fixed in the latest version of
liblucy-perl, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 828766@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
intrigeri <intrigeri@debian.org> (supplier of updated liblucy-perl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 07 Jul 2016 15:31:07 +0000
Source: liblucy-perl
Binary: liblucy-perl
Architecture: source
Version: 0.3.3-7
Distribution: unstable
Urgency: medium
Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
Changed-By: intrigeri <intrigeri@debian.org>
Closes: 828766
Description: 
 liblucy-perl - search engine library
Changes:
 liblucy-perl (0.3.3-7) unstable; urgency=medium
 .
   * Team upload.
 .
   [ gregor herrmann ]
   * Rename autopkgtest configuration file(s) as per new pkg-perl-
     autopkgtest schema.
 .
   [ intrigeri ]
   * reproducible2.patch: added.
     Thanks to Reiner Herrmann <reiner@reiner-h.de> for the patch!
     Closes: #828766
Checksums-Sha1: 
 eb4e187f659edf35afdd4b21dcc1f52a7a9482c9 2112 liblucy-perl_0.3.3-7.dsc
 58639c824f04a1d12712ff4f3672f1c002c18546 13104 liblucy-perl_0.3.3-7.debian.tar.xz
Checksums-Sha256: 
 1d3475150c545136c8096646bfeaf82cf9fc40af632b021ce7f0f14ce3b7cb92 2112 liblucy-perl_0.3.3-7.dsc
 7aa229e493c2c6aa6042904668e1081dac7d747f004e542e313a1d70dd9d6547 13104 liblucy-perl_0.3.3-7.debian.tar.xz
Files: 
 c3197101f61d3ac42a4474335b410721 2112 perl optional liblucy-perl_0.3.3-7.dsc
 d1802581032b0c67e016e7d4dc933194 13104 perl optional liblucy-perl_0.3.3-7.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJXfndBAAoJEOxtg78p/CqOZskQAIr1+ZK6glB5w6FmtrV5rVN7
weOiL0bcb1zPMIdQnynJKK8novd3XZ7L1wnPJI7RUMW43q+iOlaf1HJPH0yOxqsJ
8YmF1Eb1jAy4W6Dd8iS6mO2+GOg37N1Ved7zpY4z3cH4csY9ep84VgopB5Atr7Q0
8cyDFL3vF/MNPN6RbS1ZiZtKFasJojVwIEbQ4e4nTKyR4wLke4uKbFr2/jp7zSCx
Fs7/CJ1itaCPWLHp3H+YpVKj+j5J00CEzS3aeuUFrhUEmho3EUI2vqXtyaIPoQuS
No/sdCZBe+j4NtLwa6+yZtpKHxSrcyZgq47rdMuyUIrzBemS16mUOoC2nK7bf9OR
SGC3BX+nv2YYEgk8S1ZnvfX3Ct7WEXneihRPDBvlwwIJJb0t+c7hdEYtYShTzsfB
PMACPYOkNahYb3i7j4B+1L6DkMY5HsdX7z4J0O/4ZYaKMSrG8Epl9Aomgdxl/5DB
8DyFMXfkiuyWZ/VTe3hM1cYVRtQw3LpkzUvfBbRGDTpbm7XKtfvloCY+QQ7NPoIk
9gQT7roBahXG9H4Fb6zyJnXvnhOHJ+dQi1T5qJ36drVw5lesbuXdZmn31GdKxwJr
BFhXbhw8JPmdCAA2sTXVgVwkZfDMi2K7n7Q5ULSwHfoZXymgCBgC0aOxWoD6JRpV
c60u7GVJOEJovQOrjxQ4
=fkJ8
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.