Debian Bug report logs - #828752
mod-dnssd: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: submit@bugs.debian.org

Subject: mod-dnssd: please make the build reproducible

Date: Mon, 27 Jun 2016 15:35:56 +0200

[Message part 1 (text/plain, inline)]

Source: mod-dnssd
Version: 0.6-3.1
Severity: wishlist
Tags: patch upstream
User: reproducible-builds@lists.alioth.debian.org
Usertags: locale
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that mod-dnssd could not be built reproducibly.
The README file generated with lyxn contains differently translated
lynx-output depending on locale/language settings.

The attached patch fixes this by using 'C' as the used language.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

[mod-dnssd.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 828752@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Reiner Herrmann <reiner@reiner-h.de>, 828752@bugs.debian.org

Subject: Re: Bug#828752: mod-dnssd: please make the build reproducible

Date: Thu, 06 Oct 2022 11:06:16 -0700

[Message part 1 (text/plain, inline)]

On 2016-06-27, Reiner Herrmann wrote:
> While working on the "reproducible builds" effort [1], we have noticed
> that mod-dnssd could not be built reproducibly.
> The README file generated with lyxn contains differently translated
> lynx-output depending on locale/language settings.
>
> The attached patch fixes this by using 'C' as the used language.

The locales issue does not appear to affect the locales currently used
on tests.reproducible-builds.org, but I was able to sometimes reproduce
the issue with reprotest depending on which locale reprotest used.

I've attached simpler patches which just avoid using lynx by passing
--disable-lynx to configure and removing lynx from build-depends, as
using lynx also embeds build paths in a way that makes the README
reference files that do not even exist:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/mod-dnssd.html

  file:///build/1st/mod-dnssd-0.6/doc/README.html#license
  vs.
  file:///build/2/mod-dnssd-0.6/2nd/doc/README.html#license

The package does not even ship a README.html, as this is a byproduct of
using lynx on the generated .html file to dump a plain-text README.

By not using lynx, it simply ships the provided readme.

I intend to NMU with these patches applied, though will likely use
DELAYED/10 to give time for the maintainer to respond.

live well,
  vagrant

[0001-debian-rules-Pass-disable-lynx-in-dh_auto_configure-.patch (text/x-diff, inline)]

From 726c21a87f728defba54cc206c42838c73c1032c Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Thu, 6 Oct 2022 17:02:08 +0000
Subject: [PATCH 1/3] debian/rules: Pass --disable-lynx in dh_auto_configure
 override. (Closes: #828752)

Using lynx embeds the build path and sometimes locale-specific
differences in the generated README.
---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index 0d40890..f211bad 100755
--- a/debian/rules
+++ b/debian/rules
@@ -6,3 +6,6 @@ export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 	dh $@ --with apache2
 
 override_dh_auto_install:
+
+override_dh_auto_configure:
+	dh_auto_configure -- --disable-lynx
-- 
2.30.2

[0002-debian-control-Remove-lynx-from-Build-Depends.patch (text/x-diff, inline)]

From af404126fb9080662fb2fc67a602334c0d431c9b Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Thu, 6 Oct 2022 17:04:13 +0000
Subject: [PATCH 2/3] debian/control: Remove lynx from Build-Depends.

---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index d31ca56..ce371f7 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: httpd
 Priority: optional
 Maintainer: Regis Boudin <regis@debian.org>
 Uploaders: Sebastien ESTIENNE <sebastien.estienne@gmail.com>
-Build-Depends: debhelper (>= 10), apache2-dev, dh-apache2,libavahi-client-dev (>= 0.6.4), lynx, libapr1-dev
+Build-Depends: debhelper (>= 10), apache2-dev, dh-apache2,libavahi-client-dev (>= 0.6.4), libapr1-dev
 Standards-Version: 4.1.1
 Homepage: http://0pointer.de/lennart/projects/mod_dnssd/
 
-- 
2.30.2

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 828752@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 828752@bugs.debian.org

Subject: Re: Bug#828752: mod-dnssd: please make the build reproducible

Date: Thu, 06 Oct 2022 13:42:16 -0700

[Message part 1 (text/plain, inline)]

Control: tags 828752 pending

On 2022-10-06, Vagrant Cascadian wrote:
> I intend to NMU with these patches applied, though will likely use
> DELAYED/10 to give time for the maintainer to respond.

Uploaded an NMU to DELAYED/10:

diff -Nru mod-dnssd-0.6/debian/changelog mod-dnssd-0.6/debian/changelog
--- mod-dnssd-0.6/debian/changelog	2017-11-26 09:49:30.000000000 -0800
+++ mod-dnssd-0.6/debian/changelog	2022-10-06 11:11:40.000000000 -0700
@@ -1,3 +1,13 @@
+mod-dnssd (0.6-3.3) unstable; urgency=medium
+
+  * Non-maintainer upload.
+
+  * debian/rules: Pass --disable-lynx in dh_auto_configure override.
+    (Closes: #828752)
+  * debian/control: Remove lynx from Build-Depends.
+
+ -- Vagrant Cascadian <vagrant@reproducible-builds.org>  Thu, 06 Oct 2022 11:11:40 -0700
+
 mod-dnssd (0.6-3.2) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru mod-dnssd-0.6/debian/control mod-dnssd-0.6/debian/control
--- mod-dnssd-0.6/debian/control	2017-11-26 09:49:30.000000000 -0800
+++ mod-dnssd-0.6/debian/control	2022-10-06 11:11:40.000000000 -0700
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Regis Boudin <regis@debian.org>
 Uploaders: Sebastien ESTIENNE <sebastien.estienne@gmail.com>
-Build-Depends: debhelper (>= 10), apache2-dev, dh-apache2,libavahi-client-dev (>= 0.6.4), lynx, libapr1-dev
+Build-Depends: debhelper (>= 10), apache2-dev, dh-apache2,libavahi-client-dev (>= 0.6.4), libapr1-dev
 Standards-Version: 4.1.1
 Homepage: http://0pointer.de/lennart/projects/mod_dnssd/
 
diff -Nru mod-dnssd-0.6/debian/rules mod-dnssd-0.6/debian/rules
--- mod-dnssd-0.6/debian/rules	2017-11-26 09:49:30.000000000 -0800
+++ mod-dnssd-0.6/debian/rules	2022-10-06 11:11:40.000000000 -0700
@@ -6,3 +6,6 @@
 	dh $@ --with apache2
 
 override_dh_auto_install:
+
+override_dh_auto_configure:
+	dh_auto_configure -- --disable-lynx

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 828752-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 828752-close@bugs.debian.org

Subject: Bug#828752: fixed in mod-dnssd 0.6-3.3

Date: Sun, 16 Oct 2022 19:10:37 +0000

Source: mod-dnssd
Source-Version: 0.6-3.3
Done: Vagrant Cascadian <vagrant@reproducible-builds.org>

We believe that the bug you reported is fixed in the latest version of
mod-dnssd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 828752@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@reproducible-builds.org> (supplier of updated mod-dnssd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 06 Oct 2022 11:11:40 -0700
Source: mod-dnssd
Architecture: source
Version: 0.6-3.3
Distribution: unstable
Urgency: medium
Maintainer: Regis Boudin <regis@debian.org>
Changed-By: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: 828752
Changes:
 mod-dnssd (0.6-3.3) unstable; urgency=medium
 .
   * Non-maintainer upload.
 .
   * debian/rules: Pass --disable-lynx in dh_auto_configure override.
     (Closes: #828752)
   * debian/control: Remove lynx from Build-Depends.
Checksums-Sha1:
 3734b28704e5088788f385f36d9d592d0eab7595 1426 mod-dnssd_0.6-3.3.dsc
 382e36d19fa19d08d62cb177a7eea7b8306c83ca 3744 mod-dnssd_0.6-3.3.debian.tar.xz
Checksums-Sha256:
 61bb8e03b25ab0d9e2889d82c298619aca89b96b459643296f6aec6733e72d07 1426 mod-dnssd_0.6-3.3.dsc
 6571d5197ad2f3285d102f0c74903defe7ba98c6d6a39d1a6318bbef71c0521e 3744 mod-dnssd_0.6-3.3.debian.tar.xz
Files:
 418cf24d8d1f4b730b908c3a8ee70f56 1426 httpd optional mod-dnssd_0.6-3.3.dsc
 5bf70ff77ef68c85a9fdc5bbe749a17b 3744 httpd optional mod-dnssd_0.6-3.3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iJYEARYKAD4WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYz8b7CAcdmFncmFudEBy
ZXByb2R1Y2libGUtYnVpbGRzLm9yZwAKCRDcUY/If5cWqr+wAPsGZfn0dEYXjVfj
T71/vrR9ieezbDVaDjUjfziNbjIxTAEA67Fa2JIy0AkI2oSfZEAuBUJi66B/ibeg
JYrCvbj6Nwo=
=cy6p
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.