Debian Bug report logs - #828168
x42-plugins: midimap.lv2/manifest.ttl uses non-portable shell syntax; please make the build reproducible (shell)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Daniel Shahaf <danielsh@apache.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: x42-plugins: midimap.lv2/manifest.ttl uses non-portable shell syntax; please make the build reproducible (shell)

Date: Sat, 25 Jun 2016 16:40:15 +0000

[Message part 1 (text/plain, inline)]

Package: x42-plugins
Version: 20160619-1
Severity: normal
Tags: upstream patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: environment

Dear Maintainer,

While working on the “reproducible builds” effort, we have noticed that
x42-plugins could not be built reproducibly; the diff between two
builds is:

    https://tests.reproducible-builds.org/debian/dbdtxt/unstable/amd64/x42-plugins_20160619-1.diffoscope.txt
    │   │   │   ├── ./usr/lib/lv2/midimap.lv2/manifest.ttl
    │   │   │   │ @@ -14,43 +14,43 @@
    │   │   │   │  mmpset:lp_thirds_c4_colors
    │   │   │   │  	a pset:Preset ;
    │   │   │   │  	lv2:appliesTo <http://gareus.org/oss/lv2/midimap> ;
    │   │   │   │ -	rdfs:seeAlso <presets.ttl> .
    │   │   │   │ +\trdfs:seeAlso <presets.ttl> .

This difference is down to midimap.lv2/Makefile [1] calling echo(1) with
an argument that contains a literal backslash.  The behaviour of echo(1)
in that case is (according to POSIX) implementation-defined.  Since
makefiles use echo(1) from the building user's shell, the build output
differs when the building user uses SHELL=bash v. SHELL=dash:

    % LC_ALL=C dash -c 'echo "\t"' | xxd 
    0000000: 090a                                     ..
    % LC_ALL=C bash -c 'echo "\t"' | xxd 
    0000000: 5c74 0a                                  \t.

I believe the attached patch will fix the issue.

Note that when built under bash, pluginlibConfig.cmakep.lv2/manifest.ttl
would contain literal «\t» sequences; I'm not sure what their effect
would be.

Cheers,

Daniel

[1] https://sources.debian.net/src/x42-plugins/20160619-1/midimap.lv2/Makefile/#L84

[0002-unportable-shell-syntax.patch (text/x-diff, attachment)]

Message #10 received at 828168-submitter@bugs.debian.org (full text, mbox, reply):

From: Jaromír Mikeš <mira.mikes@seznam.cz>

To: 828168-submitter@bugs.debian.org

Subject: Bug#828168 marked as pending

Date: Sat, 25 Jun 2016 22:15:06 +0000

tag 828168 pending
thanks

Hello,

Bug #828168 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:

    http://git.debian.org/?p=pkg-multimedia/x42-plugins.git;a=commitdiff;h=b6db083

---
commit b6db0831d9c439789d55e19d46e6bfd6ea4d600f
Author: Jaromír Mikeš <mira.mikes@seznam.cz>
Date:   Sun Jun 26 00:06:58 2016 +0200

    Finalize changelog.

diff --git a/debian/changelog b/debian/changelog
index ab8dde0..c7e0a72 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,6 @@
-x42-plugins (20160619-2) UNRELEASED; urgency=medium
+x42-plugins (20160619-2) unstable; urgency=medium
 
-  * Start new upload.
+  * Add patch to fix reproducible-builds. (Closes: #828168)
 
  -- Jaromír Mikeš <mira.mikes@seznam.cz>  Sat, 25 Jun 2016 23:51:47 +0200
 

Message #15 received at 828168-close@bugs.debian.org (full text, mbox, reply):

From: Jaromír Mikeš <mira.mikes@seznam.cz>

To: 828168-close@bugs.debian.org

Subject: Bug#828168: fixed in x42-plugins 20160619-2

Date: Sat, 25 Jun 2016 22:26:38 +0000

Source: x42-plugins
Source-Version: 20160619-2

We believe that the bug you reported is fixed in the latest version of
x42-plugins, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 828168@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jaromír Mikeš <mira.mikes@seznam.cz> (supplier of updated x42-plugins package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 25 Jun 2016 23:51:47 +0200
Source: x42-plugins
Binary: x42-plugins
Architecture: source amd64
Version: 20160619-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Jaromír Mikeš <mira.mikes@seznam.cz>
Description:
 x42-plugins - Collection of LV2 plugins
Closes: 828168
Changes:
 x42-plugins (20160619-2) unstable; urgency=medium
 .
   * Add patch to fix reproducible-builds. (Closes: #828168)
Checksums-Sha1:
 36f65a94745ed78e8dd72fbae48a0e0e6feb2daf 2275 x42-plugins_20160619-2.dsc
 ee2cb940bd448a094bb7b204f1bd8ba00064b402 4240 x42-plugins_20160619-2.debian.tar.xz
 48a262f18e4bcaa67b85a9698adbe588f4d72df1 37036 x42-plugins-dbgsym_20160619-2_amd64.deb
 9d683b27bb1b597067dc65f436deebe9b2e0717e 2275466 x42-plugins_20160619-2_amd64.deb
Checksums-Sha256:
 56c225280f9b3247f3d877ebca616c1289f3714e1162e8908a690ab3e58167ef 2275 x42-plugins_20160619-2.dsc
 8581a62822005ca3836ec73dea0f1a927c49deb0db57a732d1f5165fb8be27ce 4240 x42-plugins_20160619-2.debian.tar.xz
 239e63b8bf06f4be030978fa4900dd3c7fda0c12a731872cf8adddc8551a555d 37036 x42-plugins-dbgsym_20160619-2_amd64.deb
 015b94cf128f3c3c303b06b8ca7e904027dc2a1aa1dd445f03c9047fcca2362c 2275466 x42-plugins_20160619-2_amd64.deb
Files:
 fc2e465f4164cfcd0337d846c2c9713c 2275 sound optional x42-plugins_20160619-2.dsc
 b1c449050e59426e9d5a5587ba48c0bd 4240 sound optional x42-plugins_20160619-2.debian.tar.xz
 011a135a35f310711908318393d254a6 37036 debug extra x42-plugins-dbgsym_20160619-2_amd64.deb
 895a48cd808b32782a043e8a497842a5 2275466 sound optional x42-plugins_20160619-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJXbwIpAAoJEFsBlFXiuE+lQWwP/Rcscik9ueQwhXGhmbABA5Tg
dlGtV34jRulYEpiL8slg9FT/MHT7OpR5r4Rxf72vt1PNKZYPmPtMDpN2gA5P3CP1
RlNkLQclzG4R3I7MP8KDENkSR7midXuKGkcDjcDRS2DBhcXbJV7ki6iC5lIEaxr3
w0RvXYUBfqj6Lo1F9rgXQi7S1PMXjqbyfVzm4LrRb526KYG1lNRbek3+qcjckrd9
79Yxa4GHiujr5fYu7REg5m+/J++p1QrBvOphZfsjiF3H+qMvZnf/jSI1rNpR9sje
3LPC+jeAqbWyyFE3wm13qgIDe7Urf9fH2K8fcq5ZnTiQgO5nBtMTw3YQntWfOweg
EJftUT+LziMkfVVnREJRrw9aeT7fcsNt7t+9plMPxDCIH09q3nKtI43YmbpmH4wx
SMpqXkrOrXFA9iXT5tW92A3zbAVwhCzNVr2W0U6QraQ1mXVM/Cffsrv+/OyX/aP9
plVy6hxy0Y9dsIfAIsSJb4wlT1PCv3HjYqsj/wUt7CzBPJXOu3H6zV/I/xXrD2p6
w6ksowmVnmTSV5DW64YSEE4sH84JizTKOC3lxXwJqG9mSpKfWGw0V/vonMQcc3i7
oTqV53YSmHTCG8+nh1Lnqlo/ZGP/zKJTzGU2x4mdvKRGeIxoDN8LL34Yq5LCipHg
JRBM1Bm2xSPKlM+agsni
=+6OZ
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.