Debian Bug report logs - #827546
git-buildpackage: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Sascha Steinbiss <sascha@steinbiss.name>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: git-buildpackage: please make the build reproducible

Date: Fri, 17 Jun 2016 15:48:09 +0000

[Message part 1 (text/plain, inline)]

Package: git-buildpackage
Version: 0.7.5
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps randomness

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that git-buildpackage could not be built reproducibly.

This is fixed by the attached patch. Firstly, it sets deterministic timestamps
(the last Debian release date) in the manpages. This is currently done
explicitly in the docs/Makefile as the more generic docbook2man patch [2]
has not been accepted yet.
Secondly, the patch excludes some test configuration module variables from the
Epydoc documentation as they contain the names of build-specific temporary
directories.
Once applied, git-buildpackage can be built reproducibly in our current
experimental framework.

Best regards
Sascha

[1] https://wiki.debian.org/ReproducibleBuilds
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800797

[reproducible.patch (text/x-diff, attachment)]

Message #12 received at 827546@bugs.debian.org (full text, mbox, reply):

From: Guido Günther <agx@sigxcpu.org>

To: 827546@bugs.debian.org

Cc: ,control@bugs.debian.org

Subject: [git-buildpackage/master] tests: Omit build dependend variables from epydocs

Date: Sat, 2 Jul 2016 21:16:04 +0200 (CEST)

tag 827546 pending
thanks

Date:   Sat Jul 2 20:59:28 2016 +0200
Author: Guido Günther <agx@sigxcpu.org>
Commit ID: d92b656799ca50abec3883cea773cc0e5529a434
Commit URL: https://git.sigxcpu.org/cgit/git-buildpackage/;a=commitdiff;h=d92b656799ca50abec3883cea773cc0e5529a434
Patch URL: https://git.sigxcpu.org/cgit/git-buildpackage/;a=commitdiff_plain;h=d92b656799ca50abec3883cea773cc0e5529a434

    tests: Omit build dependend variables from epydocs

    based on a patch from Sascha Steinbiss
    Closes: #827546

A snapshot build including this change will be available at
http://honk.sigxcpu.org:8001/job/git-buildpackage/
      

Message #19 received at 827546@bugs.debian.org (full text, mbox, reply):

From: Guido Günther <agx@sigxcpu.org>

To: Sascha Steinbiss <sascha@steinbiss.name>, 827546@bugs.debian.org

Subject: Re: Bug#827546: git-buildpackage: please make the build reproducible

Date: Sat, 2 Jul 2016 21:19:32 +0200

Hi Sascha,
On Fri, Jun 17, 2016 at 03:48:09PM +0000, Sascha Steinbiss wrote:
> While working on the "reproducible builds" effort [1], we have noticed
> that git-buildpackage could not be built reproducibly.

Thanks for the patch. Two comments inline below:

> This is fixed by the attached patch. Firstly, it sets deterministic timestamps
> (the last Debian release date) in the manpages. This is currently done
> explicitly in the docs/Makefile as the more generic docbook2man patch [2]
> has not been accepted yet.
> Secondly, the patch excludes some test configuration module variables from the
> Epydoc documentation as they contain the names of build-specific temporary
> directories.
> Once applied, git-buildpackage can be built reproducibly in our current
> experimental framework.
> 
> Best regards
> Sascha
> 
> [1] https://wiki.debian.org/ReproducibleBuilds
> [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800797

> diff --git a/docs/Makefile b/docs/Makefile
> index 581e0a1..106245f 100644
> --- a/docs/Makefile
> +++ b/docs/Makefile
> @@ -27,6 +27,7 @@ VERSION_ENT=version.ent
>  GBP_VERSION=../gbp/version.py
>  DEB_VERSION=$(shell sed -ne 's/^gbp_version="\([.a-z0-9~-]\+\)"/\1/p' $(GBP_VERSION))
>  CHANGELOG=../debian/changelog
> +MAN_DATE=$(shell dpkg-parsechangelog -l ../debian/changelog -SDate | TZ=UTC LC_ALL=C date -f- +'%d %B %Y')
>  
>  # Stuff to build docs outside Debian
>  HAVE_SGML2X ?= 1
> @@ -49,12 +50,14 @@ BUILD_MAN_XREF_PAGES=$(patsubst %,buildxref/%,$(SGML_MANPAGES))
>  
>  buildxref/%.1 buildxref/%.5: man.%.sgml manpages/%.sgml
>  	docbook2man -o buildxref $<
> +	sed -i -r "s/\"[^\"]+\"/\"$(MAN_DATE)\"/3" $@
>  
>  manpage.refs: $(BUILD_MAN_XREF_PAGES)
>  	cp buildxref/$@ $@
>  
>  %.1 %.5: manpage.refs
>  	docbook2man -o . man.$*.sgml
> +	sed -i -r "s/\"[^\"]+\"/\"$(MAN_DATE)\"/3" $@

I'd rather see this fixed in docbook2man. I'm happy to apply this
temporarily but want to add a bugref so I can revert that patch once
it's fixed. I couldn't find a bug filed against docbook-utils
though. Where should I look?

>  git-pbuilder.1: ../bin/git-pbuilder
>  	pod2man $< $@
> diff --git a/setup.cfg b/setup.cfg
> index d443f2a..2bbb17a 100644
> --- a/setup.cfg
> +++ b/setup.cfg
> @@ -10,7 +10,7 @@ name = git-buildpackage
>  sourcecode = no
>  url = https://honk.sigxcpu.org/piki/projects/git-buildpackage/
>  target = build/apidocs/
> -fail-on = docstring_warning
> +#fail-on = docstring_warning

We can avoid these leaving the broken reference detection intact:

    https://git.sigxcpu.org/cgit/git-buildpackage/commit/?id=d92b656799ca50abec3883cea773cc0e5529a434

Cheers,
 -- Guido

Message #24 received at 827546@bugs.debian.org (full text, mbox, reply):

From: Sascha Steinbiss <sascha@steinbiss.name>

To: Guido Günther <agx@sigxcpu.org>

Cc: 827546@bugs.debian.org

Subject: Re: Bug#827546: git-buildpackage: please make the build reproducible

Date: Sun, 3 Jul 2016 11:03:38 +0100

[Message part 1 (text/plain, inline)]

Hi Guido,

thanks for taking a look at the patch!


>> %.1 %.5: manpage.refs
>> 	docbook2man -o . man.$*.sgml
>> +	sed -i -r "s/\"[^\"]+\"/\"$(MAN_DATE)\"/3" $@
> 
> I'd rather see this fixed in docbook2man. I'm happy to apply this
> temporarily but want to add a bugref so I can revert that patch once
> it's fixed. I couldn't find a bug filed against docbook-utils
> though. Where should I look?

It seems that this bug has been filed against the docbook-utils source package. It’s #800797.

>> git-pbuilder.1: ../bin/git-pbuilder
>> 	pod2man $< $@
>> diff --git a/setup.cfg b/setup.cfg
>> index d443f2a..2bbb17a 100644
>> --- a/setup.cfg
>> +++ b/setup.cfg
>> @@ -10,7 +10,7 @@ name = git-buildpackage
>> sourcecode = no
>> url = https://honk.sigxcpu.org/piki/projects/git-buildpackage/
>> target = build/apidocs/
>> -fail-on = docstring_warning
>> +#fail-on = docstring_warning
> 
> We can avoid these leaving the broken reference detection intact:
> 
>    https://git.sigxcpu.org/cgit/git-buildpackage/commit/?id=d92b656799ca50abec3883cea773cc0e5529a434

Even better! I haven’t used epydoc much myself so apparently you know more details. Thanks!

Cheers
Sascha

[signature.asc (application/pgp-signature, attachment)]

Message #29 received at 827546@bugs.debian.org (full text, mbox, reply):

From: Guido Günther <agx@sigxcpu.org>

To: Sascha Steinbiss <sascha@steinbiss.name>, 827546@bugs.debian.org

Subject: Re: Bug#827546: git-buildpackage: please make the build reproducible

Date: Sun, 3 Jul 2016 13:22:06 +0200

On Sun, Jul 03, 2016 at 11:03:38AM +0100, Sascha Steinbiss wrote:
> Hi Guido,
> 
> thanks for taking a look at the patch!
> 
> 
> >> %.1 %.5: manpage.refs
> >> 	docbook2man -o . man.$*.sgml
> >> +	sed -i -r "s/\"[^\"]+\"/\"$(MAN_DATE)\"/3" $@
> > 
> > I'd rather see this fixed in docbook2man. I'm happy to apply this
> > temporarily but want to add a bugref so I can revert that patch once
> > it's fixed. I couldn't find a bug filed against docbook-utils
> > though. Where should I look?
> 
> It seems that this bug has been filed against the docbook-utils source package. It’s #800797.

Thanks. So I'll add this until docbook-utils is fixed.
Cheers,
 -- Guido

Message #34 received at 827546-close@bugs.debian.org (full text, mbox, reply):

From: Guido Günther <agx@sigxcpu.org>

To: 827546-close@bugs.debian.org

Subject: Bug#827546: fixed in git-buildpackage 0.8.0

Date: Tue, 05 Jul 2016 10:05:08 +0000

Source: git-buildpackage
Source-Version: 0.8.0

We believe that the bug you reported is fixed in the latest version of
git-buildpackage, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 827546@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guido Günther <agx@sigxcpu.org> (supplier of updated git-buildpackage package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 04 Jul 2016 21:47:42 +0200
Source: git-buildpackage
Binary: git-buildpackage git-buildpackage-rpm
Architecture: source all
Version: 0.8.0
Distribution: experimental
Urgency: medium
Maintainer: Guido Günther <agx@sigxcpu.org>
Changed-By: Guido Günther <agx@sigxcpu.org>
Description:
 git-buildpackage - Suite to help with Debian packages in Git repositories
 git-buildpackage-rpm - Suite to help with RPM packages in Git repositories
Closes: 561071 685031 733640 808027 825536 827546 828703 828838 829025 829070 829458
Changes:
 git-buildpackage (0.8.0) experimental; urgency=medium
 .
   [ Markus Lehtonen ]
   * [c5cfb5e] Introduce gbp-rpm-ch.
     Initial version of gbp rpm-ch command, a tool for maintaining
     RPM changelogs. The new command supports %changelog section inside spec
     files as well as separate changelog files ("OBS style"). (Closes: #808027)
 .
   [ Guido Günther ]
   * [b4b7f9f] clone: Be a bit more verbose and let the user know that we
     started cloning
   * [1f58d21] PatchSeries: Strip comment from patch names (Closes: #825536)
   * [1989c32] pq: Report number of imported patches
   * [dcb145f] Use existing option as example in gbp-buildpackage manpage.
     Thanks to Nicolas Braud-Santoni (Closes: #828703)
   * [f1c64e2] manpages: add examples for gbp {clone,import-dsc}
   * [83dfa67] GitRepository: Deleting a non-existing branch should not throw
     an error
   * [ba7b087] docs: Clarify some gbp pq options
   * [ebc6b91] import_orig: Recover from import errors by winding back branches
     and tags to their pre-error states (Closes: #828838)
   * [4964234] dch: Log version number when preparing a snapshot
     (Closes: #829025)
   * [7a6641a] import-dsc: Don't fail on 1.0 non-native packages without a
     Debian version
     (Closes: #829070)
   * [8c4460c] Actually install gbp-rpm-ch and unbreak manpage generation
   * [d92b656] tests: Omit build dependend variables from epydocs
     based on a patch from Sascha Steinbiss (Closes: #827546)
   * [d977377] Set date in manpages based on last changelog entry
     for reproducibility. This can be reverted once ocbook2man is fixed
     (#800797).
     Thanks to Sascha Steinbiss for the patch
   * [53f37eb] import-orig: Make default import message more gbp-dch friendly.
   * [312c9b9] Use imperative for git messages as suggested in gh:#26.
   * [2bc3801] import_dsc: don't assume component tarballs have the correct name.
     (Closes: #829458)
   * [bc3805c] import_orig: add support for importing additional tarballs.
     We expect the additional tarballs to be located next to the orig tarball
     and to be already named properly. (Closes: #561071)
   * [870c901] Docs: Clarify on possible key names and priorities in gbp.conf
   * [7a521d4] Handle Ctrl-C more gracefully
   * [b540c98] additional tarballs: allow one to configure components via gbp.conf
   * [1d4d4a2] config: Allow one to give list values in plural form
   * [700e164] config: Properly abort on config file parsing errors
     instead of printing an exception on the console
   * [3b4912d] config: always use 'gbp <cmd>' in help output.
     The {git,gbp}- versions went away ages ago
   * [f545010] Give more instructions when config is unparseable
     and make return codes and messages consistent.
     (Closes: #733640)
   * [a0ed81b] Require python 2.7. It's the default up to Wheezy
     (Closes: #685031)
 .
   [ Otto Kekäläinen ]
   * [af16f59] Fix simple spelling errors in comments and strings
   * [f28a26b] Fix spelling of existant->existent in function names, strings
     and comments
Checksums-Sha1:
 6d30e86348aabd8f228a96672a275875b54e783c 2070 git-buildpackage_0.8.0.dsc
 382dedfea64e6e84745482ecff830bec6478df4b 1698452 git-buildpackage_0.8.0.tar.xz
 357cd7eff39359cbb25a73752cb7539f337d81a2 97498 git-buildpackage-rpm_0.8.0_all.deb
 7cfed1bf9a97d8a51650e044b457a2cf96fe42f9 343518 git-buildpackage_0.8.0_all.deb
Checksums-Sha256:
 0fb90ee848814d40d300a22dbee4f93e19a35f6335105a7f6c2dd9dfefbbea15 2070 git-buildpackage_0.8.0.dsc
 01a6856dace950cab5b4dd3089527aa6aeee86e3b9fe7e2ee28c8dff59dff81d 1698452 git-buildpackage_0.8.0.tar.xz
 3291e1e3330165505465a6ad4a2ad8848fd7b6fe9a31a797939245006b1a73e1 97498 git-buildpackage-rpm_0.8.0_all.deb
 091dda0da06bbf1a11b07269c5541e2ae7feafd32043c1eabe02756416f7e074 343518 git-buildpackage_0.8.0_all.deb
Files:
 02477936f012dcd478884f3ccb5d62a2 2070 vcs optional git-buildpackage_0.8.0.dsc
 14cf9d8e350c38fbb279bfb0310884a0 1698452 vcs optional git-buildpackage_0.8.0.tar.xz
 d9f093837d5b179926eb64c7a8d371e0 97498 vcs optional git-buildpackage-rpm_0.8.0_all.deb
 19aaaf924631b476b7c351524b6c2212 343518 vcs optional git-buildpackage_0.8.0_all.deb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJXer6wAAoJEAe4t7DqmBILDL0P+wXObekzf7zZ9kFVhi4D78Nf
bBQXKvxOZCVcaoZNKXSuqzp/vHcCtWY5Q6qCUxfi8ds6QY/UH6jfbL71hZ17ocF3
2nwoTYPHT/2nWAfvNtNpsnDnqqWsO6bx1kBNY6QxR3AbEt7HCKNhfYXzYoosze8c
HVw7bUOdTJdxfD+ne7Sqli8bHxODNy5EqbdZrFPIUaw0J9bj/1INk+yw7qtDa+nH
m3LqSnEya5YkhIYAq26M9nurVy7tV5P3SLXR6dqPStZmPKcHb9DcC+msFgrsmt69
lTtGWQjsMQowc1RdivtziIBPi/VNA8+05Vkskh25BHHuulNoXaxjtoUdXUNCRvwB
90ej73eQeZLrMC7np3vp3X7E35VhcPrIgRiyhPy1AcniOloO9U/I9L1dzyJ6WlnS
OG6pKeUqOOlgihhzIshyjqVd0wcpN1Mflm5nzgs8aH4ZWbWquSGCY5/t9H4TZ9Ko
Vb8KiAK1OKyjS0JcKC28wr1NJCoYXRTtIfTQh/ULjhcaVD+CDLEQwp0bYwiUMWy0
HhdOMTP4DYmgk70/l54cnEP90KfA3n9rgMkk0D9OfIGnSwlL30R5nutryAqQbvAK
it3l02yiy2DLJRlJSz5jj7s5PN3EaP8w+9FnmnspMn6/gLHF5HDeSxONW3zOlXJ7
mTz9DGJiH/0Qz9mIhg40
=2r5z
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.