Debian Bug report logs - #826994
Missing init-script(s)?

version graph

Package: zfsutils-linux; Maintainer for zfsutils-linux is Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>; Source for zfsutils-linux is src:zfs-linux (PTS, buildd, popcon).

Reported by: Carsten Leonhardt <leo@debian.org>

Date: Fri, 10 Jun 2016 23:45:02 UTC

Severity: wishlist

Tags: patch

Found in version zfs-linux/0.6.5.7-1

Fixed in version zfs-linux/0.7.11-2

Done: Mo Zhou <cdluminate@gmail.com>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Fri, 10 Jun 2016 23:45:06 GMT) (full text, mbox, link).


Acknowledgement sent to Carsten Leonhardt <leo@debian.org>:
New Bug report received and forwarded. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Fri, 10 Jun 2016 23:45:06 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Carsten Leonhardt <leo@debian.org>
To: submit@bugs.debian.org
Subject: Missing init-script(s)?
Date: Sat, 11 Jun 2016 01:43:13 +0200
Package: zfsutils-linux
Version: 0.6.5.7-1
Severity: important

Dear Maintainers,

I was wondering why my zpools aren't available after a reboot, until I
found out that you provide systemd service files that would make them
available, but no init file(s).

Carsten



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Sat, 11 Jun 2016 06:57:03 GMT) (full text, mbox, link).


Acknowledgement sent to Petter Reinholdtsen <pere@hungry.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Sat, 11 Jun 2016 06:57:03 GMT) (full text, mbox, link).


Message #10 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>
To: Carsten Leonhardt <leo@debian.org>, 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Missing init-script(s)?
Date: Sat, 11 Jun 2016 08:54:19 +0200
[Carsten Leonhardt]
> Dear Maintainers,
>
> I was wondering why my zpools aren't available after a reboot, until I
> found out that you provide systemd service files that would make them
> available, but no init file(s).

Hm, wonder where those went.  The Wheezy packages from ZoL had init.d
scripts, at least.  I guess we can dig them out from there.  Are the
kFreeBSD packages using init.d scripts?  Perhaps we can reuse those?
-- 
Happy hacking
Petter Reinholdtsen



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Sat, 11 Jun 2016 10:09:11 GMT) (full text, mbox, link).


Acknowledgement sent to Turbo Fredriksson <turbo@bayour.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Sat, 11 Jun 2016 10:09:11 GMT) (full text, mbox, link).


Message #15 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Turbo Fredriksson <turbo@bayour.com>
To: Petter Reinholdtsen <pere@hungry.com>, 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Bug#826994: Missing init-script(s)?
Date: Sat, 11 Jun 2016 11:07:40 +0100
On Jun 11, 2016, at 7:54 AM, Petter Reinholdtsen wrote:

> Hm, wonder where those went.  The Wheezy packages from ZoL had init.d
> scripts, at least.  I guess we can dig them out from there.  Are the
> kFreeBSD packages using init.d scripts?  Perhaps we can reuse those?

See ./etc/init.d in the ZFS source directory.




Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Mon, 04 Jul 2016 02:39:08 GMT) (full text, mbox, link).


Acknowledgement sent to Tim Connors <tim.w.connors@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Mon, 04 Jul 2016 02:39:08 GMT) (full text, mbox, link).


Message #20 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Tim Connors <tim.w.connors@gmail.com>
To: 826994@bugs.debian.org
Cc: Petter Reinholdtsen <pere@hungry.com>, Carsten Leonhardt <leo@debian.org>
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Missing init-script(s)?
Date: Mon, 4 Jul 2016 12:37:30 +1000 (AEST)
DDs - any news on this?

zfsutils_0.6.5.7-8-jessie_amd64.deb from ZoL contained amongst others:

-rwxr-xr-x root/root      2871 2016-05-20 08:59 ./etc/init.d/zfs-zed
-rwxr-xr-x root/root      5623 2016-05-20 08:59 ./etc/init.d/zfs-mount
-rwxr-xr-x root/root      2262 2016-05-20 08:59 ./etc/init.d/zfs-share
-rwxr-xr-x root/root      5100 2016-05-20 08:59 ./etc/init.d/zfs-import

This was sufficient to ensure my pools were all imported and mounted on
the systems I've banished systemd from for reliability reasons.  Alas, all
that zfsutils-linux in debian contains in the whole of /etc/ are:

168691,5> dpkg -L zfsutils-linux  | grep /etc/
/etc/cron.d
/etc/cron.d/zfsutils-linux
/etc/default
/etc/default/zfs
/etc/zfs
/etc/zfs/zfs-functions


(we've also lost:
-rw-r--r-- root/root     11305 2016-05-20 08:52 ./etc/bash_completion.d/zfs
)


-- 
Tim Connors



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Mon, 04 Jul 2016 03:03:04 GMT) (full text, mbox, link).


Acknowledgement sent to Richard Laager <rlaager@wiktel.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Mon, 04 Jul 2016 03:03:04 GMT) (full text, mbox, link).


Message #25 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Richard Laager <rlaager@wiktel.com>
To: Tim Connors <tim.w.connors@gmail.com>, 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Bug#826994: Missing init-script(s)?
Date: Sun, 3 Jul 2016 21:52:58 -0500
On 07/03/2016 09:37 PM, Tim Connors wrote:
> (we've also lost:
> -rw-r--r-- root/root     11305 2016-05-20 08:52 ./etc/bash_completion.d/zfs

This is present:
/usr/share/bash-completion/completions/zfs

-- 
Richard



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Mon, 04 Jul 2016 15:30:04 GMT) (full text, mbox, link).


Acknowledgement sent to Craig Sanders <cas@taz.net.au>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Mon, 04 Jul 2016 15:30:04 GMT) (full text, mbox, link).


Message #30 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Craig Sanders <cas@taz.net.au>
To: Tim Connors <tim.w.connors@gmail.com>
Cc: 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Bug#826994: Missing init-script(s)?
Date: Tue, 5 Jul 2016 01:21:12 +1000
On Mon, Jul 04, 2016 at 12:37:30PM +1000, Tim Connors wrote:
> zfsutils_0.6.5.7-8-jessie_amd64.deb from ZoL contained amongst others:
> 
> -rwxr-xr-x root/root      2871 2016-05-20 08:59 ./etc/init.d/zfs-zed
> -rwxr-xr-x root/root      5623 2016-05-20 08:59 ./etc/init.d/zfs-mount
> -rwxr-xr-x root/root      2262 2016-05-20 08:59 ./etc/init.d/zfs-share
> -rwxr-xr-x root/root      5100 2016-05-20 08:59 ./etc/init.d/zfs-import
> 
> This was sufficient to ensure my pools were all imported and mounted
> on the systems I've banished systemd from for reliability reasons.
> Alas, all that zfsutils-linux in debian contains in the whole of /etc/
> are:
> [ list of files that don't include the init scripts ]

Unfortunately, debian's ZoL only fully supports systemd at the moment.

Until this is resolved satisfactorily, you can copy the ZoL init scripts
and run:

update-rc.d zfs-import defaults
update-rc.d zfs-mount defaults
update-rc.d zfs-zed defaults
update-rc.d zfs-share defaults

It Worked For Me<tm>


I've since seen notes saying:

    INSTALLING INIT SCRIPT LINKS

      To setup the init script links in /etc/rc?.d manually on a Debian
      GNU/Linux (or derived) system, run the following commands (the
      order is important!):

        update-rc.d zfs-import start 07 S .       stop 07 0 1 6 .
        update-rc.d zfs-mount  start 02 2 3 4 5 . stop 06 0 1 6 .
        update-rc.d zfs-zed    start 07 2 3 4 5 . stop 08 0 1 6 .
        update-rc.d zfs-share  start 27 2 3 4 5 . stop 05 0 1 6 .


When I asked Aron Xu about this back in Feb, he said:

 > The only stopper for adding LSB (sysvinit) support is manpower, I
 > dropped the support to make things easier for doing an initial upload
 > for the archive. systemd support is tested and used in production by
 > myself on Jessie systems without problem, though. If there is people
 > willing to give a hand on maintaining LSB support I'm happy to carry
 > it.

I guess that means "patches welcome".

craig

-- 
craig sanders <cas@taz.net.au>



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Mon, 04 Jul 2016 19:45:03 GMT) (full text, mbox, link).


Acknowledgement sent to Petter Reinholdtsen <pere@hungry.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Mon, 04 Jul 2016 19:45:03 GMT) (full text, mbox, link).


Message #35 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>
To: Craig Sanders <cas@taz.net.au>, 826994@bugs.debian.org, Tim Connors <tim.w.connors@gmail.com>
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Bug#826994: Bug#826994: Missing init-script(s)?
Date: Mon, 04 Jul 2016 21:42:44 +0200
[Craig Sanders]
> I've since seen notes saying:
>
>     INSTALLING INIT SCRIPT LINKS
>
>       To setup the init script links in /etc/rc?.d manually on a Debian
>       GNU/Linux (or derived) system, run the following commands (the
>       order is important!):
>
>         update-rc.d zfs-import start 07 S .       stop 07 0 1 6 .
>         update-rc.d zfs-mount  start 02 2 3 4 5 . stop 06 0 1 6 .
>         update-rc.d zfs-zed    start 07 2 3 4 5 . stop 08 0 1 6 .
>         update-rc.d zfs-share  start 27 2 3 4 5 . stop 05 0 1 6 .

These notes are obsolete.  Debian no longer support the start/stop
arguments to update-rc.d, as dependency based boot ordering is used.
Use the 'defaults' versions mentioned above.  Note the ordering is still
important, as the dependencies must be registered before the scripts
using them.

> I guess that means "patches welcome".

Yeah.  Especially tested patches. :)

-- 
Happy hacking
Petter Reinholdtsen



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Thu, 05 Jan 2017 18:09:03 GMT) (full text, mbox, link).


Acknowledgement sent to Håkan Johansson <f96hajo@chalmers.se>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Thu, 05 Jan 2017 18:09:03 GMT) (full text, mbox, link).


Message #40 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Håkan Johansson <f96hajo@chalmers.se>
To: <826994@bugs.debian.org>
Subject: patch
Date: Thu, 5 Jan 2017 18:50:32 +0100
[Message part 1 (text/plain, inline)]
Dear Maintainers,

I am interested in getting the startup scripts /etc/init.d/zfs- into the 
packages(s).

Attached is a first patch attempt.  (I am completely new to debian 
packaging...)

It has been (lightly) tested on two machines: after update from the ZoL 
packages to jessie-backports they no longer imported/mounted the ZFS 
filesystems after reboot.  They do with packages compiled with the patch.

Since the scripts are already in the source package, the only addition is 
a fix for zfs-zed.in (lintian warned without $local_fs), the install 
rules are lifted from zfs-pkg [1].

There are two known issues:

one lintian warning for each script, e.g.:
W: zfsutils-linux: init.d-script-does-not-source-init-functions etc/init.d/zfs-import
as far as I can see, zfs-functions does include /lib/lsb/init-functions,
but lintian does not know this.  How to fix this?  lintian override?

the zfs-share startup script depends on zfs-zed, but as zfs-zed has been 
split to a separate package, but depending on zfsutils-linux this is not 
installed yet when zfsutils-linux tries to start zfs-share and thus fails.
How to handle that?  (usr/lib/systemd/system/zfs-share.service is in 
zfsutils-linux so putting /etc/init.d/zfs-share in zfs-zed does not seem 
right...)

Cheers,
Håkan

[1] https://github.com/zfsonlinux/pkg-zfs/blob/master/debian/jessie/debian/rules
[patch_1_826994.diff (text/x-diff, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Thu, 05 Jan 2017 18:27:03 GMT) (full text, mbox, link).


Acknowledgement sent to Håkan Johansson <f96hajo@chalmers.se>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Thu, 05 Jan 2017 18:27:03 GMT) (full text, mbox, link).


Message #45 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Håkan Johansson <f96hajo@chalmers.se>
To: <826994@bugs.debian.org>
Subject: Re: Bug#826994: Info received (patch)
Date: Thu, 5 Jan 2017 19:25:57 +0100
[Message part 1 (text/plain, inline)]
clarifications:

zfs-functions is included from each script

I dropped the explicit start/stop levels in the rules, as the above 
bug discussion told that they are no longer used

Håkan

Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Sat, 04 Feb 2017 20:03:05 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Sat, 04 Feb 2017 20:03:05 GMT) (full text, mbox, link).


Message #50 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Patch
Date: Sat, 4 Feb 2017 12:53:24 -0700
Håkan Johansson,

Patch works wonderfully.  Thank you.

    Chris



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Fri, 17 Mar 2017 15:03:02 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Fri, 17 Mar 2017 15:03:02 GMT) (full text, mbox, link).


Message #55 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Apply Patch
Date: Fri, 17 Mar 2017 08:50:17 -0600
This patch has been working for me on several systems.  Also works with zfs_0.6.5.9-2~bpo8+1.

Since this patch seems to be working fine, can it be officially applied?

     Chris



Added tag(s) patch. Request was from Carsten Leonhardt <leo@debian.org> to control@bugs.debian.org. (Tue, 25 Jul 2017 14:15:06 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Sat, 04 Nov 2017 12:12:03 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Sat, 04 Nov 2017 12:12:03 GMT) (full text, mbox, link).


Message #62 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Re: Apply Patch
Date: Sat, 4 Nov 2017 06:03:25 -0600
Patch does not apply to 0.7.3:

patch -p1 --dry-run < ../zfs-sysvinit_patch_1.diff
checking file debian/rules
Hunk #1 succeeded at 116 with fuzz 2 (offset 4 lines).
checking file debian/zfs-zed.install
Hunk #1 succeeded at 1 with fuzz 1.
checking file debian/zfsutils-linux.install
Hunk #1 FAILED at 9.
1 out of 1 hunk FAILED
checking file etc/init.d/zfs-zed.in



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Wed, 06 Dec 2017 21:30:09 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Wed, 06 Dec 2017 21:30:09 GMT) (full text, mbox, link).


Message #67 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Updated Patch
Date: Wed, 6 Dec 2017 14:26:17 -0700
[Message part 1 (text/plain, inline)]
I've modified the diff to patch against 0.7.3-3 and it patches fine.  I also applied a fix for the zed binary location.  The /etc/zfs/zfs-functions was
looking for it in /sbin when it was actually in /usr/sbin.  I googled but could not find what the equivalent @sbindir@ for /usr/sbin would be so I just hard
coded /usr/sbin/zed.  The /etc/init.d/zfs-zed init script now starts zed just fine.

The patch compiles against Sid without problems and it seems to boot fine.

However, the base 0.7.3-3 package won't compile on Jessie so I cannot even test the patch.
I receive an error about missing files:

Error:
chmod a-x /var/temp/sdeb/zfs_0.7.3-3/zfs-linux-0.7.3/debian/tmp/etc/zfs/zfs-functions
chmod a-x /var/temp/sdeb/zfs_0.7.3-3/zfs-linux-0.7.3/debian/tmp/etc/default/zfs
make[1]: Leaving directory '/var/temp/sdeb/zfs_0.7.3-3/zfs-linux-0.7.3'
   debian/rules override_dh_install
make[1]: Entering directory '/var/temp/sdeb/zfs_0.7.3-3/zfs-linux-0.7.3'
find . -name lib*.la -delete
dh_install --fail-missing
dh_install: usr/share/zfs/zfs-helpers.sh exists in debian/tmp but is not installed to anywhere
dh_install: etc/zfs/vdev_id.conf.multipath.example exists in debian/tmp but is not installed to anywhere
dh_install: etc/zfs/vdev_id.conf.sas_direct.example exists in debian/tmp but is not installed to anywhere
dh_install: etc/zfs/vdev_id.conf.alias.example exists in debian/tmp but is not installed to anywhere
dh_install: etc/zfs/vdev_id.conf.sas_switch.example exists in debian/tmp but is not installed to anywhere
dh_install: etc/init.d/zfs-mount exists in debian/tmp but is not installed to anywhere
dh_install: etc/init.d/zfs-zed exists in debian/tmp but is not installed to anywhere
dh_install: etc/init.d/zfs-import exists in debian/tmp but is not installed to anywhere
dh_install: etc/init.d/zfs-share exists in debian/tmp but is not installed to anywhere
dh_install: etc/sudoers.d/zfs exists in debian/tmp but is not installed to anywhere
dh_install: missing files, aborting
debian/rules:175: recipe for target 'override_dh_install' failed
make[1]: *** [override_dh_install] Error 2
make[1]: Leaving directory '/var/temp/sdeb/zfs_0.7.3-3/zfs-linux-0.7.3'
debian/rules:34: recipe for target 'binary' failed
make: *** [binary] Error 2
dpkg-buildpackage: error: debian/rules binary gave error exit status 2

I'm still trying to track down what missing files it is looking for between Jessie and Sid.

    Chris
[sysvinit_patch_2_826994.diff (text/x-patch, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Thu, 07 Dec 2017 12:33:02 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Thu, 07 Dec 2017 12:33:02 GMT) (full text, mbox, link).


Message #72 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Re: Updated Patch
Date: Thu, 7 Dec 2017 05:29:02 -0700
On Wed, 6 Dec 2017 14:26:17 -0700 Chris Dos <chris@chrisdos.com> wrote:
> However, the base 0.7.3-3 package won't compile on Jessie so I cannot even test the patch.
> I receive an error about missing files:
>
> Error:
> chmod a-x /var/temp/sdeb/zfs_0.7.3-3/zfs-linux-0.7.3/debian/tmp/etc/zfs/zfs-functions
> chmod a-x /var/temp/sdeb/zfs_0.7.3-3/zfs-linux-0.7.3/debian/tmp/etc/default/zfs
> make[1]: Leaving directory '/var/temp/sdeb/zfs_0.7.3-3/zfs-linux-0.7.3'
>    debian/rules override_dh_install
> make[1]: Entering directory '/var/temp/sdeb/zfs_0.7.3-3/zfs-linux-0.7.3'
> find . -name lib*.la -delete
> dh_install --fail-missing
> dh_install: usr/share/zfs/zfs-helpers.sh exists in debian/tmp but is not installed to anywhere
> dh_install: etc/zfs/vdev_id.conf.multipath.example exists in debian/tmp but is not installed to anywhere
> dh_install: etc/zfs/vdev_id.conf.sas_direct.example exists in debian/tmp but is not installed to anywhere
> dh_install: etc/zfs/vdev_id.conf.alias.example exists in debian/tmp but is not installed to anywhere
> dh_install: etc/zfs/vdev_id.conf.sas_switch.example exists in debian/tmp but is not installed to anywhere
> dh_install: etc/init.d/zfs-mount exists in debian/tmp but is not installed to anywhere
> dh_install: etc/init.d/zfs-zed exists in debian/tmp but is not installed to anywhere
> dh_install: etc/init.d/zfs-import exists in debian/tmp but is not installed to anywhere
> dh_install: etc/init.d/zfs-share exists in debian/tmp but is not installed to anywhere
> dh_install: etc/sudoers.d/zfs exists in debian/tmp but is not installed to anywhere
> dh_install: missing files, aborting
> debian/rules:175: recipe for target 'override_dh_install' failed
> make[1]: *** [override_dh_install] Error 2
> make[1]: Leaving directory '/var/temp/sdeb/zfs_0.7.3-3/zfs-linux-0.7.3'
> debian/rules:34: recipe for target 'binary' failed
> make: *** [binary] Error 2
> dpkg-buildpackage: error: debian/rules binary gave error exit status 2
>
> I'm still trying to track down what missing files it is looking for between Jessie and Sid.
>
>     Chris

Talked with f_g (Fabian Grünbichler) on irc and found out debhelper is needed from Jessie Backports.  Installed debhelper version 10.2.5~bpo8+1 and now this
compiles fine against Jessie along with the sysvinit patch.  I'll post back if there are any problems running the script.

Please add the patch so the sysvinit users can use the Debian packages.

    Chris




Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Mon, 11 Dec 2017 23:54:02 GMT) (full text, mbox, link).


Acknowledgement sent to Antonio Russo <antonio.e.russo@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Mon, 11 Dec 2017 23:54:02 GMT) (full text, mbox, link).


Message #77 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Antonio Russo <antonio.e.russo@gmail.com>
To: Chris Dos <chris@chrisdos.com>
Cc: 826994@bugs.debian.org
Subject: [zfsutils-linux] Re: Updated Patch
Date: Mon, 11 Dec 2017 18:50:47 -0500
The patch looks like it does three things:

1. Adds a dependency to zfs-zed
2. Corrects the path of zfs-zed in zfs-function
3. Installs zfs-import, zfs-mount, and zfs-zed as sysv startup scripts

1 should be submitted upstream to zfsonlinux, since this should be shared by
everyone. Once accepted upstream, I think Aron Xu will be more likely to accept
that change (esp. if it is in the stable branch). Also, shouldn't the preexisting
Required-{Start,Stop} be removed (this patch just adds other Required-* lines)?

2 should be factored out into a quilt patch (the same problem is addressed
in the systemd zfs-zed.service unit in 1004-zed-service-bindir.patch). Maybe it
should even be included in that quilt patch?

3: We should be 100% sure that that the /dev/null symlink to zfs-import doesn't
interfere strangely with the newly added zfs-import.target (already included in the
upstream stable branch). I don't think it will, but someone should double check.

Antonio



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Sun, 04 Mar 2018 17:57:03 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Sun, 04 Mar 2018 17:57:03 GMT) (full text, mbox, link).


Message #82 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Updated Patch for 0.7.6-1
Date: Sun, 4 Mar 2018 10:44:51 -0700
[Message part 1 (text/plain, inline)]
I've attached the updated patch to compile against 0.7.6-1.
[sysvinit_patch_3_826994.diff (text/x-patch, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Wed, 28 Mar 2018 17:09:02 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Zubrzycki <debian@mid-earth.net>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Wed, 28 Mar 2018 17:09:02 GMT) (full text, mbox, link).


Message #87 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Zubrzycki <debian@mid-earth.net>
To: 826994@bugs.debian.org
Subject: Re: Updated Patch for 0.7.6-1
Date: Wed, 28 Mar 2018 12:59:56 -0400
Please, lets get this fixed and merged. sysvinit is still officially supported in debian, although it’s not required. Some of us still like our init systems to be just that, and of course zfs fully supports it as well. It’s a bit insane that we have to manually install the init files on every system ourselves, they could have at least been hidden in docs/ or something


-chris zubrzycki
- --
PGP ID: 0xA2ABC070
Fingerprint: 26B0 BA6B A409 FA83 42B3  1688 FBF9 8232 A2AB C070
========================================================

"Sadly, text alone cannot convey the depths of my sarcasm."







Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Sun, 08 Apr 2018 06:39:03 GMT) (full text, mbox, link).


Acknowledgement sent to Aron Xu <aron@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Sun, 08 Apr 2018 06:39:03 GMT) (full text, mbox, link).


Message #92 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <aron@debian.org>
To: Chris Dos <chris@chrisdos.com>, 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Updated Patch for 0.7.6-1
Date: Sun, 8 Apr 2018 14:37:07 +0800
Hi,

This patch modifies upstream source code directly which is undesired.
Would you mind to submit the change upstream?


Regards,
Aron Xu



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Sun, 08 Apr 2018 14:00:06 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Sun, 08 Apr 2018 14:00:06 GMT) (full text, mbox, link).


Message #97 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: Aron Xu <aron@debian.org>, 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Updated Patch for 0.7.6-1
Date: Sun, 8 Apr 2018 07:55:53 -0600
On 04/08/2018 12:37 AM, Aron Xu wrote:
> Hi,
> 
> This patch modifies upstream source code directly which is undesired.
> Would you mind to submit the change upstream?
> 
> 
> Regards,
> Aron Xu
> 

I did not make the first patch which was created by Håkan Johansson, so I'll
look into that.

I did make the patch to fix the zed binary location.
The debian source for 0.7.6-1 in the rules on line 74 shows:
mv '$(CURDIR)/debian/tmp/sbin/zed' '$(CURDIR)/debian/tmp/usr/sbin/zed'
and the configure option on line 48: --sbindir=/sbin \

The ZOL sysvinit source shows the zed binary in /sbin:
https://github.com/zfsonlinux/zfs/blob/master/etc/init.d/zfs-functions.in

So it would look like the zfs-functions will need to be fixed by something
like the patch I submitted, or zed binary should be put back to /sbin instead
of /usr/sbin/.

     Chris



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Sun, 08 Apr 2018 21:42:03 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Sun, 08 Apr 2018 21:42:03 GMT) (full text, mbox, link).


Message #102 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Re: Bug#826994: [Pkg-zfsonlinux-devel] Bug#826994: Updated Patch for 0.7.6-1
Date: Sun, 8 Apr 2018 15:41:06 -0600
On 04/08/2018 12:37 AM, Aron Xu wrote:
> Hi,
> 
> This patch modifies upstream source code directly which is undesired.
> Would you mind to submit the change upstream?
> 
> 
> Regards,
> Aron Xu
> 

Bug report opened for ZFSonLinux upstream:
https://github.com/zfsonlinux/zfs/issues/7412

	Chris



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Tue, 10 Apr 2018 00:12:15 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Tue, 10 Apr 2018 00:12:15 GMT) (full text, mbox, link).


Message #107 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: Aron Xu <aron@debian.org>, 826994@bugs.debian.org
Subject: Re: Bug#826994: [Pkg-zfsonlinux-devel] Bug#826994: Updated Patch for 0.7.6-1
Date: Mon, 9 Apr 2018 18:10:43 -0600
[Message part 1 (text/plain, inline)]
On 04/08/2018 12:37 AM, Aron Xu wrote:
> Hi,
> 
> This patch modifies upstream source code directly which is undesired.
> Would you mind to submit the change upstream?
> 
> 
> Regards,
> Aron Xu
> 

I've changed the patch to use two quilt patches and I submitted the local_fs
dependency to ZoL:
https://github.com/zfsonlinux/zfs/issues/7420

I also changed the zfs-share init script to be part of the zfs-zed package as
it is dependent on the zed package.

I appreciate the help from Richard Laager for assisting me with this patch.

	Chris
[sysvinit_patch_4_826994.diff (text/x-patch, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Tue, 10 Apr 2018 13:18:02 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Tue, 10 Apr 2018 13:18:02 GMT) (full text, mbox, link).


Message #112 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Re: Bug#826994: [Pkg-zfsonlinux-devel] Bug#826994: Updated Patch for 0.7.6-1
Date: Tue, 10 Apr 2018 07:16:24 -0600
[Message part 1 (text/plain, inline)]
Updated the patch to remove the $local_fs dependency in the zed init script.
I'm not sure of the reasoning Håkan Johansson had for that dependency.  The
zfs-zed script requires zfs-mount to be start and zfs-mount requires local
file systems to be mounted.

	Chris
[sysvinit_patch_5_826994.diff (text/x-patch, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Sun, 13 May 2018 15:33:03 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Zubrzycki <debian@mid-earth.net>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Sun, 13 May 2018 15:33:03 GMT) (full text, mbox, link).


Message #117 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Zubrzycki <debian@mid-earth.net>
To: 826994@bugs.debian.org
Subject: init scripts
Date: Sun, 13 May 2018 11:20:51 -0400
I tested this patch and it works great on jessie and stretch with systemd uninstalled.


Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Sat, 19 May 2018 15:15:03 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Sat, 19 May 2018 15:15:03 GMT) (full text, mbox, link).


Message #122 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Patch updated for 0.7.9-2
Date: Sat, 19 May 2018 09:03:34 -0600
[Message part 1 (text/plain, inline)]
I've updated the patch to work with 0.7.9-2.

I'm getting a bit frustrated about why this patch is not being committed.  I
figured you where waiting for for another release.  Well, another release has
happened and this patch was not included.  Please include this patch, and if
something is wrong with it, please let me know so we can get it sorted out and
get it committed.  It has been almost two years since this bug was opened!

	Chris
[sysvinit_patch_5_826994_0.7.9-2.diff (text/x-patch, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>:
Bug#826994; Package zfsutils-linux. (Sat, 19 May 2018 18:15:03 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@lists.alioth.debian.org>. (Sat, 19 May 2018 18:15:03 GMT) (full text, mbox, link).


Message #127 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: ZoL Bug Affecting 0.7.9-2 on Jessie and Stretch
Date: Sat, 19 May 2018 12:13:24 -0600
This ZoL bug is affecting building zfs-dkms_0.7.9-2 on Jessie and Stretch:
https://github.com/zfsonlinux/zfs/issues/7540



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Sun, 03 Jun 2018 13:27:03 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Sun, 03 Jun 2018 13:27:03 GMT) (full text, mbox, link).


Message #132 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Patch updated for 0.7.9-3
Date: Sun, 3 Jun 2018 07:22:21 -0600
[Message part 1 (text/plain, inline)]
I've updated the patch for 0.7.9-3 thought there where no changes that
prevented the last patch from working.

Please commit the patch to enable sysvinit for ZFS.
[sysvinit_patch_5_826994_0.7.9-3.diff (text/x-patch, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Sun, 24 Jun 2018 21:15:04 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Zubrzycki <debian@mid-earth.net>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Sun, 24 Jun 2018 21:15:04 GMT) (full text, mbox, link).


Message #137 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Zubrzycki <debian@mid-earth.net>
To: 826994@bugs.debian.org
Subject: ini scripts
Date: Sun, 24 Jun 2018 17:01:28 -0400
I don’t understand the reluctance in merging this. I shouldn’t have to keep building custom versions so my pools import on boot...


Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Mon, 25 Jun 2018 21:27:02 GMT) (full text, mbox, link).


Acknowledgement sent to Antonio Russo <antonio.e.russo@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Mon, 25 Jun 2018 21:27:02 GMT) (full text, mbox, link).


Message #142 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Antonio Russo <antonio.e.russo@gmail.com>
To: Chris Zubrzycki <debian@mid-earth.net>
Cc: 826994@bugs.debian.org
Subject: [zfsutils-linux]
Date: Mon, 25 Jun 2018 17:23:20 -0400
[snip]
> I shouldn’t have to keep building custom versions so my pools import on boot...

If you just install the regular Debian zfs packaging, and then make sure the init
scripts are installed an enabled, they will stay enabled. (upgrading the zfs
packaging won't disable init scripts it knows nothing about).

As frustrating as this all is, you do not need to rebuild the package just to
install a few init scripts once per machine. If you're provisioning a large number
of machines regularly, I also sympathize, but it's still just a couple more lines
in Ansible.



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Tue, 26 Jun 2018 11:27:03 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Tue, 26 Jun 2018 11:27:03 GMT) (full text, mbox, link).


Message #147 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Re: Bug#826994: [zfsutils-linux]
Date: Tue, 26 Jun 2018 05:23:05 -0600
On 06/25/2018 03:23 PM, Antonio Russo wrote:
> [snip]
> If you just install the regular Debian zfs packaging, and then make sure the init
> scripts are installed an enabled, they will stay enabled. (upgrading the zfs
> packaging won't disable init scripts it knows nothing about).
> 
> As frustrating as this all is, you do not need to rebuild the package just to
> install a few init scripts once per machine. If you're provisioning a large number
> of machines regularly, I also sympathize, but it's still just a couple more lines
> in Ansible.
> 

The thing is someone should sysvinit scripts should be installed by default.
This bug is more then two years old and there was a working patch posted 18
months ago.  I've been continuing to update the patch and it is still not
being included.   This is starting to seem more and more deliberate at this
point to never support sysvinit for ZFS, and to not support something a
critical as a file system.

	Chris



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Tue, 26 Jun 2018 19:09:05 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Zubrzycki <chris@mid-earth.net>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Tue, 26 Jun 2018 19:09:05 GMT) (full text, mbox, link).


Message #152 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Zubrzycki <chris@mid-earth.net>
To: 826994@bugs.debian.org
Subject: Re: [zfsutils-linux]
Date: Tue, 26 Jun 2018 14:57:54 -0400
That's a workaround at best, not a solution. The scripts aren't configured with the Debian package so the macros are not expanded. The update-defaults command doesn't get run on new systems, nor do we get any upstream modifications or fixes.  It seems to be a well-done patch for an officially supported init system, I haven't heard any reason yet to not merge it.


Sent from my iPhone

> On Jun 25, 2018, at 17:23, Antonio Russo <antonio.e.russo@gmail.com> wrote:
> 
> [snip]
>> I shouldn’t have to keep building custom versions so my pools import on boot...
> 
> If you just install the regular Debian zfs packaging, and then make sure the init
> scripts are installed an enabled, they will stay enabled. (upgrading the zfs
> packaging won't disable init scripts it knows nothing about).
> 
> As frustrating as this all is, you do not need to rebuild the package just to
> install a few init scripts once per machine. If you're provisioning a large number
> of machines regularly, I also sympathize, but it's still just a couple more lines
> in Ansible.



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Tue, 26 Jun 2018 20:21:03 GMT) (full text, mbox, link).


Acknowledgement sent to Richard Laager <rlaager@wiktel.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Tue, 26 Jun 2018 20:21:03 GMT) (full text, mbox, link).


Message #157 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Richard Laager <rlaager@wiktel.com>
To: 826994@bugs.debian.org
Subject: Re: Patch updated for 0.7.9-3
Date: Tue, 26 Jun 2018 15:07:50 -0500
I can't speak to why this isn't being included, so I'm staying out of
that issue.

I do see one possible technical error:

/etc/init.d/zfs-share is installed in zfs-zed per the .install file, but
the debian/rules has it as -pzfsutils-linux rather than -pzfs-zed.

-- 
Richard



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Tue, 10 Jul 2018 05:06:03 GMT) (full text, mbox, link).


Acknowledgement sent to Elliott Mitchell <ehem+debian@m5p.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Tue, 10 Jul 2018 05:06:03 GMT) (full text, mbox, link).


Message #162 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Elliott Mitchell <ehem+debian@m5p.com>
To: 826994@bugs.debian.org
Subject: Tags Missing too
Date: Mon, 9 Jul 2018 21:43:20 -0700
I'm unsure of the "correct" values to use, but either nfs-kernel-server
or nfs needs to be added to X-Start-Before and X-Stop-After for zfs-mount
too.  Otherwise insserv may try to load a NFS server before ZFS
filesystems are mounted.


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@m5p.com  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445





Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Thu, 26 Jul 2018 18:42:04 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Zubrzycki <chris@mid-earth.net>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Thu, 26 Jul 2018 18:42:04 GMT) (full text, mbox, link).


Message #167 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Zubrzycki <chris@mid-earth.net>
To: 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Bug#826994: Missing init-script(s)?
Date: Thu, 26 Jul 2018 14:39:47 -0400
So can we get the nfs order straight and get it merged? There are people who are very willing to give a hand maintaining LSB support, as this bug report and patches demonstrate.



On Tue, 5 Jul 2016 01:21:12 +1000 Craig Sanders <cas@taz.net.au> wrote:


> When I asked Aron Xu about this back in Feb, he said:
> 
>  > The only stopper for adding LSB (sysvinit) support is manpower, I
>  > dropped the support to make things easier for doing an initial upload
>  > for the archive. systemd support is tested and used in production by
>  > myself on Jessie systems without problem, though. If there is people
>  > willing to give a hand on maintaining LSB support I'm happy to carry
>  > it.
> 
> I guess that means "patches welcome”.





Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Fri, 07 Sep 2018 21:06:02 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Zubrzycki <chris@mid-earth.net>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Fri, 07 Sep 2018 21:06:02 GMT) (full text, mbox, link).


Message #172 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Zubrzycki <chris@mid-earth.net>
To: 826994@bugs.debian.org
Subject: new release
Date: Fri, 7 Sep 2018 16:54:11 -0400
ZFS 0.7.10 was just released. Could we please get sysvinit scripts into this one?

https://github.com/zfsonlinux/zfs/releases/tag/zfs-0.7.10


Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Tue, 25 Sep 2018 19:06:03 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Tue, 25 Sep 2018 19:06:03 GMT) (full text, mbox, link).


Message #177 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Patch updated for 0.7.11-1
Date: Tue, 25 Sep 2018 12:53:13 -0600
[Message part 1 (text/plain, inline)]
I've updated the patch for 0.7.11-1 though there where no changes that
prevented the last patch from working.

Please commit the patch to enable sysvinit for ZFS.
[sysvinit_patch_6_826994_0.7.11-1.diff (text/x-patch, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Tue, 09 Oct 2018 17:39:02 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Tue, 09 Oct 2018 17:39:02 GMT) (full text, mbox, link).


Message #182 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Fixed Patch
Date: Tue, 9 Oct 2018 11:36:22 -0600
[Message part 1 (text/plain, inline)]
The last patch I posted was missing part of the patch for the init scripts.
I've attached the patch with the missing information.
[sysvinit_patch_7_826994_0.7.11-1.diff (text/x-patch, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Tue, 16 Oct 2018 21:24:03 GMT) (full text, mbox, link).


Acknowledgement sent to Carsten Leonhardt <leo@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Tue, 16 Oct 2018 21:24:03 GMT) (full text, mbox, link).


Message #187 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Carsten Leonhardt <leo@debian.org>
To: 826994@bugs.debian.org
Subject: Re: Missing init-script(s)?
Date: Tue, 16 Oct 2018 23:12:46 +0200
Control: severity -1 serious

Not shipping init scripts equivalent to the service files violates
policy 9.11, therefore the bug severity is serious.



Severity set to 'serious' from 'important' Request was from Carsten Leonhardt <leo@debian.org> to 826994-submit@bugs.debian.org. (Tue, 16 Oct 2018 21:24:03 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Wed, 17 Oct 2018 05:09:03 GMT) (full text, mbox, link).


Acknowledgement sent to Aron Xu <aron@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Wed, 17 Oct 2018 05:09:03 GMT) (full text, mbox, link).


Message #194 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <aron@debian.org>
To: leo@debian.org, 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Missing init-script(s)?
Date: Wed, 17 Oct 2018 13:04:43 +0800
Control: severity -1 wishlist

Please don't ping-pong here by changing the severity again, wishlist
is the final priority set for this bug.

I'm not against LSB support, please make it upstream. I think this
statement is clear enough.

Regards,
Aron



Severity set to 'wishlist' from 'serious' Request was from Aron Xu <aron@debian.org> to 826994-submit@bugs.debian.org. (Wed, 17 Oct 2018 05:09:03 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Wed, 17 Oct 2018 07:06:03 GMT) (full text, mbox, link).


Acknowledgement sent to Petter Reinholdtsen <pere@hungry.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Wed, 17 Oct 2018 07:06:03 GMT) (full text, mbox, link).


Message #201 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>
To: Carsten Leonhardt <leo@debian.org>, 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Missing init-script(s)?
Date: Wed, 17 Oct 2018 09:01:33 +0200
[Carsten Leonhardt]
> Not shipping init scripts equivalent to the service files violates
> policy 9.11, therefore the bug severity is serious.

I had a look at this part of Debian policy[1], which reads:

 "9.11. Alternate init systems

  A number of other init systems are available now in Debian that can be
  used in place of sysvinit. Alternative init implementations must
  support running SysV init scripts as described at System run levels
  and init.d scripts for compatibility.

  Packages may integrate with these replacement init systems by
  providing implementation-specific configuration information about how
  and when to start a service or in what order to run certain tasks at
  boot time. However, any package integrating with other init systems
  must also be backwards-compatible with sysvinit by providing a
  SysV-style init script with the same name as and equivalent
  functionality to any init-specific job, as this is the only start-up
  configuration method guaranteed to be supported by all init
  implementations. An exception to this rule is scripts or jobs provided
  by the init implementation itself; such jobs may be required for an
  implementation-specific equivalent of the /etc/rcS.d/ scripts and may
  not have a one-to-one correspondence with the init scripts."

I agree that providing only systemd services and no init.d script is a
violation of a "must" requirement from this part of policy.  As far as I
can tell, the exception do not come into play, as the zfsonlinux scripts
are not "provided by the init implementation itself".

The fact that systemd is the default and init.d scripts are the only way
to start services on hurd and kfreebsd make me suspect this section of
policy could use an update to make it more explicit that the systemd and
init.d scripts need to have equivalent behaviour.  But zfsonlinux is not
relevant for hurd and kfreebsd, so in this case it only affect those not
using systemd on linux.

If using the /lib/init/init-d-script mechanism I described in 2013[2]
can be used for some of the zfs daemons, the init.d scripts should not
take long to write, nor to maintain. :)

 [1] <URL: https://www.debian.org/doc/debian-policy/ch-opersys.html#alternate-init-systems >
 [2] <URL: http://people.skolelinux.org/pere/blog/Debian_init_d_boot_script_example_for_rsyslog.html >

-- 
Happy hacking
Petter Reinholdtsen



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Wed, 17 Oct 2018 07:36:03 GMT) (full text, mbox, link).


Acknowledgement sent to Carsten Leonhardt <leo@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Wed, 17 Oct 2018 07:36:03 GMT) (full text, mbox, link).


Message #206 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Carsten Leonhardt <leo@debian.org>
To: Aron Xu <aron@debian.org>
Cc: 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Missing init-script(s)?
Date: Wed, 17 Oct 2018 09:33:23 +0200
Dear Aron,

> I'm not against LSB support, please make it upstream. I think this
> statement is clear enough.

Great. In that case, please apply the patch that's being maintained by
Chris Dos for quite some time now. You find it in this bug's history. It
doesn't touch upstream except in zfs-functions.in, and that's only
because the debian package modifies the install location of zed. The
init-scripts are in the upstream source already for a long time. Quite
probably longer than systemd support.

> Control: severity -1 wishlist
>
> Please don't ping-pong here by changing the severity again, wishlist
> is the final priority set for this bug.

Quote from "severity levels" section:

serious
    is a severe violation of Debian policy (roughly, it violates a
    "must" or "required" directive), or, in the package maintainer's or
    release manager's opinion, makes the package unsuitable for release.


Regards,

Carsten



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Wed, 17 Oct 2018 07:48:02 GMT) (full text, mbox, link).


Acknowledgement sent to Aron Xu <aron@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Wed, 17 Oct 2018 07:48:02 GMT) (full text, mbox, link).


Message #211 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Aron Xu <aron@debian.org>
To: leo@debian.org, 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Bug#826994: Missing init-script(s)?
Date: Wed, 17 Oct 2018 15:43:54 +0800
On Wed, Oct 17, 2018 at 3:36 PM Carsten Leonhardt <leo@debian.org> wrote:
>
> Dear Aron,
>
> > I'm not against LSB support, please make it upstream. I think this
> > statement is clear enough.
>
> Great. In that case, please apply the patch that's being maintained by
> Chris Dos for quite some time now. You find it in this bug's history. It
> doesn't touch upstream except in zfs-functions.in, and that's only
> because the debian package modifies the install location of zed. The
> init-scripts are in the upstream source already for a long time. Quite
> probably longer than systemd support.
>

As said by "upstream", please have all the init scripts incorporated
to upstream ZoL repository and I can enable them quickly. You can find
that systemd support is shipped by upstream directly and we don't have
Debian local changes. I don't want to apply a big patch introducing
something not blessed by upstream, nor being actively used/tested
myself.

Regards,
Aron



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Wed, 17 Oct 2018 09:03:03 GMT) (full text, mbox, link).


Acknowledgement sent to Carsten Leonhardt <leo@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Wed, 17 Oct 2018 09:03:03 GMT) (full text, mbox, link).


Message #216 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Carsten Leonhardt <leo@debian.org>
To: Aron Xu <aron@debian.org>
Cc: 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Bug#826994: Missing init-script(s)?
Date: Wed, 17 Oct 2018 10:58:46 +0200
Aron Xu <aron@debian.org> writes:

> As said by "upstream", please have all the init scripts incorporated
> to upstream ZoL repository and I can enable them quickly. You can find
> that systemd support is shipped by upstream directly and we don't have
> Debian local changes. I don't want to apply a big patch introducing
> something not blessed by upstream, nor being actively used/tested
> myself.

Isn't this the upstream repository?

https://github.com/zfsonlinux/zfs/tree/master/etc/init.d

Did you look at Chris Dos' patch? It's quite small and as I wrote
earlier, only touches one upstream file, where you made a change for
systemd support too (because of the changed zed location).

Regards,

Carsten



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Wed, 17 Oct 2018 13:15:06 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Wed, 17 Oct 2018 13:15:07 GMT) (full text, mbox, link).


Message #221 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Devuan Compatibility
Date: Wed, 17 Oct 2018 07:12:37 -0600
If this patch gets applied, would it also be possible to patch the Devuan
compatibility bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900089

It's only a one line change and it would make it so the Devuan devs won't need
to make their own package.

Bugs 826994 and 900089 are the only two issues preventing the packages from
working in Devuan.



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Wed, 17 Oct 2018 15:06:02 GMT) (full text, mbox, link).


Acknowledgement sent to Petter Reinholdtsen <pere@hungry.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Wed, 17 Oct 2018 15:06:02 GMT) (full text, mbox, link).


Message #226 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>
To: Chris Dos <chris@chrisdos.com>, 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Devuan Compatibility
Date: Wed, 17 Oct 2018 17:03:34 +0200
[Chris Dos]
> If this patch gets applied,

I believe the point Aron is trying to get through to those of you who
care about init.d scripts, is that you should work with the upstream
project to get the scripts included there, to avoid having the Debian
packages deviate from upstream any more.

In other words, you are barking up the wrong tree.  Try the upstream
tree, it might work better.

-- 
Happy hacking
Petter Reinholdtsen



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Wed, 17 Oct 2018 16:33:03 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Zubrzycki <debian@mid-earth.net>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Wed, 17 Oct 2018 16:33:03 GMT) (full text, mbox, link).


Message #231 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Zubrzycki <debian@mid-earth.net>
To: 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Devuan Compatibility
Date: Wed, 17 Oct 2018 12:21:28 -0400
On Wed, 17 Oct 2018 17:03:34 +0200 Petter Reinholdtsen <pere@hungry.com> wrote:
> 
> [Chris Dos]
> > If this patch gets applied,
> 
> I believe the point Aron is trying to get through to those of you who
> care about init.d scripts, is that you should work with the upstream
> project to get the scripts included there, to avoid having the Debian
> packages deviate from upstream any more.
> 
> In other words, you are barking up the wrong tree.  Try the upstream
> tree, it might work better.

I think you may be confused here. The scripts have been upstream for years. In fact for many years they were the *only* upstream init scripts. https://github.com/zfsonlinux/zfs/tree/master/etc/init.d has them, last modified 2 years - 3 months ago. That is upstream. They were successfully shipped in the upstream debian packages until debian finally accepted a native package. We have been trying to get the sysv scripts added back in since then. The patch from Chris Dos does not add any init scripts, it only has them installed to the debian package and changes the location of 2 binaries to where debian put them. His patch only adds 30 lines to the debian build scripts almost all in debian/rules. How exactly do we bark this up upstream's tree?


-chris zubrzycki
- --
PGP ID: 0xA2ABC070
Fingerprint: 26B0 BA6B A409 FA83 42B3  1688 FBF9 8232 A2AB C070
========================================================

Unix  _IS_  user friendly... It's just selective about who its friends are.






Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Fri, 19 Oct 2018 06:33:02 GMT) (full text, mbox, link).


Acknowledgement sent to Richard Laager <rlaager@wiktel.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Fri, 19 Oct 2018 06:33:02 GMT) (full text, mbox, link).


Message #236 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Richard Laager <rlaager@wiktel.com>
To: Aron Xu <aron@debian.org>, 826994@bugs.debian.org
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: Bug#826994: Missing init-script(s)?
Date: Fri, 19 Oct 2018 01:25:21 -0500
On 10/17/18 12:04 AM, Aron Xu wrote:
> I'm not against LSB support, please make it upstream. I think this
> statement is clear enough.
On 10/17/18 2:43 AM, Aron Xu wrote:
> As said by "upstream", please have all the init scripts incorporated
> to upstream ZoL repository and I can enable them quickly.

The sysvinit scripts are already in the upstream tree and the released
tarballs. You can see them in the package's .orig.tar.gz in the
etc/init.d directory. The patch simply calls dh_installinit in
debian/rules as appropriate.

Here is the link to the latest patch:
https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=826994;filename=sysvinit_patch_7_826994_0.7.11-1.diff;msg=182

As you can see, it does not actually create any init scripts, but simply
uses the ones already present in the orig.tar.gz.

-- 
Richard



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Fri, 19 Oct 2018 07:45:07 GMT) (full text, mbox, link).


Acknowledgement sent to Petter Reinholdtsen <pere@hungry.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Fri, 19 Oct 2018 07:45:07 GMT) (full text, mbox, link).


Message #241 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>
To: Richard Laager <rlaager@wiktel.com>, 826994@bugs.debian.org, Aron Xu <aron@debian.org>
Subject: Re: [Pkg-zfsonlinux-devel] #826994: Bug#826994: Missing init-script(s)?
Date: Fri, 19 Oct 2018 09:40:29 +0200

[Richard Laager]
> The sysvinit scripts are already in the upstream tree and the released
> tarballs. You can see them in the package's .orig.tar.gz in the
> etc/init.d directory. The patch simply calls dh_installinit in
> debian/rules as appropriate.

Right, then I had misunderstood, at least.  If the script is already
upstream, it is Debians responsibility to add code to install it at the
correct location.

-- 
Vennlig hilsen
Petter Reinholdtsen



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Fri, 19 Oct 2018 09:21:05 GMT) (full text, mbox, link).


Acknowledgement sent to Colm Buckley <colm@tuatha.org>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Fri, 19 Oct 2018 09:21:05 GMT) (full text, mbox, link).


Message #246 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Colm Buckley <colm@tuatha.org>
To: Petter Reinholdtsen <pere@hungry.com>, 826994@bugs.debian.org
Cc: Richard Laager <rlaager@wiktel.com>, Aron Xu <aron@debian.org>
Subject: Re: [Pkg-zfsonlinux-devel] Bug#826994: #826994: Bug#826994: Missing init-script(s)?
Date: Fri, 19 Oct 2018 20:16:17 +1100
[Message part 1 (text/plain, inline)]
... which is exactly what the patch does.

On Fri 19 Oct 2018, 18:45 Petter Reinholdtsen <pere@hungry.com wrote:

>
>
> [Richard Laager]
> > The sysvinit scripts are already in the upstream tree and the released
> > tarballs. You can see them in the package's .orig.tar.gz in the
> > etc/init.d directory. The patch simply calls dh_installinit in
> > debian/rules as appropriate.
>
> Right, then I had misunderstood, at least.  If the script is already
> upstream, it is Debians responsibility to add code to install it at the
> correct location.
>
> --
> Vennlig hilsen
> Petter Reinholdtsen
>
> _______________________________________________
> Pkg-zfsonlinux-devel mailing list
> Pkg-zfsonlinux-devel@alioth-lists.debian.net
>
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-zfsonlinux-devel
[Message part 2 (text/html, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Fri, 19 Oct 2018 13:12:05 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Fri, 19 Oct 2018 13:12:05 GMT) (full text, mbox, link).


Message #251 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org
Subject: Devuan Compatibility
Date: Fri, 19 Oct 2018 07:09:20 -0600
Since it actually looks like there is nothing wrong with the sysvinit patch
and it should be applied, can we apply the Devuan patch as well:
https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=900089;filename=add_devuan_compatibility_900089.patch;msg=37

It changes one line in debian/zfs-dkms.dkms

--- a/debian/zfs-dkms.dkms
+++ b/debian/zfs-dkms.dkms
@@ -7,7 +7,7 @@ PRE_BUILD="configure
   --with-config=kernel
   --with-linux=$(
     case `lsb_release -is` in
-      (Debian)
+      (Debian|Devuan)
         if [[ -e ${kernel_source_dir/%build/source} ]]
         then
           echo ${kernel_source_dir/%build/source}


I would just like to get everything working for the sysvinit zfs system for
both Debian and Devuan users.  The bottom line is that we are a community and
are all in this together.



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Wed, 24 Oct 2018 15:54:03 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Wed, 24 Oct 2018 15:54:03 GMT) (full text, mbox, link).


Message #256 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: 826994@bugs.debian.org, Aron Xu <aron@debian.org>
Cc: pere@hungry.com, rlaager@wiktel.com, leo@debian.org, Lumin <cdluminate@gmail.com>
Subject: ZFS Missing init-scripts, Status? #826994
Date: Wed, 24 Oct 2018 09:52:01 -0600
Hello Aron,

I would just like to get a final statement from you regarding if this patch is
going to be applied or not?

If this sysvinit bug is going to forever remain a wishlist and never have the
patch applied, then say so and I'll make other arrangements and no longer
maintain the patch.

	Chris



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Thu, 25 Oct 2018 12:21:03 GMT) (full text, mbox, link).


Acknowledgement sent to Lumin <cdluminate@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Thu, 25 Oct 2018 12:21:03 GMT) (full text, mbox, link).


Message #261 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Lumin <cdluminate@gmail.com>
To: Chris Dos <chris@chrisdos.com>
Cc: 826994@bugs.debian.org, Aron Xu <aron@debian.org>, pere@hungry.com, rlaager@wiktel.com, leo@debian.org
Subject: Re: ZFS Missing init-scripts, Status? #826994
Date: Thu, 25 Oct 2018 12:16:43 +0000
Hi Chris,

I guess aron is busy recently. Anyway personally I'm going to look into
non-systemd init system support for ZFS because I planned to get rid of
systemd forever.

Since I'm new to this package and it's bugs, some time is needed for me
to go through the historical discussions and do some checks and tests
by myself. That will take some time.

On Wed, Oct 24, 2018 at 09:52:01AM -0600, Chris Dos wrote:
> Hello Aron,
> 
> I would just like to get a final statement from you regarding if this patch is
> going to be applied or not?
> 
> If this sysvinit bug is going to forever remain a wishlist and never have the
> patch applied, then say so and I'll make other arrangements and no longer
> maintain the patch.
> 
> 	Chris



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Thu, 25 Oct 2018 13:09:02 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Thu, 25 Oct 2018 13:09:02 GMT) (full text, mbox, link).


Message #266 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: Lumin <cdluminate@gmail.com>
Cc: 826994@bugs.debian.org, Aron Xu <aron@debian.org>, pere@hungry.com, rlaager@wiktel.com, leo@debian.org
Subject: Re: ZFS Missing init-scripts, Status? #826994
Date: Thu, 25 Oct 2018 07:06:25 -0600
On 10/25/18 6:16 AM, Lumin wrote:
> Hi Chris,
> 
> I guess aron is busy recently. Anyway personally I'm going to look into
> non-systemd init system support for ZFS because I planned to get rid of
> systemd forever.
> 
> Since I'm new to this package and it's bugs, some time is needed for me
> to go through the historical discussions and do some checks and tests
> by myself. That will take some time.

Good news.  Please let me know if I can help in anyway.

	Chris



Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Fri, 26 Oct 2018 08:33:03 GMT) (full text, mbox, link).


Acknowledgement sent to Lumin <cdluminate@gmail.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Fri, 26 Oct 2018 08:33:03 GMT) (full text, mbox, link).


Message #271 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Lumin <cdluminate@gmail.com>
To: Chris Dos <chris@chrisdos.com>
Cc: 826994@bugs.debian.org, Aron Xu <aron@debian.org>, pere@hungry.com, rlaager@wiktel.com, leo@debian.org
Subject: Re: ZFS Missing init-scripts, Status? #826994
Date: Fri, 26 Oct 2018 08:29:50 +0000
Hi Chris,

Could you please help me review the pending -2 upload?
It's hard to go through the historical discussion. It's
possible that I missed something.

https://salsa.debian.org/zfsonlinux-team/zfs/tree/lumin

I tested this branch with my Debian Unstable (OpenRC) setup.
Is there any patch that should go into -2 as well?

On Thu, Oct 25, 2018 at 07:06:25AM -0600, Chris Dos wrote:
> On 10/25/18 6:16 AM, Lumin wrote:
> > Hi Chris,
> > 
> > I guess aron is busy recently. Anyway personally I'm going to look into
> > non-systemd init system support for ZFS because I planned to get rid of
> > systemd forever.
> > 
> > Since I'm new to this package and it's bugs, some time is needed for me
> > to go through the historical discussions and do some checks and tests
> > by myself. That will take some time.
> 
> Good news.  Please let me know if I can help in anyway.
> 
> 	Chris



Reply sent to Mo Zhou <cdluminate@gmail.com>:
You have taken responsibility. (Fri, 26 Oct 2018 10:48:06 GMT) (full text, mbox, link).


Notification sent to Carsten Leonhardt <leo@debian.org>:
Bug acknowledged by developer. (Fri, 26 Oct 2018 10:48:06 GMT) (full text, mbox, link).


Message #276 received at 826994-close@bugs.debian.org (full text, mbox, reply):

From: Mo Zhou <cdluminate@gmail.com>
To: 826994-close@bugs.debian.org
Subject: Bug#826994: fixed in zfs-linux 0.7.11-2
Date: Fri, 26 Oct 2018 10:44:48 +0000
Source: zfs-linux
Source-Version: 0.7.11-2

We believe that the bug you reported is fixed in the latest version of
zfs-linux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 826994@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mo Zhou <cdluminate@gmail.com> (supplier of updated zfs-linux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 26 Oct 2018 09:32:06 +0000
Source: zfs-linux
Binary: libnvpair1linux libuutil1linux libzfslinux-dev libzfs2linux libzpool2linux zfs-dkms zfs-initramfs zfs-dracut zfsutils-linux zfs-zed zfs-test zfs-dbg
Architecture: source
Version: 0.7.11-2
Distribution: unstable
Urgency: medium
Maintainer: Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>
Changed-By: Mo Zhou <cdluminate@gmail.com>
Description:
 libnvpair1linux - Solaris name-value library for Linux
 libuutil1linux - Solaris userland utility library for Linux
 libzfs2linux - OpenZFS filesystem library for Linux
 libzfslinux-dev - OpenZFS filesystem development files for Linux
 libzpool2linux - OpenZFS pool library for Linux
 zfs-dbg    - Debugging symbols for OpenZFS userland libraries and tools
 zfs-dkms   - OpenZFS filesystem kernel modules for Linux
 zfs-dracut - OpenZFS root filesystem capabilities for Linux - dracut
 zfs-initramfs - OpenZFS root filesystem capabilities for Linux - initramfs
 zfs-test   - OpenZFS test infrastructure an support scripts
 zfs-zed    - OpenZFS Event Daemon
 zfsutils-linux - command-line tools to manage OpenZFS filesystems
Closes: 826994 900089
Changes:
 zfs-linux (0.7.11-2) unstable; urgency=medium
 .
   * Support Devuan in dkms script. (Closes: #900089)
     Thanks to Chris Dos <chris@chrisdos.com>
   * Install init scripts to support non-systemd setups. (Closes: #826994)
     Thanks to Chris Dos <chris@chrisdos.com>
   * Override init.d-script-does-not-source-init-functions for
     zfsutils-linux and zfs-zed.
   * Patch upstream init scripts to make them work for Debian+OpenRC setup.
   * Patch upstream init script to fix missing dependency on local_fs.
Checksums-Sha1:
 9787603d47df53aa4a18d0f12349b06dce6bf9b0 3004 zfs-linux_0.7.11-2.dsc
 55febd86dbc66fbda7530b9d64b76e8874f1e49d 44084 zfs-linux_0.7.11-2.debian.tar.xz
 ff3d1bffa22e5ead03715b763e5dd036a428454f 6689 zfs-linux_0.7.11-2_source.buildinfo
Checksums-Sha256:
 5965223558a8c241faa310f761d8265b4b4034f741b337a7f62c74d4392ff9d5 3004 zfs-linux_0.7.11-2.dsc
 8e518cc59c6e23bf846b485314b3107884a3eeec4e87ba10b9edec6275462a62 44084 zfs-linux_0.7.11-2.debian.tar.xz
 b9893f97b6d5c6d66801b61a5f96fc53d29f5a9e5b5f4d4cb2d1042cc8e74996 6689 zfs-linux_0.7.11-2_source.buildinfo
Files:
 178c7a4406075f3ff1afd4e6a23cf1e5 3004 contrib/kernel optional zfs-linux_0.7.11-2.dsc
 c3d48bd598ec29d20fba8907f86d75f8 44084 contrib/kernel optional zfs-linux_0.7.11-2.debian.tar.xz
 2217291d030946a83f2599f062768a2f 6689 contrib/kernel optional zfs-linux_0.7.11-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEY4vHXsHlxYkGfjXeYmRes19oaooFAlvS4B4ACgkQYmRes19o
aor4Xg//d4DkRUJUqm2vIDYLaTN2qJDAzPbKod2ExP4wdDacP34/shC7NJ5F2dGY
F9LLfU0SHB8ovkMMA6COewPEy3iQAVAwM5CXRe40jwpmyriq0CvrZ2qZFdFnL0xq
rOesW0Ay9sPC/vRffKxGXQ8sWl/KIeIvUPRuMydHDX129bIwsOs9OnhoO53xSuGg
DlNO3TRN5S3u4c0EkkFBNTrma07hWzjqKA9sUnoKTuT96CG68jXNENgiKRANGPqL
k/VPHW/6DZKmndnfXlTb3/6cSKlHuN2ukJgn/zU8y6jtTFTtnCUhB+jcZiBV7fY5
ch55NdxR9s1GCMcl1X2bhbB4xlyxySMn18zk2OOpclN0cf2d8oIaqCtTff4Batu3
I/5mwRfz24YnG0R5ST4iDeHmyz8nVSaFsxuj4fNuQLq0mUeVvqYYEpjTtmZpl2B7
+hrYPrn0tr9RpZtuXtDOsbtguINIMajzuI0+5iEuC6z5f450q0t9h72EEQvcvDuZ
iP17Jp0LDHms8W0vrPb5ywyTFVzTbfVOfoIPFsCA6MpirvdqUQlmIImWGwVIR3FE
zzo8LFRmVKS+Z9R3ZRTA0AeyfCHh9mb2YeMiItzN76s6q9tZs62NbWUfPgCLlAug
27wH3TcUe9/UpZq+fJygp5M5rf3q1oR6RHmO1xe2nf3TmauSjIk=
=Fnm3
-----END PGP SIGNATURE-----




Information forwarded to debian-bugs-dist@lists.debian.org, Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>:
Bug#826994; Package zfsutils-linux. (Fri, 26 Oct 2018 13:21:10 GMT) (full text, mbox, link).


Acknowledgement sent to Chris Dos <chris@chrisdos.com>:
Extra info received and forwarded to list. Copy sent to Debian ZFS on Linux maintainers <pkg-zfsonlinux-devel@alioth-lists.debian.net>. (Fri, 26 Oct 2018 13:21:10 GMT) (full text, mbox, link).


Message #281 received at 826994@bugs.debian.org (full text, mbox, reply):

From: Chris Dos <chris@chrisdos.com>
To: Lumin <cdluminate@gmail.com>, 826994@bugs.debian.org
Cc: Aron Xu <aron@debian.org>, pere@hungry.com, rlaager@wiktel.com, leo@debian.org
Subject: Re: Bug#826994: ZFS Missing init-scripts, Status? #826994
Date: Fri, 26 Oct 2018 07:19:36 -0600
Hi Lumin,

I think you nailed it.  I see you added the Devuan patch as well and I cannot
think of any other patches are needed.

Thank you so very much.  What a relief, and after more than two years this is
finally done.  I cannot express how much I and others appreciate this.

    Chris

On 10/26/18 2:29 AM, Lumin wrote:
> Hi Chris,
> 
> Could you please help me review the pending -2 upload?
> It's hard to go through the historical discussion. It's
> possible that I missed something.
> 
> https://salsa.debian.org/zfsonlinux-team/zfs/tree/lumin
> 
> I tested this branch with my Debian Unstable (OpenRC) setup.
> Is there any patch that should go into -2 as well?
> 
> On Thu, Oct 25, 2018 at 07:06:25AM -0600, Chris Dos wrote:
>> On 10/25/18 6:16 AM, Lumin wrote:
>>> Hi Chris,
>>>
>>> I guess aron is busy recently. Anyway personally I'm going to look into
>>> non-systemd init system support for ZFS because I planned to get rid of
>>> systemd forever.
>>>
>>> Since I'm new to this package and it's bugs, some time is needed for me
>>> to go through the historical discussions and do some checks and tests
>>> by myself. That will take some time.
>>
>> Good news.  Please let me know if I can help in anyway.
>>
>> 	Chris
> 



Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sun, 25 Nov 2018 07:29:20 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sat Jul 1 20:47:52 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.