Debian Bug report logs - #826982
hoichess: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: submit@bugs.debian.org

Subject: hoichess: please make the build reproducible

Date: Fri, 10 Jun 2016 22:20:10 +0200

[Message part 1 (text/plain, inline)]

Source: hoichess
Version: 0.10.3-6.1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that hoichess could not be built reproducibly.
The list of object files is unsorted, which causes a non-deterministic
linking order.

The attached patch fixes this.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds

[hoichess.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 826982-done@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: 826982-done@bugs.debian.org

Subject: hoichess, reproducible on amd64

Date: Thu, 8 Sep 2016 16:47:29 +0200

[Message part 1 (text/plain, inline)]

Hi, this patch is not working anymore unfortunately (the new upstream changed the Makefile and the patch doesn't apply
anymore)

I see amd64 seems fixed now, but armhf and i386 aren't.

I think this might be due to a bug in the toolchain rather than a bug in the software, and I'm closing this one.

Unfortunately I have no skills to check these dbg differences

G.

[signature.asc (application/pgp-signature, attachment)]

Message #15 received at 826982@bugs.debian.org (full text, mbox, reply):

From: Reiner Herrmann <reiner@reiner-h.de>

To: 826982@bugs.debian.org

Cc: Gianfranco Costamagna <locutusofborg@debian.org>

Subject: Re: Bug#826982 closed by Gianfranco Costamagna <locutusofborg@debian.org> (hoichess, reproducible on amd64)

Date: Thu, 8 Sep 2016 20:33:52 +0200

[Message part 1 (text/plain, inline)]

Control: reopen -1

> Hi, this patch is not working anymore unfortunately (the new upstream changed the Makefile and the patch doesn't apply
> anymore)

I attached an updated patch for the new version.

> I see amd64 seems fixed now, but armhf and i386 aren't.

As this is a fileordering related issue, being reproducible on amd64
unfortunately doesn't say much, as we usually don't see those issues
on amd64 _in our setup_.

> I think this might be due to a bug in the toolchain rather than a bug in the software, and I'm closing this one.

The issue is still that source files are collected with 'wildcard',
which returns files in non-deterministic readdir order.
If the file list is passed to the linker, it needs to be sorted.

Kind regards,
  Reiner

[hoichess.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 826982@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: Reiner Herrmann <reiner@reiner-h.de>, "826982@bugs.debian.org" <826982@bugs.debian.org>

Cc: Samuel Henrique <samueloph@gmail.com>

Subject: Re: Bug#826982 closed by Gianfranco Costamagna <locutusofborg@debian.org> (hoichess, reproducible on amd64)

Date: Fri, 9 Sep 2016 07:46:45 +0000 (UTC)

Hi Reiner, Samuel


>Control: reopen -1


that was a really quick turnaround and patch, thanks!

>I attached an updated patch for the new version.

thanks
>As this is a fileordering related issue, being reproducible on amd64
>unfortunately doesn't say much, as we usually don't see those issues
>on amd64 _in our setup_.


oh indeed, I understand now

>The issue is still that source files are collected with 'wildcard',
>which returns files in non-deterministic readdir order.
>If the file list is passed to the linker, it needs to be sorted.


not sure if "wildcard" tool might be fixed then ;)

But I cc'd the person who want to adopt this package, I'll be happy to see
him committing the patch and maybe ask me for sponsorhip
(or anybody else).

Let me know,

G.

Message #27 received at 826982@bugs.debian.org (full text, mbox, reply):

From: Samuel Henrique <samueloph@gmail.com>

To: Gianfranco Costamagna <locutusofborg@debian.org>

Cc: Reiner Herrmann <reiner@reiner-h.de>, "826982@bugs.debian.org" <826982@bugs.debian.org>

Subject: Re: Bug#826982 closed by Gianfranco Costamagna <locutusofborg@debian.org> (hoichess, reproducible on amd64)

Date: Fri, 9 Sep 2016 10:40:54 -0300

[Message part 1 (text/plain, inline)]

Hi all,

Thanks for the head up Gianfanco, I'll commit this patch to git within the
next hours and then ask for sponsorship.
Also, thanks a lot for the patch Reiner, you're always saving the
reproducibility of the packages i work with :)

Regards

Samuel Henrique <samueloph>

2016-09-09 4:46 GMT-03:00 Gianfranco Costamagna <locutusofborg@debian.org>:

> Hi Reiner, Samuel
>
>
> >Control: reopen -1
>
>
> that was a really quick turnaround and patch, thanks!
>
> >I attached an updated patch for the new version.
>
> thanks
> >As this is a fileordering related issue, being reproducible on amd64
> >unfortunately doesn't say much, as we usually don't see those issues
> >on amd64 _in our setup_.
>
>
> oh indeed, I understand now
>
> >The issue is still that source files are collected with 'wildcard',
> >which returns files in non-deterministic readdir order.
> >If the file list is passed to the linker, it needs to be sorted.
>
>
> not sure if "wildcard" tool might be fixed then ;)
>
> But I cc'd the person who want to adopt this package, I'll be happy to see
> him committing the patch and maybe ask me for sponsorhip
> (or anybody else).
>
> Let me know,
>
> G.
>

[Message part 2 (text/html, inline)]

Message #32 received at 826982-submitter@bugs.debian.org (full text, mbox, reply):

From: Samuel Henrique <samueloph@gmail.com>

To: 826982-submitter@bugs.debian.org

Subject: Bug#826982 marked as pending

Date: Fri, 09 Sep 2016 15:08:16 +0000

tag 826982 pending
thanks

Hello,

Bug #826982 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:

    http://git.debian.org/?p=collab-maint/hoichess.git;a=commitdiff;h=c430c40

---
commit c430c407738e622bb29d5501155ce8ac5c136a2e
Author: Samuel Henrique <samueloph@gmail.com>
Date:   Fri Sep 9 12:07:39 2016 -0300

    Add reproducible-build.patch

diff --git a/debian/changelog b/debian/changelog
index 9794e0f..4467dc0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,12 +1,15 @@
-hoichess (0.19.0-3) UNRELEASED; urgency=medium
+hoichess (0.19.0-3) unstable; urgency=medium
 
   * New maintainer. Thanks to all previous people that have helped this
     package, special mention to Joao Eriberto Mota Filho <eriberto@debian.org>,
     whom sponsored me and dedicated a lot of time and effort into reviewing my
     changes (closes: #835307).
   * debian/copyright: Switch to DEP-5 format.
+  * debian/patches:
+    - reproducible-build.patch: New patch, sort source files for deterministic
+      linking order, thanks to Reiner Herrmann (closes: #826982).
 
- -- Samuel Henrique <samueloph@gmail.com>  Thu, 08 Sep 2016 01:11:24 -0300
+ -- Samuel Henrique <samueloph@gmail.com>  Fri, 09 Sep 2016 11:57:30 -0300
 
 hoichess (0.19.0-2) unstable; urgency=medium
 

Message #37 received at 826982-close@bugs.debian.org (full text, mbox, reply):

From: Samuel Henrique <samueloph@gmail.com>

To: 826982-close@bugs.debian.org

Subject: Bug#826982: fixed in hoichess 0.19.0-3

Date: Fri, 09 Sep 2016 22:09:38 +0000

Source: hoichess
Source-Version: 0.19.0-3

We believe that the bug you reported is fixed in the latest version of
hoichess, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 826982@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Henrique <samueloph@gmail.com> (supplier of updated hoichess package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 09 Sep 2016 11:57:30 -0300
Source: hoichess
Binary: hoichess
Architecture: source
Version: 0.19.0-3
Distribution: unstable
Urgency: medium
Maintainer: Samuel Henrique <samueloph@gmail.com>
Changed-By: Samuel Henrique <samueloph@gmail.com>
Description:
 hoichess   - xboard compatible chess engine to play chess with
Closes: 826982 835307
Changes:
 hoichess (0.19.0-3) unstable; urgency=medium
 .
   * New maintainer. Thanks to all previous people that have worked on this
     package, special mention to Joao Eriberto Mota Filho <eriberto@debian.org>,
     whom sponsored me and dedicated a lot of time and effort into reviewing my
     changes (closes: #835307).
   * debian/copyright: Switch to DEP-5 format.
   * debian/patches:
     - reproducible-build.patch: New patch, sort source files for deterministic
       linking order, thanks to Reiner Herrmann (closes: #826982).
Checksums-Sha1:
 a2259c6d86f915c50fc8f806f6b389c91f351d42 1842 hoichess_0.19.0-3.dsc
 6b5ab0ba777dd310698107e7f81a0990b218258a 6396 hoichess_0.19.0-3.debian.tar.xz
Checksums-Sha256:
 adf8668116c2a39df59449cbe9fcdcfd9ad6dd67013bc462a43e7f917434c930 1842 hoichess_0.19.0-3.dsc
 cf5057628363641205b23d09839283dd2505c3c4f49a59b0b01e99fe640ec2f9 6396 hoichess_0.19.0-3.debian.tar.xz
Files:
 ea74c9c3cf5b729257880fb1ef179f3c 1842 games optional hoichess_0.19.0-3.dsc
 3ed3619ed3a4ec3c08fe30d65a3eb897 6396 games optional hoichess_0.19.0-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJX0yg1AAoJEN5juccE6+nvdwgQAJIPnPCQ16uPBLSCmiKbAG8s
C9JCoqIH6nkmJoXm/dVzHBwCtJVzAISQlnjxGKF3fW4ZW5Ro89I11r3wmH0o/SWf
vjZ0eefZAmi3diGfrZnCCD+h/ucwfb08qJ8f6fVPyPr3CFsyVSiLEyvRb2qEihPY
4Q4OOXa2zJjohbPLktVkJvQIO7Qgjw5aq566rg2oYjhGUwsrNjY+jpBdNbGF0W0G
kuLoyB7Y5WrDmTKtS7eWHHhLvSXI4raDoiRhNAqU5XSDHIn/x/K9kdmbtm5eh2zl
sUWsW9wuo0lfq2h/ag4Lp9f0nxZk/YGFt0mEok1JwRNB5INXxRHwFMzV5EITCg8a
E+NlnaN1vLltQoSR+CpbEwKF9C/0vvFk2WVhShzw1hGVuR/MXFC5pPcz/Tv2F9DX
NJtc5ujuN+PoCyKnQOXYLWWEr6A76cUHIT4HX+MNEaCME+8nRODDoNMFH4rgPaEW
fIEeECj0rMnbAaKQ4dr8+5dWBD85m//6DNxxfkaWbL+NHAUAv6EHunM0sHIoHr7w
qrpOSWYInyYS77gOk626bQ+AmQ4YJm9ZfU8UOCqLCemg3m7CJN3WENcYMgg7ibOL
Si1cKlZ5pZaHpn9h1O5owr4JBmqIGK52myK6nYwQ8ahFJ3POLaG2ILrts54QpWN9
NWZWwjsn7Bt8a7K8/1uh
=2UFl
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.