Debian Bug report logs - #825406
cdist: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: submit@bugs.debian.org

Subject: cdist: please make the build reproducible

Date: Thu, 26 May 2016 18:45:50 +0100

[Message part 1 (text/plain, inline)]

Source: cdist
Version: 4.0.0-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: ordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Hi,

Whilst working on the "reproducible builds" effort [0], we noticed that cdist could not be built reproducibly.

Patch attached.

 [0] https://wiki.debian.org/ReproducibleBuilds


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[cdist.diff.txt (text/plain, attachment)]

Message #10 received at 825406@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: 825406@bugs.debian.org

Subject: Re: cdist: please make the build reproducible

Date: Thu, 26 May 2016 18:50:04 +0100

forwarded 825406 https://github.com/ungleich/cdist/pull/437
thanks

Hi,

I've forwarded this issue upstream here:

  https://github.com/ungleich/cdist/pull/437


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #17 received at 825406@bugs.debian.org (full text, mbox, reply):

From: Axel Beckert <abe@debian.org>

To: 825406@bugs.debian.org, Reproducible Builds discussion list <reproducible-builds@lists.alioth.debian.org>

Subject: Re: [Reproducible-builds] Bug#825406: cdist: please make the build reproducible

Date: Thu, 26 May 2016 19:52:22 +0200

Hi,

Chris Lamb wrote:
> -for type in man7/cdist-type__*.text; do
> +for type in $(ls man7/cdist-type__*.text | LC_ALL=C); do

There is a "sort" missing after "LC_ALL=C".

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Message #22 received at 825406@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <chris@chris-lamb.co.uk>

To: 825406@bugs.debian.org

Cc: Axel Beckert <abe@debian.org>

Subject: Re: cdist: please make the build reproducible

Date: Thu, 26 May 2016 19:52:27 +0100

[Message part 1 (text/plain, inline)]

Alex Beckert wrote:

> There is a "sort" missing after "LC_ALL=C".

Whoops. Updated patch attached. Thanks!


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[cdist.diff.txt (text/plain, attachment)]

Message #27 received at 825406@bugs.debian.org (full text, mbox, reply):

From: Dmitry Bogatov <KAction@gnu.org>

To: Chris Lamb <chris@chris-lamb.co.uk>, 825406@bugs.debian.org, debian-bugs-dist@lists.debian.org

Subject: Re: Bug#825406: cdist: please make the build reproducible

Date: Fri, 27 May 2016 01:14:02 +0300

> There is a "sort" missing after "LC_ALL=C".

Whoops. Updated patch attached. Thanks!

-----------------------

-for type in man7/cdist-type__*.text; do
+for type in $(ls man7/cdist-type__*.text | LC_ALL=C sort); do
     no_dir="${type#man7/}";
     no_type="${no_dir#cdist-type}";
     name="${no_type%.text}";

-----------------------

I dislike this solution. While this works in this particular case,
parsing of 'ls' is evil. Another proposal, consider this shell script:

	#!/bin/sh
	for file in * ; do
	    printf '>> %s\n' "$file"
	done

Is output guaranted to be same for same files in same locale? If yes,
I would just export LC_ALL=C in debian/rules (or maybe it should be
exported by /usr/bin/dh?). If no, I think we need to patch /bin/sh.
Opinions?

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io

Message #32 received at 825406@bugs.debian.org (full text, mbox, reply):

From: Chris Lamb <lamby@debian.org>

To: Dmitry Bogatov <KAction@gnu.org>, 825406@bugs.debian.org

Subject: Re: Bug#825406: cdist: please make the build reproducible

Date: Fri, 27 May 2016 10:16:55 +0100

> Is output guaranted to be same for same files in same locale?

No, and can also be in (non-deterministic) filesystem order.

> If no, I think we need to patch /bin/sh.

We would not be able to patch every /bin/sh in every distribution, so it wouldn't be a good idea for Debian to take this approach.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

Message #37 received at 825406@bugs.debian.org (full text, mbox, reply):

From: Dmitry Bogatov <KAction@gnu.org>

To: Chris Lamb <lamby@debian.org>, 825406@bugs.debian.org, debian-bugs-dist@lists.debian.org

Subject: Re: Bug#825406: cdist: please make the build reproducible

Date: Fri, 27 May 2016 13:10:00 +0300

> > If no, I think we need to patch /bin/sh.
> We would not be able to patch every /bin/sh in every distribution,
> so it wouldn't be a good idea for Debian to take t his approach.

As far as I know, following can provide /bin/sh: dash,bash,posh,mksh,zsh.
Many, I agree. But do you know of any better generic solution? Piping to sort
is not a solution, given that filename is anything, but '/' and '\0'.

Since principled solution would require a lot of time, I will apply
you patch (thanks), but situation is unsatisfactory.

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io

Message #42 received at 825406-close@bugs.debian.org (full text, mbox, reply):

From: Dmitry Bogatov <KAction@gnu.org>

To: 825406-close@bugs.debian.org

Subject: Bug#825406: fixed in cdist 4.0.0-2

Date: Sat, 28 May 2016 07:33:55 +0000

Source: cdist
Source-Version: 4.0.0-2

We believe that the bug you reported is fixed in the latest version of
cdist, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 825406@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Bogatov <KAction@gnu.org> (supplier of updated cdist package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 28 May 2016 01:25:09 +0300
Source: cdist
Binary: cdist
Architecture: source
Version: 4.0.0-2
Distribution: unstable
Urgency: medium
Maintainer: Dmitry Bogatov <KAction@gnu.org>
Changed-By: Dmitry Bogatov <KAction@gnu.org>
Description:
 cdist      - Usable Configuration Management System
Closes: 825406
Changes:
 cdist (4.0.0-2) unstable; urgency=medium
 .
   * patches/ensure-reproducible-build.patch: ensure deterministic file
     processing order.  Thanks to Chris Lamb <chris@chris-lamb.co.uk>.
     (Closes: #825406)
   * Call dh_fixperms after calling 'chmod +x' on files with shebang, since
     seems it is overzealos and causes executable manpage.
Checksums-Sha1:
 846dc0e1c8c10ebc808fa755df66d041198b514a 1907 cdist_4.0.0-2.dsc
 4d3642fcecfac0a548dc6104f497368a859f6c19 6580 cdist_4.0.0-2.debian.tar.xz
Checksums-Sha256:
 29cbef7e1cd85be1a9f6e7df2ac4c7802122acfb415419470223971af1854018 1907 cdist_4.0.0-2.dsc
 a59e0512316fc0649a8932fa7e4c0dd1a5861dfb88ed5030987df7d2cd392e7f 6580 cdist_4.0.0-2.debian.tar.xz
Files:
 cb23a1e867dd31b30cdba2057a2bb25c 1907 admin optional cdist_4.0.0-2.dsc
 ac87bc497652bbd5701c42ce78169d26 6580 admin optional cdist_4.0.0-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXSUh9AAoJEPNPCXROn13Z7esQAJi0Fj8pIlWKBa7T8fCFr2F7
kSdr1I8suR4vIHZSRlHQQxc5TegKMmhfW63mWYuUPo4fYmpAkMxjAeZPFLvQBy4D
jwnQ6A/k/uL+xgFjjHZPRvE1MIGB9buB8ymu6Y9tEXHpiTKQ8NtqPvi+YKlrpAUm
hZXo3KvMP/Ix2ryPU4RX+Dl8/ocPAmuABS3z/tiCKCZtXhCM9oNmkxejjFbQr4Jt
6veuCILuoucSL+IfFaNG+kLzMEKn/aUW+MOBwvTFIf+jAJKzamu/MH1TZkTEa5RY
59gSN7yc04kdMT1ybiO63136t5HOhkq6Xiyybkd4Anc4tivcnLRRWt0WzIjjEpaK
uBctNnszOoYHrjqwqQhmYxC/aewgGlB0c7n7adq38CS42ryFJG5lDAp39a/vK0Se
0/EgQcw2kCFhVaOhkdv+wEJpqy88O6AfacrPPvyn6Kjr0VzlbccpSqIQISuzhhZn
KyubhTlNU2xk/hw0gcw1SEDx661+O6LilkxWwei8PxShUfKfOUqQfE2YGZ19/y43
rvJnewhOzXumdYdMB0fYNeHKakkLeDcKkTIDUPfefOZRhc+IjdtgS0hBCAZD9/Cl
4vlXBOIW4Ygnpsq43b39yr9OVE0K6Jn9kzvg05tJHsvTGtMZ8LzHmutrKP8RcoG9
OW9gy+AoVcFAvhfC2cDe
=5xe6
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.