Debian Bug report logs - #825075
deb-systemd-invoke: incomplete handling of policy-rc.d status codes

version graph

Package: init-system-helpers; Maintainer for init-system-helpers is Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>; Source for init-system-helpers is src:init-system-helpers (PTS, buildd, popcon).

Reported by: Edward Allcutt <edward.allcutt@openmarket.com>

Date: Mon, 23 May 2016 11:42:02 UTC

Severity: normal

Found in version init-system-helpers/1.33

Fixed in version init-system-helpers/1.34

Done: Martin Pitt <mpitt@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>:
Bug#825075; Package init-system-helpers. (Mon, 23 May 2016 11:42:05 GMT) (full text, mbox, link).


Acknowledgement sent to Edward Allcutt <edward.allcutt@openmarket.com>:
New Bug report received and forwarded. Copy sent to Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>. (Mon, 23 May 2016 11:42:06 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Edward Allcutt <edward.allcutt@openmarket.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Cc: Edward Allcutt <edward.allcutt@openmarket.com>
Subject: deb-systemd-invoke: incomplete handling of policy-rc.d status codes
Date: Mon, 23 May 2016 12:22:50 +0100 (BST)
Package: init-system-helpers
Version: 1.33
Severity: normal

Dear Maintainer,

In particular, where policy-rc.d returns 0 deb-systemd-invoke prints a
spurious warning. The original spec for policy-rc.d mentioned only 0 as
the return code for "action allowed" and 104 was added later.
invoke-rc.d treats 0 the same as 104 and so should deb-systemd-invoke.

Thanks,

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (900, 'testing'), (800, 'unstable'), (700, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.5.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages init-system-helpers depends on:
ii  perl-base  5.22.2-1

init-system-helpers recommends no packages.

init-system-helpers suggests no packages.

-- no debconf information



Information forwarded to debian-bugs-dist@lists.debian.org, Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>:
Bug#825075; Package init-system-helpers. (Sun, 29 May 2016 20:15:04 GMT) (full text, mbox, link).


Acknowledgement sent to Martin Pitt <mpitt@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>. (Sun, 29 May 2016 20:15:04 GMT) (full text, mbox, link).


Message #10 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>
To: Edward Allcutt <edward.allcutt@openmarket.com>, 825075@bugs.debian.org
Cc: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: Re: Bug#825075: deb-systemd-invoke: incomplete handling of policy-rc.d status codes
Date: Sun, 29 May 2016 22:13:35 +0200
Control: tag -1 pending

Hello Edward,

Edward Allcutt [2016-05-23 12:22 +0100]:
> In particular, where policy-rc.d returns 0 deb-systemd-invoke prints a
> spurious warning. The original spec for policy-rc.d mentioned only 0 as
> the return code for "action allowed" and 104 was added later.
> invoke-rc.d treats 0 the same as 104 and so should deb-systemd-invoke.

Thanks for pointing out! Fixed in git.

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)



Added tag(s) pending. Request was from Martin Pitt <mpitt@debian.org> to submit@bugs.debian.org. (Sun, 29 May 2016 20:15:04 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>:
Bug#825075; Package init-system-helpers. (Sun, 29 May 2016 20:15:13 GMT) (full text, mbox, link).


Acknowledgement sent to Martin Pitt <mpitt@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>. (Sun, 29 May 2016 20:15:13 GMT) (full text, mbox, link).


Reply sent to Martin Pitt <mpitt@debian.org>:
You have taken responsibility. (Mon, 30 May 2016 16:27:15 GMT) (full text, mbox, link).


Notification sent to Edward Allcutt <edward.allcutt@openmarket.com>:
Bug acknowledged by developer. (Mon, 30 May 2016 16:27:15 GMT) (full text, mbox, link).


Message #22 received at 825075-close@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>
To: 825075-close@bugs.debian.org
Subject: Bug#825075: fixed in init-system-helpers 1.34
Date: Mon, 30 May 2016 16:24:11 +0000
Source: init-system-helpers
Source-Version: 1.34

We believe that the bug you reported is fixed in the latest version of
init-system-helpers, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 825075@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Martin Pitt <mpitt@debian.org> (supplier of updated init-system-helpers package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 30 May 2016 15:52:48 +0200
Source: init-system-helpers
Binary: init-system-helpers dh-systemd init
Architecture: source all amd64
Version: 1.34
Distribution: unstable
Urgency: medium
Maintainer: Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>
Changed-By: Martin Pitt <mpitt@debian.org>
Description:
 dh-systemd - debhelper add-on to handle systemd unit files
 init       - init metapackage
 init-system-helpers - helper tools for all init systems
Closes: 756023 820359 825075
Changes:
 init-system-helpers (1.34) unstable; urgency=medium
 .
   [ Martin Pitt ]
   * Make "init" not essential any more and lower priority from "required" to
     "important", so that we can drop it from minimal chroots and docker
     containers at some point. Explicitly mark init-system-helpers as essential
     now (before it was only transitively essential due to  init depending on
     it). (Closes: #756023)
   * Mark init "Important: yes" instead, so that one does not accidentally
     uninstall it.
   * deb-systemd-invoke: Accept policy-rc.d exit code 0 as "allowed" in
     addition to code 104, like invoke-rc.d. (Closes: #825075)
 .
   [ Dan Nicholson ]
   * deb-systemd-helper, dh_systemd_start: Use split rather than
     Text::ParseWords::shellwords since the latter will strip valid \
     escapes from unit names. The values then need to have leading and
     trailing quotes stripped. (Closes: #820359)
   * dh_systemd_enable: Drop unused Text::ParseWords use.
Checksums-Sha1:
 8ec95355251f2a664fe634b3023e1f2f4d42ede2 1867 init-system-helpers_1.34.dsc
 4c2bad2b9da68c9c8499a7ec3a1b170713c51612 57696 init-system-helpers_1.34.tar.xz
 fc42b5c2d5eba3aaf87490398882afb7a5317f6e 21986 dh-systemd_1.34_all.deb
 ec30e7fe47b9ab171b4dad079013ac3befb85ce1 35772 init-system-helpers_1.34_all.deb
 5e1faa3e65a1500e33008ed16f982651c0f9ecfc 8162 init_1.34_amd64.deb
Checksums-Sha256:
 5db2f2c6bab48ba32d99f0ed1f3364576060c2be6ed65fc318a94f12341e582e 1867 init-system-helpers_1.34.dsc
 328bec32d5e95c2e81dfbb027bb3e2bfc847d8cf759f548010c1dd1934ece625 57696 init-system-helpers_1.34.tar.xz
 0980e6daf3a1faad5fdbe7cf87985c259043714387c7184dac9695d076b9852b 21986 dh-systemd_1.34_all.deb
 c36f7e594fa157afeef6be10ccb110f6b30696a820aca4d04330d82606f0d00a 35772 init-system-helpers_1.34_all.deb
 a00a40a2f8e08b3bfe42788cafaf6e32bbaa260cc6b6799e9c8f7eb9844388dc 8162 init_1.34_amd64.deb
Files:
 5ce18fb948eb3699234ab53f256820b4 1867 admin extra init-system-helpers_1.34.dsc
 608ac7c7194b13df0df8c3456cd62086 57696 admin extra init-system-helpers_1.34.tar.xz
 34f5f815857a2fb851bc8933f3e0c423 21986 admin extra dh-systemd_1.34_all.deb
 fa1b479dce3d9e5ac663dd48d095ceae 35772 admin required init-system-helpers_1.34_all.deb
 039da57b26ec2ae7e02444c3e7f1e5a3 8162 metapackages important init_1.34_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXTEYKAAoJENFO8V2v4RNHymYP/jnhkCUQvXs9QEwwWbnm8LEY
p+jhSfwkxa/vmNqG86hru9S8+7BHG4Du4sJNLaUB+yHzf+TEG4VX2owhQtiMSPXT
ehPWY8AGBtJfVwNHrcB3VpnX49BjxzB7UV/HeUcZi3ZIna3UJ0bsOA1IpUx2e7KY
IlfrkX9sEfPnKByDzla5fAc6flZh9vQ6YMkxT47QtvOoCK18WllNRK/eZO31FnIy
EFAbHxNbJqxtwNB5PcJKwpiA0pRP2lyAUozD/BTUEboBNGfRuYtwKq9rEg5+C4EO
pVnKy5icHAZnLDlcvDigCeXbq9jJQL9KL2+1ygpkHFT6C2wMTa6CFg5YZGexXckq
9a9P2sWD3hXAEdzbQyzQw6VOCryDKtIncG56DeKSua171U8fhwy6q1lF6FQeIwhZ
NTSUQwYLUR3tkyUp0Smt3/Q/lEvb9LW0C+Mh3kImXj8AvEOttnQ7RjZ4MoGWiD8M
DW7D0RBODzHjUTZORtmiSiJKKdBiB3CBXbnC7GRwrkuTgztLwb+Quid89Syl90kI
waRA/HBxlqiS+z875ZTRxk13q9lxCSxJ54XxQkCxy6bAzZkH2bqdRy843ecfPcaF
RO/iWr3mKrRvWVaIhZ3q4bzyx5xRtrvMsz2c1pv4i/4X1r+QSApAyJPIBRvY46n2
MpQxujlS0D2QHt9c59vU
=9I5p
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sun, 03 Jul 2016 07:45:13 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sat Jan 6 07:45:34 2018; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.