Debian Bug report logs - #824974
grub-pc: grub-probe fails on root-on-ZFS systems

version graph

Package: grub-common; Maintainer for grub-common is GRUB Maintainers <pkg-grub-devel@alioth-lists.debian.net>; Source for grub-common is src:grub2 (PTS, buildd, popcon).

Reported by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>

Date: Sun, 22 May 2016 00:15:02 UTC

Severity: important

Tags: patch, upstream

Merged with 841021

Found in version grub2/2.02~beta2-36

Fixed in version grub2/2.02~beta3-3

Done: Colin Watson <cjwatson@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, pkg-zfsonlinux-devel@lists.alioth.debian.org, GRUB Maintainers <pkg-grub-devel@lists.alioth.debian.org>:
Bug#824974; Package grub-pc. (Sun, 22 May 2016 00:15:06 GMT) (full text, mbox, link).


Acknowledgement sent to Nicolas Braud-Santoni <nicolas@braud-santoni.eu>:
New Bug report received and forwarded. Copy sent to pkg-zfsonlinux-devel@lists.alioth.debian.org, GRUB Maintainers <pkg-grub-devel@lists.alioth.debian.org>. (Sun, 22 May 2016 00:15:06 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: grub-pc: grub-probe fails on root-on-ZFS systems
Date: Sun, 22 May 2016 02:08:36 +0200
Package: grub-pc
Version: 2.02~beta2-36
Severity: normal

Dear Maintainer,

On my freshly setup Stretch system, update-grub fails with the following error:

> /usr/sbin/grub-probe: error: failed to get canonical path of `/dev/vacuum-crypt'.

This led me to having no grub.cfg file (until I wrote one by hand) and
  will probably manifest itself when I upgrade the kernel.


My setup is as follows:
- /boot is on /dev/sda1 (ext4);
  it is designated by label (vacuum-boot) in /etc/fstab
- /dev/sda2 contains a LUKS volume (vacuum-crypt)
- vacuum-crypt contains a ZFS pool (vacuum) that hold the filesystem.


I am aware that ZFS support in Debian is extremely new.
My goal, in opening this bug, is to keep track of what needs to be done on Grub's
  side so that it works correctly for ZFS users.


Best regards,

  nicoo 


-- Package-specific info:

*********************** BEGIN /proc/mounts
/dev/sda1 /boot ext4 rw,nosuid,nodev,noexec,relatime,data=ordered 0 0
*********************** END /proc/mounts

*********************** BEGIN /boot/grub/grub.cfg
insmod linux
set root=(hd0,msdos1)
linux /vmlinuz-4.5.0-2-amd64 root=ZFS=vacuum/ROOT/debian boot=zfs security=apparmor
initrd /initrd.img-4.5.0-2-amd64
*********************** END /boot/grub/grub.cfg

*********************** BEGIN /proc/mdstat
cat: /proc/mdstat: No such file or directory
*********************** END /proc/mdstat

*********************** BEGIN /dev/disk/by-id
total 0
lrwxrwxrwx 1 root root  9 May 22 01:27 ata-HITACHI_HTS723232A7A364_E3834563JNZL0N -> ../../sda
lrwxrwxrwx 1 root root 10 May 22 01:27 ata-HITACHI_HTS723232A7A364_E3834563JNZL0N-part1 -> ../../sda1
lrwxrwxrwx 1 root root 10 May 22 01:27 ata-HITACHI_HTS723232A7A364_E3834563JNZL0N-part2 -> ../../sda2
lrwxrwxrwx 1 root root 10 May 22 01:27 dm-name-vacuum-crypt -> ../../dm-0
lrwxrwxrwx 1 root root 10 May 22 01:27 dm-uuid-CRYPT-LUKS1-ffe82002193847da88304475aebe7501-vacuum-crypt -> ../../dm-0
lrwxrwxrwx 1 root root  9 May 22 01:27 usb-General_1-0:0 -> ../../sdb
lrwxrwxrwx 1 root root 10 May 22 01:27 usb-General_1-0:0-part1 -> ../../sdb1
lrwxrwxrwx 1 root root  9 May 22 01:27 wwn-0x5000cca61de5b93a -> ../../sda
lrwxrwxrwx 1 root root 10 May 22 01:27 wwn-0x5000cca61de5b93a-part1 -> ../../sda1
lrwxrwxrwx 1 root root 10 May 22 01:27 wwn-0x5000cca61de5b93a-part2 -> ../../sda2
*********************** END /dev/disk/by-id

*********************** BEGIN /dev/disk/by-uuid
total 0
lrwxrwxrwx 1 root root 10 May 22 01:27 2016-04-02-20-59-26-00 -> ../../sdb1
lrwxrwxrwx 1 root root 10 May 22 01:27 5902543104507671737 -> ../../dm-0
lrwxrwxrwx 1 root root 10 May 22 01:27 87b818b8-c6ac-4802-85d5-be4b1ade3101 -> ../../sda1
lrwxrwxrwx 1 root root 10 May 22 01:27 ffe82002-1938-47da-8830-4475aebe7501 -> ../../sda2
*********************** END /dev/disk/by-uuid

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.5.0-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=, LC_CTYPE= (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages grub-pc depends on:
ii  debconf [debconf-2.0]  1.5.59
ii  dpkg                   1.18.7
ii  grub-common            2.02~beta2-36
ii  grub-pc-bin            2.02~beta2-36
ii  grub2-common           2.02~beta2-36
ii  ucf                    3.0036

grub-pc recommends no packages.

grub-pc suggests no packages.

-- debconf information:
  grub2/linux_cmdline:
* grub-pc/install_devices_empty: true
  grub2/force_efi_extra_removable: false
  grub-pc/install_devices_failed_upgrade: true
  grub-pc/postrm_purge_boot_grub: false
  grub2/device_map_regenerated:
  grub2/kfreebsd_cmdline:
* grub-pc/install_devices:
  grub2/kfreebsd_cmdline_default: quiet
  grub-pc/timeout: 5
  grub-pc/mixed_legacy_and_grub2: true
  grub2/linux_cmdline_default: quiet
  grub-pc/partition_description:
  grub-pc/install_devices_disks_changed:
  grub-pc/kopt_extracted: false
  grub-pc/install_devices_failed: false
  grub-pc/chainload_from_menu.lst: true
  grub-pc/disk_description:
  grub-pc/hidden_timeout: false



Information forwarded to debian-bugs-dist@lists.debian.org, GRUB Maintainers <pkg-grub-devel@lists.alioth.debian.org>:
Bug#824974; Package grub-pc. (Thu, 13 Oct 2016 09:48:03 GMT) (full text, mbox, link).


Acknowledgement sent to Fabian Grünbichler <f.gruenbichler@proxmox.com>:
Extra info received and forwarded to list. Copy sent to GRUB Maintainers <pkg-grub-devel@lists.alioth.debian.org>. (Thu, 13 Oct 2016 09:48:03 GMT) (full text, mbox, link).


Message #10 received at 824974@bugs.debian.org (full text, mbox, reply):

From: Fabian Grünbichler <f.gruenbichler@proxmox.com>
To: 824974@bugs.debian.org
Subject: Re: grub-pc: grub-probe fails on root-on-ZFS systems
Date: Thu, 13 Oct 2016 11:37:23 +0200
[Message part 1 (text/plain, inline)]
Tags: patch, upstream

this should be fixed with the attached patch included in Ubuntu
yakkety's grub2 package.

it uses the environment variable ZPOOL_VDEV_NAME_PATH to cause "zpool
status" to generate output like "zpool status -P" would (since the
latter is not available for all ZFS implementations, the environment
variable is the safe way to go).

since the output now contains device paths starting with '/', grub-probe
will not prepend them with '/dev/', but use them directly. this should
fix all of the possible device paths, not just '/dev/disk/by-*' like
previous patches attempting to fix this did.

note that this is filed upstream as http://savannah.gnu.org/bugs/?43653
but not yet fixed.

example output:

# zpool status
  pool: rpool
 state: ONLINE
  scan: none requested
config:

  NAME                               STATE     READ WRITE CKSUM
  rpool                              ONLINE       0     0     0
    ata-QEMU_HARDDISK_QM00001-part2  ONLINE       0     0     0
    ata-QEMU_HARDDISK_QM00002        ONLINE       0     0     0
  logs
    ata-QEMU_HARDDISK_QM00007        ONLINE       0     0     0

errors: No known data errors

# zpool status -P
  pool: rpool
 state: ONLINE
config:

  NAME                                               STATE     READ WRITE CKSUM
  rpool                                              ONLINE       0     0     0
    /dev/disk/by-id/ata-QEMU_HARDDISK_QM00001-part2  ONLINE       0     0     0
    /dev/disk/by-id/ata-QEMU_HARDDISK_QM00002-part1  ONLINE       0     0     0
  logs
    /dev/disk/by-id/ata-QEMU_HARDDISK_QM00007-part1  ONLINE       0     0     0

errors: No known data errors

# ZPOOL_VDEV_NAME_PATH=YES zpool status
  pool: rpool
 state: ONLINE
  scan: none requested
config:

  NAME                                               STATE     READ WRITE CKSUM
  rpool                                              ONLINE       0     0     0
    /dev/disk/by-id/ata-QEMU_HARDDISK_QM00001-part2  ONLINE       0     0     0
    /dev/disk/by-id/ata-QEMU_HARDDISK_QM00002-part1  ONLINE       0     0     0
  logs
    /dev/disk/by-id/ata-QEMU_HARDDISK_QM00007-part1  ONLINE       0     0     0

errors: No known data errors

[zpool_full_device_name.patch (text/x-diff, attachment)]

Added tag(s) upstream and patch. Request was from Fabian Grünbichler <f.gruenbichler@proxmox.com> to control@bugs.debian.org. (Thu, 13 Oct 2016 10:15:03 GMT) (full text, mbox, link).


Bug reassigned from package 'grub-pc' to 'grub-common'. Request was from Fabian Grünbichler <f.gruenbichler@proxmox.com> to control@bugs.debian.org. (Wed, 19 Oct 2016 09:42:07 GMT) (full text, mbox, link).


No longer marked as found in versions grub2/2.02~beta2-36. Request was from Fabian Grünbichler <f.gruenbichler@proxmox.com> to control@bugs.debian.org. (Wed, 19 Oct 2016 09:42:08 GMT) (full text, mbox, link).


Severity set to 'important' from 'normal' Request was from Fabian Grünbichler <f.gruenbichler@proxmox.com> to control@bugs.debian.org. (Wed, 19 Oct 2016 09:42:08 GMT) (full text, mbox, link).


Marked as found in versions grub2/2.02~beta2-36. Request was from Fabian Grünbichler <f.gruenbichler@proxmox.com> to control@bugs.debian.org. (Wed, 19 Oct 2016 09:42:08 GMT) (full text, mbox, link).


Merged 824974 841021 Request was from Fabian Grünbichler <f.gruenbichler@proxmox.com> to control@bugs.debian.org. (Wed, 19 Oct 2016 09:42:09 GMT) (full text, mbox, link).


Reply sent to Colin Watson <cjwatson@debian.org>:
You have taken responsibility. (Tue, 01 Nov 2016 12:36:09 GMT) (full text, mbox, link).


Notification sent to Nicolas Braud-Santoni <nicolas@braud-santoni.eu>:
Bug acknowledged by developer. (Tue, 01 Nov 2016 12:36:09 GMT) (full text, mbox, link).


Message #27 received at 824974-close@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>
To: 824974-close@bugs.debian.org
Subject: Bug#824974: fixed in grub2 2.02~beta3-3
Date: Tue, 01 Nov 2016 12:34:35 +0000
Source: grub2
Source-Version: 2.02~beta3-3

We believe that the bug you reported is fixed in the latest version of
grub2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 824974@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated grub2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 01 Nov 2016 11:10:52 +0000
Source: grub2
Binary: grub2 grub-linuxbios grub-efi grub-common grub2-common grub-emu grub-emu-dbg grub-pc-bin grub-pc-dbg grub-pc grub-rescue-pc grub-coreboot-bin grub-coreboot-dbg grub-coreboot grub-efi-ia32-bin grub-efi-ia32-dbg grub-efi-ia32 grub-efi-amd64-bin grub-efi-amd64-dbg grub-efi-amd64 grub-efi-ia64-bin grub-efi-ia64-dbg grub-efi-ia64 grub-efi-arm-bin grub-efi-arm-dbg grub-efi-arm grub-efi-arm64-bin grub-efi-arm64-dbg grub-efi-arm64 grub-ieee1275-bin grub-ieee1275-dbg grub-ieee1275 grub-firmware-qemu grub-uboot-bin grub-uboot-dbg grub-uboot grub-xen-bin grub-xen-dbg grub-xen grub-xen-host grub-yeeloong-bin grub-yeeloong-dbg grub-yeeloong grub-theme-starfield grub-mount-udeb
Architecture: source
Version: 2.02~beta3-3
Distribution: unstable
Urgency: medium
Maintainer: GRUB Maintainers <pkg-grub-devel@lists.alioth.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description:
 grub-common - GRand Unified Bootloader (common files)
 grub-coreboot - GRand Unified Bootloader, version 2 (Coreboot version)
 grub-coreboot-bin - GRand Unified Bootloader, version 2 (Coreboot binaries)
 grub-coreboot-dbg - GRand Unified Bootloader, version 2 (Coreboot debug files)
 grub-efi   - GRand Unified Bootloader, version 2 (dummy package)
 grub-efi-amd64 - GRand Unified Bootloader, version 2 (EFI-AMD64 version)
 grub-efi-amd64-bin - GRand Unified Bootloader, version 2 (EFI-AMD64 binaries)
 grub-efi-amd64-dbg - GRand Unified Bootloader, version 2 (EFI-AMD64 debug files)
 grub-efi-arm - GRand Unified Bootloader, version 2 (ARM UEFI version)
 grub-efi-arm-bin - GRand Unified Bootloader, version 2 (ARM UEFI binaries)
 grub-efi-arm-dbg - GRand Unified Bootloader, version 2 (ARM UEFI debug files)
 grub-efi-arm64 - GRand Unified Bootloader, version 2 (ARM64 UEFI version)
 grub-efi-arm64-bin - GRand Unified Bootloader, version 2 (ARM64 UEFI binaries)
 grub-efi-arm64-dbg - GRand Unified Bootloader, version 2 (ARM64 UEFI debug files)
 grub-efi-ia32 - GRand Unified Bootloader, version 2 (EFI-IA32 version)
 grub-efi-ia32-bin - GRand Unified Bootloader, version 2 (EFI-IA32 binaries)
 grub-efi-ia32-dbg - GRand Unified Bootloader, version 2 (EFI-IA32 debug files)
 grub-efi-ia64 - GRand Unified Bootloader, version 2 (IA64 version)
 grub-efi-ia64-bin - GRand Unified Bootloader, version 2 (IA64 binaries)
 grub-efi-ia64-dbg - GRand Unified Bootloader, version 2 (IA64 debug files)
 grub-emu   - GRand Unified Bootloader, version 2 (emulated version)
 grub-emu-dbg - GRand Unified Bootloader, version 2 (emulated debug files)
 grub-firmware-qemu - GRUB firmware image for QEMU
 grub-ieee1275 - GRand Unified Bootloader, version 2 (Open Firmware version)
 grub-ieee1275-bin - GRand Unified Bootloader, version 2 (Open Firmware binaries)
 grub-ieee1275-dbg - GRand Unified Bootloader, version 2 (Open Firmware debug files)
 grub-linuxbios - GRand Unified Bootloader, version 2 (dummy package)
 grub-mount-udeb - export GRUB filesystems using FUSE (udeb)
 grub-pc    - GRand Unified Bootloader, version 2 (PC/BIOS version)
 grub-pc-bin - GRand Unified Bootloader, version 2 (PC/BIOS binaries)
 grub-pc-dbg - GRand Unified Bootloader, version 2 (PC/BIOS debug files)
 grub-rescue-pc - GRUB bootable rescue images, version 2 (PC/BIOS version)
 grub-theme-starfield - GRand Unified Bootloader, version 2 (starfield theme)
 grub-uboot - GRand Unified Bootloader, version 2 (ARM U-Boot version)
 grub-uboot-bin - GRand Unified Bootloader, version 2 (ARM U-Boot binaries)
 grub-uboot-dbg - GRand Unified Bootloader, version 2 (ARM U-Boot debug files)
 grub-xen   - GRand Unified Bootloader, version 2 (Xen version)
 grub-xen-bin - GRand Unified Bootloader, version 2 (Xen binaries)
 grub-xen-dbg - GRand Unified Bootloader, version 2 (Xen debug files)
 grub-xen-host - GRand Unified Bootloader, version 2 (Xen host version)
 grub-yeeloong - GRand Unified Bootloader, version 2 (Yeeloong version)
 grub-yeeloong-bin - GRand Unified Bootloader, version 2 (Yeeloong binaries)
 grub-yeeloong-dbg - GRand Unified Bootloader, version 2 (Yeeloong debug files)
 grub2      - GRand Unified Bootloader, version 2 (dummy package)
 grub2-common - GRand Unified Bootloader (common files for version 2)
Closes: 824974
Changes:
 grub2 (2.02~beta3-3) unstable; urgency=medium
 .
   [ Chad MILLER ]
   * Signal to zpool that it should emit full names of constituent devices
     (closes: #824974, LP: #1527727).
 .
   [ Mathieu Trudel-Lapierre ]
   * Fix support for IPv6 PXE booting under UEFI (LP: #1229458):
     - misc-fix-invalid-char-strtol.patch: fix strto*l methods invalid chars.
     - net_read_bracketed_ipv6_addr.patch: read bracketed IPv6 addresses.
     - bootp_new_net_bootp6_command.patch: add new bootp6 commands.
     - efinet_uefi_ipv6_pxe_support.patch: teach efinet to allow bootp6.
     - bootp_process_dhcpack_http_boot.patch: process DHCPACK, support HTTP.
     - efinet_set_network_from_uefi_devpath.patch: configure network from the
       devpath provided by the UEFI firmware.
     - efinet_set_dns_from_uefi_proto.patch: set DNS nameservers and search
       domains from the UEFI protocol.
   * debian/patches/install_signed.patch: update patch for the new names of
     the EFI binaries from shim.
   * debian/control: Breaks shim (<< 0.9+1474479173.6c180c6-0ubuntu1~) due to
     the renamed binaries in the new shim.
   * debian/postinst.in: call on to update-secureboot-policy on configure to
     make sure users can disable shim validation if necessary.
   * debian/build-efi-images: add loopback and squash4 modules to the signed
     EFI images.
Checksums-Sha1:
 e99ee6ac7d6fbf4c379e82efa12ffb9cfee1481c 6299 grub2_2.02~beta3-3.dsc
 f1fd460d9b910204121e4555caa07b8a20c3024d 1018836 grub2_2.02~beta3-3.debian.tar.xz
Checksums-Sha256:
 226f45b8e284023231acf34180ed6d52dc234ef3f3f302b06462fc394daf3721 6299 grub2_2.02~beta3-3.dsc
 f4ef081a18bc6fc734bca013d0c9bd0a1201a9400f1dd53ad0627c65add8155f 1018836 grub2_2.02~beta3-3.debian.tar.xz
Files:
 30bd3453f4ad96826cda50449d2c29b8 6299 admin extra grub2_2.02~beta3-3.dsc
 979e794b3fbd3747dea20cab3c73e087 1018836 admin extra grub2_2.02~beta3-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer

iQIcBAEBCAAGBQJYGHtOAAoJEDk1h9l9hlAL37EP/iRuKdVKdkCyHE+aIqpJYQti
lXJpxME2+T9XrU+OpZ7NheaZUqqAMj8T1hcUr6jmfyLxFfjIz9V74wnB4nKKjtFq
wJOJeRZJj7hU37jZZd0OZaXeokoPjt7mxka5+zkl/Iysz2KK61aM7WWXBRnLlt85
tasOm3MDUtX2RZfK0A6NmdjiIwOvIsXvWhLPKfOjkDQ3n4E2mopkh1r8r73ILwTf
8H3XthksnF+F/St4v4uythRptDvfKIUMkJqNXRmDec8E3XbI/qkixXmJtYmhlgbb
O7N6vNa/VG8FaZYvrQ+5lfKk6j03fArXpp0xhiwwbRqcLQ1lyzhlvMi4iLHq7AiJ
NBZSL1qSVtkEYepau/E0/4NvaMhDjw3k6MiKe2v92npxHszGgVDKyycYVIhU3GH7
tsRH6yF71I4e2QvBetWV7SdY7c866hSetYOjr99tcZQUVv+XRfrCl/vffAHjjtmY
JpLF1CBXrj1aHrqBaifTzXnT4v8ToJ5fPvYs2/sEEKBX4smkZqugNeu0dQV5zULL
rfqASWn7n8PFrqQh7s/ZocqnvB1LQ82ynGFgAFS+8DzUpmRYFpDZDnLy4FXRh150
6BidQi68dSFbBOgjpchhucBR6IDsBWAjFAro3jlJstr0w/TPQARCF9o3aD29YZgR
DakPFkEAIrLmGeUxqHTv
=LkFi
-----END PGP SIGNATURE-----




Reply sent to Colin Watson <cjwatson@debian.org>:
You have taken responsibility. (Tue, 01 Nov 2016 12:36:09 GMT) (full text, mbox, link).


Notification sent to Achim Gottinger <achim@ag-web.biz>:
Bug acknowledged by developer. (Tue, 01 Nov 2016 12:36:10 GMT) (full text, mbox, link).


Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 05 Dec 2016 08:18:57 GMT) (full text, mbox, link).


Bug unarchived. Request was from Don Armstrong <don@debian.org> to control@bugs.debian.org. (Wed, 07 Dec 2016 01:48:44 GMT) (full text, mbox, link).


Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 27 Jan 2017 08:26:30 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sat Jul 1 20:48:59 2023; Machine Name: bembo

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.