Debian Bug report logs - #824808
gdal: please make the build reproducible (fileordering)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Alexis Bienvenüe <pado@passoire.fr>

To: submit@bugs.debian.org

Subject: gdal: please make the build reproducible (fileordering)

Date: Fri, 20 May 2016 01:28:00 +0200

[Message part 1 (text/plain, inline)]

Source: gdal
Version: 2.1.0+dfsg-2
Severity: wishlist
Tags: patch upstream
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Dear Maintainer,

While working on the “reproducible builds” effort [1], we have noticed
that 'gdal' could not be built reproducibly.

Either one of the two attached patches fixes the order files are passed
to libtool — but I don't know if one of them could be an acceptable
solution.
One applied, gdal can be built reproducibly in our current experimental
framework.

Regards,
Alexis Bienvenüe.

[1]: https://wiki.debian.org/ReproducibleBuilds

[sort-files-1 (text/plain, attachment)]

[sort-files-2 (text/plain, attachment)]

Message #10 received at 824808@bugs.debian.org (full text, mbox, reply):

From: Sebastiaan Couwenberg <sebastic@xs4all.nl>

To: Alexis Bienvenüe <pado@passoire.fr>, 824808@bugs.debian.org

Subject: Re: Bug#824808: gdal: please make the build reproducible (fileordering)

Date: Fri, 20 May 2016 11:18:20 +0200

Control: tags -1 pending

Hi Alexis,

Thanks for the patches.

On 05/20/2016 01:28 AM, Alexis Bienvenüe wrote:
> Either one of the two attached patches fixes the order files are passed
> to libtool — but I don't know if one of them could be an acceptable
> solution.

The second patches seems better because it doesn't rely on external ls
which is not a given for the Windows builds.

I don't understand the need for the buildit target, isn't it sufficient
to do the wildcard sorting in the $(LIBGDAL) target?

I've modified your patch to do that, and that seems to work too.

https://anonscm.debian.org/cgit/pkg-grass/gdal.git/tree/debian/patches/sort-files-in-static-library.patch?id=caf37a5adc5ea187af41b0faca799f45d2364bec

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1

Message #17 received at 824808@bugs.debian.org (full text, mbox, reply):

From: Alexis Bienvenüe <pado@passoire.fr>

To: Sebastiaan Couwenberg <sebastic@xs4all.nl>, 824808@bugs.debian.org

Subject: Re: Bug#824808: gdal: please make the build reproducible (fileordering)

Date: Fri, 20 May 2016 11:29:02 +0200

Le 20/05/2016 11:18, Sebastiaan Couwenberg a écrit :
> The second patches seems better because it doesn't rely on external ls
> which is not a given for the Windows builds.

OK I see.

> I don't understand the need for the buildit target, isn't it sufficient
> to do the wildcard sorting in the $(LIBGDAL) target?

In some situations some of the target dependencies do not exist before
the "make target" call. When this arises, as $(wildcard) is expanded
before building the dependencies, it can miss some files… I was not sure
of the situation here, so I added a transitional target to be safe.

> I've modified your patch to do that, and that seems to work too.
> 
> https://anonscm.debian.org/cgit/pkg-grass/gdal.git/tree/debian/patches/sort-files-in-static-library.patch?id=caf37a5adc5ea187af41b0faca799f45d2364bec

Thanks!

Regards,
Alexis.

Message #22 received at 824808@bugs.debian.org (full text, mbox, reply):

From: Sebastiaan Couwenberg <sebastic@xs4all.nl>

To: Alexis Bienvenüe <pado@passoire.fr>, 824808@bugs.debian.org

Subject: Re: Bug#824808: gdal: please make the build reproducible (fileordering)

Date: Fri, 20 May 2016 12:07:49 +0200

Hi Alexis,

On 05/20/2016 11:29 AM, Alexis Bienvenüe wrote:
> Le 20/05/2016 11:18, Sebastiaan Couwenberg a écrit :
>> The second patches seems better because it doesn't rely on external ls
>> which is not a given for the Windows builds.
> 
> OK I see.
> 
>> I don't understand the need for the buildit target, isn't it sufficient
>> to do the wildcard sorting in the $(LIBGDAL) target?
> 
> In some situations some of the target dependencies do not exist before
> the "make target" call. When this arises, as $(wildcard) is expanded
> before building the dependencies, it can miss some files… I was not sure
> of the situation here, so I added a transitional target to be safe.
> 
>> I've modified your patch to do that, and that seems to work too.
>>
>> https://anonscm.debian.org/cgit/pkg-grass/gdal.git/tree/debian/patches/sort-files-in-static-library.patch?id=caf37a5adc5ea187af41b0faca799f45d2364bec
> 
> Thanks!

Thanks for the clarification. I'll include that when forwarding the
patch upstream, we may use the separate target after all if upstream
likes that better too.

We're currently waiting for the vtk6 build on mipsel for the gdal
transition (#823335) to complete. When GDAL 2.1.0 is in testing I'll
upload a new revision to unstable which will include the patch for this
issue.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1

Message #27 received at 824808-close@bugs.debian.org (full text, mbox, reply):

From: Bas Couwenberg <sebastic@debian.org>

To: 824808-close@bugs.debian.org

Subject: Bug#824808: fixed in gdal 2.1.0+dfsg-3

Date: Sat, 28 May 2016 11:52:06 +0000

Source: gdal
Source-Version: 2.1.0+dfsg-3

We believe that the bug you reported is fixed in the latest version of
gdal, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 824808@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bas Couwenberg <sebastic@debian.org> (supplier of updated gdal package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 28 May 2016 12:11:11 +0200
Source: gdal
Binary: libgdal20 libgdal-dev libgdal-doc gdal-bin python-gdal python3-gdal libgdal-perl libgdal-java
Architecture: source amd64 all
Version: 2.1.0+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Debian GIS Project <pkg-grass-devel@lists.alioth.debian.org>
Changed-By: Bas Couwenberg <sebastic@debian.org>
Description:
 gdal-bin   - Geospatial Data Abstraction Library - Utility programs
 libgdal-dev - Geospatial Data Abstraction Library - Development files
 libgdal-doc - Documentation for the Geospatial Data Abstraction Library
 libgdal-java - Java bindings to the Geospatial Data Abstraction Library
 libgdal-perl - Perl bindings to the Geospatial Data Abstraction Library
 libgdal20  - Geospatial Data Abstraction Library
 python-gdal - Python bindings to the Geospatial Data Abstraction Library
 python3-gdal - Python 3 bindings to the Geospatial Data Abstraction Library
Closes: 824808
Changes:
 gdal (2.1.0+dfsg-3) unstable; urgency=medium
 .
   * Add (modified) patch by Alexis Bienvenüe to make the build reproducible.
     (closes: #824808)
Checksums-Sha1:
 5f05c6aa9d3490f7d200343a532d2819aa5e3c18 3217 gdal_2.1.0+dfsg-3.dsc
 27b13b9de0117d64436bc20cedf34ecd63367e03 141332 gdal_2.1.0+dfsg-3.debian.tar.xz
 d0f0a24c3ed9e9dcff0230e152114fe0ba694c5a 409308 gdal-bin-dbgsym_2.1.0+dfsg-3_amd64.deb
 c331c5345387479341f88724e4e234191ceea0d6 328022 gdal-bin_2.1.0+dfsg-3_amd64.deb
 db62d6f6076e7d0d68ccb9c695f265b4656a9b7f 5873176 libgdal-dev_2.1.0+dfsg-3_amd64.deb
 b554cdc9e7fdca0d5fbb5a2a0ab9e563a37dcc74 1985172 libgdal-doc_2.1.0+dfsg-3_all.deb
 19f495689086c8f4524da4412fe868518a87918f 667532 libgdal-java-dbgsym_2.1.0+dfsg-3_amd64.deb
 647312a0c704d1155ab515b03cb12eff13ebd0f2 402786 libgdal-java_2.1.0+dfsg-3_amd64.deb
 80f016609946fcdd86ea5ecabd3acf873a68fc65 1028708 libgdal-perl-dbgsym_2.1.0+dfsg-3_amd64.deb
 928606808c93dfc516ca471650b00f691eb861b1 458506 libgdal-perl_2.1.0+dfsg-3_amd64.deb
 f7b8de00959f2314b50ce1e03ffba58f1e6d3a26 27470800 libgdal20-dbgsym_2.1.0+dfsg-3_amd64.deb
 41a6934ef515596a08f4f8961ce78ae5a1651655 5019494 libgdal20_2.1.0+dfsg-3_amd64.deb
 dfaf54cef3435ea4aa64d484b62803788f8bd07e 982566 python-gdal-dbgsym_2.1.0+dfsg-3_amd64.deb
 2b56308f53d76c3bb5756fcbdb09a00422c14644 682458 python-gdal_2.1.0+dfsg-3_amd64.deb
 33a34cee66e18d2834debd5be8607c4d3c02310a 1020550 python3-gdal-dbgsym_2.1.0+dfsg-3_amd64.deb
 6733bc28d9dd31d55c0f2df1d1d1afeb10ba154f 498232 python3-gdal_2.1.0+dfsg-3_amd64.deb
Checksums-Sha256:
 710777ce21d7ef2b4260f0d84f5bf6c854a19ce481c5ce92fb66b5484884151b 3217 gdal_2.1.0+dfsg-3.dsc
 12f78f68b024f82a2e31c3a89df3b5524542047d91a3ddba158a443eafd2e17f 141332 gdal_2.1.0+dfsg-3.debian.tar.xz
 3b2075cfceb734b66d00756dca6f6edd86d0d0b8af0859f35c92013a027710e4 409308 gdal-bin-dbgsym_2.1.0+dfsg-3_amd64.deb
 fbe7d2e44e0ab2f65b041c28f4dd6c94acae041610e4d77a2f42aa2fdb8b64c4 328022 gdal-bin_2.1.0+dfsg-3_amd64.deb
 2417cb99afecddade00c2607941b7477a32611efd84449867396326f87535c96 5873176 libgdal-dev_2.1.0+dfsg-3_amd64.deb
 eb5c513cb317ad9128580689e576465a222ab422e35f91cc5f8f2e8719ea341a 1985172 libgdal-doc_2.1.0+dfsg-3_all.deb
 c5201353e888aeaef46e383b5f616ea4badbcb78d5fd8a3a78fe94adab97bc96 667532 libgdal-java-dbgsym_2.1.0+dfsg-3_amd64.deb
 30ba9359948707ce4aa1ec819faf467d922ca6f0ccfca94d6f3765017aa376b3 402786 libgdal-java_2.1.0+dfsg-3_amd64.deb
 4937bbed20dcd4ba4f05301c2be4aae9b846b0892aa27e122703161806dd5469 1028708 libgdal-perl-dbgsym_2.1.0+dfsg-3_amd64.deb
 27efb08328a7b3d9cc5b1b4c4c084e11ad9fb16c2f7c5f9229988513845c798a 458506 libgdal-perl_2.1.0+dfsg-3_amd64.deb
 e466516b5992534309f745a358e61acedc09875b7c8cf5baa3f2f1d2df14564d 27470800 libgdal20-dbgsym_2.1.0+dfsg-3_amd64.deb
 7c449ae33831286305c19d9ed13e2e821aef7160add76b818cd8054f72b896ee 5019494 libgdal20_2.1.0+dfsg-3_amd64.deb
 be228ae281653c537841d10e3a4237f80a373b86c0397020fc69bf9dce573522 982566 python-gdal-dbgsym_2.1.0+dfsg-3_amd64.deb
 1cecf7905572a017427f4b3a785fe38b790a96be7bd2432127c5339b8e521077 682458 python-gdal_2.1.0+dfsg-3_amd64.deb
 716147eedd4efc96921d3b565d947fef33f68be4417eab536de340acf0cbb968 1020550 python3-gdal-dbgsym_2.1.0+dfsg-3_amd64.deb
 48e5b3573d72d5d6c28055928bf5da2d8837c5c33c0d17c9745ecbb47d0d047f 498232 python3-gdal_2.1.0+dfsg-3_amd64.deb
Files:
 7faa0ec182148cd383abf732375a7cbc 3217 science optional gdal_2.1.0+dfsg-3.dsc
 3681d2a5f58e50b2c2ab213c834d6d80 141332 science optional gdal_2.1.0+dfsg-3.debian.tar.xz
 efa17f3f75913f8e8ad02399eaf5b010 409308 debug extra gdal-bin-dbgsym_2.1.0+dfsg-3_amd64.deb
 9ecba119f4c9ccb01e62743d6ec598ec 328022 science optional gdal-bin_2.1.0+dfsg-3_amd64.deb
 399abcfb267f1cf8b2e299951186e77f 5873176 libdevel optional libgdal-dev_2.1.0+dfsg-3_amd64.deb
 45711d0cd5f3517b1ce7ed57b20bff83 1985172 doc optional libgdal-doc_2.1.0+dfsg-3_all.deb
 100bcf9102b764219decf1b13baa8fb4 667532 debug extra libgdal-java-dbgsym_2.1.0+dfsg-3_amd64.deb
 c14b802ce23608942a5e8496ce391c3d 402786 java optional libgdal-java_2.1.0+dfsg-3_amd64.deb
 b30ec397bb8e15e9e1d77e3b8049d76d 1028708 debug extra libgdal-perl-dbgsym_2.1.0+dfsg-3_amd64.deb
 a68f3509908f2271633c9c6affbcc49c 458506 perl optional libgdal-perl_2.1.0+dfsg-3_amd64.deb
 7712b585ac5bb4858ea3fa6f67adf570 27470800 debug extra libgdal20-dbgsym_2.1.0+dfsg-3_amd64.deb
 4b51ee5aed8cf6f8ed7567e34207eef3 5019494 libs optional libgdal20_2.1.0+dfsg-3_amd64.deb
 b2517a3720b237c889b36de5da69417a 982566 debug extra python-gdal-dbgsym_2.1.0+dfsg-3_amd64.deb
 4acdf6c0edaafabcc5c22bccbb66fb29 682458 python optional python-gdal_2.1.0+dfsg-3_amd64.deb
 1b38ba1dec1536bafba6cbd0f340c7ea 1020550 debug extra python3-gdal-dbgsym_2.1.0+dfsg-3_amd64.deb
 8d9340be891769843b74566caf542c70 498232 python optional python3-gdal_2.1.0+dfsg-3_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJXSXnCAAoJEGdQ8QrojUrxHCMP/0hKSW5msoLyo32iV02QU0hb
rjcwxbjKBOwb97HAo/C6AkpXR0EIyd9Y10+HFC+t2z0JuB01z/uNGY8FpUTejQjs
aV7NlC9EeI1LBNcRyPBTQecZlNs4gK3AnHu/EeQE4wgc7uvSfrKoVRx8gr0dsDs/
VziRGz6fd3wjHrhUiKAzT6S7S26YX9OS+qqpO8gw5VyRyXnfsbv9RdRHbRaz846L
ak639bTG+o4GUfXdZrxtYyoihQm1nk6BrUIMCEbit4/q+Y9M+nv9u/BZU7bc2hsJ
n6ASiAUSY3WOVjpIRkHFF2E5nzEK0e2uOmv0A6FD46aaJQsfKdANXGk0Kyc2c4Xt
eVPegHjwX6IrQ6tVBZStHU5GZM2ii+Pi+Ar9AnrpsXQBL0lXwhcp8Vjwu5dczUWW
OT8LoBuJyq9+5O5g5b+1+0dQPSTJ8zVjLgrn8KUcTZKYCjd99ZyaG8leP52FrJEx
0tcq0Dqqas7lH37lelJ2a32sTyrQb3+D3RdsoQ7CG7C4xhaZtw+Dyk9jL/U99y9P
Zod15O+/4d8dxRdWAZyoGa6GnBX78RYKBrScPIpm3BWJRGVKcqNiNzfl3VdvTX0T
IBLpeQai+U6+ZkGR+o7G5UIxTGHJlLHb+mPUYzZPAIhqtPkj74cTECixXd8WPQfE
Hnff9QBQ95bG6jybHdRk
=3LOr
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.