Debian Bug report logs - #823954
php5: Binary package "php5" does not need the whole build process to be created

[Message part 1 (text/plain, inline)]
Package: src:php5
Version: 5.6.21+dfsg-1

Dear maintainer:

The "php5" binary package is "Architecture: all" and it does not
really contain any file which is generated by compiling C source code.

So, it would make sense if "dpkg-buildpackage -A" generated this
package directly without "building" anything.

Briefly, the attached patch does this:

* The old "build" target is renamed to "build-arch".

* The old "install" target is renamed to "install-arch".

* A new "build-indep" target is created which does nothing
  (because there is really nothing to build).

* A new "install-indep" target is created which just puts
  /usr/share/bug/php5/control in place. This is removed from
  the old install target.

* The /usr/share/bug/php5/script symlink is handled by dh_link
  and "debian/php5.links".

I've checked that "dpkg-buildpackage -A" generates exactly the same
"php5" package as before. I believe "dpkg-buildpackage -B" should also
work, but in either case, I am confindent that it would be easy to
fix if it does not.

In my i3 at home, the patch reduces build time for "dpkg-buildpackage -A"
from 85 minutes to a few seconds.

Thanks.
[php5.patch.txt (text/plain, attachment)]
Santiago,

src:php5 is going to be killed from testing soon and it's not going to
be part of next stable release. Do you still think it's worth updating
it for source-only uploads? I know that you put some effort into this,
but I am keeping php5 in unstable just for the sake of security- and
proposed-updates right now (and there are still some r-deps that needs
to be fixed before I can kill it from ).

Cheers,
-- 
Ondřej Surý <ondrej@sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
Vše pro chleba (https://vseprochleba.cz) – Potřeby pro pečení chleba
všeho druhu

On Tue, May 10, 2016, at 19:19, Santiago Vila wrote:
> Package: src:php5
> Version: 5.6.21+dfsg-1
> 
> Dear maintainer:
> 
> The "php5" binary package is "Architecture: all" and it does not
> really contain any file which is generated by compiling C source code.
> 
> So, it would make sense if "dpkg-buildpackage -A" generated this
> package directly without "building" anything.
> 
> Briefly, the attached patch does this:
> 
> * The old "build" target is renamed to "build-arch".
> 
> * The old "install" target is renamed to "install-arch".
> 
> * A new "build-indep" target is created which does nothing
>   (because there is really nothing to build).
> 
> * A new "install-indep" target is created which just puts
>   /usr/share/bug/php5/control in place. This is removed from
>   the old install target.
> 
> * The /usr/share/bug/php5/script symlink is handled by dh_link
>   and "debian/php5.links".
> 
> 
> I've checked that "dpkg-buildpackage -A" generates exactly the same
> "php5" package as before. I believe "dpkg-buildpackage -B" should also
> work, but in either case, I am confindent that it would be easy to
> fix if it does not.
> 
> In my i3 at home, the patch reduces build time for "dpkg-buildpackage -A"
> from 85 minutes to a few seconds.
> 
> Thanks.
> _______________________________________________
> pkg-php-maint mailing list
> pkg-php-maint@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-php-maint
> Email had 1 attachment:
> + php5.patch.txt
>   4k (text/plain)

On Wed, May 11, 2016 at 03:11:26PM +0200, Ondřej Surý wrote:

> src:php5 is going to be killed from testing soon and it's not going to
> be part of next stable release. Do you still think it's worth updating
> it for source-only uploads? I know that you put some effort into this,
> but I am keeping php5 in unstable just for the sake of security- and
> proposed-updates right now (and there are still some r-deps that needs
> to be fixed before I can kill it from ).

This is not only for source-only uploads, this is also a QA issue.

I'm checking all packages for "dpkg-buildpackage -A". This one makes
me to waste 80 minutes of CPU time only to ensure that "dpkg-buildpackage -A"
works, so if the question is "does it worth to fix this in stretch while
the package still exists?" I would answer "definitely yes".

In other words: the upload could be source-only for you, but as far as
I have it in my list of packages to check, it is certainly not
source-only for me.

I could of course exclude the package from the list of packages to
check, but I would much prefer to reserve such list for packages that
make the autobuilder to hang, like this one which also hangs
the autobuilder from reproducible builds people:

https://reproducible.debian.net/rb-pkg/unstable/amd64/tbb.html

Moreover, the patch is very small and it should be very easy to check
for correctness (otherwise, I would probably not have bothered to
create it in the first place).

Thanks.

Fair enough. Building updated package right now.

Cheers,
-- 
Ondřej Surý <ondrej@sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server
Vše pro chleba (https://vseprochleba.cz) – Potřeby pro pečení chleba
všeho druhu

On Wed, May 11, 2016, at 15:49, Santiago Vila wrote:
> On Wed, May 11, 2016 at 03:11:26PM +0200, Ondřej Surý wrote:
> 
> > src:php5 is going to be killed from testing soon and it's not going to
> > be part of next stable release. Do you still think it's worth updating
> > it for source-only uploads? I know that you put some effort into this,
> > but I am keeping php5 in unstable just for the sake of security- and
> > proposed-updates right now (and there are still some r-deps that needs
> > to be fixed before I can kill it from ).
> 
> This is not only for source-only uploads, this is also a QA issue.
> 
> I'm checking all packages for "dpkg-buildpackage -A". This one makes
> me to waste 80 minutes of CPU time only to ensure that "dpkg-buildpackage
> -A"
> works, so if the question is "does it worth to fix this in stretch while
> the package still exists?" I would answer "definitely yes".
> 
> In other words: the upload could be source-only for you, but as far as
> I have it in my list of packages to check, it is certainly not
> source-only for me.
> 
> I could of course exclude the package from the list of packages to
> check, but I would much prefer to reserve such list for packages that
> make the autobuilder to hang, like this one which also hangs
> the autobuilder from reproducible builds people:
> 
> https://reproducible.debian.net/rb-pkg/unstable/amd64/tbb.html
> 
> 
> Moreover, the patch is very small and it should be very easy to check
> for correctness (otherwise, I would probably not have bothered to
> create it in the first place).
> 
> Thanks.

On Wed, May 11, 2016 at 03:57:07PM +0200, Ondřej Surý wrote:
> Fair enough. Building updated package right now.

Thanks a lot!

Source: php5
Source-Version: 5.6.21+dfsg-2

We believe that the bug you reported is fixed in the latest version of
php5, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 823954@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ondřej Surý <ondrej@debian.org> (supplier of updated php5 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 11 May 2016 15:55:22 +0200
Source: php5
Binary: php5 php5-common libapache2-mod-php5 libapache2-mod-php5filter php5-cgi php5-cli php5-phpdbg php5-fpm libphp5-embed php5-dev php5-dbg php5-curl php5-enchant php5-gd php5-gmp php5-imap php5-interbase php5-intl php5-ldap php5-mcrypt php5-readline php5-mysql php5-mysqlnd php5-odbc php5-pgsql php5-pspell php5-recode php5-snmp php5-sqlite php5-sybase php5-tidy php5-xmlrpc php5-xsl
Architecture: source
Version: 5.6.21+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian PHP Maintainers <pkg-php-maint@lists.alioth.debian.org>
Changed-By: Ondřej Surý <ondrej@debian.org>
Description:
 libapache2-mod-php5 - server-side, HTML-embedded scripting language (Apache 2 module)
 libapache2-mod-php5filter - server-side, HTML-embedded scripting language (apache 2 filter mo
 libphp5-embed - HTML-embedded scripting language (Embedded SAPI library)
 php5       - server-side, HTML-embedded scripting language (metapackage)
 php5-cgi   - server-side, HTML-embedded scripting language (CGI binary)
 php5-cli   - command-line interpreter for the php5 scripting language
 php5-common - Common files for packages built from the php5 source
 php5-curl  - CURL module for php5
 php5-dbg   - Debug symbols for PHP5
 php5-dev   - Files for PHP5 module development
 php5-enchant - Enchant module for php5
 php5-fpm   - server-side, HTML-embedded scripting language (FPM-CGI binary)
 php5-gd    - GD module for php5
 php5-gmp   - GMP module for php5
 php5-imap  - IMAP module for php5
 php5-interbase - interbase/firebird module for php5
 php5-intl  - internationalisation module for php5
 php5-ldap  - LDAP module for php5
 php5-mcrypt - MCrypt module for php5
 php5-mysql - MySQL module for php5
 php5-mysqlnd - MySQL module for php5 (Native Driver)
 php5-odbc  - ODBC module for php5
 php5-pgsql - PostgreSQL module for php5
 php5-phpdbg - server-side, HTML-embedded scripting language (PHPDBG binary)
 php5-pspell - pspell module for php5
 php5-readline - Readline module for php5
 php5-recode - recode module for php5
 php5-snmp  - SNMP module for php5
 php5-sqlite - SQLite module for php5
 php5-sybase - Sybase / MS SQL Server module for php5
 php5-tidy  - tidy module for php5
 php5-xmlrpc - XML-RPC module for php5
 php5-xsl   - XSL module for php5
Closes: 823954
Changes:
 php5 (5.6.21+dfsg-2) unstable; urgency=medium
 .
   [ Santiago Vila ]
   * Make src:php5 compatible with source-only uploads (Closes: #823954)
Checksums-Sha1:
 137e311e2cffae98d42af7c340a0ef61e32f6a88 5135 php5_5.6.21+dfsg-2.dsc
 2a17a9988db7e90cb9a0b85b7d0a2bc3242f9e82 225776 php5_5.6.21+dfsg-2.debian.tar.xz
Checksums-Sha256:
 a7410c334003c0fb1139852a52a32437adb0a4557251f8344d4c58142e582386 5135 php5_5.6.21+dfsg-2.dsc
 e2381a34dcedcadaec9d3f46d2249327c64e704a07e8b70a0cc16dd593c53ea0 225776 php5_5.6.21+dfsg-2.debian.tar.xz
Files:
 e7a88a0bc3d905c0abd8d06a5a2211c1 5135 php optional php5_5.6.21+dfsg-2.dsc
 49c11e038a6ee500b5a990bf535407eb 225776 php optional php5_5.6.21+dfsg-2.debian.tar.xz

Debian Bug report logs - #823954 php5: Binary package "php5" does not need the whole build process to be created

Debian Bug report logs - #823954
php5: Binary package "php5" does not need the whole build process to be created