Debian Bug report logs - #823883
autodep8: Support PyPy packages

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Barry Warsaw <barry@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: autodep8: Support PyPy packages

Date: Mon, 09 May 2016 20:14:00 -0400

Package: autodep8
Version: 0.5.1
Severity: wishlist

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Dear Maintainer,

Currently autodep8 does a great job of adding simple import tests for
Python 2 and Python 3 packages.  It doesn't yet support PyPy though,
and as we add more support for PyPy in the archive, it would be nice
to get PyPy tests for free too.

- -- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.5.0-2-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages autodep8 depends on:
ii  dctrl-tools  2.24-2
ii  python3      3.5.1-3

autodep8 recommends no packages.

autodep8 suggests no packages.

- -- no debconf information

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXMSfFAAoJEBJutWOnSwa/ojIQALXBcswEuxWRRKo8KWv/8QUu
0x6EXLxOVNhd+u2km+8YGaQx3rB8wcg1mKpEWVfmncNHVXp3VTW0GkcLzTi0CFHV
rqDXiFeMjbcO9xOxfGoVVMZMB1tYRlPNahv58yc/ePYuaouWamxj3CeQ/KiW6fZU
h81galucUL7/1pkLXpkum3nQx/7D5X51J5MK35sF8XylP3+ozpIH7VuklA5Whu52
Jcxgos121XN1zuP93ZMgiGCjjpXIl9UdBnK30n0CNWtQgbcKwcgrOt/KXUddLn5Q
5NuH0dJc7Fd8oO3O9T2D4dyHSXCtbCllLXqyvOGovi3acNZuLB1GfNRrCop1ZiWd
bGWTbp8GnV/kRoYW+hYnzJI/2LlJi/qtRwboJcu9DipBQgQDu1bCf0tUPfzMzRhX
iaFCX+O20mcE71V1hhIYImpboQrtydxkurO+yuwdbAHda3alsK95CvABDtRPO14f
FR5ebMBJh2RDgLr6IECA6Y1/Gku8ndGezh34lqnNGxZ+b4cO4USZJ4GaJVEmdql8
wwNXJL/qdIsvxsz0Aoyeog4lC1brfnBWI7CSlzAGiY+O6Mhz1Lvp9RvolByVLlcI
1fTtxwd4PD5Nu6OTV4tiAAw7zl8Rz9fEVczHIhnNz8ZtduISWYPoksnu+VlSSPBa
w3xWFcS8MTpaIgJL8/Cr
=8DFJ
-----END PGP SIGNATURE-----

Message #10 received at 823883@bugs.debian.org (full text, mbox, reply):

From: Barry Warsaw <barry@debian.org>

To: 823883@bugs.debian.org

Date: Tue, 10 May 2016 10:49:16 -0400

[Message part 1 (text/plain, inline)]

Looks like I could, so I did!

I pushed a 'pypy' branch to git which, if not perfect, seems to work for me in
some limited testing without breaking the existing test suite.  I'll attach a
diff here for the fun of it.

[823883.diff (text/x-patch, attachment)]

Message #15 received at 823883@bugs.debian.org (full text, mbox, reply):

From: Antonio Terceiro <terceiro@debian.org>

To: Barry Warsaw <barry@debian.org>, 823883@bugs.debian.org

Subject: Re: Bug#823883: (no subject)

Date: Wed, 11 May 2016 10:25:34 -0300

[Message part 1 (text/plain, inline)]

On Tue, May 10, 2016 at 10:49:16AM -0400, Barry Warsaw wrote:
> Looks like I could, so I did!
> 
> I pushed a 'pypy' branch to git which, if not perfect, seems to work for me in
> some limited testing without breaking the existing test suite.  I'll attach a
> diff here for the fun of it.

Thanks

> diff --git a/test/python_test.sh b/test/python_test.sh
> index 578a85f..79d9ce9 100644
> --- a/test/python_test.sh
> +++ b/test/python_test.sh
> @@ -16,6 +16,15 @@ test_python_detect_source_py3() {
>    assertTrue 'have py3 test' 'grep --quiet "print(" stdout'
>  }
>  
> +# PyPy is only Python 2 compatible for now.
> +test_python_detect_source_pypy() {
> +  has 'debian/control' 'Source: python-foo\n\nPackage:pypy-foo'
> +  check_run autodep8
> +  assertTrue 'get upstream name' 'grep --quiet "import foo;" stdout'
> +  assertTrue 'have py2 test' 'grep --quiet "print " stdout'
> +  assertFalse 'dont have py3 test' 'grep --quiet "print(" stdout'
> +}

this test is indistinguishable from one that tests for python2 only ...
only now I noted that all of the python tests are inherentily flawed as
they are testing whether print is called with or without parenthesis,
instead of checking for what really matters, which is what interpreter
was actually called.

I fixed that in
http://anonscm.debian.org/cgit/collab-maint/autodep8.git/commit/?id=33d660c

would you mind rebasing your patch on top of the current master and
testing again?

-- 
Antonio Terceiro <terceiro@debian.org>

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 823883@bugs.debian.org (full text, mbox, reply):

From: Barry Warsaw <barry@debian.org>

Cc: 823883@bugs.debian.org

Subject: Re: Bug#823883: (no subject)

Date: Wed, 11 May 2016 15:10:37 -0400

[Message part 1 (text/plain, inline)]

On May 11, 2016, at 10:25 AM, Antonio Terceiro wrote:

>this test is indistinguishable from one that tests for python2 only ...
>only now I noted that all of the python tests are inherentily flawed as
>they are testing whether print is called with or without parenthesis,
>instead of checking for what really matters, which is what interpreter
>was actually called.
>
>I fixed that in
>http://anonscm.debian.org/cgit/collab-maint/autodep8.git/commit/?id=33d660c
>
>would you mind rebasing your patch on top of the current master and
>testing again?

Done!  I also fleshed out a few other tests related to PyPy support.
Hopefully I did them correctly. ;)

Thanks again.  pypy branch updated.

[Message part 2 (application/pgp-signature, inline)]

Message #25 received at 823883-close@bugs.debian.org (full text, mbox, reply):

From: Antonio Terceiro <terceiro@debian.org>

To: 823883-close@bugs.debian.org

Subject: Bug#823883: fixed in autodep8 0.6

Date: Fri, 27 May 2016 16:19:50 +0000

Source: autodep8
Source-Version: 0.6

We believe that the bug you reported is fixed in the latest version of
autodep8, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 823883@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Antonio Terceiro <terceiro@debian.org> (supplier of updated autodep8 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 27 May 2016 09:38:30 -0300
Source: autodep8
Binary: autodep8
Architecture: source
Version: 0.6
Distribution: unstable
Urgency: medium
Maintainer: Autopkgtest team <autopkgtest-devel@lists.alioth.debian.org>
Changed-By: Antonio Terceiro <terceiro@debian.org>
Description:
 autodep8   - DEP-8 test control file generator
Closes: 823883 823931
Changes:
 autodep8 (0.6) unstable; urgency=medium
 .
   [ Ondřej Nový ]
   * Python: Substitute hyphen with underscore for module name
 .
   [ Barry Warsaw ]
   * Python: Added support for PyPy (Closes: #823883)
 .
   [ Antonio Terceiro ]
   * If `debian/tests/control.autodep8` exists, autodep8 will prepend the
     contents of that file to its own output. (Closes: #823931)
   * dkms: add missing `@` in Depends: line of generated test control files
   * manpage: include one example for each supported package type
Checksums-Sha1:
 a49ed738662a7964c85570b56e8f51e4ddd0e72c 1668 autodep8_0.6.dsc
 9bf26c34a1082c153457ac11bd14db23fc14ec78 7560 autodep8_0.6.tar.xz
Checksums-Sha256:
 5016e0351f6ba5b2a787d0b804a921728b3f11ec7a1c978e2d5b02a431c78ab2 1668 autodep8_0.6.dsc
 195a998fc92a1fe203ee673c3dfb457c68349d9914d55d6b1365df6e09f8c548 7560 autodep8_0.6.tar.xz
Files:
 e2e7599468df35a051c5434417ba143e 1668 devel optional autodep8_0.6.dsc
 e91f9464d6f6b8ab7462af66268cb90c 7560 devel optional autodep8_0.6.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXSE7bAAoJEPwNsbvNRgveb6QP/1EZAkztvLj6kaznGuz2psHW
xnP8jeruu7JP/QvQHADv9bjooS4I/5FYjBfRFJtM9znYISDOs4/4JIHvf72niZMO
HIa07kM+fg+cLxQxL5mNKhcTq4JVUe6dsctw75jepVZeMMrC2SOVnTZZE9Ezk86E
aeRz6wOn/e8+NuinRDJZlbuff/Kmj/aX6HiAznkseRlgMnaCjdnyZ2RolbVeSJRr
BlWUVnfxLSfKB2o3SG4S+JDm2llHfWjGV19FwQtDpIXiyEtqwUoF/FVO217luRGa
vd8+Y3IuXHrnyq+ZBAq3b6UD/j8pupxDhXFyET55BLsBrUBxnsLDBNOA47fHmk39
2IuVzAkKa0pVLE+VXnE3zxa3yqInsWdsi/7Erydl3WIejy2rJaAngYbFNzriA12u
Iq7OKm52EvHvQnF4+zsb1Igmw37jIOsZrclgydlzZxa/AdK8btNV5vGuLIzShXul
Y1PL9Di1cQVpQQ8JQzmK9q/XiIiBvwgJJwieLnP8VAOYp34CfVeXohyUpRhI+4+B
q3pwRZ82p2YrFsQoP8i/YE+ee0xofSEz2IJVqp8sjHklTi3Xh/A0XS9Hv/6+0FIX
UuNwzPIgY0llt1tOD0DPSvY/Zr+ay0YQfp1XmmpRE5SevFB1I7bOK7G8p/+10vdY
qXvsI2cN7y9dhI8o8cjz
=iU0C
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.