Debian Bug report logs - #823879
allegro4.4: please make the build reproducible (locale)

version graph

Package: src:allegro4.4; Maintainer for src:allegro4.4 is Debian Games Team <pkg-games-devel@lists.alioth.debian.org>;

Reported by: Daniel Shahaf <danielsh@apache.org>

Date: Mon, 9 May 2016 23:42:01 UTC

Severity: wishlist

Tags: patch

Found in version allegro4.4/2:4.4.2-5

Fixed in version allegro4.4/2:4.4.2-8

Done: Andreas Rönnquist <gusnan@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to debian-bugs-dist@lists.debian.org, danielsh@apache.org, reproducible-builds@lists.alioth.debian.org, Debian Games Team <pkg-games-devel@lists.alioth.debian.org>:
Bug#823879; Package src:allegro4.4. (Mon, 09 May 2016 23:42:06 GMT) (full text, mbox, link).

Acknowledgement sent to Daniel Shahaf <danielsh@apache.org>:
New Bug report received and forwarded. Copy sent to danielsh@apache.org, reproducible-builds@lists.alioth.debian.org, Debian Games Team <pkg-games-devel@lists.alioth.debian.org>. (Mon, 09 May 2016 23:42:06 GMT) (full text, mbox, link).

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Daniel Shahaf <danielsh@apache.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: allegro4.4: please make the build reproducible (locale)
Date: Mon, 09 May 2016 23:38:57 +0000
Source: allegro4.4
Version: 2:4.4.2-5
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: locale

Hi!

While working on the “reproducible builds” effort [1], we have noticed
that allegro4.4 could not be built reproducibly [2]: the members of
examples/source.tar.gz are sorted in a locale-dependent manner.

The following patch sorts that tarball's members in a fixed
(locale-independent) order:

[[[
diff --git a/debian/rules b/debian/rules
index a9ba95b..c1f9880 100755
--- a/debian/rules
+++ b/debian/rules
@@ -58,7 +58,9 @@ override_dh_auto_install:
 # Create examples source tar.gz
 	rm -rf build/tmp; mkdir build/tmp
 	cp examples/*.c examples/*.h examples/*.dat examples/*.pcx examples/*.txt examples/*.ini tests/*.c build/tmp/
-	cd build/tmp; GZIP="-9n" tar zcvf source.tar.gz --mtime="$(BUILD_DATE)" --mode=go=rX,u+rw,a-s *
+	# Glob expansions are sorted in a locale-sensitive manner; set the
+	# locale to make the order reproducible.
+	cd build/tmp && (LC_ALL=C; export LC_ALL; GZIP="-9n" tar zcvf source.tar.gz --mtime="$(BUILD_DATE)" --mode=go=rX,u+rw,a-s *)
 	cp build/tmp/source.tar.gz $(CURDIR)/debian/tmp/$(DOC_EXAMPLES_DIR)
 
 override_dh_makeshlibs:
]]]

I believe this patch should make allegro4.4 fully reproducible.

Thanks,

Daniel

 [1]: https://wiki.debian.org/ReproducibleBuilds
 [2]: https://tests.reproducible-builds.org/dbdtxt/unstable/amd64/allegro4.4_4.4.2-7.diffoscope.txt

Reply sent to Andreas Rönnquist <gusnan@debian.org>:
You have taken responsibility. (Tue, 10 May 2016 17:51:37 GMT) (full text, mbox, link).

Notification sent to Daniel Shahaf <danielsh@apache.org>:
Bug acknowledged by developer. (Tue, 10 May 2016 17:51:37 GMT) (full text, mbox, link).

Message #10 received at 823879-close@bugs.debian.org (full text, mbox, reply):

From: Andreas Rönnquist <gusnan@debian.org>
To: 823879-close@bugs.debian.org
Subject: Bug#823879: fixed in allegro4.4 2:4.4.2-8
Date: Tue, 10 May 2016 17:48:59 +0000
Source: allegro4.4
Source-Version: 2:4.4.2-8

We believe that the bug you reported is fixed in the latest version of
allegro4.4, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 823879@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Rönnquist <gusnan@debian.org> (supplier of updated allegro4.4 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 10 May 2016 19:15:57 +0200
Source: allegro4.4
Binary: liballegro4.4 liballegro4-dev allegro4-doc liballeggl4.4 liballeggl4-dev libjpgalleg4.4 libjpgalleg4-dev libloadpng4.4 libloadpng4-dev liblogg4.4 liblogg4-dev
Architecture: source all amd64
Version: 2:4.4.2-8
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Andreas Rönnquist <gusnan@debian.org>
Description:
 allegro4-doc - documentation for the Allegro library
 liballeggl4-dev - development files for the allegrogl library
 liballeggl4.4 - library to mix OpenGL graphics with Allegro routines
 liballegro4-dev - development files for the Allegro library
 liballegro4.4 - portable library for cross-platform game and multimedia developme
 libjpgalleg4-dev - development files for the JPG loading addon for Allegro 4
 libjpgalleg4.4 - JPG loading addon for Allegro 4
 libloadpng4-dev - development files for the PNG loading addon for Allegro 4
 libloadpng4.4 - PNG loading addon for Allegro 4
 liblogg4-dev - development files for the OGG loading addon for Allegro 4
 liblogg4.4 - OGG loading addon for Allegro 4
Closes: 823879
Changes:
 allegro4.4 (2:4.4.2-8) unstable; urgency=medium
 .
   * Make build reproducible, fixing examples/source.tar.gz sorted
     locale-dependant (Closes: #823879)
   * Fix vcs-field-uses-insecure-url lintian warning
   * Update Standards-Version to 3.9.8 - no changes required
Checksums-Sha1:
 a02e9156f78eb62e6250a92621d922aeaa508a00 2794 allegro4.4_4.4.2-8.dsc
 af24343f5b1623c5d27863d29f1e2f857a7882de 57704 allegro4.4_4.4.2-8.debian.tar.xz
 500cc85a45d7448f302f16ed14d0c3eccde8ec66 1649758 allegro4-doc_4.4.2-8_all.deb
 1970670ce4af209ab3a70ec1e9a9f45b0c4f16b2 138852 liballeggl4-dev_4.4.2-8_amd64.deb
 fa73c4bb744bbf6bb6953bbcf83e19e62b6adcc5 279694 liballeggl4.4-dbgsym_4.4.2-8_amd64.deb
 d34e74dd59f09a3a377870e7d6c164d8201fc81c 190604 liballeggl4.4_4.4.2-8_amd64.deb
 03728fe25666c869046787ad8c0df7da101637c6 590724 liballegro4-dev-dbgsym_4.4.2-8_amd64.deb
 1d622b07060906f62db68aedf6023b32ee191b3c 288206 liballegro4-dev_4.4.2-8_amd64.deb
 2361512d3767327811005d0ce76525ac29b6a0ae 1056050 liballegro4.4-dbgsym_4.4.2-8_amd64.deb
 cf055acde8a56d83f552adc9269b4e0bfa789e6a 444296 liballegro4.4_4.4.2-8_amd64.deb
 a8cd1b95513ec29d6bace8293f288553fb1b3bea 83312 libjpgalleg4-dev_4.4.2-8_amd64.deb
 5094c58211c1518027a53980c966f230cbb97e46 59688 libjpgalleg4.4-dbgsym_4.4.2-8_amd64.deb
 d411f0523fc19e51c8f0c5e9bef4247ee3e172a3 106772 libjpgalleg4.4_4.4.2-8_amd64.deb
 615082fd0fd9ad2b3d97467cd9a2e2b84a066a69 83346 libloadpng4-dev_4.4.2-8_amd64.deb
 1b8d5a1600b0c0206ec1354b02c119ce49037c89 22670 libloadpng4.4-dbgsym_4.4.2-8_amd64.deb
 abb8a66252b582301ba28879ab6111d174c7bdde 87998 libloadpng4.4_4.4.2-8_amd64.deb
 155ad4a7f3bd67dfcc7b56238f750880d6647bf0 82802 liblogg4-dev_4.4.2-8_amd64.deb
 0a221cc15fea0efaefcc082cc8fc1bcf726d035b 13248 liblogg4.4-dbgsym_4.4.2-8_amd64.deb
 dc71c9c38d652443f6ead8270aad107ae22e5959 86164 liblogg4.4_4.4.2-8_amd64.deb
Checksums-Sha256:
 567e4348054a620c04730f3660c690622a1fa32cf507c75d04cdd808c0b80ebc 2794 allegro4.4_4.4.2-8.dsc
 16ea214909d6168ae3fac1fe2615cb3c9e3e328d7cf3237c951a62e15ba4588e 57704 allegro4.4_4.4.2-8.debian.tar.xz
 69eaed68ec8038b67ba5bf3abfd197023b4453834a1e85c08a3cfd020c2a4571 1649758 allegro4-doc_4.4.2-8_all.deb
 14fa5c7dcae653a3f2a827c18139d264ee708daf655f8d0101436b07381aca63 138852 liballeggl4-dev_4.4.2-8_amd64.deb
 34c28c9ef3bfb9689c1c39f909f00ae847f688019a28dce3d16f3e8de19765f8 279694 liballeggl4.4-dbgsym_4.4.2-8_amd64.deb
 0b4a9379e949207399448bb6bb3f83f5c9f64114f6604a4a1496b7e0f35ac91f 190604 liballeggl4.4_4.4.2-8_amd64.deb
 bd9ee8a0b105a5d37a1cc1768265fccf0672ffd4181d7e15a011ebbccf718ccc 590724 liballegro4-dev-dbgsym_4.4.2-8_amd64.deb
 505cefef71f865ab325d4d246d317a009fb06a9850ca3fcec51ba7239166ea49 288206 liballegro4-dev_4.4.2-8_amd64.deb
 b2d23e80b80bd1410dec61e23657183df2b6e8023e4b08fefc0a4dca0db531cb 1056050 liballegro4.4-dbgsym_4.4.2-8_amd64.deb
 d0612ab8943dc0d91f630094187bcf9bc341aa72a29b3153d4f72254dddd2c9f 444296 liballegro4.4_4.4.2-8_amd64.deb
 0c9796e2ba1e53534fad33317275f6ec1bb0bc40a4d6b7b6d34852dda0e6aefe 83312 libjpgalleg4-dev_4.4.2-8_amd64.deb
 346b831abc9734395915f508cc770b39f496951e1809ef1973715b27703ee913 59688 libjpgalleg4.4-dbgsym_4.4.2-8_amd64.deb
 90e6414aa29013a1e7180d4d739f7dc1f1aba1876627054d69bc19ca32aa5871 106772 libjpgalleg4.4_4.4.2-8_amd64.deb
 d554ad1758f8f84b7cb98a712391c9be09e26816a5f01ba89b8be8984e1dd8cf 83346 libloadpng4-dev_4.4.2-8_amd64.deb
 c7c34eb9f907ad01b88e97b9b7eea1fd4c42bbfbd97281f8fac34da160bdb4b2 22670 libloadpng4.4-dbgsym_4.4.2-8_amd64.deb
 46cb48c058b9039cf5f53c2a4df5a32545af25597068cda321a7b7050a7f39da 87998 libloadpng4.4_4.4.2-8_amd64.deb
 e53fd1901eb9f8c4599cfd14b2f18fcb1151180e2660cdb28f4052250c3d531a 82802 liblogg4-dev_4.4.2-8_amd64.deb
 a64fa5dc109ca4930c6a4a641ef65fef15eb4d228552eacb11aa5c8f3dbd8682 13248 liblogg4.4-dbgsym_4.4.2-8_amd64.deb
 ccc3253bfa26d601364c13b7069f35140cc3e70f634c46b43deafb8c0c62a5e1 86164 liblogg4.4_4.4.2-8_amd64.deb
Files:
 0962c21949b53daff161771e0ddba4d5 2794 devel optional allegro4.4_4.4.2-8.dsc
 77025336c0c81077a9a8c8e148a0b4b2 57704 devel optional allegro4.4_4.4.2-8.debian.tar.xz
 43ef5f33904e9391eabbb6a87ff9ae8e 1649758 doc optional allegro4-doc_4.4.2-8_all.deb
 313d6b09d054cdacd9d77ac9387efe61 138852 libdevel extra liballeggl4-dev_4.4.2-8_amd64.deb
 ac15a42c75cba7421aa8fd9a620dd943 279694 debug extra liballeggl4.4-dbgsym_4.4.2-8_amd64.deb
 d530eb7aa9cee692bcc60409c92fe37a 190604 libs optional liballeggl4.4_4.4.2-8_amd64.deb
 b92ffe4483fc2699b16266453f8ad80d 590724 debug extra liballegro4-dev-dbgsym_4.4.2-8_amd64.deb
 9d3a678532062353c699e8f841a02336 288206 libdevel extra liballegro4-dev_4.4.2-8_amd64.deb
 f2245ea10b43ad956844ec9d4533cfeb 1056050 debug extra liballegro4.4-dbgsym_4.4.2-8_amd64.deb
 75afc91ff9ddeceab3b9a53275d1429f 444296 libs optional liballegro4.4_4.4.2-8_amd64.deb
 c791bc941e68f80918648bfb30a3b3fa 83312 libdevel extra libjpgalleg4-dev_4.4.2-8_amd64.deb
 0ce09ce88d8bc11004ecf9fbef897c4b 59688 debug extra libjpgalleg4.4-dbgsym_4.4.2-8_amd64.deb
 49e3344deb18d4ed898604a2a0c1809d 106772 libs optional libjpgalleg4.4_4.4.2-8_amd64.deb
 8b3e964aa71349b2a91c7cb763416f5e 83346 libdevel extra libloadpng4-dev_4.4.2-8_amd64.deb
 c579cfcbf8ff336859b57f15b224bfd4 22670 debug extra libloadpng4.4-dbgsym_4.4.2-8_amd64.deb
 fad0fed7a89019ac288573b017cd607c 87998 libs optional libloadpng4.4_4.4.2-8_amd64.deb
 9a6fd955b2ba5d1e264446a94e5867e4 82802 libdevel extra liblogg4-dev_4.4.2-8_amd64.deb
 4a243f5791d71789e92e7f9d2ac05e9c 13248 debug extra liblogg4.4-dbgsym_4.4.2-8_amd64.deb
 cb736b6a411a60cbbc58f4f458e8e40e 86164 libs optional liblogg4.4_4.4.2-8_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXMhinAAoJEBlLYxqy2iiIFJEP/2Kp0TOMKO/W8MMdLncBSkcJ
5X4XHfSL/u5LmBSE2/6VVFzdqDUtHcapND5oYl2aSuZ1Ymq6RA5pKm3DABOIDV9c
o379GYPvlGzyTp8Lh6yucNF78mQPmbMM5TAAi3Q2xYCdXFEdWh8Eys7cvPgr93Cq
whVtAsxkcN+IXaHPp+75Wac39cwvqyCLo72xPz7cweN0LHzpItzD4eJtGKOPkVyT
O8CF0ldT2t5iXUe0RR1bOwIAvs8FGQfmTQW+5jRMB6Mzp8TiGKENVhbTZEDxo8e7
4Wux3Jd+dodo4qXd+4cAAKyFAShSotF3QCczRYAdH/bcqc7hXFkMJcTLffZMYvQn
EBf9kzqQNiXCq4dYHTls8jfAKQpPPm0Awlz2zOcKGQZiP15Lq2hv+HzBr9YrmNmp
SLw56aNHAAzujVtr3MfBAfx61geQKpU/oa89cagMlIzeCVHwxDNQSPtSzznmdPvi
/4EbAOkR5rbvxBfM3Ge6Au3Zop5v27n+RfQ3Jh2fU0IkQyyLcwbpI1RJDBEu1TQh
gONm2msEaLzWRqRy9kzPVXcREjXYYB5gkc3oO9q7SuQFbTFZiHUi9ZRyNNjO65E7
Lgq8lLea6Kz9Iz2zVm5sJXsjNqNOpjO2hmXz8EIjBtOz+dGtrvqCm+FtgHNT9lRW
Bc3dBFKvkomJY/y+hhkA
=Cry2
-----END PGP SIGNATURE-----

Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 13 Jun 2016 07:36:10 GMT) (full text, mbox, link).

Send a report that this bug log contains spam.

Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 13:50:58 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.