Debian Bug report logs - #823616
fpga-icestorm-chipdb: please make the build reproducible (randomness)

[Message part 1 (text/plain, inline)]
Source: fpga-icestorm
Version: 0~20160218gitf2b2549-1
Severity: wishlist
Tags: upstream patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness

Dear Maintainer,

While working on the “reproducible builds” effort [1], we have noticed
that fpga-icestorm-chipdb could not be built reproducibly: the order of
".pins" sections in chipdb-1k.txt and chipdb-8k.txt is random [2].

The attached patch ensures a stable section order in those two files.
I believe with this patch, fpga-icestorm will be fully reproducible.

Best,

Daniel

 [1]: https://wiki.debian.org/ReproducibleBuilds
 [2]: https://tests.reproducible-builds.org/rb-pkg/unstable/amd64/fpga-icestorm.html

[fpga-icestorm-reproducible.patch (text/x-diff, attachment)]
Source: fpga-icestorm
Source-Version: 0~20160218gitf2b2549-2

We believe that the bug you reported is fixed in the latest version of
fpga-icestorm, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 823616@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ruben Undheim <ruben.undheim@gmail.com> (supplier of updated fpga-icestorm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 06 May 2016 20:45:23 +0200
Source: fpga-icestorm
Binary: fpga-icestorm-chipdb fpga-icestorm
Architecture: source
Version: 0~20160218gitf2b2549-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Maintainers <debian-science-maintainers@lists.alioth.debian.org>
Changed-By: Ruben Undheim <ruben.undheim@gmail.com>
Description:
 fpga-icestorm - Tools to handle the bitstream format of Lattice iCE40 FPGAs
 fpga-icestorm-chipdb - Chip database files for fpga-icestorm
Closes: 823616
Changes:
 fpga-icestorm (0~20160218gitf2b2549-2) unstable; urgency=medium
 .
   [ Daniel Shahaf ]
   * Fixed reproducibility (Closes: 823616) - thanks for the patch!
 .
   [ Ruben Undheim ]
   * debian/control:
     - Updated Standards version to 3.9.8 - no changes
Checksums-Sha1:
 5dd73d455cd16eb42a308d9d5b3a6f78fd10750b 2226 fpga-icestorm_0~20160218gitf2b2549-2.dsc
 6c4cf8c39ebd96c3a00213674dcba25fc0ba09cc 8460 fpga-icestorm_0~20160218gitf2b2549-2.debian.tar.xz
Checksums-Sha256:
 86cc91f8c41657085b99cf7fe180b8402ac1bf9ffecc3a3b6ab4d902eb8c4c09 2226 fpga-icestorm_0~20160218gitf2b2549-2.dsc
 318fe66e9d1aa1b56142b29564cebbc0aeb232fb6f5775f0aa7ffcaa364feca8 8460 fpga-icestorm_0~20160218gitf2b2549-2.debian.tar.xz
Files:
 7f9e4fe1813f3a8793585fbc2ba1368b 2226 electronics optional fpga-icestorm_0~20160218gitf2b2549-2.dsc
 2b4b91fe3b9eb58c03a0c7a8e5b43f6b 8460 electronics optional fpga-icestorm_0~20160218gitf2b2549-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJXLOZ3AAoJEPxqH2TRCNERcw4P/A6DEWFUAfRqzZ76HKpjepe9
cYv60AI5NT5vT98wqh8O13ASUy7yffIksREiEMYa42w3cyUv0VzSi3ZUDUd6+O7Q
ak4tphgBcqtyh+vNTeDyBqzkUpxwGymq4mlFM1Ov/KslscChjh+RnaSYx6CrDLWv
ayvAkVrvTRb0oqTZpiryfKIvivjV6E8a5+eG7numaD7SZmMby8rq0LMiPScMRS0U
mvEipOAwXKiBMotkjw+lw6n2ina8SmG4glbL5x2OjlVgleEEHOKwAPpt7OVeoFl4
WrnJoU8smpMzd9GFaTD1rFrMAHF/4kgxVDfL7JzrjUnv/Jnj6vQm1n+F/uLcwcju
a53Mvu3K1nxFWel+WTVTUEa7PQsP/8mde+POM6yAIqkjlkTQ5A0HytgP1KcuzkW6
NKBfOFl6/1pQ4lnnVNfeFDMnBCYqa2riM5WRuIS7+FEy4gNvWBJa1AiKH+w46w7M
95DUJJIiAQRBa9C6dETi6+hT1qlt425qg0cYQ2Mcz4NOVzkdNE2PZiC1bpf0uDZz
4XpWSTCt/pYe+jIjvzGShdPMEUahbCzI5MyAuyKH6aRhdLBgrROztbjmu9eW1oex
zEK2FjXc7Wj08NcblRadWtWDFCkML4LJa78tkG0aDltzcs64i9tRL50iugdB9KmX
4j5xcyFdHSicfj5okIpk
=DjBM
-----END PGP SIGNATURE-----

Hi Daniel,

Thanks a lot for figuring out why it wasn't reproducible. I wasn't sure where to start.

I will apply your patch.

Cheers!
Ruben

On Fri, May 06, 2016 at 05:08:10PM +0000, Daniel Shahaf wrote:
> Source: fpga-icestorm
> Version: 0~20160218gitf2b2549-1
> Severity: wishlist
> Tags: upstream patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: randomness
> 
> Dear Maintainer,
> 
> While working on the “reproducible builds” effort [1], we have noticed
> that fpga-icestorm-chipdb could not be built reproducibly: the order of
> ".pins" sections in chipdb-1k.txt and chipdb-8k.txt is random [2].
> 
> The attached patch ensures a stable section order in those two files.
> I believe with this patch, fpga-icestorm will be fully reproducible.
> 
> Best,
> 
> Daniel
> 
>  [1]: https://wiki.debian.org/ReproducibleBuilds
>  [2]: https://tests.reproducible-builds.org/rb-pkg/unstable/amd64/fpga-icestorm.html

> diff --git a/debian/patches/reproducible.patch b/debian/patches/reproducible.patch
> new file mode 100644
> index 0000000..43779cb
> --- /dev/null
> +++ b/debian/patches/reproducible.patch
> @@ -0,0 +1,17 @@
> +Description: make the build reproducible
> +Author: Daniel Shahaf <danielsh@apache.org>
> +Bug-Debian: https://bugs.debian.org/-1
> +Last-Update: 2016-05-06
> +
> +--- fpga-icestorm-0~20160218gitf2b2549.orig/icebox/icebox_chipdb.py
> ++++ fpga-icestorm-0~20160218gitf2b2549/icebox/icebox_chipdb.py
> +@@ -172,7 +172,7 @@ all_group_segments = ic.group_segments(a
> + print(".device %s %d %d %d" % (ic.device, ic.max_x+1, ic.max_y+1, len(all_group_segments)))
> + print()
> + 
> +-for key in list(icebox.pinloc_db.keys()):
> ++for key in sorted(icebox.pinloc_db.keys()):
> +     key_dev, key_package = key.split("-")
> +     if key_dev == ic.device:
> +         print(".pins %s" % (key_package))
> +
> diff --git a/debian/patches/series b/debian/patches/series
> index 0353649..e512c55 100644
> --- a/debian/patches/series
> +++ b/debian/patches/series
> @@ -3,3 +3,4 @@
>  03_cxxflags.patch
>  override-CXX.patch
>  fix_spelling_in_binaries.patch
> +reproducible.patch

> -- 
> debian-science-maintainers mailing list
> debian-science-maintainers@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-science-maintainers

Debian Bug report logs - #823616 fpga-icestorm-chipdb: please make the build reproducible (randomness)

Debian Bug report logs - #823616
fpga-icestorm-chipdb: please make the build reproducible (randomness)