Debian Bug report logs - #822566
stk: please make the build reproducible (fileordering)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Alexis Bienvenüe <pado@passoire.fr>

To: submit@bugs.debian.org

Subject: stk: please make the build reproducible (fileordering)

Date: Mon, 25 Apr 2016 15:11:46 +0200

[Message part 1 (text/plain, inline)]

Source: stk
Version: 4.5.0-3
Severity: wishlist
Tags: patch upstream
User: reproducible-builds@lists.alioth.debian.org
Usertags: fileordering
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Dear Maintainer,

While working on the “reproducible builds” effort [1], we have noticed
that 'stk' could not be built reproducibly.

The attached patch fixes the order in which *.o files are merged. Once
applied, stk can be built reproducibly in our current experimental
framework.

Regards,
Alexis Bienvenüe.

 [1]: https://wiki.debian.org/ReproducibleBuilds

[stk_4.5.0-3_reproducible.diff (text/x-patch, attachment)]

Message #10 received at 822566@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: Alexis Bienvenüe <pado@passoire.fr>, 822566@bugs.debian.org

Subject: Re: Bug#822566: stk: please make the build reproducible (fileordering)

Date: Mon, 25 Apr 2016 10:32:31 -0300

Hi,

On 25 April 2016 at 10:11, Alexis Bienvenüe <pado@passoire.fr> wrote:
> Source: stk
> Version: 4.5.0-3
> Severity: wishlist
> Tags: patch upstream
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: fileordering
> X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org
>
> Dear Maintainer,
>
> While working on the “reproducible builds” effort [1], we have noticed
> that 'stk' could not be built reproducibly.
>
> The attached patch fixes the order in which *.o files are merged. Once
> applied, stk can be built reproducibly in our current experimental
> framework.

Thanks, but couldn't this be simpler by using the already-defined
variable $(OBJECTS)? Does using that fix the problem?

-- 

Saludos,
Felipe Sateler

Message #15 received at 822566@bugs.debian.org (full text, mbox, reply):

From: Alexis Bienvenüe <pado@passoire.fr>

To: Felipe Sateler <fsateler@debian.org>, 822566@bugs.debian.org

Subject: Re: Bug#822566: stk: please make the build reproducible (fileordering)

Date: Mon, 25 Apr 2016 16:13:23 +0200

Hi.

Le 25/04/2016 15:32, Felipe Sateler a écrit :
> Thanks, but couldn't this be simpler by using the already-defined
> variable $(OBJECTS)? Does using that fix the problem?

I agree that would be better, but it does not seem to be the same: eg.
Generator.o is in src/Makefile.in's $(OBJECTS) but is _not_ built
because there is no Generator.cpp, so it is not included in *.o

Regards,
Alexis Bienvenüe.

Message #20 received at 822566@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: Alexis Bienvenüe <pado@passoire.fr>

Cc: 822566@bugs.debian.org

Subject: Re: Bug#822566: stk: please make the build reproducible (fileordering)

Date: Mon, 25 Apr 2016 13:09:24 -0300

[Message part 1 (text/plain, inline)]

On 25 Apr 2016 11:13, "Alexis Bienvenüe" <pado@passoire.fr> wrote:
>
> Hi.
>
> Le 25/04/2016 15:32, Felipe Sateler a écrit :
> > Thanks, but couldn't this be simpler by using the already-defined
> > variable $(OBJECTS)? Does using that fix the problem?
>
> I agree that would be better, but it does not seem to be the same: eg.
> Generator.o is in src/Makefile.in's $(OBJECTS) but is _not_ built
> because there is no Generator.cpp, so it is not included in *.o

Ok, so the upstream makefile would need work. Thanks, I will discuss with
upstream, if the required change cannot be done relatively soon, I will
apply your patch.

Saludos

[Message part 2 (text/html, inline)]

Message #25 received at 822566-submitter@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: 822566-submitter@bugs.debian.org

Subject: Bug#822566 marked as pending

Date: Thu, 12 May 2016 03:11:49 +0000

tag 822566 pending
thanks

Hello,

Bug #822566 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:

    http://git.debian.org/?p=pkg-multimedia/stk.git;a=commitdiff;h=45c1ce8

---
commit 45c1ce83400a6d012ed9ab7ffe37b1d289c65978
Author: Felipe Sateler <fsateler@debian.org>
Date:   Thu May 12 00:09:24 2016 -0300

    Release to unstable

diff --git a/debian/changelog b/debian/changelog
index b704d95..217cf59 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,16 @@
+stk (4.5.2+dfsg-2) unstable; urgency=medium
+
+  [ Felipe Sateler ]
+  * Do not remove Rt{Audio,Midi}, they are not installed anymore
+  * Bump standards version
+  * Only build demo program when realtime is enabled (Closes: #815509)
+  * Remove stale files on clean
+
+  [ Alexis Bienvenüe ]
+  * Fix order of .o files (Closes: #822566)
+
+ -- Felipe Sateler <fsateler@debian.org>  Thu, 12 May 2016 00:09:16 -0300
+
 stk (4.5.2+dfsg-1) unstable; urgency=medium
 
   * New upstream release

Message #30 received at 822566-close@bugs.debian.org (full text, mbox, reply):

From: Felipe Sateler <fsateler@debian.org>

To: 822566-close@bugs.debian.org

Subject: Bug#822566: fixed in stk 4.5.2+dfsg-2

Date: Thu, 12 May 2016 04:15:05 +0000

Source: stk
Source-Version: 4.5.2+dfsg-2

We believe that the bug you reported is fixed in the latest version of
stk, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 822566@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Felipe Sateler <fsateler@debian.org> (supplier of updated stk package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 12 May 2016 00:09:16 -0300
Source: stk
Binary: libstk0-dev libstk-4.5.0 stk stk-doc
Architecture: source
Version: 4.5.2+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers@lists.alioth.debian.org>
Changed-By: Felipe Sateler <fsateler@debian.org>
Description:
 libstk-4.5.0 - Sound Synthesis Toolkit
 libstk0-dev - Sound Synthesis Toolkit (development files)
 stk        - Sound Synthesis Toolkit (example applications)
 stk-doc    - Sound Synthesis Toolkit (documentation)
Closes: 815509 822566
Changes:
 stk (4.5.2+dfsg-2) unstable; urgency=medium
 .
   [ Felipe Sateler ]
   * Do not remove Rt{Audio,Midi}, they are not installed anymore
   * Bump standards version
   * Only build demo program when realtime is enabled (Closes: #815509)
   * Remove stale files on clean
 .
   [ Alexis Bienvenüe ]
   * Fix order of .o files (Closes: #822566)
Checksums-Sha1:
 b055d7d8a4623a438196c37186d470963b4941c2 2351 stk_4.5.2+dfsg-2.dsc
 b3f09cbdae2ffdb18615f05e04d82741790fffb1 14528 stk_4.5.2+dfsg-2.debian.tar.xz
Checksums-Sha256:
 c25e1d95122490e91a736a8e317a846684174cf9d854698a624d9ab2fb11d082 2351 stk_4.5.2+dfsg-2.dsc
 38da867d85b7720581dc960da09f18ac3498102c5b572b013010d35b39896d37 14528 stk_4.5.2+dfsg-2.debian.tar.xz
Files:
 62fdef211f6ab890259d608059b3896f 2351 sound optional stk_4.5.2+dfsg-2.dsc
 f8a20a962afe3122d4f7dc07a5b33ae3 14528 sound optional stk_4.5.2+dfsg-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXM/RMAAoJEKO6uuJAjdbPAhgP/3OEXlSg657WOil8DjQ6kB5G
74Sjuw+G05Brhbw3NGuvi/cmh5BlbyGaywz7a9HSlLsxFNAz0GFAZH5G+zkSHA2d
oQv4rj1R2YBsk4CO527dADLie8t7CZ8DWYf2b3vmodA35thEScYwDLZYMB/COn0O
suPs9/NcD+aRhzdbQ8/knEIiSzoOajPkwF5gL+8fXMv/A9qz2cLKUiEIRuoKRF73
DyRsNptPLuJzKhj8+ZwsACGpNUeWzV0HQLBSbnUoa0j3XXhObRQsF/dosUxt3WXG
3uZP/GBFGKRW5c4m+jZxaYZZX3xLLlbGUtq4vg1qNRMPLHRdcJZ4hybl6KPkFRJS
0BkSPHkiatjmfsDV7y9a2IjySQS+2hh3Dz0ZbqlONAm+CcXrxoIYe8CcHOi2HcRG
3+zrgc1AUdJBFEOxigMOkQL33A6RCgECfvmbtgI3GeLnaJOGZpT2t4PG3V1yTXR4
KKa9epNMHH/1Ft2U4Oz9PKLRq34GyshpJFwe/Z//sV1QSjWJn4lIU9z641T0ML9n
BjwyveocZeP+YJ6OHVg+/78aYnDTmqeM2hkvwzyWOOIXUv0d2fQRoiaqEQOH2yip
yml081RTKzj4rfptO/PatR4YnU3Tyjq8pU/XDKF5FTgOo+t2ZrCiUOsf0uyPrhS1
kVhlSpXHPjBTmcEWXFHh
=t2Mr
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.