Debian Bug report logs - #822210
sdl2-config.cmake: extra leading / trailing whitespace

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Jason Pleau <jason@jpleau.ca>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: sdl2-config.cmake: extra leading / trailing whitespace

Date: Thu, 21 Apr 2016 21:36:19 -0400

Package: libsdl2-dev
Version: 2.0.4+dfsg1-2+b1
Severity: normal

Dear Maintainer,

When trying to use SDL2 in a small project with CMake, I encountered the
following error:

CMake Error at CMakeLists.txt:18 (add_executable):
  Target "run" links to item "-L/usr/lib/x86_64-linux-gnu -lSDL2 " which has
  leading or trailing whitespace.  This is now an error according to policy
  CMP0004.


This is the relevant part of my own CMakeLists.txt (line 18):

------------------------------

find_package(SDL2 REQUIRED)

------------------------------


The offending line is in /usr/lib/x86_64-linux-gnu/cmake/SDL2/sdl2-config.cmake
(could be different depending on the arch used)

Line #10:

------------------------------------------------------

set(SDL2_LIBRARIES "-L${SDL2_LIBDIR}  -lSDL2 ")

------------------------------------------------------

Removing the trailing whitespace after -lSDL2 fixes the issue for me. (There's
also an extra leading whitespace before -lSDL2)

I am not certain how to fix this properly in the sdl2-config.cmake.in file,
otherwise I would have provided a patch.

For the info, the version of CMake I am running: 3.5.1-1

Thanks !



-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.5.2-jpleau (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libsdl2-dev depends on:
ii  libasound2-dev     1.1.0-1
ii  libdbus-1-dev      1.10.8-1
ii  libegl1-mesa-dev   11.1.3-1
ii  libgl1-mesa-dev    11.1.3-1
ii  libgles2-mesa-dev  11.1.3-1
ii  libglu1-mesa-dev   9.0.0-2.1
ii  libpulse-dev       8.0-2+b2
ii  libsdl2-2.0-0      2.0.4+dfsg1-2+b1
ii  libsndio-dev       1.1.0-2
ii  libudev-dev        229-4
ii  libwayland-dev     1.10.0-2
ii  libx11-dev         2:1.6.3-1
ii  libxcursor-dev     1:1.1.14-1+b1
ii  libxext-dev        2:1.3.3-1
ii  libxi-dev          2:1.7.6-1
ii  libxinerama-dev    2:1.1.3-1+b1
ii  libxkbcommon-dev   0.5.0-1
ii  libxrandr-dev      2:1.5.0-1
ii  libxss-dev         1:1.2.2-1
ii  libxt-dev          1:1.1.5-1
ii  libxv-dev          2:1.0.10-1+b1
ii  libxxf86vm-dev     1:1.1.4-1

libsdl2-dev recommends no packages.

libsdl2-dev suggests no packages.

-- no debconf information

Message #10 received at 822210@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: 822210@bugs.debian.org

Subject: Re: sdl2-config.cmake: extra leading / trailing whitespace

Date: Fri, 22 Apr 2016 14:23:53 +0200

[Message part 1 (text/plain, inline)]

Hi,
> set(SDL2_LIBRARIES "-L${SDL2_LIBDIR}  -lSDL2 ")

I know where that space comes from:

quoting configure.in

SDL_LIBS="-lSDL2 $BASE_LDFLAGS"


changing to 
SDL_LIBS="-lSDL2$BASE_LDFLAGS"

fixes the issue, because in our case BASE_LDFLAGS is undefined.

I'm not sure why the cmake build is not even creating it, and I'm not sure how
to best fix the issue.

I think a patch would be welcome, so the maintainers can apply it if needed :)

thanks for the bug report,

Gianfranco

[signature.asc (application/pgp-signature, attachment)]

Message #15 received at 822210@bugs.debian.org (full text, mbox, reply):

From: Jason Pleau <jason@jpleau.ca>

To: 822210@bugs.debian.org, locutusofborg@debian.org

Subject: Re: sdl2-config.cmake: extra leading / trailing whitespace

Date: Sun, 24 Apr 2016 13:22:21 -0400

[Message part 1 (text/plain, inline)]

Hi Gianfranco,

On Fri, 22 Apr 2016 14:23:53 +0200 Gianfranco Costamagna
<locutusofborg@debian.org> wrote:
> Hi,
> > set(SDL2_LIBRARIES "-L${SDL2_LIBDIR}  -lSDL2 ")
> 
> I know where that space comes from:
> 
> quoting configure.in
> 
> SDL_LIBS="-lSDL2 $BASE_LDFLAGS"
> 
> 
> changing to 
> SDL_LIBS="-lSDL2$BASE_LDFLAGS"
> 
> fixes the issue, because in our case BASE_LDFLAGS is undefined.
> 
> I'm not sure why the cmake build is not even creating it, and I'm not sure how
> to best fix the issue.
> 
> I think a patch would be welcome, so the maintainers can apply it if needed :)

I attached a patch, would something like this be an acceptable solution
? If yes I think we should forward upstream

> 
> thanks for the bug report,
> 
> Gianfranco
> 

-- 
Jason Pleau

[0001-patch-to-remove-trailing-whitespace-in-sdl2-config.c.patch (text/x-patch, attachment)]

Message #20 received at 822210@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: Jason Pleau <jason@jpleau.ca>, "822210@bugs.debian.org" <822210@bugs.debian.org>, Manuel Montecelo <mafm@debian.org>, <icculus@icculus.org>, Sam Lantinga <slouken@gmail.com>

Subject: Re: sdl2-config.cmake: extra leading / trailing whitespace

Date: Wed, 27 Apr 2016 13:08:34 +0000 (UTC)

Hi Manuel and libsdl2 developers!


How do you feel about the patch below?
I think we should apply it, to avoid cmake breakages in linux systems.

thanks for considering it,

--- a/configure.in
+++ b/configure.in
@@ -97,7 +97,7 @@
 
 if test x$have_no_cygwin = xyes; then
 BASE_CFLAGS="-mno-cygwin"
-            BASE_LDFLAGS="-mno-cygwin"
+            BASE_LDFLAGS=" -mno-cygwin"
 fi
 BASE_CFLAGS="$BASE_CFLAGS -I/usr/include/mingw"
 ;;
@@ -123,7 +123,7 @@
 #    fi
 #done
 SDL_CFLAGS="$BASE_CFLAGS"
-SDL_LIBS="-lSDL2 $BASE_LDFLAGS"
+SDL_LIBS="-lSDL2$BASE_LDFLAGS"
 CPPFLAGS="$CPPFLAGS $EXTRA_CFLAGS"
 CFLAGS="$CFLAGS $EXTRA_CFLAGS"
 LDFLAGS="$LDFLAGS $EXTRA_LDFLAGS"

(probably also BASE_CFLAGS needs some similar patching)

cheers,


Gianfranco


Il Domenica 24 Aprile 2016 19:22, Jason Pleau <jason@jpleau.ca> ha scritto:
Hi Gianfranco,

On Fri, 22 Apr 2016 14:23:53 +0200 Gianfranco Costamagna
<locutusofborg@debian.org> wrote:
> Hi,
> > set(SDL2_LIBRARIES "-L${SDL2_LIBDIR}  -lSDL2 ")
> 
> I know where that space comes from:
> 
> quoting configure.in
> 
> SDL_LIBS="-lSDL2 $BASE_LDFLAGS"
> 
> 
> changing to 
> SDL_LIBS="-lSDL2$BASE_LDFLAGS"
> 
> fixes the issue, because in our case BASE_LDFLAGS is undefined.
> 
> I'm not sure why the cmake build is not even creating it, and I'm not sure how
> to best fix the issue.
> 
> I think a patch would be welcome, so the maintainers can apply it if needed :)

I attached a patch, would something like this be an acceptable solution
? If yes I think we should forward upstream

> 
> thanks for the bug report,
> 
> Gianfranco
> 

-- 
Jason Pleau

Message #25 received at 822210@bugs.debian.org (full text, mbox, reply):

From: "Manuel A. Fernandez Montecelo" <manuel.montezelo@gmail.com>

To: Gianfranco Costamagna <locutusofborg@debian.org>

Cc: Jason Pleau <jason@jpleau.ca>, "822210@bugs.debian.org" <822210@bugs.debian.org>, Ryan Gordon <icculus@icculus.org>, Sam Lantinga <slouken@gmail.com>

Subject: Re: sdl2-config.cmake: extra leading / trailing whitespace

Date: Wed, 27 Apr 2016 22:41:34 +0100

Hi,

2016-04-27 14:08 GMT+01:00 Gianfranco Costamagna <locutusofborg@debian.org>:
> Hi Manuel and libsdl2 developers!
>
>
> How do you feel about the patch below?
> I think we should apply it, to avoid cmake breakages in linux systems.

It looks a bit odd to have to play with whitespace in this way.

I'm fine with it in general, though; but since this is not Debian
specific I prefer if it's applied (or at least blessed) by upstream
first.  If it's failing for Jason, it should affect more people using
other distros or the code directly from SDL repos.


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo@gmail.com>

Message #30 received at 822210@bugs.debian.org (full text, mbox, reply):

From: "Manuel A. Fernandez Montecelo" <manuel.montezelo@gmail.com>

To: Gianfranco Costamagna <locutusofborg@debian.org>

Cc: Jason Pleau <jason@jpleau.ca>, "822210@bugs.debian.org" <822210@bugs.debian.org>, Ryan Gordon <icculus@icculus.org>, Sam Lantinga <slouken@gmail.com>

Subject: Re: sdl2-config.cmake: extra leading / trailing whitespace

Date: Fri, 29 Apr 2016 11:44:45 +0100

[Message part 1 (text/plain, inline)]

Control: forwarded -1 https://bugzilla.libsdl.org/show_bug.cgi?id=3295


2016-04-27 22:41 GMT+01:00 Manuel A. Fernandez Montecelo
<manuel.montezelo@gmail.com>:
> Hi,
>
> 2016-04-27 14:08 GMT+01:00 Gianfranco Costamagna <locutusofborg@debian.org>:
>> Hi Manuel and libsdl2 developers!
>>
>>
>> How do you feel about the patch below?
>> I think we should apply it, to avoid cmake breakages in linux systems.
>
> It looks a bit odd to have to play with whitespace in this way.
>
> I'm fine with it in general, though; but since this is not Debian
> specific I prefer if it's applied (or at least blessed) by upstream
> first.  If it's failing for Jason, it should affect more people using
> other distros or the code directly from SDL repos.

This has been reported in upstream's bugzilla already (by somebody
else), with no fixes so far -- setting "forwarded" accordingly to
track the evolution upstream.


At a first glance, it looks very odd for cmake to be so fussy about
whitespace, but I guess that they have a good reason.

I've been looking into it and a more definitive/robust fix could be to
trim the strings coming from configure, so the same problem is avoided
in other systems or in future changes to other variables.  (Patch
attached).

Since "string(STRIP input output)" does not return the stripped
string, instead of using the string() function in the same spot where
the original variable is used, one has to use an "output variable" and
then use the variable as substitute in the original command.

So the result looks a bit ugly and duplicates the number of lines, and
everything is a bit cumbersome, but I think that it works.

Jason, if you want to test it to see if it works fine, then I can
submit both to upstream's bug report for them to decide.

(If anybody wants to use the attached patch as a basis for better
patches, feel free to do it.  Also anybody feel free to submit the
patches upstream, but better if tested first).


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo@gmail.com>

[sdl2-config.cmake.in (application/octet-stream, attachment)]

Message #37 received at 822210@bugs.debian.org (full text, mbox, reply):

From: Jason Pleau <jason@jpleau.ca>

To: "Manuel A. Fernandez Montecelo" <manuel.montezelo@gmail.com>, 822210@bugs.debian.org, Gianfranco Costamagna <locutusofborg@debian.org>

Subject: Re: Bug#822210: sdl2-config.cmake: extra leading / trailing whitespace

Date: Fri, 29 Apr 2016 21:35:57 -0400

[Message part 1 (text/plain, inline)]

Hi (removed the SDL maintainers/developers from this email, don't want
to spam..)

On 04/29/2016 06:44 AM, Manuel A. Fernandez Montecelo wrote:

... [snip] ...

> 
> At a first glance, it looks very odd for cmake to be so fussy about
> whitespace, but I guess that they have a good reason.
> 
> I've been looking into it and a more definitive/robust fix could be to
> trim the strings coming from configure, so the same problem is avoided
> in other systems or in future changes to other variables.  (Patch
> attached).
> 
> Since "string(STRIP input output)" does not return the stripped
> string, instead of using the string() function in the same spot where
> the original variable is used, one has to use an "output variable" and
> then use the variable as substitute in the original command.
> 
> So the result looks a bit ugly and duplicates the number of lines, and
> everything is a bit cumbersome, but I think that it works.
> 
> Jason, if you want to test it to see if it works fine, then I can
> submit both to upstream's bug report for them to decide.

It looks like ${prefix} is not set when defining ${stripped_prefix}. So
for example SDL2_INCLUDE_DIRS is set to /include/SDL2.

I got it to work with the following:

# sdl2 cmake project-config input for ./configure scripts

string(STRIP "@prefix@" prefix)
string(STRIP "@exec_prefix@" stripped_exec_prefix)
string(STRIP "@libdir@" stripped_libdir)
string(STRIP "@includedir@" stripped_includedir)
string(STRIP "-L${SDL2_LIBDIR} @SDL_RLD_FLAGS@ @SDL_LIBS@"
stripped_SDL2_LIBRARIES)

set(exec_prefix "${stripped_exec_prefix}")
set(libdir "${stripped_libdir}")
set(SDL2_PREFIX "${stripped_prefix}")
set(SDL2_EXEC_PREFIX "${stripped_prefix}")
set(SDL2_LIBDIR "${stripped_libdir}")
set(SDL2_INCLUDE_DIRS "${stripped_includedir}/SDL2")
set(SDL2_LIBRARIES "${stripped_SDL2_LIBRARIES}")


(patch format attached)


> 
> (If anybody wants to use the attached patch as a basis for better
> patches, feel free to do it.  Also anybody feel free to submit the
> patches upstream, but better if tested first).
> 
> 
> Cheers.
> 

Thanks !

-- 
Jason Pleau

[fix_cmake_sdl_whitespace.patch (text/x-patch, attachment)]

Message #42 received at 822210@bugs.debian.org (full text, mbox, reply):

From: "Manuel A. Fernandez Montecelo" <manuel.montezelo@gmail.com>

To: Jason Pleau <jason@jpleau.ca>

Cc: 822210@bugs.debian.org, Gianfranco Costamagna <locutusofborg@debian.org>

Subject: Re: Bug#822210: sdl2-config.cmake: extra leading / trailing whitespace

Date: Sun, 1 May 2016 15:42:26 +0100

2016-04-30 2:35 GMT+01:00 Jason Pleau <jason@jpleau.ca>:
> On 04/29/2016 06:44 AM, Manuel A. Fernandez Montecelo wrote:
>> Jason, if you want to test it to see if it works fine, then I can
>> submit both to upstream's bug report for them to decide.
>
> It looks like ${prefix} is not set when defining ${stripped_prefix}. So
> for example SDL2_INCLUDE_DIRS is set to /include/SDL2.

Thanks for testing!


> I got it to work with the following:
>
> # sdl2 cmake project-config input for ./configure scripts
>
> string(STRIP "@prefix@" prefix)
> string(STRIP "@exec_prefix@" stripped_exec_prefix)
> string(STRIP "@libdir@" stripped_libdir)
> string(STRIP "@includedir@" stripped_includedir)
> string(STRIP "-L${SDL2_LIBDIR} @SDL_RLD_FLAGS@ @SDL_LIBS@"
> stripped_SDL2_LIBRARIES)
>
> set(exec_prefix "${stripped_exec_prefix}")
> set(libdir "${stripped_libdir}")
> set(SDL2_PREFIX "${stripped_prefix}")
> set(SDL2_EXEC_PREFIX "${stripped_prefix}")
> set(SDL2_LIBDIR "${stripped_libdir}")
> set(SDL2_INCLUDE_DIRS "${stripped_includedir}/SDL2")
> set(SDL2_LIBRARIES "${stripped_SDL2_LIBRARIES}")

So you only changed the first line, compared to mine?

If it needs this change, I think that my solution is not very robust
and that the assumptions made don't work and can fail in other cases.


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo@gmail.com>

Message #47 received at 822210@bugs.debian.org (full text, mbox, reply):

From: "Manuel A. Fernandez Montecelo" <manuel.montezelo@gmail.com>

To: Jason Pleau <jason@jpleau.ca>, 822210@bugs.debian.org, Gianfranco Costamagna <locutusofborg@debian.org>

Subject: Re: Bug#822210: sdl2-config.cmake: extra leading / trailing whitespace

Date: Thu, 19 May 2016 12:10:34 +0100

Hi!

2016-05-01 15:42 Manuel A. Fernandez Montecelo:
>
>If it needs this change, I think that my solution is not very robust
>and that the assumptions made don't work and can fail in other cases.

So I've been fighting with this for a while this morning and couldn't
get it to work as originally intended.  In the end, I uploaded a new
version of the package with the patch stripping only the SDL2_LIBRARIES
variable.

If other vars contain whitespace in the future it will not work, but
that's fundamentally a problem with upstream...  I submitted the patch
for their consideration in any case.

It would be great if you can verify that this works fine in your system,
but I am quite confident that it does so I published the new release to
the archive already -- lest it slips through the cracks and it's delayed
for a few more weeks.


Cheers.
-- 
Manuel A. Fernandez Montecelo <manuel.montezelo@gmail.com>

Message #52 received at 822210-close@bugs.debian.org (full text, mbox, reply):

From: mafm@debian.org (Manuel A. Fernandez Montecelo)

To: 822210-close@bugs.debian.org

Subject: Bug#822210: fixed in libsdl2 2.0.4+dfsg2-1

Date: Thu, 19 May 2016 11:22:12 +0000

Source: libsdl2
Source-Version: 2.0.4+dfsg2-1

We believe that the bug you reported is fixed in the latest version of
libsdl2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 822210@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Manuel A. Fernandez Montecelo <mafm@debian.org> (supplier of updated libsdl2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 19 May 2016 11:48:54 +0100
Source: libsdl2
Binary: libsdl2-2.0-0 libsdl2-dev libsdl2-doc
Architecture: source amd64 all
Version: 2.0.4+dfsg2-1
Distribution: unstable
Urgency: medium
Maintainer: Debian SDL packages maintainers <pkg-sdl-maintainers@lists.alioth.debian.org>
Changed-By: Manuel A. Fernandez Montecelo <mafm@debian.org>
Description:
 libsdl2-2.0-0 - Simple DirectMedia Layer
 libsdl2-dev - Simple DirectMedia Layer development files
 libsdl2-doc - Reference manual for libsdl2
Closes: 814276 822210 822924
Changes:
 libsdl2 (2.0.4+dfsg2-1) unstable; urgency=medium
 .
   [ Manuel A. Fernandez Montecelo ]
   * Bump Policy Standards-Version to 3.9.8 (no changes needed)
   * Drop -dbg package
   * Fixes for reproducible builds:
     - timestamps_in_tarball, use --clamp-mtime with changelog as date
     - timestamps_in_gzip_headers, export GZIP="-9n"
     - sort files by name when creating "examples.tar.gz"
   * Add depends from -doc on libjs-jquery, use symlink instead of embedded
     copy
   * Ensure proper migration from -dbg package using "dh_strip
     --dbgsym-migration"
   * Bump debhelper dependency for --dbgsym-migration
   * Enable ibus support (Closes: #822924)
   * d/patches:
     - Add bug_822210_fix_sdl2-config.cmake_whitespace.patch: Fix upstream
       problem with sdl2-config.cmake (Closes: #822210)
 .
   [ Gianfranco Costamagna ]
   * Fix insecure VCS fields.
   * Re-import the same tarball without SDL-qsort.c file.
     - the license issue is fixed already, because the original
       maintainer relicensed it (so we are adding it as a patch now)
       this repack can be removed in the next upstream tarball import.
       (Closes: #814276).
Checksums-Sha1:
 278b810b93387318c3653eec379098a37a546f1b 2666 libsdl2_2.0.4+dfsg2-1.dsc
 a988b1b54364ebd4b42fde851de311e75c8ba6ad 2547306 libsdl2_2.0.4+dfsg2.orig.tar.gz
 96bd008ab6034fb3f5474e736a8f61da9b969490 20680 libsdl2_2.0.4+dfsg2-1.debian.tar.xz
 c676cb785dda5a1f29041fa0aa7c4f0910fd46a1 1369324 libsdl2-2.0-0-dbgsym_2.0.4+dfsg2-1_amd64.deb
 0dc0ba6b4ca01a0434176b5261c9a27a7012016b 342482 libsdl2-2.0-0_2.0.4+dfsg2-1_amd64.deb
 7a44437f38d713d827e455228da8a3867ba5f1e3 611856 libsdl2-dev_2.0.4+dfsg2-1_amd64.deb
 25e74af6677f58f902aec58c3fb8c9859b812206 7909934 libsdl2-doc_2.0.4+dfsg2-1_all.deb
Checksums-Sha256:
 f6d9e703cc19503afefce1c504e7562d5229345862077c0d65571124df6ff2b8 2666 libsdl2_2.0.4+dfsg2-1.dsc
 01ce67019865525e43d5fee0b18b28594bfe2409593601fc657f5a0675b126d5 2547306 libsdl2_2.0.4+dfsg2.orig.tar.gz
 04d470d13e5348a066c604236753a88e49b6bfba4d2bf1c68237c11b9f312cc8 20680 libsdl2_2.0.4+dfsg2-1.debian.tar.xz
 2c8693ed66cb604023da732bc6c20a807a2db52735537e929db7fb46c9b8e49c 1369324 libsdl2-2.0-0-dbgsym_2.0.4+dfsg2-1_amd64.deb
 d374955b7cbbd58340f7c9cdfc457103fb59b3eb1909db2c2824710967ec85d8 342482 libsdl2-2.0-0_2.0.4+dfsg2-1_amd64.deb
 70f52117fd0b89e7e1b44e21e1808f6adf3f8c9ec3fd0e9cc3266311dde1c4ee 611856 libsdl2-dev_2.0.4+dfsg2-1_amd64.deb
 eb1ccf17e5fb89151d6d1d08dd59004f5a161b420c2c9ed4d3d1117320a4cf46 7909934 libsdl2-doc_2.0.4+dfsg2-1_all.deb
Files:
 f8cf89b7c8d00e987a4ce23880d3e0a3 2666 libs optional libsdl2_2.0.4+dfsg2-1.dsc
 18cd2577392a7d178b46bd126c0549ef 2547306 libs optional libsdl2_2.0.4+dfsg2.orig.tar.gz
 44792a2dcb35236da9c145f72a9988a6 20680 libs optional libsdl2_2.0.4+dfsg2-1.debian.tar.xz
 82e6928f8e8f9e746d1740a8e71933b1 1369324 debug extra libsdl2-2.0-0-dbgsym_2.0.4+dfsg2-1_amd64.deb
 7945f4ebde61843a9e2b8347ad24f3c8 342482 libs optional libsdl2-2.0-0_2.0.4+dfsg2-1_amd64.deb
 af8dbff02d812f4cbb949596934acfcc 611856 libdevel optional libsdl2-dev_2.0.4+dfsg2-1_amd64.deb
 fc628d5b516b9a998c016f936d50f174 7909934 doc optional libsdl2-doc_2.0.4+dfsg2-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJXPZtRAAoJEH92BqRF3KgOCj4P/0Mg3c72WW1X/67aCsq5KIRL
OvtOYPaX9sPJvltTnFnM7ErP/JZvnh0gVHGWhVzvRgOdsWTMpjmP4GftzOk0mge+
bHsJKnqiGXGrs0e6u1kULT2yYMXzzB4PYICl0z1MJVqSRt5WgxUFr7DmRcX5qjmb
g7fjbcVneiYATTao07QKx3BSJqYOrVhL0xG7ILNrp37uxhzOYLD2wlwhQmM5r2uV
ppr73JpFTgsAOAekAu4kqncPaBTEBH1p4POSm9FOBohOwv7AqSFYmijxjEdUEqU5
lmiHaOa5ZBGmHM+qElJvQtW6+JsTzp6cR3zUo6VdlRY9GFVvSLj1mIllCpBJVvns
uVzpa2cLLpriG5P4sOGl5pJgQBeLWlcqVTph0O0iVji5ISoWTGNxX2Ha72B/2tCX
DThp6s5zVgRD+osMRpPxEhpNWC76dtAzHuSVj8WrdcUAJg9kafbrpXQ+jW6HRU6G
TnCezDmUnWLJrbwEZUWIHeNurvqRy96IVzmB/9RgP+urZdXGgkPAygIQruBk90zE
7pWWTwLW5AHQ2S0cWYcrkGjEl6EDV9ed4JP1h13MpolLxz4jcrJWl5oXirIl6qMu
FJRvW6KCLJtTGffdGrrsID2SEdVWsKsA433nsRRcU+wLARgY/AxkCCQbfvl0DSWC
c7U0DgFYRizE4lUkt9l3
=J3gw
-----END PGP SIGNATURE-----

Message #57 received at 822210@bugs.debian.org (full text, mbox, reply):

From: Jason Pleau <jason@jpleau.ca>

To: "Manuel A. Fernandez Montecelo" <manuel.montezelo@gmail.com>, 822210@bugs.debian.org, Gianfranco Costamagna <locutusofborg@debian.org>

Subject: Re: Bug#822210: sdl2-config.cmake: extra leading / trailing whitespace

Date: Fri, 20 May 2016 19:12:22 -0400

Hi

On 05/19/2016 07:10 AM, Manuel A. Fernandez Montecelo wrote:
> Hi!
> 
> 2016-05-01 15:42 Manuel A. Fernandez Montecelo:
>>
>> If it needs this change, I think that my solution is not very robust
>> and that the assumptions made don't work and can fail in other cases.
> 
> So I've been fighting with this for a while this morning and couldn't
> get it to work as originally intended.  In the end, I uploaded a new
> version of the package with the patch stripping only the SDL2_LIBRARIES
> variable.
> 
> If other vars contain whitespace in the future it will not work, but
> that's fundamentally a problem with upstream...  I submitted the patch
> for their consideration in any case.
> 
> It would be great if you can verify that this works fine in your system,
> but I am quite confident that it does so I published the new release to
> the archive already -- lest it slips through the cracks and it's delayed
> for a few more weeks.

Seems to work here, thanks for the fix and upload!

> 
> 
> Cheers.

-- 
Jason Pleau

Send a report that this bug log contains spam.