Debian Bug report logs - #820908
shout plugin should kill with TERM instead of HUP

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: shout plugin should kill with TERM instead of HUP

Date: Wed, 13 Apr 2016 11:23:00 -0400

[Message part 1 (text/plain, inline)]

Package: gmpc-plugins
Version: 11.8.16-2
Severity: normal

I use ogg123 to stream audio with the shout plugin, from an icecast
server fed by (among other things) and MPD daemon controled by GMPC.

ogg123 doesn't stop when sent SIGHUP. this is probably so that you can
start music in a terminal and keep it running when the terminal is
closed, so it makes sense to me.

unfortunately, the shout plugin sends SIGHUP when the player is
stopped, so ogg123 keeps on playing the streams. many users probably
don't notice the issue because in most cases the stream itself stops
and then ogg123 terminates.

but some more professional streams (like mine) have fallbacks
configured, which can play other music like a random mix or a fallback
jingle. in my case, I made a fallback jingle, and it's quite annoying
to hear ogg123 keep on playing when i stop the player.

this should really send SIGTERM instead of SIGHUP, which resolves the
problem.

patch attached.

-- System Information:
Debian Release: 8.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'stable'), (1, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.2.0-0.bpo.1-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages gmpc-plugins depends on:
ii  gmpc                        11.8.16-9
ii  libatk1.0-0                 2.14.0-1
ii  libavahi-client3            0.6.31-5
ii  libavahi-common3            0.6.31-5
ii  libavahi-glib1              0.6.31-5
ii  libc6                       2.19-18+deb8u4
ii  libcairo2                   1.14.0-2.1+deb8u1
ii  libdbus-1-3                 1.8.20-0+deb8u1
ii  libdbus-glib-1-2            0.102-1
ii  libfontconfig1              2.11.0-6.3
ii  libfreetype6                2.5.2-3+deb8u1
ii  libgdk-pixbuf2.0-0          2.31.1-2+deb8u4
ii  libglib2.0-0                2.42.1-1+b1
ii  libgtk2.0-0                 2.24.25-3+deb8u1
ii  libjavascriptcoregtk-1.0-0  2.4.9-1~deb8u1
ii  libmpd1                     0.20.0-1.2
ii  libpango-1.0-0              1.36.8-3
ii  libpangocairo-1.0-0         1.36.8-3
ii  libpangoft2-1.0-0           1.36.8-3
ii  libsoup2.4-1                2.48.0-1
ii  libsqlite3-0                3.8.7.1-1+deb8u1
ii  libtag1c2a                  1.9.1-2.1
ii  libtagc0                    1.9.1-2.1
ii  libwebkitgtk-1.0-0          2.4.9-1~deb8u1
ii  libxml2                     2.9.1+dfsg1-5+deb8u1
ii  zlib1g                      1:1.2.8.dfsg-2+b1

gmpc-plugins recommends no packages.

gmpc-plugins suggests no packages.

-- no debconf information

[kill-term.patch (text/x-diff, attachment)]

Message #12 received at 820908@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@orangeseeds.org>

To: me@emillon.org

Cc: 807735@bugs.debian.org, 820908@bugs.debian.org

Subject: NMU for gmpc-plugins

Date: Wed, 13 Apr 2016 14:13:14 -0400

Hi!

I have two bugs (in CC) that I would like to see fixed in
gmpc-plugins. Since there hasn't been an upload for a long time in the
package, i figured you wouldn't mind!

But just in case, I'll give you a few days to review the patches in case
you want to interject, then I will upload the package to DELAYED/10.

Thanks!

A.

-- 
Dr. King’s major assumption was that if you are nonviolent, if you
suffer, your opponent will see your suffering and will be moved to
change his heart. He only made one fallacious assumption: In order for
nonviolence to work, your opponent must have a conscience. The United
States has none.
                        - Stokely Carmichael

Message #17 received at 820908@bugs.debian.org (full text, mbox, reply):

From: Étienne Millon <me@emillon.org>

To: Antoine Beaupré <anarcat@orangeseeds.org>

Cc: 820908@bugs.debian.org, 807735@bugs.debian.org

Subject: Re: NMU for gmpc-plugins

Date: Fri, 15 Apr 2016 20:29:20 +0200

[Message part 1 (text/plain, inline)]

Hi,

Please go ahead.

Thanks for taking care of this :)

[Message part 2 (text/html, inline)]

Message #22 received at 820908@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>

To: Étienne Millon <me@emillon.org>

Cc: 820908@bugs.debian.org, 807735@bugs.debian.org

Subject: Re: NMU for gmpc-plugins

Date: Fri, 15 Apr 2016 18:40:00 -0400

[Message part 1 (text/plain, inline)]

On 2016-04-15 14:29:20, Étienne Millon wrote:
> Hi,
>
> Please go ahead.
>
> Thanks for taking care of this :)

Great! It's now in DELAYED/10, here's a debdiff for you to review (and I
guess merge into the git repo i don't seem to have access to).

[gmpc-plugins.debdiff (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

a.

-- 
Wire telegraph is a kind of a very, very long cat. You pull his tail
in New York and his head is meowing in Los Angeles. Radio operates
exactly the same way: you send signals here, they receive them
there. The only difference is that there is no cat.
                         - Albert Einstein

Message #27 received at 820908-close@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>

To: 820908-close@bugs.debian.org

Subject: Bug#820908: fixed in gmpc-plugins 11.8.16-2.1

Date: Tue, 26 Apr 2016 00:49:08 +0000

Source: gmpc-plugins
Source-Version: 11.8.16-2.1

We believe that the bug you reported is fixed in the latest version of
gmpc-plugins, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 820908@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Antoine Beaupré <anarcat@debian.org> (supplier of updated gmpc-plugins package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 15 Apr 2016 18:20:01 -0400
Source: gmpc-plugins
Binary: gmpc-plugins gmpc-plugins-dbg
Architecture: source amd64
Version: 11.8.16-2.1
Distribution: unstable
Urgency: medium
Maintainer: Etienne Millon <me@emillon.org>
Changed-By: Antoine Beaupré <anarcat@debian.org>
Description:
 gmpc-plugins - Plugins for the GNOME Music Player Client
 gmpc-plugins-dbg - Plugins for the GNOME Music Player Client (debugging symbols)
Closes: 807735 820908
Changes:
 gmpc-plugins (11.8.16-2.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Disable a bunch of plugins (jamendo, magnatune, tagedit and albumview)
     to workaround FTBFS (Closes: #807735)
   * shout plugin should kill with TERM instead of HUP (Closes: #820908)
Checksums-Sha1:
 d2fd972d8e23e1be6f0a7f33cc17d6c0d8ce97ef 2276 gmpc-plugins_11.8.16-2.1.dsc
 880462b7997c8ef49ccc7f66303d6942dd1fc1f6 4440 gmpc-plugins_11.8.16-2.1.debian.tar.xz
 ce2aca2290ad0353873d03538cbc9bd1e80b5ea0 146024 gmpc-plugins-dbg_11.8.16-2.1_amd64.deb
 1abe3f15c5739479c098e46d3f32c0029993f8b4 38158 gmpc-plugins_11.8.16-2.1_amd64.deb
Checksums-Sha256:
 011faec76061666068a685a4647fe9b120461a8180623be5a9b41638470f4fd6 2276 gmpc-plugins_11.8.16-2.1.dsc
 bb72f95ee78a072867a0f120d0b95f8231f95f0f8381c03be205f12093ee62e5 4440 gmpc-plugins_11.8.16-2.1.debian.tar.xz
 fb13b0cae8dbf7ba08dca81e72f095fe3c55313a3ecafe3ff57f455a46f5f1e5 146024 gmpc-plugins-dbg_11.8.16-2.1_amd64.deb
 05bcae2c1973b775769e4b7afcc7adf4c73b4976448b302da1d2891b37cf0de5 38158 gmpc-plugins_11.8.16-2.1_amd64.deb
Files:
 b9e7524b9c1a9e1751c06a8390d996c9 2276 sound optional gmpc-plugins_11.8.16-2.1.dsc
 58175400539b0ad8851c7706bc121c62 4440 sound optional gmpc-plugins_11.8.16-2.1.debian.tar.xz
 1ddfff9850f5ebb13554700ee0f5bb61 146024 debug extra gmpc-plugins-dbg_11.8.16-2.1_amd64.deb
 f3fa56ff091e74b118aa7c60b3edd3f3 38158 sound optional gmpc-plugins_11.8.16-2.1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXHriWAAoJEHkhUlJ7dZIe7U8P/2gceI0cuKeYyT7/qtIINUyz
n1PUNDMVoS+dJBuLg2kzXQFqVoOGEaxcpLsWRNvCC1g08bxef0McCQSyiJo+utEw
pVMbwDC5XZuqT5Ynuhbo3KxbVJMrZDo5AA3kj6f6H+Gve9Dkn5XZeCRSXME/4v1J
nrcL+3NyUPgfzOcdOGx0xGDBxtsWNCXbccbTKMh1tquh5mUwkNxMo+V9Wj7ST2sm
pGA48VxR5DjisyQuxG6rwsV2X3gZHev1eBuoKEfVYI/l+dcQlEiO+PW1mgQ5hLDH
Sc2M/Hr2fA7h05F1AAh0q65YIwtkXSHpY0wTf7GXjZPBnLKhIQofjbv/UWNcab2i
FZFccdVL3QzYWgEMcr9IlKzHodVL790nRDSksf/pKfefBjoqVDX98dKZfc0KhyMR
QfDnMG/H19omyup9nwuNofz900d0HfkqU/SwjJYrdO9J9Jwgzs3KcrItDLNMla7u
UJ7N+SsU8WT+N9rkUcM+J5gSefaOs7XhHewRPel2GAOuw7CMDlbvtJDilq1AX4sA
lxbNBWUQlwnBbVoc1jzePnFB+fyjt7TYDtQbaZJ0iCS7D6AoK46J/NUlodxKHRC9
etoxLd82pCuBk9itEScplCtKVYzl7rRh49e0i0rQTSWeZz4SyVjMNnMcsFMqS7Z+
OKtypkjpRfzrm2iUEoeZ
=4Z0o
-----END PGP SIGNATURE-----

Message #32 received at 820908@bugs.debian.org (full text, mbox, reply):

From: Étienne Millon <me@emillon.org>

To: Antoine Beaupré <anarcat@debian.org>

Cc: 820908@bugs.debian.org, 807735@bugs.debian.org

Subject: Re: NMU for gmpc-plugins

Date: Sun, 1 May 2016 17:56:38 +0200

Thanks, I just pushed the diff to the git repository.
I actually do not use this package very often, so if you would like to
adopt it I'm all for it :) (same applies to gmpc).
Let me know what you think.

Message #37 received at 820908@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>

To: Étienne Millon <me@emillon.org>

Cc: 820908@bugs.debian.org, 807735@bugs.debian.org

Subject: Re: NMU for gmpc-plugins

Date: Sun, 01 May 2016 17:49:10 -0400

On 2016-05-01 11:56:38, Étienne Millon wrote:
> Thanks, I just pushed the diff to the git repository.
> I actually do not use this package very often, so if you would like to
> adopt it I'm all for it :) (same applies to gmpc).
> Let me know what you think.

I'd be glad to. Next time I need to make an update, I'll adopt it if
it's okay with you. :)

Do you have special communications with upstream to get notified of
releases (if there's upstream still?)

a.
-- 
Being cynical is the only way to deal with modern civilization — you
can't just swallow it whole.
                        - Frank Zappa

Send a report that this bug log contains spam.