Debian Bug report logs - #820895
sphinx: please extend SOURCE_DATE_EPOCH support

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Alexis Bienvenüe <pado@passoire.fr>

To: submit@bugs.debian.org

Subject: sphinx: please extend SOURCE_DATE_EPOCH support

Date: Wed, 13 Apr 2016 15:00:24 +0200

[Message part 1 (text/plain, inline)]

Source: sphinx
Version: 1.3.6-2
Severity: wishlist
Tags: patch upstream
User: reproducible-builds@lists.alioth.debian.org
Usertags: toolchain
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Dear Maintainer,

While working on the “reproducible builds” effort [1], we have noticed
that, even though sphinx honours the SOURCE_DATE_EPOCH environment
variable [2], this support is still incomplete: default copyright year
and gettext don't use it.

Various packages (eg. fabric, guidata) that build-depend on sphinx use a
conf.py that sets the copyright year from current time, like

  copyright = u'2006-%s, Author' % time.strftime('%Y')

This also breaks reproducibility of the building process.

The attached patch extends the SOURCE_DATE_EPOCH support in copyright
year and gettext, and corrects copyright strings that does not
corresponds to SOURCE_DATE_EPOCH, so that affected packages can be built
reproducibly without any change.

Regards,
Alexis Bienvenüe.

[1] https://wiki.debian.org/ReproducibleBuilds
[2] https://reproducible-builds.org/specs/source-date-epoch/

[sphinx_1.3.6-2_extend_SDE.diff (text/x-patch, attachment)]

Message #10 received at 820895@bugs.debian.org (full text, mbox, reply):

From: Dmitry Shachnev <mitya57@debian.org>

To: Alexis Bienvenüe <pado@passoire.fr>, 820895@bugs.debian.org

Subject: Re: Bug#820895: sphinx: please extend SOURCE_DATE_EPOCH support

Date: Sun, 24 Apr 2016 15:40:41 +0300

[Message part 1 (text/plain, inline)]

Hi Alexis,

On Wed, Apr 13, 2016 at 03:00:24PM +0200, Alexis Bienvenüe wrote:
> The attached patch extends the SOURCE_DATE_EPOCH support in copyright
> year and gettext, and corrects copyright strings that does not
> corresponds to SOURCE_DATE_EPOCH, so that affected packages can be built
> reproducibly without any change.

Thanks a lot for your efforts!

Can you please submit your patch upstream (like you did it for #822197)?

I would really prefer to get this patch reviewed/accepted by upstream before
including it in the Debian packaging. (Also, if you will be submitting it,
better use stable branch of git rather than master, which will make sure your
change will be in the next bugfix release if accepted.)

--
Dmitry Shachnev

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 820895@bugs.debian.org (full text, mbox, reply):

From: Alexis Bienvenüe <pado@passoire.fr>

To: Dmitry Shachnev <mitya57@debian.org>, 820895@bugs.debian.org

Subject: Re: Bug#820895: sphinx: please extend SOURCE_DATE_EPOCH support

Date: Fri, 29 Apr 2016 00:02:25 +0200

Control: forwarded -1 https://github.com/sphinx-doc/sphinx/pull/2503

Hi Dmitry.

Le 24/04/2016 14:40, Dmitry Shachnev a écrit :
> Can you please submit your patch upstream (like you did it for #822197)?
> 
> I would really prefer to get this patch reviewed/accepted by upstream before
> including it in the Debian packaging. (Also, if you will be submitting it,
> better use stable branch of git rather than master, which will make sure your
> change will be in the next bugfix release if accepted.)

As suggested - thanks, and sorry for the delay.

Alexis.

Message #24 received at 820895-close@bugs.debian.org (full text, mbox, reply):

From: Dmitry Shachnev <mitya57@debian.org>

To: 820895-close@bugs.debian.org

Subject: Bug#820895: fixed in sphinx 1.4.1-1

Date: Tue, 17 May 2016 16:29:41 +0000

Source: sphinx
Source-Version: 1.4.1-1

We believe that the bug you reported is fixed in the latest version of
sphinx, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 820895@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Shachnev <mitya57@debian.org> (supplier of updated sphinx package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 17 May 2016 18:57:02 +0300
Source: sphinx
Binary: python-sphinx python3-sphinx sphinx-common sphinx-doc libjs-sphinxdoc
Architecture: source
Version: 1.4.1-1
Distribution: experimental
Urgency: medium
Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>
Changed-By: Dmitry Shachnev <mitya57@debian.org>
Description:
 libjs-sphinxdoc - JavaScript support for Sphinx documentation
 python-sphinx - documentation generator for Python projects (implemented in Pytho
 python3-sphinx - documentation generator for Python projects (implemented in Pytho
 sphinx-common - documentation generator for Python projects - common data
 sphinx-doc - documentation generator for Python projects - documentation
Closes: 649488 820895 824375
Changes:
 sphinx (1.4.1-1) experimental; urgency=medium
 .
   * New upstream release (closes: #824375).
   * Drop the following patches, applied upstream:
     - disable_distribute_setup.diff
     - source_date_epoch.diff
     - reproducible_grammar.diff
     - reproducible_inventory.diff
     - reproducible_js_locale.diff
     - reproducible_searchindex.diff
   * Refresh and rebase other patches.
   * Update debian/watch to correctly mangle upstream alpha releases.
   * Demote sphinx-rtd-theme to Suggests, it has become optional.
   * Add dependency on python[3]-imagesize packages.
   * Bump Pygments build- and test dependencies to 2.1.1.
   * Demote python-sphinx recommendation of sphinx-doc to a suggestion.
   * Refactor the command to run tests to better match upstream.
   * Build-depend on dvipng to get the pngmath test run.
   * Update numbers in jstest/run-tests for the new version.
   * Add a patch from Alexis Bienvenüe to extend SOURCE_DATE_EPOCH support
     (closes: #820895).
   * Add a patch to fix a typing-related test failure with Python 3.5.2.
   * Update debian/copyright based on upstream LICENSE and AUTHORS files.
   * Add a patch to make compile_catalog code work with python-babel 2.3.
   * Add a patch to support LuaTeX 0.85.
   * Build-depend on texlive-luatex for tests.
   * Adapt dh-sphinxdoc/install-js for doctools.js changes.
   * Update sphinx-autogen manpage.
   * Bump Standards-Version to 3.9.8, no changes needed.
   * Build-depend on python3-xapian (closes: #649488).
Checksums-Sha1:
 5541b439731aa8a0a578065a330e69dd0e694942 3020 sphinx_1.4.1-1.dsc
 d18b856710b22ae9740147e21754ca5b851af9b2 4259820 sphinx_1.4.1.orig.tar.gz
 46d26b8a2fd6172889a95af10c59c28cb524ac61 33604 sphinx_1.4.1-1.debian.tar.xz
Checksums-Sha256:
 e8b982c651ccc6fceabd22760a8b4ae01844b9091e81a7291b1b30a751cb0288 3020 sphinx_1.4.1-1.dsc
 c6871a784d24aba9270b6b28541537a57e2fcf4d7c799410eba18236bc76d6bc 4259820 sphinx_1.4.1.orig.tar.gz
 1454508e6aad463d7b07b88074db0be15f668fcaa17a0d62adbb77b823044fc4 33604 sphinx_1.4.1-1.debian.tar.xz
Files:
 320f735f6c491d0e31dabbd7794a942f 3020 python optional sphinx_1.4.1-1.dsc
 4c4988e0306a04cef8dccc384281e585 4259820 python optional sphinx_1.4.1.orig.tar.gz
 72eebca249dd14d5c68d2bee31ca867e 33604 python optional sphinx_1.4.1-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXO0AJAAoJENb+cQNj+F3TDIUQAJapCUHKW59eXuxty6n3mb4y
miCot8DSma0cdNl6eNLeJQ8YyS1siefHEB2sgE7ohwYAb7b0W6tJBMNOOuHYZHFt
PYlWdUqQdQz8xknAhI1wYTDSd4WiULYwy0Qa4BOTS++sy9ybTgCy7DC/fQ9MQkOV
2TyEQQ46CgrgKOKsvoolHir/q/pt3lJ6HCIfqvdJqlANQQK8Jz4uZ1YAymRVR8zz
nRUZA8JvUvoJdQld6LbjZZZtbxFc9MIPX4jqgqX8AHTbx8EmQXdCxgqLAKfslTE0
mNrw/Ohy120oIzbuCcm2H4pOXmW3USw9dxGwDipA3YTCDUqEgaetXlQJ35vuvcKO
ojvCrzj50gTg87XDvm3L4p14+t0XWVft1ftZY/ARBG5NMJfkOwthfcQgmlSzwX4h
R4sVQoWmTDMkcFsZfci6t/KKP/Bcgi/U9ObJjmCaMQ7pCQx/artcZEoAcsa2fFHv
8u3fS8w8NMUv6ZRIGmVAI9556dKVEGGcCBi2T4RZCE4x0MwSUufk2XsqC0crWajI
ZMDP/TqCMZVI7JcG4vNvT0bR8UpMT8+56yZTDJ1Bmk13fpfuInuj03PEro0jgijK
O2CDGHSOV8cyPuMSGrf7tHv81NxoBXpd1NTD89nRSD9Rwpb2F+GWUVRn199enxtu
VmnKRFfHM8QPoWq5FWyp
=AZ0D
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.