Debian Bug report logs - #818815
oolite: FTBFS with libc 2.23: non-floating-point argument in call to function '__builtin_isfinite'

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Michlmayr <tbm@hpe.com>

To: submit@bugs.debian.org

Subject: oolite: FTBFS with libc 2.23: non-floating-point argument in call to function '__builtin_isfinite'

Date: Sun, 20 Mar 2016 16:05:15 -0400

Package: oolite
Version: 1.82-1
Severity: important
User: debian-glibc@lists.debian.org
Usertags: 2.23

This package fails to build with libc6 2.23 (2.23-0experimental0 from
experimental).

> sbuild (Debian sbuild) 0.68.0 (15 Jan 2016) on dl580gen9-02.hlinux
...
>       -MMD -MP -Wdate-time -D_FORTIFY_SOURCE=2 -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -fno-strict-aliasing -fexceptions -fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -pthread -fPIC -Wall -DGSWARN -DGSDIAGNOSE -Wno-import -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fgnu-runtime -Wall -std=gnu99 -DLOADSAVEGUI -DLINUX -DXP_UNIX -Wno-import -DHAVE_LIBESPEAK=1 `pkg-config --cflags libpng glu gl x11 sdl mozjs185 nspr openal vorbisfile minizip` -DNDEBUG -DOO_CHECK_GL_HEAVY=0 -DOO_EXCLUDE_DEBUG_SUPPORT=1 -DOO_OXP_VERIFIER_ENABLED=0 -DOO_LOCALIZATION_TOOLS=0 -DDEBUG_GRAPHVIZ=0 -DOO_FOV_INFLIGHT_CONTROL_ENABLEDD=0 -fconstant-string-class=NSConstantString -Isrc/SDL -Isrc/Core -Isrc/BSDCompat -Isrc/Core/Scripting -Isrc/Core/Materials -Isrc/Core/Entities -Isrc/Core/OXPVerifier -Isrc/Core/Debug -Isrc/Core/Tables -I. -I/usr/local/include/GNUstep -I/usr/include/GNUstep \
>        -o obj.spk/oolite.obj/OOPListScript.m.o
> src/Core/Scripting/OOJSPlayerShip.m: In function 'ValidateContracts':
> src/Core/Scripting/OOJSPlayerShip.m:1499:3: error: non-floating-point argument in call to function '__builtin_isfinite'
>    if (argc > offset+5 && JS_ValueToECMAUint32(context, OOJS_ARGV[offset + 5], &uValue) && isfinite(uValue))
>    ^
> gcc src/Core/Scripting/OOScript.m -c \
>       -MMD -MP -Wdate-time -D_FORTIFY_SOURCE=2 -DGNUSTEP -DGNUSTEP_BASE_LIBRARY=1 -DGNU_RUNTIME=1 -DGNUSTEP_BASE_LIBRARY=1 -fno-strict-aliasing -fexceptions -fobjc-exceptions -D_NATIVE_OBJC_EXCEPTIONS -pthread -fPIC -Wall -DGSWARN -DGSDIAGNOSE -Wno-import -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fgnu-runtime -Wall -std=gnu99 -DLOADSAVEGUI -DLINUX -DXP_UNIX -Wno-import -DHAVE_LIBESPEAK=1 `pkg-config --cflags libpng glu gl x11 sdl mozjs185 nspr openal vorbisfile minizip` -DNDEBUG -DOO_CHECK_GL_HEAVY=0 -DOO_EXCLUDE_DEBUG_SUPPORT=1 -DOO_OXP_VERIFIER_ENABLED=0 -DOO_LOCALIZATION_TOOLS=0 -DDEBUG_GRAPHVIZ=0 -DOO_FOV_INFLIGHT_CONTROL_ENABLEDD=0 -fconstant-string-class=NSConstantString -Isrc/SDL -Isrc/Core -Isrc/BSDCompat -Isrc/Core/Scripting -Isrc/Core/Materials -Isrc/Core/Entities -Isrc/Core/OXPVerifier -Isrc/Core/Debug -Isrc/Core/Tables -I. -I/usr/local/include/GNUstep -I/usr/include/GNUstep \
>        -o obj.spk/oolite.obj/OOScript.m.o
> /usr/share/GNUstep/Makefiles/rules.make:468: recipe for target 'obj.spk/oolite.obj/OOJSPlayerShip.m.o' failed

-- 
Martin Michlmayr
Linux for HPE Helion, Hewlett Packard Enterprise

Message #10 received at 818815@bugs.debian.org (full text, mbox, reply):

From: Gianfranco Costamagna <locutusofborg@debian.org>

To: 818815@bugs.debian.org

Subject: oolite: FTBFS with libc 2.23: non-floating-point argument in call to function '__builtin_isfinite'

Date: Fri, 29 Apr 2016 15:33:13 +0200

[Message part 1 (text/plain, inline)]

control: tags -1 patch

the following patch (stolen from adios similar patch) should fix the issue:
--- oolite-1.82.orig/src/Core/Scripting/OOJSPlayerShip.m
+++ oolite-1.82/src/Core/Scripting/OOJSPlayerShip.m
@@ -1496,7 +1496,7 @@ static BOOL ValidateContracts(JSContext

        if (!isCargo)
        {
-               if (argc > offset+5 && JS_ValueToECMAUint32(context, OOJS_ARGV[offset + 5], &uValue) && isfinite(uValue))
+               if (argc > offset+5 && JS_ValueToECMAUint32(context, OOJS_ARGV[offset + 5], &uValue) && isfinite((double)uValue))
                {
                        *risk = uValue;
                }


thanks for considering it,


Gianfranco

[fix-glib-cast.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #17 received at 818815@bugs.debian.org (full text, mbox, reply):

From: Nicolas Boulenguez <nicolas@debian.org>

To: Gianfranco Costamagna <locutusofborg@debian.org>, 818815@bugs.debian.org

Subject: Re: Bug#818815: oolite: FTBFS with libc 2.23: non-floating-point argument in call to function '__builtin_isfinite'

Date: Sat, 30 Apr 2016 14:50:00 +0200

On Fri, Apr 29, 2016 at 03:33:13PM +0200, Gianfranco Costamagna wrote:
> the following patch (stolen from adios similar patch) should fix the issue:

Thanks a lot for the patch.
I will only work on it once my not-games packages with reverse
dependencies have migrated.

Message #24 received at 818815-close@bugs.debian.org (full text, mbox, reply):

From: Nicolas Boulenguez <nicolas@debian.org>

To: 818815-close@bugs.debian.org

Subject: Bug#818815: fixed in oolite 1.82-2

Date: Mon, 11 Jul 2016 13:36:44 +0000

Source: oolite
Source-Version: 1.82-2

We believe that the bug you reported is fixed in the latest version of
oolite, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 818815@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nicolas Boulenguez <nicolas@debian.org> (supplier of updated oolite package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 11 Jul 2016 14:56:24 +0200
Source: oolite
Binary: oolite oolite-doc oolite-data oolite-data-sounds
Architecture: source
Version: 1.82-2
Distribution: unstable
Urgency: medium
Maintainer: Nicolas Boulenguez <nicolas@debian.org>
Changed-By: Nicolas Boulenguez <nicolas@debian.org>
Description:
 oolite     - space sim game, inspired by Elite
 oolite-data - space sim game, inspired by Elite (data files)
 oolite-data-sounds - space sim game, inspired by Elite (sounds)
 oolite-doc - space sim game, inspired by Elite (documentation)
Closes: 702092 818815 825680
Changes:
 oolite (1.82-2) unstable; urgency=medium
 .
   * README: avoid nvidia drivers without nvidia card. Closes: #702092.
   [ Petter Reinholdtsen <pere@hungry.com> ]
   * Add StrategyGame category to desktop file. Closes: #825680.
   [ Gianfranco Costamagna <locutusofborg@debian.org> ]
   * Make a cast explicit for glib-2.23. Closes: #818815.
Checksums-Sha1:
 bdc298dd2ca8ad1c37102f8907aa2978b724eb1a 2548 oolite_1.82-2.dsc
 63ca7137acd790d1700d300191d71f56040a7a24 35240 oolite_1.82-2.debian.tar.xz
Checksums-Sha256:
 621b5bc8ed44091b01d6e290bd61cae143cf2cbd2661c5249c75b44b0b364b4d 2548 oolite_1.82-2.dsc
 e76e9c93b8a0bcff11e95326d7fc4068dfc74444f4700093ceade49cfbf2b4d5 35240 oolite_1.82-2.debian.tar.xz
Files:
 11f2927e3e423074b152691f2f2471cc 2548 games optional oolite_1.82-2.dsc
 febeaa56278651828c3755335b1e31bf 35240 games optional oolite_1.82-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXg5zWAAoJELUqnPRJDfyNOuYP/2mHjFyKuhIiVjs8RPPJN8mV
3fDEGvDeqkeWFntD7PXZKwvOJMvR9U5CIuq6NR5mrli7U/28pAtdhMyHEv0eI6xD
SHnSyZmjIdANyQvNZxFbN+1as+ybR+pdYYJGlq95W5LcGkVXVK30qlnhUzadt6iK
FC4TgDbb89jUm3Bg1v8HTcuzSOwq7iNzMhTVqKj86wbSAejYM5v0toS0CLGP7RXX
TJgm0bys0R27Pe3qJf6JMGEMkPiOuekVORR2TEGvcYbn5pt6YZaRVE3BLqGGG+Lx
HNqp1DvgcJbK1aWQEk0Lmxm8Y4UBVJmTv7yJCWKkieRPIyK/4XvxSQ22pSNgKOGS
KYzVwcU04RrC5sHbfqPTunBEslhiMxSKZkQleiJpBzgUbdVxNvorYYRbeh610/CU
Vujo/dxLn1gpwcybjKcMngC690VqAkG7XdPnCCvjtnI1hb9LJ5yGM5DzCz6YQyjh
wWJKNQxpWT1lSmRlTrJJpqEteNoWAtq24GxomVhRPB3WkHDbNuVZF+UgaCVIx+9M
wONl+vwxbH24UBzZVtTTR1/iY6JI/IFwsBLIM5UpYgn2y7go83Jcj6k9sECbIpIi
/K7ap8CMj4wa/InzL8q5IQCbPrRCPVQEpFjxKaEohUnsRtOSu3JNSoTlNY67jGyX
g8S5jMFJHxFX5Ab8RUIR
=syMi
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.