Debian Bug report logs - #818237
vagrant-libvirt: undefined method `group_by' for nil:NilClass (NoMethodError)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Graham Cobb <g+debian@cobb.uk.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: vagrant-libvirt: undefined method `group_by' for nil:NilClass (NoMethodError)

Date: Mon, 14 Mar 2016 22:13:31 +0000

Package: vagrant
Version: 1.8.1+dfsg-1
Severity: normal

Using the stretch version of vagrant, attempting to install the "vagrant-libvirt"
plugin fails:

vagrant plugin install vagrant-libvirt
Installing the 'vagrant-libvirt' plugin. This can take a few minutes...
/usr/lib/ruby/2.3.0/rubygems/specification.rb:946:in `all=': undefined method `group_by' for nil:NilClass (NoMethodError)
	from /usr/lib/ruby/vendor_ruby/vagrant/bundler.rb:275:in `with_isolated_gem'
	from /usr/lib/ruby/vendor_ruby/vagrant/bundler.rb:231:in `internal_install'
	from /usr/lib/ruby/vendor_ruby/vagrant/bundler.rb:102:in `install'
	from /usr/lib/ruby/vendor_ruby/vagrant/plugin/manager.rb:62:in `block in install_plugin'
	from /usr/lib/ruby/vendor_ruby/vagrant/plugin/manager.rb:72:in `install_plugin'
	from /usr/share/vagrant/plugins/commands/plugin/action/install_gem.rb:37:in `call'
	from /usr/lib/ruby/vendor_ruby/vagrant/action/warden.rb:34:in `call'
	from /usr/lib/ruby/vendor_ruby/vagrant/action/builder.rb:116:in `call'
	from /usr/lib/ruby/vendor_ruby/vagrant/action/runner.rb:66:in `block in run'
	from /usr/lib/ruby/vendor_ruby/vagrant/util/busy.rb:19:in `busy'
	from /usr/lib/ruby/vendor_ruby/vagrant/action/runner.rb:66:in `run'
	from /usr/share/vagrant/plugins/commands/plugin/command/base.rb:14:in `action'
	from /usr/share/vagrant/plugins/commands/plugin/command/install.rb:32:in `block in execute'
	from /usr/share/vagrant/plugins/commands/plugin/command/install.rb:31:in `each'
	from /usr/share/vagrant/plugins/commands/plugin/command/install.rb:31:in `execute'
	from /usr/share/vagrant/plugins/commands/plugin/command/root.rb:56:in `execute'
	from /usr/lib/ruby/vendor_ruby/vagrant/cli.rb:42:in `execute'
	from /usr/lib/ruby/vendor_ruby/vagrant/environment.rb:268:in `cli'
	from /usr/bin/vagrant:173:in `<main>'

If I purge vargrant and then install the upstream package (version 1:1.8.1 from
https://www.vagrantup.com/downloads.html) I can install the vagrant-libvirt plugin
with no problem.  Switching back to the debian version reproduces the original
problem.


-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.3.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_IE.utf8, LC_CTYPE=en_IE.utf8 (charmap=UTF-8) (ignored: LC_ALL set to en_IE.utf8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)

Versions of packages vagrant depends on:
ii  bsdtar             3.1.2-11+b1
ii  bundler            1.11.2-1
ii  curl               7.47.0-1
ii  openssh-client     1:7.1p2-2
ii  ruby               1:2.3.0+1
ii  ruby-childprocess  0.5.9-1
ii  ruby-erubis        2.7.0-3
ii  ruby-i18n          0.7.0-2
ii  ruby-listen        3.0.3-3
ii  ruby-log4r         1.1.10-4
ii  ruby-net-scp       1.2.1-3
ii  ruby-net-sftp      1:2.1.2-3
ii  ruby-net-ssh       1:3.0.1-3
ii  ruby-nokogiri      1.6.7.2-3
ii  ruby-rb-inotify    0.9.7-1
ii  ruby-rest-client   1.8.0-2

vagrant recommends no packages.

Versions of packages vagrant suggests:
pn  virtualbox  <none>

-- no debconf information

Message #10 received at 818237@bugs.debian.org (full text, mbox, reply):

From: Wolodja Wentland <debian@babilen5.org>

To: Debian Bug Tracking System <818237@bugs.debian.org>

Subject: Re: vagrant-libvirt: undefined method `group_by' for nil:NilClass (NoMethodError)

Date: Fri, 01 Apr 2016 11:17:33 +0200

Package: vagrant
Version: 1.8.1+dfsg-1
Followup-For: Bug #818237

Hello,

i looked into this issue and found the following discussion:

https://github.com/pradels/vagrant-libvirt/issues/575

which led me to:

https://github.com/rubygems/rubygems/commit/044b0e2685e4b219b013f1067d670918a48c1f62

I can confirm that editing /usr/lib/ruby/2.3.0/rubygems/specification.rb as
suggested fixes the issue at hand. This issue therefore seems to be with
rubygems rather than vagrant itself.

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.4.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_GB.utf-8, LC_CTYPE=en_GB.utf-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages vagrant depends on:
ii  bsdtar             3.1.2-11+b1
ii  bundler            1.11.2-1
ii  curl               7.47.0-1
ii  openssh-client     1:7.2p2-2
ii  ruby               1:2.3.0+1
ii  ruby-childprocess  0.5.9-1
ii  ruby-erubis        2.7.0-3
ii  ruby-i18n          0.7.0-2
ii  ruby-listen        3.0.3-3
ii  ruby-log4r         1.1.10-4
ii  ruby-net-scp       1.2.1-3
ii  ruby-net-sftp      1:2.1.2-3
ii  ruby-net-ssh       1:3.0.1-3
ii  ruby-nokogiri      1.6.7.2-3
ii  ruby-rb-inotify    0.9.7-1
ii  ruby-rest-client   1.8.0-2

vagrant recommends no packages.

Versions of packages vagrant suggests:
ii  virtualbox  5.0.16-dfsg-2

-- no debconf information

Message #21 received at 818237@bugs.debian.org (full text, mbox, reply):

From: Christian Hofstaedtler <zeha@debian.org>

To: 818237@bugs.debian.org

Cc: Wolodja Wentland <debian@babilen5.org>, terceiro@debian.org

Subject: Re: Re: vagrant-libvirt: undefined method `group_by' for nil:NilClass (NoMethodError)

Date: Fri, 1 Apr 2016 13:50:04 +0200

Control: reassign 818237 vagrant

* Debian Bug Tracking System <owner@bugs.debian.org> [160401 13:27]:
> > reassign 818237 libruby2.3
> Bug #818237 [vagrant] vagrant-libvirt: undefined method `group_by' for nil:NilClass (NoMethodError)
> Bug reassigned from package 'vagrant' to 'libruby2.3'.
> No longer marked as found in versions vagrant/1.8.1+dfsg-1.

Well, no.

Just because someone on the internet says "here change this file
over there to make it go away" doesn't mean the bug is -in that file-.

The documentation for the function in question very specifically
says that it is not a stable interface for anyone to use. If vagrant
relies on assigning nil for a list, then that is a vagrant bug from
my PoV.

Note that vagrant upstream doesn't even say if they consider this a
bug or not, they just weasel around it by saying "our binary works",
when their binary just uses old versions of ruby, rubygems and
bundler.

I've checked that rubygems 2.6.2 shows the same behaviour, and I
assume that, if anybody else was using it this way, it would already
have been fixed.

If you need this fixed, please fix it in vagrant.

(vagrants bundler.rb looks like it relies on the very specifics of
how bundler and rubygems work internally. That is not a sane thing
to do, at least not if changes to it are not followed quickly.)

Best,
-- 
 ,''`.  Christian Hofstaedtler <zeha@debian.org>
: :' :  Debian Developer
`. `'   7D1A CFFA D9E0 806C 9C4C  D392 5C13 D6DB 9305 2E03
  `-

Message #28 received at 818237@bugs.debian.org (full text, mbox, reply):

From: Christian Hofstaedtler <zeha@debian.org>

To: 818237@bugs.debian.org

Cc: Wolodja Wentland <debian@babilen5.org>, terceiro@debian.org, debian-ruby@lists.debian.org

Subject: Re: Bug#818237: Re: vagrant-libvirt: undefined method `group_by' for nil:NilClass (NoMethodError)

Date: Fri, 1 Apr 2016 14:22:14 +0200

This might be a suitable patch for vagrant, but I clearly don't
understand enough of what vagrant is doing there in the first place.
(The patch makes vagrant plugin install vagrant-libvirt work for
me, but that's the only thing I tried.)

---
 lib/vagrant/bundler.rb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/vagrant/bundler.rb b/lib/vagrant/bundler.rb
index 5a5c185..c4a3837 100644
--- a/lib/vagrant/bundler.rb
+++ b/lib/vagrant/bundler.rb
@@ -272,7 +272,6 @@ module Vagrant
 
       # Reset the all specs override that Bundler does
       old_all = Gem::Specification._all
-      Gem::Specification.all = nil
 
       # /etc/gemrc and so on.
       old_config = nil
@@ -286,6 +285,8 @@ module Vagrant
       end
       Gem.configuration = NilGemConfig.new
 
+      Gem::Specification.reset
+
       # Use a silent UI so that we have no output
       Gem::DefaultUserInteraction.use_ui(Gem::SilentUI.new) do
         return yield

-- 
2.7.0

Message #33 received at 818237@bugs.debian.org (full text, mbox, reply):

From: Wolodja Wentland <debian@babilen5.org>

To: Christian Hofstaedtler <zeha@debian.org>, 818237@bugs.debian.org

Cc: terceiro@debian.org, debian-ruby@lists.debian.org

Subject: Re: Bug#818237: Re: vagrant-libvirt: undefined method `group_by' for nil:NilClass (NoMethodError)

Date: Fri, 01 Apr 2016 15:19:04 +0200

Christian Hofstaedtler <zeha@debian.org> writes:

> [ text/plain ]
> This might be a suitable patch for vagrant, but I clearly don't
> understand enough of what vagrant is doing there in the first place.
> (The patch makes vagrant plugin install vagrant-libvirt work for
> me, but that's the only thing I tried.)
[ patch ]

Thank you very much for looking into this, Christian! I have tried your
patch and it does indeed solve the issue at hand. I also follow your
reasoning and hope that vagrant upstream will look into this issue,
rather than "weasel around" the underlying issue as you so pointedly
said in an earlier mail.
-- 
Wolodja <debian@babilen5.org>

4096R/CAF14EFC
081C B7CD FF04 2BA9 94EA  36B2 8B7F 7D30 CAF1 4EFC

Message #44 received at 818237@bugs.debian.org (full text, mbox, reply):

From: Antonio Terceiro <terceiro@debian.org>

To: 818237@bugs.debian.org

Cc: Christian Hofstaedtler <zeha@debian.org>, Wolodja Wentland <debian@babilen5.org>, debian-ruby@lists.debian.org

Subject: Re: Bug#818237: Re: vagrant-libvirt: undefined method `group_by' for nil:NilClass (NoMethodError)

Date: Fri, 1 Apr 2016 11:34:11 -0300

[Message part 1 (text/plain, inline)]

Control: tag -1 pending

On Fri, Apr 01, 2016 at 02:22:14PM +0200, Christian Hofstaedtler wrote:
> This might be a suitable patch for vagrant, but I clearly don't
> understand enough of what vagrant is doing there in the first place.
> (The patch makes vagrant plugin install vagrant-libvirt work for
> me, but that's the only thing I tried.)

This seems to work for me as well. I have a locally-built package with
this patch installed here, and if nothing weird shows up I should upload
a fixed package during the weekend.

I have one question on the patch though:

> ---
>  lib/vagrant/bundler.rb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/vagrant/bundler.rb b/lib/vagrant/bundler.rb
> index 5a5c185..c4a3837 100644
> --- a/lib/vagrant/bundler.rb
> +++ b/lib/vagrant/bundler.rb
> @@ -272,7 +272,6 @@ module Vagrant
>  
>        # Reset the all specs override that Bundler does
>        old_all = Gem::Specification._all
> -      Gem::Specification.all = nil
>  
>        # /etc/gemrc and so on.
>        old_config = nil
> @@ -286,6 +285,8 @@ module Vagrant
>        end
>        Gem.configuration = NilGemConfig.new
>  
> +      Gem::Specification.reset
> +

any specific reason to put this call down here, instead of exactly in
the place of the broken one?

-- 
Antonio Terceiro <terceiro@debian.org>

[signature.asc (application/pgp-signature, inline)]

Message #51 received at 818237@bugs.debian.org (full text, mbox, reply):

From: Christian Hofstaedtler <zeha@debian.org>

To: Antonio Terceiro <terceiro@debian.org>

Cc: 818237@bugs.debian.org, Wolodja Wentland <debian@babilen5.org>, debian-ruby@lists.debian.org

Subject: Re: Bug#818237: Re: vagrant-libvirt: undefined method `group_by' for nil:NilClass (NoMethodError)

Date: Fri, 1 Apr 2016 17:04:31 +0200

* Antonio Terceiro <terceiro@debian.org> [160401 16:34]:
> On Fri, Apr 01, 2016 at 02:22:14PM +0200, Christian Hofstaedtler wrote:
> > ...

> I have one question on the patch though:
> 
> > diff --git a/lib/vagrant/bundler.rb b/lib/vagrant/bundler.rb
[..]
> >        # Reset the all specs override that Bundler does
> >        old_all = Gem::Specification._all
> > -      Gem::Specification.all = nil
> >  
> >        # /etc/gemrc and so on.
> >        old_config = nil
> > @@ -286,6 +285,8 @@ module Vagrant
> >        end
> >        Gem.configuration = NilGemConfig.new
> >  
> > +      Gem::Specification.reset
> > +
> 
> any specific reason to put this call down here, instead of exactly in
> the place of the broken one?

I -guessed- that Gem.configuration = NilGemConfig.new may reset
Gem.(pre|post)_reset_hooks, but upon closer inspection it doesn't
appear to do that.

As such, no good reason to move it.

-- 
 ,''`.  Christian Hofstaedtler <zeha@debian.org>
: :' :  Debian Developer
`. `'   7D1A CFFA D9E0 806C 9C4C  D392 5C13 D6DB 9305 2E03
  `-

Message #56 received at 818237@bugs.debian.org (full text, mbox, reply):

From: Wolodja Wentland <debian@babilen5.org>

To: Christian Hofstaedtler <zeha@debian.org>, Antonio Terceiro <terceiro@debian.org>

Cc: 818237@bugs.debian.org, debian-ruby@lists.debian.org

Subject: Re: Bug#818237: Re: vagrant-libvirt: undefined method `group_by' for nil:NilClass (NoMethodError)

Date: Sun, 03 Apr 2016 14:13:13 +0200

Christian Hofstaedtler <zeha@debian.org> writes:

> [ text/plain ]
> * Antonio Terceiro <terceiro@debian.org> [160401 16:34]:
>> On Fri, Apr 01, 2016 at 02:22:14PM +0200, Christian Hofstaedtler wrote:

> As such, no good reason to move it.

Due to our discussion the following PR has been submitted to upstream:
https://github.com/mitchellh/vagrant/pull/7198.
-- 
Wolodja <debian@babilen5.org>

4096R/CAF14EFC
081C B7CD FF04 2BA9 94EA  36B2 8B7F 7D30 CAF1 4EFC

Message #57 received at 817014-close@bugs.debian.org (full text, mbox, reply):

From: Antonio Terceiro <terceiro@debian.org>

To: 817014-close@bugs.debian.org

Subject: Bug#817014: fixed in vagrant 1.8.1+dfsg-2

Date: Sun, 03 Apr 2016 22:26:27 +0000

Source: vagrant
Source-Version: 1.8.1+dfsg-2

We believe that the bug you reported is fixed in the latest version of
vagrant, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 817014@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Antonio Terceiro <terceiro@debian.org> (supplier of updated vagrant package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 03 Apr 2016 18:57:57 -0300
Source: vagrant
Binary: vagrant
Architecture: source
Version: 1.8.1+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Antonio Terceiro <terceiro@debian.org>
Changed-By: Antonio Terceiro <terceiro@debian.org>
Description:
 vagrant    - Tool for building and distributing virtualized development enviro
Closes: 817014
Changes:
 vagrant (1.8.1+dfsg-2) unstable; urgency=medium
 .
   [ Christian Hofstaedtler ]
   * Fix Vagrant::Bundler to work against Rubygems from Ruby 2.3
     (Closes: #817014)
 .
   [ Antonio Terceiro ]
   * debian/tests/smoke-test: add simple plugin installation step to smoke test
     to catch any future issues with that.
   * Renumber patches
   * Bump Standards-Version to 3.9.7, no changes needed
   * Change Vcs-* to use https URLs
Checksums-Sha1:
 296e329372519999683efba0a7d62ca567378648 1984 vagrant_1.8.1+dfsg-2.dsc
 eadd3d8291372f2234f49ba83430a0ff7344b4c1 12760 vagrant_1.8.1+dfsg-2.debian.tar.xz
Checksums-Sha256:
 37e7b84642da6534f3fa4bb7047e949de032b2121cd055af2af49b4901b3a0e1 1984 vagrant_1.8.1+dfsg-2.dsc
 2d1751cf0c303c510366e16d7d2692ec04f5652c835ac8b7531f1c8494617f7d 12760 vagrant_1.8.1+dfsg-2.debian.tar.xz
Files:
 35b3bc9db87c74e839ed16a7801fc7a5 1984 admin optional vagrant_1.8.1+dfsg-2.dsc
 44486e29545b345fd704940055b56b45 12760 admin optional vagrant_1.8.1+dfsg-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXAZLKAAoJEPwNsbvNRgveRkUP/jfaC6UBgEJZlpuONcOSJAIg
12v8/KzLtORoNNzSMiRftL2cMqDPx/r8L9HGNbjxrxZgu1sZt/W+syLd5i0ZY6Zm
UK6hHOHqH3D2Ioc3S3KyfCSlzC/auBFVRBgnkLz7egG+BuBLpC7u/INiY4O9n+RI
mDgU3ImLXtxM0DPwhfZjR4LFJ/N1PBThaTbVjKtCYyAu4O9WYYWCiGtxBnRjW0u/
lUkecacCzwOyN0qJG+IuX6LjD8jZZufCP7UZ2h5+db3LiWXrQVOVGdlPELk9tDgy
wOTjLpGZJJRc3bQ/QYEPHiF/dPgVdiN+/xF665BagEHVXep+iLM6/pI7IfCY570d
ici82DPm5FicI98QWnEN8zvWJJY5yJLQu4R78fLqkU8uK/c81jzGmp/Aca1QQiET
TuR4cLiV793zhM4wqa8UB1P7xzTz5YF9rUx8IycqyWromiyyWFP1cjstETITGSsz
gC0TJjap4EsMumgGi4j1go+2dCDoOfM7uJGwxOdZd2A+Q1MyUhCzZ3mm/yNNuFP6
Afcm+4BBU6qWQRm/ZGKCXf5ZVPUQ0aI6+NvH24/jbQD02LquCDEWrRMKr2Rjy5N+
0K25/bLIl/Py3VfjgkZJ6gAYf8L6PnTcjKp450GfLNvn10yxvz5UDFbM3vVREXw0
DLizPQirN61l//ohrLck
=AmtA
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.