Debian Bug report logs - #817940
multipath-tools: multipathd is not linked to libsystemd, fails to notify systemd when ready

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Ryan Harper <ryan.harper@canonical.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: multipath-tools: multipathd is not linked to libsystemd, fails to notify systemd when ready

Date: Fri, 11 Mar 2016 13:05:39 -0600

[Message part 1 (text/plain, inline)]

Package: multipath-tools
Version: 0.5.0+git1.656f8865-5
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu xenial ubuntu-patch

Dear Maintainer,

When installing multipath-tools package on Debian stretch/sid, the package fails
to start.

Setting up kpartx (0.5.0+git1.656f8865-5) ...
Setting up multipath-tools (0.5.0+git1.656f8865-5) ...
Job for multipathd.service failed because the control process exited with error
code. See "systemctl status multipathd.service" and "journalctl -xe" for
details.
invoke-rc.d: initscript multipath-tools, action "start" failed.
dpkg: error processing package multipath-tools (--configure):
subprocess installed post-installation script returned error exit status 1


Looking at systemctl status -l multipathd  we can see that the service timed
out and gets killed.  However, during this start-up period, multipathd is
functional, one can issue multipath -ll and other commands.


# systemctl status multipathd
● multipathd.service - Device-Mapper Multipath Device Controller
   Loaded: loaded (/lib/systemd/system/multipathd.service; enabled; vendor prese
   Active: failed (Result: timeout) since Fri 2016-03-11 13:00:03 CST; 14s ago
 Main PID: 1176 (code=exited, status=0/SUCCESS)

Mar 11 12:58:33 debian systemd[1]: Starting Device-Mapper Multipath Device Contr
Mar 11 12:58:33 debian multipathd[1176]: could not create uxsock: 98
Mar 11 12:58:33 debian multipathd[1176]: path checkers start up
Mar 11 13:00:03 debian systemd[1]: multipathd.service: Start operation timed out
Mar 11 13:00:03 debian multipathd[1176]: --------shut down-------
Mar 11 13:00:03 debian systemd[1]: Failed to start Device-Mapper Multipath Devic
Mar 11 13:00:03 debian systemd[1]: multipathd.service: Unit entered failed state
Mar 11 13:00:03 debian systemd[1]: multipathd.service: Failed with result 'timeo


The systemd service file for multipathd uses Type=notify which means that
multipathd will issue sd_notify() calls via libsystemd linkage to systemd itself
to indicate when it is ready.

Using ldd to examine /sbin/multipathd and it does not show a link to libsystemd.

root@debian:~# ldd /sbin/multipathd  | grep systemd
root@debian:~# ldd /sbin/multipathd 
	linux-vdso.so.1 (0x00007ffd25ba4000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f2a316b4000)
	libdevmapper.so.1.02.1 => /lib/x86_64-linux-gnu/libdevmapper.so.1.02.1 (0x00007f2a31458000)
	libreadline.so.6 => /lib/x86_64-linux-gnu/libreadline.so.6 (0x00007f2a3120d000)
	libudev.so.1 => /lib/x86_64-linux-gnu/libudev.so.1 (0x00007f2a311ed000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f2a30fe9000)
	libmultipath.so.0 => /lib/libmultipath.so.0 (0x00007f2a30d9c000)
	libmpathpersist.so.0 => /lib/libmpathpersist.so.0 (0x00007f2a30b94000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f2a307f0000)
	/lib64/ld-linux-x86-64.so.2 (0x00005603084da000)
	librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f2a305e7000)
	libselinux.so.1 => /lib/x86_64-linux-gnu/libselinux.so.1 (0x00007f2a303c5000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f2a300c0000)
	libtinfo.so.5 => /lib/x86_64-linux-gnu/libtinfo.so.5 (0x00007f2a2fe95000)
	libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007f2a2fc25000)


This is a result of the debian/rules file which attempts to build multipathd
twice, once with USE_SYSTEMD=1 (for the system) and USE_SYSTEMD=1 for the udeb
packaging (for the debian installer).

Looking closely at a build-log of the package, we can see that when run the
rule 'build-stamp', we invoke make with USE_SYSTEMD=1, however, make does not
find that any of the files in the tree have been modified and does not bother
to recompile any of the packages.

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/rules: add clean-tree to build-stamp to ensure multipathd
    builds with USE_SYSTEMD=1

The simplest, (though maybe not optimal) fix was to have build-stamp depend on
clean-tree target which will run make clean prior to building multipath-tools
with the USE_SYSTEMD=1 and ulimately have multipathd link against libsystemd.

The result is now that multipathd.service can start properly.

Thanks for considering the patch.


-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-7-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

[multipath-tools_0.5.0+git1.656f8865-5ubuntu1.debdiff (text/x-diff, attachment)]

Message #10 received at 817940@bugs.debian.org (full text, mbox, reply):

From: Ritesh Raj Sarraf <rrs@debian.org>

To: Ryan Harper <ryan.harper@canonical.com>, 817940@bugs.debian.org

Subject: Re: Bug#817940: multipath-tools: multipathd is not linked to libsystemd, fails to notify systemd when ready

Date: Sat, 12 Mar 2016 16:08:03 +0530

[Message part 1 (text/plain, inline)]

Hello Ryan,


Thank you for the root cause and the patch. I have applied, built and
verified it. It will be part of the next upload.


Thanks,
Ritesh


On Fri, 2016-03-11 at 13:05 -0600, Ryan Harper wrote:
> Package: multipath-tools
> Version: 0.5.0+git1.656f8865-5
> Severity: normal
> Tags: patch
> User: ubuntu-devel@lists.ubuntu.com
> Usertags: origin-ubuntu xenial ubuntu-patch
> 
> Dear Maintainer,
> 
> When installing multipath-tools package on Debian stretch/sid, the
> package fails
> to start.
> 
> Setting up kpartx (0.5.0+git1.656f8865-5) ...
> Setting up multipath-tools (0.5.0+git1.656f8865-5) ...
> Job for multipathd.service failed because the control process exited
> with error
> code. See "systemctl status multipathd.service" and "journalctl -xe"
> for
> details.
> invoke-rc.d: initscript multipath-tools, action "start" failed.
> dpkg: error processing package multipath-tools (--configure):
> subprocess installed post-installation script returned error exit
> status 1
> 
> 
> Looking at systemctl status -l multipathd  we can see that the
> service timed
> out and gets killed.  However, during this start-up period,
> multipathd is
> functional, one can issue multipath -ll and other commands.
> 
> 
> # systemctl status multipathd
> ● multipathd.service - Device-Mapper Multipath Device Controller
>    Loaded: loaded (/lib/systemd/system/multipathd.service; enabled;
> vendor prese
>    Active: failed (Result: timeout) since Fri 2016-03-11 13:00:03
> CST; 14s ago
>  Main PID: 1176 (code=exited, status=0/SUCCESS)
> 
> Mar 11 12:58:33 debian systemd[1]: Starting Device-Mapper Multipath
> Device Contr
> Mar 11 12:58:33 debian multipathd[1176]: could not create uxsock: 98
> Mar 11 12:58:33 debian multipathd[1176]: path checkers start up
> Mar 11 13:00:03 debian systemd[1]: multipathd.service: Start
> operation timed out
> Mar 11 13:00:03 debian multipathd[1176]: --------shut down-------
> Mar 11 13:00:03 debian systemd[1]: Failed to start Device-Mapper
> Multipath Devic
> Mar 11 13:00:03 debian systemd[1]: multipathd.service: Unit entered
> failed state
> Mar 11 13:00:03 debian systemd[1]: multipathd.service: Failed with
> result 'timeo
> 
> 
> The systemd service file for multipathd uses Type=notify which means
> that
> multipathd will issue sd_notify() calls via libsystemd linkage to
> systemd itself
> to indicate when it is ready.
> 
> Using ldd to examine /sbin/multipathd and it does not show a link to
> libsystemd.
> 
> root@debian:~# ldd /sbin/multipathd  | grep systemd
> root@debian:~# ldd /sbin/multipathd 
> 	linux-vdso.so.1 (0x00007ffd25ba4000)
> 	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0
> (0x00007f2a316b4000)
> 	libdevmapper.so.1.02.1 => /lib/x86_64-linux-
> gnu/libdevmapper.so.1.02.1 (0x00007f2a31458000)
> 	libreadline.so.6 => /lib/x86_64-linux-gnu/libreadline.so.6
> (0x00007f2a3120d000)
> 	libudev.so.1 => /lib/x86_64-linux-gnu/libudev.so.1
> (0x00007f2a311ed000)
> 	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2
> (0x00007f2a30fe9000)
> 	libmultipath.so.0 => /lib/libmultipath.so.0
> (0x00007f2a30d9c000)
> 	libmpathpersist.so.0 => /lib/libmpathpersist.so.0
> (0x00007f2a30b94000)
> 	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6
> (0x00007f2a307f0000)
> 	/lib64/ld-linux-x86-64.so.2 (0x00005603084da000)
> 	librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1
> (0x00007f2a305e7000)
> 	libselinux.so.1 => /lib/x86_64-linux-gnu/libselinux.so.1
> (0x00007f2a303c5000)
> 	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6
> (0x00007f2a300c0000)
> 	libtinfo.so.5 => /lib/x86_64-linux-gnu/libtinfo.so.5
> (0x00007f2a2fe95000)
> 	libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3
> (0x00007f2a2fc25000)
> 
> 
> This is a result of the debian/rules file which attempts to build
> multipathd
> twice, once with USE_SYSTEMD=1 (for the system) and USE_SYSTEMD=1 for
> the udeb
> packaging (for the debian installer).
> 
> Looking closely at a build-log of the package, we can see that when
> run the
> rule 'build-stamp', we invoke make with USE_SYSTEMD=1, however, make
> does not
> find that any of the files in the tree have been modified and does
> not bother
> to recompile any of the packages.
> 
> In Ubuntu, the attached patch was applied to achieve the following:
> 
>   * debian/rules: add clean-tree to build-stamp to ensure multipathd
>     builds with USE_SYSTEMD=1
> 
> The simplest, (though maybe not optimal) fix was to have build-stamp
> depend on
> clean-tree target which will run make clean prior to building
> multipath-tools
> with the USE_SYSTEMD=1 and ulimately have multipathd link against
> libsystemd.
> 
> The result is now that multipathd.service can start properly.
> 
> Thanks for considering the patch.
> 
> 
> -- System Information:
> Debian Release: stretch/sid
>   APT prefers xenial-updates
>   APT policy: (500, 'xenial-updates'), (500, 'xenial-security'),
> (500, 'xenial'), (100, 'xenial-backports')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
> 
> Kernel: Linux 4.4.0-7-generic (SMP w/4 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
-- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 817940-close@bugs.debian.org (full text, mbox, reply):

From: Ritesh Raj Sarraf <rrs@debian.org>

To: 817940-close@bugs.debian.org

Subject: Bug#817940: fixed in multipath-tools 0.5.0+git1.656f8865-6

Date: Sat, 12 Mar 2016 15:54:46 +0000

Source: multipath-tools
Source-Version: 0.5.0+git1.656f8865-6

We believe that the bug you reported is fixed in the latest version of
multipath-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 817940@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ritesh Raj Sarraf <rrs@debian.org> (supplier of updated multipath-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 12 Mar 2016 17:47:25 +0530
Source: multipath-tools
Binary: multipath-tools multipath-tools-dbg kpartx multipath-tools-boot multipath-udeb kpartx-udeb
Architecture: source amd64 all
Version: 0.5.0+git1.656f8865-6
Distribution: unstable
Urgency: medium
Maintainer: Debian LVM Team <pkg-lvm-maintainers@lists.alioth.debian.org>
Changed-By: Ritesh Raj Sarraf <rrs@debian.org>
Description:
 kpartx     - create device mappings for partitions
 kpartx-udeb - create device mappings for partitions - udeb package (udeb)
 multipath-tools - maintain multipath block device access
 multipath-tools-boot - Support booting from multipath devices
 multipath-tools-dbg - maintain multipath block device access - debugging symbols
 multipath-udeb - maintain multipath block device access - udeb package (udeb)
Closes: 806082 814625 817147 817940
Changes:
 multipath-tools (0.5.0+git1.656f8865-6) unstable; urgency=medium
 .
   * [c791eeb] Restrict architecture to linux-any because
     multipath-tools is a Linux only tool
   * [a7baa90] Build binary independent deb package in respective target.
     Thanks to Santiago Vila (Closes: #806082)
   * [1d35c3c] Fix insecure URIs
   * [bfc44fb] Install -boot init script in correct package
   * [76cd8dc] Separate m-t-b's lintian overrides
   * [715ff28] Add separate lintian overrides for m-t-b
   * [7d81d4f] Call clean target before rebuilding with systemd support.
     Thanks to Ryan Harper (Closes: #817940)
   * [5156f96] Make build cleaner for reproducible builds.
     Thanks to Santiago Vila
   * Also close other bugs fixed by this release
     (Closes: #814625, #817147)
   * [9922d0a] Hand install multipath-tools-boot lintian override file
   * [7664de3] Add comments to lintian overrides explaning the reason for
     the overrides
Checksums-Sha1:
 7ad0f9fe398e452c76d648610754d83a3f096162 2587 multipath-tools_0.5.0+git1.656f8865-6.dsc
 d30283d53673633c527d975dc04b5b299498cf4c 26560 multipath-tools_0.5.0+git1.656f8865-6.debian.tar.xz
 740f1a6596c558487b084efda2fbf5607f2e04ad 15544 kpartx-udeb_0.5.0+git1.656f8865-6_amd64.udeb
 aa57cfd4d59847f6e5319c6cec64b8656b2dbd01 32316 kpartx_0.5.0+git1.656f8865-6_amd64.deb
 a8d7f34df8eb53a70ae1eb94b1a95fbe120543f6 19852 multipath-tools-boot_0.5.0+git1.656f8865-6_all.deb
 b9ce87332aab4d62152a118de233ec6017464113 388352 multipath-tools-dbg_0.5.0+git1.656f8865-6_amd64.deb
 779cc697270ea26a5276bc0a6a417972e42abb77 198430 multipath-tools_0.5.0+git1.656f8865-6_amd64.deb
 b28e29b4ca401531a911059235b9a90f2e739b29 126776 multipath-udeb_0.5.0+git1.656f8865-6_amd64.udeb
Checksums-Sha256:
 9e7295dfaf618226d9741596a72d73a44fd21124938db2d4e5ab66188c6f7d34 2587 multipath-tools_0.5.0+git1.656f8865-6.dsc
 b99ae70f63dbefbc6819ad20b3ff197e8058b044a48379f093367d9ad7cc998e 26560 multipath-tools_0.5.0+git1.656f8865-6.debian.tar.xz
 d3c8eb9d04611903acd9b1bac9bd9e2519531345df2dddbd5768cae54c106df0 15544 kpartx-udeb_0.5.0+git1.656f8865-6_amd64.udeb
 65cbe5131b9d98960750c5f861f7f943c587d444f25473fd77f9bc980f7c4c7e 32316 kpartx_0.5.0+git1.656f8865-6_amd64.deb
 f9047a49151dc0d79d1aaafa86180643fc5f049fbd5c21dda9762fb1baf917f9 19852 multipath-tools-boot_0.5.0+git1.656f8865-6_all.deb
 10c13e687abe4bf963a9a8fb61b3d48ce0682d4a0fa5c201ec775f2edd316ea7 388352 multipath-tools-dbg_0.5.0+git1.656f8865-6_amd64.deb
 cd310433d52b0f432489fd6165f3a1724511242b13f3642646f4604ba68676de 198430 multipath-tools_0.5.0+git1.656f8865-6_amd64.deb
 791df5f62eaddc43818c272726990acde75481f8fba8c88b7e0af78a8d4a7ea2 126776 multipath-udeb_0.5.0+git1.656f8865-6_amd64.udeb
Files:
 c1e2ca5c6578874bed261976c28c5b98 2587 admin extra multipath-tools_0.5.0+git1.656f8865-6.dsc
 7edbd6b9711c461cd1102ed055476c39 26560 admin extra multipath-tools_0.5.0+git1.656f8865-6.debian.tar.xz
 f41998c22025a5f661566fddc71f3c92 15544 debian-installer extra kpartx-udeb_0.5.0+git1.656f8865-6_amd64.udeb
 627e4a3fbd860efbefc639b6eabc2b05 32316 admin extra kpartx_0.5.0+git1.656f8865-6_amd64.deb
 7135de0892613c9c3e231910ac1b30b7 19852 admin extra multipath-tools-boot_0.5.0+git1.656f8865-6_all.deb
 23c2a6435b7a6014e4e4daac81189e8b 388352 debug extra multipath-tools-dbg_0.5.0+git1.656f8865-6_amd64.deb
 9b12574eb4e8ffcab2b76def44781c73 198430 admin extra multipath-tools_0.5.0+git1.656f8865-6_amd64.deb
 e9fd345408ea6681cf3c2f4d84a2744a 126776 debian-installer extra multipath-udeb_0.5.0+git1.656f8865-6_amd64.udeb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJW5B6xAAoJEKY6WKPy4XVpoUoP/09owiJtciFafaA9gtIkxEiN
gU5Pzq4C6ggk59FERnjbmNDa9BUIGPFnLRHqo4NnWQw9FxQGf1FrlpSELOf8WoXU
kvPF9AQ8pSkyBiTgTg05wCojRrX49Wh2aXK5dUPQk+SgBrphm2j4KUJ7w4E7ilsk
YHaYoSHhYV+njtoGWFjtX1zzxJSk7lT7Qjbl0pfS36AZ364epe1rk3RBXW9TNyNc
YKG3y5VgWHgsNOKBMzy00eQanI1jUmYfiqtjUmhs739K0JBHj9SUy0fPlihBZWoa
at6CI7mmOw0Dl5OsZF8jWp/fgIsIzvZ0NnOOEeKOc1w9rgWTUpsiofl0Qf++rOVX
C/wsD+IaOXm09oKsqrItqibGHXFYK5C9eyWn5AMsOCJZxrRb4hZqrL+XyfFHNcjH
DVKmrHCRnne6F8c6xmEJCuGEeKW9vlwRX1OJCdrmC8kPhGczjzO9qBZ+Xn5fOkx5
ESTr1RPvgw1/t7hsIS4k51FvxJYYlfpIILAnQbgPzEptsCpesCUUZyMwkE9PHEL8
bvhdpDwjZ42iEX6MINFjq6RtfTBUVvOaJxmUZiY8mnF+JHI+tQ4bLwNKPScQOh+U
hb5UnFUVatTj5P+tTeEJvLD4oBAk/NQApynMiTGAU5f858z3aWQCQ/Xa5Tel1J0a
U6g89X6POAAFixbdmVq4
=8IXD
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.