Debian Bug report logs - #817023
os-prober doesn't detect EFI partition on MBR

version graph

Package: os-prober; Maintainer for os-prober is Debian Install System Team <debian-boot@lists.debian.org>; Source for os-prober is src:os-prober (PTS, buildd, popcon).

Reported by: kay <kay.diam@gmail.com>

Date: Mon, 7 Mar 2016 09:54:02 UTC

Severity: normal

Tags: patch

Found in versions os-prober/1.71, os-prober/1.65

Fixed in versions os-prober/1.76, os-prober/1.65+deb8u1

Done: Cyril Brulebois <kibi@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Debian Install System Team <debian-boot@lists.debian.org>:
Bug#817023; Package os-prober. (Mon, 07 Mar 2016 09:54:06 GMT) (full text, mbox, link).


Acknowledgement sent to kay <kay.diam@gmail.com>:
New Bug report received and forwarded. Copy sent to Debian Install System Team <debian-boot@lists.debian.org>. (Mon, 07 Mar 2016 09:54:06 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: kay <kay.diam@gmail.com>
To: submit@bugs.debian.org
Subject: os-prober doesn't detect EFI partition on MBR
Date: Mon, 7 Mar 2016 10:50:33 +0100
Package: os-prober
Version: 1.71

Also reproducible in os-prober 1.65

https://anonscm.debian.org/cgit/d-i/os-prober.git/tree/os-probes/mounted/x86/05efi#n42..n45

Disk has regular MBR table. It has Windows 7 and Ubuntu installed on
different partitions. Os-prober doesn't detect EFI partition on MBR
table because "udevadm info" returns "dos" partition scheme instead of
expected "msdos".

  $ udevadm info /dev/sda1 | grep dos
  E: ID_PART_ENTRY_SCHEME=dos
  E: ID_PART_TABLE_TYPE=dos

  $ fdisk -lu /dev/sda | grep -B1 -A1 ef
     Device Boot Start End Blocks Id System
  /dev/sda1 * 2048 616447 307200 ef EFI (FAT-12/16/32)
  /dev/sda2 616448 128134439 63758996 7 HPFS/NTFS/exFAT

Fixing conditions below resolves the issue:

- \( "$ID_PART_ENTRY_SCHEME" != gpt -a "$ID_PART_ENTRY_SCHEME" != msdos \) -o \
+ \( "$ID_PART_ENTRY_SCHEME" != gpt -a "$ID_PART_ENTRY_SCHEME" != dos \) -o \
  \( "$ID_PART_ENTRY_SCHEME" = gpt -a "$ID_PART_ENTRY_TYPE" !=
c12a7328-f81f-11d2-ba4b-00a0c93ec93b \) -o \
- \( "$ID_PART_ENTRY_SCHEME" = msdos -a "$ID_PART_ENTRY_TYPE" != 0xef \) ]; then
+ \( "$ID_PART_ENTRY_SCHEME" = dos -a "$ID_PART_ENTRY_TYPE" != 0xef \) ]; then

Probably this bug relates to udevinfo replacement
(https://lists.debian.org/debian-user/2010/07/msg01134.html).

P.S. Cross-posting report in ubuntu launchpad
https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1553678



Marked as found in versions os-prober/1.65. Request was from Rene Engelhard <rene@debian.org> to control@bugs.debian.org. (Mon, 07 Mar 2016 10:33:28 GMT) (full text, mbox, link).


Added tag(s) patch. Request was from Rene Engelhard <rene@debian.org> to control@bugs.debian.org. (Mon, 07 Mar 2016 10:33:29 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Debian Install System Team <debian-boot@lists.debian.org>:
Bug#817023; Package os-prober. (Sat, 24 Jun 2017 17:33:05 GMT) (full text, mbox, link).


Acknowledgement sent to Cyril Brulebois <kibi@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian Install System Team <debian-boot@lists.debian.org>. (Sat, 24 Jun 2017 17:33:05 GMT) (full text, mbox, link).


Message #14 received at 817023@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>
To: kay <kay.diam@gmail.com>, 817023@bugs.debian.org
Cc: Steve McIntyre <steve@einval.com>
Subject: Re: Bug#817023: os-prober doesn't detect EFI partition on MBR
Date: Sat, 24 Jun 2017 19:31:27 +0200
[Message part 1 (text/plain, inline)]
Hi,

kay <kay.diam@gmail.com> (2016-03-07):
> Package: os-prober
> Version: 1.71
> 
> Also reproducible in os-prober 1.65
> 
> https://anonscm.debian.org/cgit/d-i/os-prober.git/tree/os-probes/mounted/x86/05efi#n42..n45
> 
> Disk has regular MBR table. It has Windows 7 and Ubuntu installed on
> different partitions. Os-prober doesn't detect EFI partition on MBR
> table because "udevadm info" returns "dos" partition scheme instead of
> expected "msdos".
> 
>   $ udevadm info /dev/sda1 | grep dos
>   E: ID_PART_ENTRY_SCHEME=dos
>   E: ID_PART_TABLE_TYPE=dos
> 
>   $ fdisk -lu /dev/sda | grep -B1 -A1 ef
>      Device Boot Start End Blocks Id System
>   /dev/sda1 * 2048 616447 307200 ef EFI (FAT-12/16/32)
>   /dev/sda2 616448 128134439 63758996 7 HPFS/NTFS/exFAT
> 
> Fixing conditions below resolves the issue:
> 
> - \( "$ID_PART_ENTRY_SCHEME" != gpt -a "$ID_PART_ENTRY_SCHEME" != msdos \) -o \
> + \( "$ID_PART_ENTRY_SCHEME" != gpt -a "$ID_PART_ENTRY_SCHEME" != dos \) -o \
>   \( "$ID_PART_ENTRY_SCHEME" = gpt -a "$ID_PART_ENTRY_TYPE" !=
> c12a7328-f81f-11d2-ba4b-00a0c93ec93b \) -o \
> - \( "$ID_PART_ENTRY_SCHEME" = msdos -a "$ID_PART_ENTRY_TYPE" != 0xef \) ]; then
> + \( "$ID_PART_ENTRY_SCHEME" = dos -a "$ID_PART_ENTRY_TYPE" != 0xef \) ]; then
> 
> Probably this bug relates to udevinfo replacement
> (https://lists.debian.org/debian-user/2010/07/msg01134.html).
> 
> P.S. Cross-posting report in ubuntu launchpad
> https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1553678

So I've tracked this to udev in systemd.git calling blkid functions to
get the partition type, and to libblkid/src/partitions/dos.c in
util-linux.git; it doesn't seem to have been called msdos previously,
so I think the proposed change looks good.

This needs to be backported to jessie and stretch AFAICT.

Cc-ing Steve since this involves EFI though, to have another pair of
eyes go over this.


KiBi.
[signature.asc (application/pgp-signature, inline)]

Reply sent to Christian Perrier <bubulle@debian.org>:
You have taken responsibility. (Wed, 28 Jun 2017 06:06:04 GMT) (full text, mbox, link).


Notification sent to kay <kay.diam@gmail.com>:
Bug acknowledged by developer. (Wed, 28 Jun 2017 06:06:04 GMT) (full text, mbox, link).


Message #19 received at 817023-close@bugs.debian.org (full text, mbox, reply):

From: Christian Perrier <bubulle@debian.org>
To: 817023-close@bugs.debian.org
Subject: Bug#817023: fixed in os-prober 1.76
Date: Wed, 28 Jun 2017 06:03:10 +0000
Source: os-prober
Source-Version: 1.76

We believe that the bug you reported is fixed in the latest version of
os-prober, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 817023@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated os-prober package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 28 Jun 2017 07:08:36 +0200
Source: os-prober
Binary: os-prober-udeb os-prober
Architecture: source i386
Version: 1.76
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description:
 os-prober  - utility to detect other OSes on a set of drives
 os-prober-udeb - utility to detect other OSes on a set of drives (udeb)
Closes: 817023
Changes:
 os-prober (1.76) unstable; urgency=medium
 .
   [ Cyril Brulebois ]
   * os-probes/mounted/x86/05efi: Fix check on ID_PART_ENTRY_SCHEME, to
     look for "dos" instead of "msdos" (Closes: #817023).
Checksums-Sha1:
 9a9cce79b186dfc0d39c161e89bd727b2388889e 1738 os-prober_1.76.dsc
 7434eef47887d820f8f4cc2f0f99afe50b22adbd 26432 os-prober_1.76.tar.xz
 433f296d850ac80650cd6b028c5b4be4bf5800cb 4180 os-prober-dbgsym_1.76_i386.deb
 30aea3afbdeeb39e938c5236cf1c318514fdae5e 14324 os-prober-udeb_1.76_i386.udeb
 5d10308829384543a04e9f8681ae2cdf1d06d69c 4915 os-prober_1.76_i386.buildinfo
 ddc63f4864197fc8076ab82949460d392cd2936f 30138 os-prober_1.76_i386.deb
Checksums-Sha256:
 beec2aa316b3e5acb6e26d7873af3dd6ea21a78cb3b9688350923665b08b8197 1738 os-prober_1.76.dsc
 d3a580610e0148ee1fea98de993b27b856870fb0a31e9ce1a33be2654e2c64ed 26432 os-prober_1.76.tar.xz
 1c228406b2d0e38880d2bf2a039bfd49e4f1d160c0a289713979f28e60b4eb17 4180 os-prober-dbgsym_1.76_i386.deb
 a1c604d56970fc6f82509368894885c00218bf0bfc4eacdab7772095c4432026 14324 os-prober-udeb_1.76_i386.udeb
 8aef2bab342d59fca435eb36ab77bd160e3f2c833c6ae18ca270569697c028fe 4915 os-prober_1.76_i386.buildinfo
 87d517767ee233edf46befdc5b5bf878b11d1ff8ffe7ebb2861f9ac41b6c0930 30138 os-prober_1.76_i386.deb
Files:
 efd9d0fffd4e7df3685ccedc1257753c 1738 debian-installer optional os-prober_1.76.dsc
 c4579128b997b4b6927f7c6793f5133e 26432 debian-installer optional os-prober_1.76.tar.xz
 52c5d02e4eed9a6f55c306fb7229f981 4180 debug extra os-prober-dbgsym_1.76_i386.deb
 5f5294e2de8e0837d638d914ccafa279 14324 debian-installer optional os-prober-udeb_1.76_i386.udeb
 995853310bf562f27d671f9e8350f22e 4915 debian-installer optional os-prober_1.76_i386.buildinfo
 fce28b52b00cc76e5676ff287e7a1ed7 30138 utils extra os-prober_1.76_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJZUz5VAAoJEIcvcCxNbiWoGOsP/3On+kRyLe5DigKw6+02vEc5
m/gcVtfPsH/y3ID8GAapxlPiXW7Jgwz4Kg4+7My+3E6yPVoa8IKD+pqBHI1CONpa
KT5HSZz/korIKMov5SZ6u+hd9dwxKaIeRQ/rG1ltT4TcxgiKb7ialpJJPnUwq/7P
crioxtizhJbMsrqny/oiXsIrJe+Q1h2fieXsTbNhTwC2ShkMqf3L71vS7AoewHaH
L05iMU43xa0cmK16s6omul2gS53Zdfmwq14/hx4BGnf5upoNQhPpLGXCWXNk6YK1
poLcaehGQdI5CMZjTzsHiKsl+XurWJL9wvOqeSUOc3FhXIdeJ4/Sdtqddk/Y8yuF
WQwDqrIV+1L1xgQ3GuTrfDovV5I3gaGSTIPBLG9ty82VevkSo4rDiJk7PvfBSktj
IfDgipChRFyvUZVsg0An7kpJbn4waUBO8WSAa72/JuOJI8RmNGgaugGJT2KDmqtg
tlhw84fDEKzVEuO0zEanCWJadxkA+YYR132uUf4+jntuxfgkv/IM9XNI/ps86m6z
dxLWwYF4sGKh6ieIdSmpgdM0XsmJSMqO7v9VXwnWKEj+WYF8QEFXQM8EgHQwCYUy
oSR8PULdgT5PZUhE3iueBDMrLxfplTYuQyaygseSXpIvuHNDM5FVImv9cp7PQRR8
Vdx0EHy6Iv7qi73XgKCo
=pkwq
-----END PGP SIGNATURE-----




Reply sent to Cyril Brulebois <kibi@debian.org>:
You have taken responsibility. (Sat, 15 Jul 2017 21:51:18 GMT) (full text, mbox, link).


Notification sent to kay <kay.diam@gmail.com>:
Bug acknowledged by developer. (Sat, 15 Jul 2017 21:51:18 GMT) (full text, mbox, link).


Message #24 received at 817023-close@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>
To: 817023-close@bugs.debian.org
Subject: Bug#817023: fixed in os-prober 1.65+deb8u1
Date: Sat, 15 Jul 2017 21:49:22 +0000
Source: os-prober
Source-Version: 1.65+deb8u1

We believe that the bug you reported is fixed in the latest version of
os-prober, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 817023@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Cyril Brulebois <kibi@debian.org> (supplier of updated os-prober package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 13 Jul 2017 13:25:12 +0200
Source: os-prober
Binary: os-prober-udeb os-prober
Architecture: source amd64
Version: 1.65+deb8u1
Distribution: jessie
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Cyril Brulebois <kibi@debian.org>
Description:
 os-prober  - utility to detect other OSes on a set of drives
 os-prober-udeb - utility to detect other OSes on a set of drives (udeb)
Closes: 791383 801278 817023
Changes:
 os-prober (1.65+deb8u1) jessie; urgency=medium
 .
   * os-probes/mounted/x86/05efi: Fix check on ID_PART_ENTRY_SCHEME, to
     look for "dos" instead of "msdos" (Closes: #817023).
   * Add -a flag to grep -qs for Windows Vista detection. It appears the
     file isn't always considered as a text file, so this should be more
     robust. Thanks to Gianluigi Tiesi for the report and the suggestion
     (Closes: #791383).
   * Add support for Windows 10 (otherwise reported as Windows Recovery
     Environment). Thanks, Philipp Wolfer! (Closes: #801278).
Checksums-Sha1:
 ae014c375fa03dab42c0dbddf244cd7674a9db99 1764 os-prober_1.65+deb8u1.dsc
 864d02b5ba0a1ddf3b3b003655a26fbfde7ae179 25008 os-prober_1.65+deb8u1.tar.xz
 36c59d3d4df90397140a448b35535d08df2bdd4e 13802 os-prober-udeb_1.65+deb8u1_amd64.udeb
 3ac0bae719c13a5e48e6afc9a6dead40488ad49b 28180 os-prober_1.65+deb8u1_amd64.deb
Checksums-Sha256:
 f5ea79d5dfc15b3221d321faadec474c6c1020df2849df1cd55a9d0d6f25eee7 1764 os-prober_1.65+deb8u1.dsc
 61ba6edf3a24010e2c5985eaa15e763e88949f6a518e907c3e2660955f3426e9 25008 os-prober_1.65+deb8u1.tar.xz
 eb2b3a470c48c27385e81d3a5b4c8a39e7456501fbe833cc2a413a0d101eaa9a 13802 os-prober-udeb_1.65+deb8u1_amd64.udeb
 f6f6df53049b7bcb0510ebdee97dae34c1f6405ff6d6c84421ad1361b860fb83 28180 os-prober_1.65+deb8u1_amd64.deb
Files:
 1aa9d564fab0bb600a4e22da11900b2f 1764 debian-installer optional os-prober_1.65+deb8u1.dsc
 a1f4ed67088f8edc43cde4ae677b2927 25008 debian-installer optional os-prober_1.65+deb8u1.tar.xz
 d5b5b3b057895101864277da29c834ff 13802 debian-installer optional os-prober-udeb_1.65+deb8u1_amd64.udeb
 d542c695e5599d6116de741314d81396 28180 utils extra os-prober_1.65+deb8u1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJZZ8YLAAoJEP+RSvDCs1Ugb+EQAK3Jo3aHxe1IjSBV+uKoVKb4
zvXRTLcB/vfmPRYwMtDxMg0X2oywEAmEiiCZpNUtTJqSOX2wVI1k5NuAo+nuf6SA
BRmNoMGDgIWyZTkc1PyASOR7oNdLedj/4bMUdYcYqUFFmQjjA4XQ5B3HBWyB9VgH
iXInrRPc8rtVxb8T+RW9nEDYFNW0lMxGU4s40CqkXlTjF9barFNbokiH00JBIPkz
Fxx8oyVKlLOkh9WvqLCllwrbx7jq5HWhzAukkDYbG3gIIFtWr7rk8lDQYcuB9T5r
FUdOWP34Ijxhr4haa3SySD+ZsBI8cmcv57ROsv5mZNst0lqsIOcYs9NQkvidv0+u
6T67T/9S6qusNKvnfBuZA+yvjWVI6vu8ZewYp/MCwjoDns7eCNbXz9gZeOqJ8lhh
zkFKrJyTEIUaFnmE4rAKZsUfYhYBxfkUXys6oXe8YodEcXAJbtrGmeiktxZBy5NT
usg2ucskclofKyWBiTFoMqz6L7/V0iz5OsrFYG6VuvKlGqOu5wsWuvYnllrjP/3+
H8/BTDOJFvmJOrNp5FKGija3zOvBCb7YLWPlgZ+u5W7PKMqW1+hN3QOf+MSP64Vz
l2dn7fAhOzSJ2TcSpHshvF3D1XnaB9XyGqzRh6AAM928wA1bXQe9Q6XlMOBht4dL
vL3bSuhNYGhWOS+whW3Y
=4fnc
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sun, 13 Aug 2017 07:25:35 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Thu Aug 8 02:59:59 2024; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.