Debian Bug report logs - #816600
postinst: IPv6 address is not displayed in 'Start SSH' invitation

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: postinst: IPv6 address is not displayed in 'Start SSH' invitation

Date: Thu, 3 Mar 2016 12:12:45 +0100

[Message part 1 (text/plain, inline)]

Package: network-console
Version: 1.53
Severity: normal
Tags: d-i patch

Dear Maintainer,

in IPv6-only environments, the "Start SSH" invitation does not include
the IPv6 address to log in to the installer system.  Below is a patch
that extends the postinst script to detect an IPv6 address if no IPv4
address could be found.

Thanks and kind regards,
  Hendrik

[0001-network-console-display-IPv6-address-to-access-insta.patch (text/plain, attachment)]

Message #10 received at 816600@bugs.debian.org (full text, mbox, reply):

From: Roger Shimizu <rogershimizu@gmail.com>

To: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>, 816600@bugs.debian.org

Subject: Re: Bug#816600: postinst: IPv6 address is not displayed in 'Start SSH' invitation

Date: Sat, 5 Mar 2016 01:01:05 +0900

On Thu, Mar 3, 2016 at 8:12 PM, Hendrik Brueckner
<brueckner@linux.vnet.ibm.com> wrote:
> Package: network-console
> Version: 1.53
> Severity: normal
> Tags: d-i patch
>
> Dear Maintainer,
>
> in IPv6-only environments, the "Start SSH" invitation does not include
> the IPv6 address to log in to the installer system.  Below is a patch
> that extends the postinst script to detect an IPv6 address if no IPv4
> address could be found.

Thanks for your patch!
It's even better if you can include kfreebsd/hurd support.

I guess you have this kinda test environment, which there's only IPv6
but no IPv4.
So you just need to run the d-i in very early stage and find how to
get IPv6 address, without really install/overwrite your system.

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1

Message #15 received at 816600@bugs.debian.org (full text, mbox, reply):

From: Dimitri John Ledkov <dimitri.ledkov@canonical.com>

To: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>, 816600@bugs.debian.org

Subject: Re: Bug#816600: postinst: IPv6 address is not displayed in 'Start SSH' invitation

Date: Thu, 10 Mar 2016 01:30:44 +0000

On Thu, Mar 3, 2016 at 11:12 AM, Hendrik Brueckner
<brueckner@linux.vnet.ibm.com> wrote:
> Package: network-console
> Version: 1.53
> Severity: normal
> Tags: d-i patch
>
> Dear Maintainer,
>
> in IPv6-only environments, the "Start SSH" invitation does not include
> the IPv6 address to log in to the installer system.  Below is a patch
> that extends the postinst script to detect an IPv6 address if no IPv4
> address could be found.
>

To be honest, I don't think it's only about IPv6-only environments.
A person performing the installation may only be on IPv6 link-local,
IPv6 autoconfigure, IPv4, only, whilst the machine to be installed has
dual-stack / all combos.
Unusual, true, but totally possible.

Thus, I think, we should enumerate all IP addresses, sans loopback,
and display them all.

-- 
Regards,

Dimitri.

Message #20 received at 816600@bugs.debian.org (full text, mbox, reply):

From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>

To: Dimitri John Ledkov <dimitri.ledkov@canonical.com>

Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>, 816600@bugs.debian.org

Subject: Re: Bug#816600: postinst: IPv6 address is not displayed in 'Start SSH' invitation

Date: Mon, 21 Mar 2016 11:33:25 +0100

Control: severity -1 wishlist

On Thu, Mar 10, 2016 at 01:30:44AM +0000, Dimitri John Ledkov wrote:
> On Thu, Mar 3, 2016 at 11:12 AM, Hendrik Brueckner
> <brueckner@linux.vnet.ibm.com> wrote:
> > Package: network-console
> > Version: 1.53
> > Severity: normal
> > Tags: d-i patch
> >
> > Dear Maintainer,
> >
> > in IPv6-only environments, the "Start SSH" invitation does not include
> > the IPv6 address to log in to the installer system.  Below is a patch
> > that extends the postinst script to detect an IPv6 address if no IPv4
> > address could be found.
> >
> 
> To be honest, I don't think it's only about IPv6-only environments.
> A person performing the installation may only be on IPv6 link-local,
> IPv6 autoconfigure, IPv4, only, whilst the machine to be installed has
> dual-stack / all combos.
> Unusual, true, but totally possible.
> 
> Thus, I think, we should enumerate all IP addresses, sans loopback,
> and display them all.

It would make sense to display all possible IP addresses to connect to
the installer environment.  This change is not that simple because it
requires debconf template modifications to provide an enumerated list
of IP addresses.  Hence reducing the severity of this bug to address
this requirement in future.

Thanks and kind regards,
  Hendrik

Message #27 received at 816600@bugs.debian.org (full text, mbox, reply):

From: Dimitri John Ledkov <xnox@ubuntu.com>

To: 816600@bugs.debian.org

Cc: Dimitri John Ledkov <xnox@ubuntu.com>

Subject: [PATCH] Adjust regexpes to include all ipv4 and ipv6 addresses, list all ip addresses (sans loopback) in the template instructions, and use only the first ip address in the example command. Closes: #816600 LP: #1552368

Date: Fri, 1 Apr 2016 00:47:00 +0100

---
 debian/changelog                 | 10 ++++++++++
 debian/network-console.postinst  | 15 +++++++++------
 debian/network-console.templates |  2 +-
 3 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index a518cd1..0521276 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+network-console (1.54) UNRELEASED; urgency=medium
+
+  [ Dimitri John Ledkov ]
+  * Adjust regexpes to include all ipv4 and ipv6 addresses, list all ip
+    addresses (sans loopback) in the template instructions, and use only
+    the first ip address in the example command. Closes: #816600 LP:
+    #1552368
+
+ -- Dimitri John Ledkov <xnox@ubuntu.com>  Fri, 01 Apr 2016 00:42:39 +0100
+
 network-console (1.53) unstable; urgency=medium
 
   [ Colin Watson ]
diff --git a/debian/network-console.postinst b/debian/network-console.postinst
index f164446..090cb26 100755
--- a/debian/network-console.postinst
+++ b/debian/network-console.postinst
@@ -85,22 +85,25 @@ apt-install openssh-server || true
 
 case "$(udpkg --print-os)" in
 	linux)
-		IPADDR=$(ip addr | grep '^[[:space:]]*inet ' | grep -v "127\.0\." | \
-			 head -n 1 | sed 's/.*inet \([0-9.]*\).*/\1/')
+		IPADDRS=$(ip addr | grep '^[[:space:]]*inet6\? ' | grep -v -e "127\.0\." -e "::1" | \
+			 sed 's/.*inet6\? \([a-f0-9.:]*\).*/\1/')
 		;;
 	kfreebsd)
-		IPADDR=$(ifconfig| grep '^[[:space:]]*inet ' | grep -v "127\.0\." | \
-			 head -n 1 | sed 's/.*inet \([0-9.]*\).*/\1/')
+		IPADDRS=$(ifconfig| grep '^[[:space:]]*inet6\? ' | grep -v -e "127\.0\." -e "::1" | \
+			 sed 's/.*inet6\? \([a-f0-9.:]*\).*/\1/')
 		;;
 	hurd)
-		IPADDR=$(fsysopts /servers/socket/2 | sed 's/.*--address=\([^ ]*\).*/\1/')
+		IPADDRS=$(fsysopts /servers/socket/2 | sed 's/ /\n/g' | sed -n 's/--address6\?=\([a-f0-9.:]*\).*/\1/p')
 		;;
 	*)
-		IPADDR="TODO"
+		IPADDRS="TODO"
 		;;
 esac
 
+IPADDR=$(IFS=" " ; set -- $IPADDRS ; echo $1)
+
 db_subst $TEMPLATE_ROOT/start ip $IPADDR
+db_subst $TEMPLATE_ROOT/start ips $IPADDRS
 db_subst $TEMPLATE_ROOT/start fingerprint $KEY_FINGERPRINT
 case "$ARCHDETECT" in
     arm*/ixp4xx)
diff --git a/debian/network-console.templates b/debian/network-console.templates
index 1c542ea..e55a653 100644
--- a/debian/network-console.templates
+++ b/debian/network-console.templates
@@ -66,7 +66,7 @@ Type: note
 #flag:translate!:3
 _Description: Start SSH
  To continue the installation, please use an SSH client to connect to the
- IP address ${ip} and log in as the "installer" user. For example:
+ IP address ${ips} and log in as the "installer" user. For example:
  .
     ssh installer@${ip}
  .
-- 
2.7.4

Message #32 received at 816600@bugs.debian.org (full text, mbox, reply):

From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>

To: Dimitri John Ledkov <xnox@ubuntu.com>, 816600@bugs.debian.org

Subject: Re: Bug#816600: [PATCH] Adjust regexpes to include all ipv4 and ipv6 addresses, list all ip addresses (sans loopback) in the template instructions, and use only the first ip address in the example command. Closes: #816600 LP: #1552368

Date: Fri, 1 Apr 2016 09:26:07 +0200

Hi Dimitri,

On Fri, Apr 01, 2016 at 12:47:00AM +0100, Dimitri John Ledkov wrote:
> ---
>  debian/changelog                 | 10 ++++++++++
>  debian/network-console.postinst  | 15 +++++++++------
>  debian/network-console.templates |  2 +-
>  3 files changed, 20 insertions(+), 7 deletions(-)
> 
> diff --git a/debian/changelog b/debian/changelog
> index a518cd1..0521276 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,13 @@
> +network-console (1.54) UNRELEASED; urgency=medium
> +
> +  [ Dimitri John Ledkov ]
> +  * Adjust regexpes to include all ipv4 and ipv6 addresses, list all ip
> +    addresses (sans loopback) in the template instructions, and use only
> +    the first ip address in the example command. Closes: #816600 LP:
> +    #1552368
> +
> + -- Dimitri John Ledkov <xnox@ubuntu.com>  Fri, 01 Apr 2016 00:42:39 +0100
> +
>  network-console (1.53) unstable; urgency=medium
> 
>    [ Colin Watson ]
> diff --git a/debian/network-console.postinst b/debian/network-console.postinst
> index f164446..090cb26 100755
> --- a/debian/network-console.postinst
> +++ b/debian/network-console.postinst
> @@ -85,22 +85,25 @@ apt-install openssh-server || true
> 
>  case "$(udpkg --print-os)" in
>  	linux)
> -		IPADDR=$(ip addr | grep '^[[:space:]]*inet ' | grep -v "127\.0\." | \
> -			 head -n 1 | sed 's/.*inet \([0-9.]*\).*/\1/')
> +		IPADDRS=$(ip addr | grep '^[[:space:]]*inet6\? ' | grep -v -e "127\.0\." -e "::1" | \
> +			 sed 's/.*inet6\? \([a-f0-9.:]*\).*/\1/')
>  		;;
>  	kfreebsd)
> -		IPADDR=$(ifconfig| grep '^[[:space:]]*inet ' | grep -v "127\.0\." | \
> -			 head -n 1 | sed 's/.*inet \([0-9.]*\).*/\1/')
> +		IPADDRS=$(ifconfig| grep '^[[:space:]]*inet6\? ' | grep -v -e "127\.0\." -e "::1" | \
> +			 sed 's/.*inet6\? \([a-f0-9.:]*\).*/\1/')
>  		;;
>  	hurd)
> -		IPADDR=$(fsysopts /servers/socket/2 | sed 's/.*--address=\([^ ]*\).*/\1/')
> +		IPADDRS=$(fsysopts /servers/socket/2 | sed 's/ /\n/g' | sed -n 's/--address6\?=\([a-f0-9.:]*\).*/\1/p')
>  		;;
>  	*)
> -		IPADDR="TODO"
> +		IPADDRS="TODO"
>  		;;
>  esac
> 
> +IPADDR=$(IFS=" " ; set -- $IPADDRS ; echo $1)
> +
>  db_subst $TEMPLATE_ROOT/start ip $IPADDR
> +db_subst $TEMPLATE_ROOT/start ips $IPADDRS
>  db_subst $TEMPLATE_ROOT/start fingerprint $KEY_FINGERPRINT
>  case "$ARCHDETECT" in
>      arm*/ixp4xx)
> diff --git a/debian/network-console.templates b/debian/network-console.templates
> index 1c542ea..e55a653 100644
> --- a/debian/network-console.templates
> +++ b/debian/network-console.templates
> @@ -66,7 +66,7 @@ Type: note
>  #flag:translate!:3
>  _Description: Start SSH
>   To continue the installation, please use an SSH client to connect to the
> - IP address ${ip} and log in as the "installer" user. For example:
> + IP address ${ips} and log in as the "installer" user. For example:
>   .
>      ssh installer@${ip}
>   .
> -- 

Looks great.  Many thanks!

Kind regards,
  Hendrik

Message #37 received at 816600-close@bugs.debian.org (full text, mbox, reply):

From: Dimitri John Ledkov <xnox@ubuntu.com>

To: 816600-close@bugs.debian.org

Subject: Bug#816600: fixed in network-console 1.54

Date: Fri, 01 Apr 2016 11:20:41 +0000

Source: network-console
Source-Version: 1.54

We believe that the bug you reported is fixed in the latest version of
network-console, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 816600@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dimitri John Ledkov <xnox@ubuntu.com> (supplier of updated network-console package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 01 Apr 2016 11:52:11 +0100
Source: network-console
Binary: network-console
Architecture: source
Version: 1.54
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Dimitri John Ledkov <xnox@ubuntu.com>
Description:
 network-console - Continue installation remotely using SSH (udeb)
Closes: 816600
Launchpad-Bugs-Fixed: 1552368
Changes:
 network-console (1.54) unstable; urgency=medium
 .
   [ Dimitri John Ledkov ]
   * Adjust regexpes to include all ipv4 and ipv6 addresses, list all ip
     addresses (sans loopback) in the template instructions, and use only
     the first ip address in the example command. Closes: #816600 LP:
     #1552368
   * Adjust variable name in template translations.
Checksums-Sha1:
 2642ada43632842980aa73e85d8213c1b4ae1cf4 1302 network-console_1.54.dsc
 338ec7f6ff91ad9e3f1bf754d537f3f4bbc03107 96788 network-console_1.54.tar.xz
Checksums-Sha256:
 75059094e6cf8f77ff8e3d690d360589530a5a587ba5fd84ec4b2a211a4d7e21 1302 network-console_1.54.dsc
 e1649704b3ecac6ee42ab8d3221253c527c76cfe4d0229fa06a19d8263deda8e 96788 network-console_1.54.tar.xz
Files:
 3226be8915777d0a59912872ec4f00e7 1302 debian-installer optional network-console_1.54.dsc
 7bff39fa2fb402d24c2250f2c86e2c8e 96788 debian-installer optional network-console_1.54.tar.xz

-----BEGIN PGP SIGNATURE-----

iQEcBAEBCgAGBQJW/lL2AAoJEMrC2LnNLKX54McIALX0x+bPc8pePqXcQqum1KQN
L0wPbmuL0564oJqDZUQD5msWsYOmimS1bTOaBsHszkJ4nZjpj34JzQGvfBmHLGbh
fRLWa3g70EFM81zQClOh4eyR7leL9hVAlV80yK/nWlfYoEzIkNCpccadw5ZTKcEg
RhFq7AahJnzya3oiRBnlfqG6XJYTAs27zbSPiLBY/9lewFVUQRHuORe7+V5lGm2A
Xvn7OogFh/tmnKl/5UTaUPJKy+LHuwgrYhP+jJ2gRTAM8ujjaBNs4B6XaPSADiDA
MnN+GD9VrVjdYYqm81mxywRY2VpLlhzGLCp8mwJhR7rG3ZKuOFn6lmY7slcLDcA=
=CyPU
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.