Debian Bug report logs - #815995
release.debian.org: britney fail with KeyError: error

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Christian Marillat <marillat@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: release.debian.org: britney fail with KeyError: error

Date: Fri, 26 Feb 2016 14:31:34 +0100

Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: britney

Hi,

Since 3 or 4 days britney fail with this error.

Christian


FAILED
I: [Fri Feb 26 08:23:05 2016] - > Removing obsolete source packages from testing
Removing obsolete source packages from testing (206):
start: 304+0: a-33:a-58:a-33:a-33:i-32:m-41:m-41:p-33
orig: 304+0: a-33:a-58:a-33:a-33:i-32:m-41:m-41:p-33
Traceback (most recent call last):
  File "/debian/britney/code/b2/britney.py", line 2933, in <module>
    Britney().main()
  File "/debian/britney/code/b2/britney.py", line 2897, in main
    self.upgrade_testing()
  File "/debian/britney/code/b2/britney.py", line 2604, in upgrade_testing
    self.do_all(actions=removals)
  File "/debian/britney/code/b2/britney.py", line 2443, in do_all
    (nuninst_end, extra) = self.iter_packages(upgrade_me, selected, nuninst=nuninst_end, lundo=lundo)
  File "/debian/britney/code/b2/britney.py", line 2313, in iter_packages
    updates, rms, _ = self._compute_groups(y.package, y.suite, y.architecture, y.is_removal)
  File "/debian/britney/code/b2/britney.py", line 1919, in _compute_groups
    and binaries_t[parch][0][binary][SOURCE] != source_name):
KeyError: 'libx265-68'


-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 4.1.18 (SMP w/8 CPU cores; PREEMPT)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Message #10 received at 815995@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: Christian Marillat <marillat@debian.org>, 815995@bugs.debian.org

Subject: Re: Bug#815995: release.debian.org: britney fail with KeyError: error

Date: Fri, 26 Feb 2016 16:53:20 +0000

[Message part 1 (text/plain, inline)]

Control: tags -1 moreinfo

Christian Marillat:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: britney
> 
> Hi,
> 
> Since 3 or 4 days britney fail with this error.
> 
> Christian
> 
> [...]
> 

Hi,

Can you please provide the following information:

 * Can we get a copy of the data set that triggers the issue?
   (including the config file).
 * What version of Britney are you using (e.g. the git commit)?

Thanks,
~Niels

[signature.asc (application/pgp-signature, attachment)]

Message #17 received at 815995@bugs.debian.org (full text, mbox, reply):

From: Christian Marillat <marillat@free.fr>

To: Niels Thykier <niels@thykier.net>

Cc: 815995@bugs.debian.org

Subject: Re: Bug#815995: release.debian.org: britney fail with KeyError: error

Date: Fri, 26 Feb 2016 19:18:17 +0100

[Message part 1 (text/plain, inline)]

On 26 févr. 2016 17:53, Niels Thykier <niels@thykier.net> wrote:

> Control: tags -1 moreinfo
>
> Christian Marillat:

[...]

> Can you please provide the following information:
>
>  * Can we get a copy of the data set that triggers the issue?
>    (including the config file).

Config file is here :

[britney2.conf (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

Command line is :

/debian/britney/code/b2/britney.py -c /debian/britney/etc/britney2.conf --control-files

Data files :

https://www.deb-multimedia.org/tests/britney-data.tar.xz

I see also the same bug in Ubuntu, but this is not the same code :

https://bazaar.launchpad.net/~ubuntu-release/britney/britney2-ubuntu/revision/566

>  * What version of Britney are you using (e.g. the git commit)?

britney2 commit is 92deb4d1b9e1237316e96b8c9b745836b69eab38

Christian

Message #26 received at 815995@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: Christian Marillat <marillat@free.fr>, 815995@bugs.debian.org

Subject: Re: Bug#815995: release.debian.org: britney fail with KeyError: error

Date: Tue, 22 Mar 2016 20:45:48 +0000

[Message part 1 (text/plain, inline)]

Control: tags -1 patch

Christian Marillat:
> On 26 févr. 2016 17:53, Niels Thykier <niels@thykier.net> wrote:
> 
>> Control: tags -1 moreinfo
>>
>> Christian Marillat:
> 
> [...]
> 
>> Can you please provide the following information:
>>
>>  * Can we get a copy of the data set that triggers the issue?
>>    (including the config file).
> 
> [... resources ...]

Many thanks for the data set and apologies for the delay.

I have written a patch (attached) that works around the issue.  I also
wrote a "minimal" test case at [1].

I will include the patch in the next patchset that I will submit for
review on d-release@l.d.o. :)

> 
> I see also the same bug in Ubuntu, but this is not the same code :
> 
> https://bazaar.launchpad.net/~ubuntu-release/britney/britney2-ubuntu/revision/566
> 

I suspect that is an unrelated issue, which is caused by their own
patches (or an old code path that is now removed).

>>  * What version of Britney are you using (e.g. the git commit)?
> 
> britney2 commit is 92deb4d1b9e1237316e96b8c9b745836b69eab38
> 
> Christian
> 

Thanks,
~Niels

[1]
https://anonscm.debian.org/cgit/collab-maint/britney2-tests.git/commit/?h=britney-fixes-2016-03&id=3485775677aee69d3dd9cb7d1415e3e51371faa1

[0001-britney-Work-around-bug-815995.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #33 received at 815995@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: debian-release <debian-release@lists.debian.org>

Cc: Christian Marillat <marillat@debian.org>, David Prévot <taffit@debian.org>, Anthony Towns <aj@erisian.com.au>

Subject: [britney] ITM: britney-fixes-2016-03-merge-round-1

Date: Wed, 30 Mar 2016 20:26:35 +0000

[Message part 1 (text/plain, inline)]

Hi,

I have bundled a series of patches and have selected a subset for
merging into master now.

 * Please review the attached patch series (or branch at [1]).
 * The patch series requires an updated version of the test suite.
   - Please checkout the "britney-fixes-2016-03-merge-round-1" in your
     britney2-tests repository[2]
 * Deadline for comments being Monday the 11th of April.

While the majority of the patches are mainly code cleanup / refactoring,
we do have a couple of highlights (in no particular order):

 * Crash fix #815995 (Patch 0010)
   - Minor tweak to this version compared to the one attached in the
     bug.
 * Versioned provides support #786803 (Patches 0008 + 0009)
   - NB: Punted on multi-arch'ified provides for now.
 * Partial support for reading packages from a standard mirror
   layout (Patch 0020)
   - It is missing the part where various ("non-mirror") input data
     files (e.g. BugsV, Dates) are moved *out* of the mirror.  I intend
     to look into that in a future patch series.
   - This is two of AJ's commits squashed, rebased and ported to
     python3.
 * Stop migration of cruft binaries no longer in testing (0016)
   - It solves cruft re-entering testing (with IGNORE_CRUFT=1)


In the "coming soon" department, I also got a patch series for improving
the excuses.yaml file considerably.  If you are interested, you can take
a peek at [3].  I will issue a separate "ITM" mail for those patches
when I am ready.

Thanks,
~Niels

[1]
https://anonscm.debian.org/cgit/users/nthykier/britney.git/log/?h=britney-fixes-2016-03-merge-round-1

[2]
https://anonscm.debian.org/cgit/collab-maint/britney2-tests.git/log/?h=britney-fixes-2016-03-merge-round-1

[3]
https://anonscm.debian.org/cgit/users/nthykier/britney.git/log/?h=britney-fixes-2016-03

[0001-britney.py-Add-all_binaries-to-store-binaries-by-pkg.patch (text/x-diff, attachment)]

[0002-Store-the-pkg_id-in-undo-instead-of-the-package-info.patch (text/x-diff, attachment)]

[0003-Use-sets-in-the-provides-table.patch (text/x-diff, attachment)]

[0004-inst-tester-split-_pick_choice-into-two.patch (text/x-diff, attachment)]

[0005-inst-tester-Move-loop-into-resolve_choices.patch (text/x-diff, attachment)]

[0006-inst-tester-Add-a-missing-param-to-doc-strings.patch (text/x-diff, attachment)]

[0007-inst-tester-Use-short-hand-syntax-for-new-sets.patch (text/x-diff, attachment)]

[0008-Partially-support-versioned-provides.patch (text/x-diff, attachment)]

[0009-Support-versioned-provides-without-multi-arch.patch (text/x-diff, attachment)]

[0010-britney-Work-around-bug-815995.patch (text/x-diff, attachment)]

[0011-Remove-all-calls-to-same_source-they-were-overkill.patch (text/x-diff, attachment)]

[0012-Use-pkg_id-instead-pkg-arch-in-BINARIES.patch (text/x-diff, attachment)]

[0013-Refactor-some-code-to-avoid-unnecessary-table-lookup.patch (text/x-diff, attachment)]

[0014-britney.py-Remove-unused-named-parameter.patch (text/x-diff, attachment)]

[0015-britney_util-Remove-some-unused-imports.patch (text/x-diff, attachment)]

[0016-Fix-migration-for-sources-with-old-cruft-that-isn-t-.patch (text/x-diff, attachment)]

[0017-britney.py-Avoid-creating-empty-lists-for-provides.patch (text/x-diff, attachment)]

[0018-britney.py-assert-provides-table-is-up-to-date.patch (text/x-diff, attachment)]

[0019-Refactor-some-local-expressions.patch (text/x-diff, attachment)]

[0020-britney.py-Add-support-for-multiple-components.patch (text/x-diff, attachment)]

[0021-Make-components-and-control-files-mutually-exclusive.patch (text/x-diff, attachment)]

[0022-britney.py-Remove-redundant-open-before-TagFile.patch (text/x-diff, attachment)]

[0023-britney.py-Rename-__log-to-log.patch (text/x-diff, attachment)]

[0024-Move-some-of-the-hint-parsing-into-hints.py.patch (text/x-diff, attachment)]

[0025-Make-excuses-a-dict-rather-than-a-list.patch (text/x-diff, attachment)]

[0026-Move-two-installability-testing-functions-to-britney.patch (text/x-diff, attachment)]

[0027-britney.py-Log-when-old-libs-are-present-but-not-rem.patch (text/x-diff, attachment)]

[0028-britney.py-Remove-uncommented-printf-debugging.patch (text/x-diff, attachment)]

[0029-Replace-some-string-concat-split-with-tuples.patch (text/x-diff, attachment)]

[0030-Remove-unused-named-parameter.patch (text/x-diff, attachment)]

[0031-Remove-redundant-assert.patch (text/x-diff, attachment)]

[0032-Remove-two-redundant-ifs-duplicating-an-earlier-if.patch (text/x-diff, attachment)]

[0033-Avoid-some-unnecessary-effort-in-compuing-affected.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #38 received at 815995-done@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 786803-done@bugs.debian.org, 815995-done@bugs.debian.org

Subject: Re: [britney] ITM: britney-fixes-2016-03-merge-round-1

Date: Sat, 23 Apr 2016 07:51:30 +0000

[Message part 1 (text/plain, inline)]

On Wed, 30 Mar 2016 20:26:35 +0000 Niels Thykier <niels@thykier.net> wrote:
> Hi,
> 
> I have bundled a series of patches and have selected a subset for
> merging into master now.
> 
> [...]
> 
> Thanks,
> ~Niels
> 
> [...]

The patch series has been merged and pushed live (a couple of weeks
ago).  Accordingly, these bugs are now closed.

Thanks,
~Niels

[signature.asc (application/pgp-signature, attachment)]

Send a report that this bug log contains spam.