Debian Bug report logs - #815916
Failure to create empty partition table on s390 DASD

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>

To: submit@bugs.debian.org

Subject: Failure to create empty partition table on s390 DASD

Date: Thu, 25 Feb 2016 18:06:23 +0100

[Message part 1 (text/plain, inline)]

Package: partman-partitioning
Version: 111
Severity: important
Tags: d-i patch
X-Debbugs-CC: debian-s390@lists.debian.org, brueckner@linux.vnet.ibm.com

Dear Maintainer,

when I try to create an empty partition table on a DASD, the
partitioning code instructs parted to write an msdos label instead of a
dasd label to the disk. This is effectively destroying the volume
metadata rendering the disk unusable. The disk can only be recovered by
low level formatting.

This is caused by the default label determination logic in
partman-partitioning/lib/disk-label.sh which only uses the architecture
to decide which default label to use.
We can't switch that unconditionally to dasd, because we would break
SCSI (and most of virtio) partitioning.

The suggested patches make sure the disk type is respected and the
appropriate label type is used:
Patch 1 is for d-i/partman-base and stores the disk label type in
/var/lib/partman/devices/<DISK>/label, which will be dasd for natively
attached DASDs as well as virtio attached DASDs in KVM.
Patch 2 is a change in d-i/partman-partitioning and uses the stored
label type to determine the proper partition table format (only when
executing on s390).

Thanks for your consideration.

-- 

Kind Regards
   Viktor Mihajlovski

[0001-parted_devices-Add-disk-label-type-to-device-directo.patch (text/x-patch, attachment)]

[0001-create_new_label-Use-correct-label-for-DASDs.patch (text/x-patch, attachment)]

Message #10 received at 815916@bugs.debian.org (full text, mbox, reply):

From: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>

To: 815916@bugs.debian.org

Subject: patch update

Date: Fri, 26 Feb 2016 13:16:23 +0100

[Message part 1 (text/plain, inline)]

the first patch to partman-base introduced a regression in the case of
pristine disks because it didn't check for ped_disk_new() failure.
Please use the new patch here instead.

-- 

Mit freundlichen Grüßen/Kind Regards
   Viktor Mihajlovski

[0001-parted_devices-Add-disk-label-type-to-device-directo.patch (text/x-patch, attachment)]

Message #13 received at 815916@bugs.debian.org (full text, mbox, reply):

From: Philipp Kern <pkern@debian.org>

To: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>, 815916@bugs.debian.org

Subject: Re: Bug#815916: patch update

Date: Sat, 27 Feb 2016 15:56:48 +0100

On Fri, Feb 26, 2016 at 01:16:23PM +0100, Viktor Mihajlovski wrote:
> the first patch to partman-base introduced a regression in the case of
> pristine disks because it didn't check for ped_disk_new() failure.
> Please use the new patch here instead.

I think you attached the old patch again, could that be?

% diff /tmp/0001-parted_devices-Add-disk-label-type-to-device-directo.patch-*
4c4
< Subject: [PATCH] parted_devices: Add disk label type to device directory
---
> Subject: [PATCHv2] parted_devices: Add disk label type to device directory

Kind regards and thanks
Philipp Kern

Message #18 received at 815916@bugs.debian.org (full text, mbox, reply):

From: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>

To: Philipp Kern <pkern@debian.org>, 815916@bugs.debian.org

Subject: Re: Bug#815916: patch update

Date: Mon, 29 Feb 2016 08:27:09 +0100

[Message part 1 (text/plain, inline)]

On 27.02.2016 15:56, Philipp Kern wrote:
> On Fri, Feb 26, 2016 at 01:16:23PM +0100, Viktor Mihajlovski wrote:
>> the first patch to partman-base introduced a regression in the case of
>> pristine disks because it didn't check for ped_disk_new() failure.
>> Please use the new patch here instead.
> 
> I think you attached the old patch again, could that be?
> 
> % diff /tmp/0001-parted_devices-Add-disk-label-type-to-device-directo.patch-*
> 4c4
> < Subject: [PATCH] parted_devices: Add disk label type to device directory
> ---
>> Subject: [PATCHv2] parted_devices: Add disk label type to device directory
> 
> Kind regards and thanks
> Philipp Kern
> 
Quite obviously, thanks for checking.
As the saying goes, third time's a charm, so here we are:

-- 

Kind Regards
   Viktor Mihajlovski

[v3-parted_devices-Add-disk-label-type-to-device-directo.patch (text/x-patch, attachment)]

Message #23 received at 815916@bugs.debian.org (full text, mbox, reply):

From: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>

To: 815916@bugs.debian.org

Subject: Followup

Date: Wed, 31 Aug 2016 13:21:58 +0200

Dear Maintainer(s),

the patches have been incorporated in Ubuntu's d-i since their 16.04
release ([1],[2]) and I would hope that thereby they have gotten
sufficient test coverage in the meantime. I haven't heard of breakages
for other architectures and they have positively fixed the issues for s390.
Based on this I'd like to propose that the patches be applied to the
respective Debian upstream packages. Thanks for your consideration.


[1]
http://changelogs.ubuntu.com/changelogs/pool/main/p/partman-base/partman-base_187ubuntu2/changelog
[2]
http://changelogs.ubuntu.com/changelogs/pool/main/p/partman-partitioning/partman-partitioning_110ubuntu4/changelog

-- 

Mit freundlichen Grüßen/Kind Regards
   Viktor Mihajlovski

Message #28 received at 815916@bugs.debian.org (full text, mbox, reply):

From: Philipp Kern <pkern@debian.org>

To: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>, 815916@bugs.debian.org

Subject: Re: Bug#815916: Followup

Date: Mon, 24 Oct 2016 00:41:32 +0200

[Message part 1 (text/plain, inline)]

On 08/31/2016 01:21 PM, Viktor Mihajlovski wrote:
> the patches have been incorporated in Ubuntu's d-i since their 16.04
> release ([1],[2]) and I would hope that thereby they have gotten
> sufficient test coverage in the meantime. I haven't heard of breakages
> for other architectures and they have positively fixed the issues for s390.
> Based on this I'd like to propose that the patches be applied to the
> respective Debian upstream packages. Thanks for your consideration.
> 
> 
> [1]
> http://changelogs.ubuntu.com/changelogs/pool/main/p/partman-base/partman-base_187ubuntu2/changelog
> [2]
> http://changelogs.ubuntu.com/changelogs/pool/main/p/partman-partitioning/partman-partitioning_110ubuntu4/changelog

I pushed the first one (together with another fix for extended
partitions) to git now. As we're currently in the process of cutting
another debian-installer release, I'll wait with the upload and then
push the fix to partman-partitioning after the new partman-base is in
the archive.

Kind regards and thanks
Philipp Kern

[signature.asc (application/pgp-signature, attachment)]

Message #33 received at 815916@bugs.debian.org (full text, mbox, reply):

From: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>

To: Philipp Kern <pkern@debian.org>, 815916@bugs.debian.org

Subject: Re: Bug#815916: Followup

Date: Mon, 24 Oct 2016 09:49:32 +0200

On 24.10.2016 00:41, Philipp Kern wrote:
[...]
>> 
>> [1] 
>> http://changelogs.ubuntu.com/changelogs/pool/main/p/partman-base/partman-base_187ubuntu2/changelog
>>
>> 
[2]
>> http://changelogs.ubuntu.com/changelogs/pool/main/p/partman-partitioning/partman-partitioning_110ubuntu4/changelog
>
>> 
> I pushed the first one (together with another fix for extended 
> partitions) to git now. As we're currently in the process of
> cutting another debian-installer release, I'll wait with the upload
> and then push the fix to partman-partitioning after the new
> partman-base is in the archive.
> 
> Kind regards and thanks Philipp Kern
> 

Thanks, I'll verify once the new package versions show up.

-- 

Mit freundlichen Grüßen/Kind Regards
   Viktor Mihajlovski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martina Köderitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

Message #38 received at 815916-close@bugs.debian.org (full text, mbox, reply):

From: Christian Perrier <bubulle@debian.org>

To: 815916-close@bugs.debian.org

Subject: Bug#815916: fixed in partman-partitioning 114

Date: Wed, 16 Nov 2016 09:21:00 +0000

Source: partman-partitioning
Source-Version: 114

We believe that the bug you reported is fixed in the latest version of
partman-partitioning, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 815916@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated partman-partitioning package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 16 Nov 2016 06:47:57 +0100
Source: partman-partitioning
Binary: partman-partitioning
Architecture: source i386
Version: 114
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description:
 partman-partitioning - Partitioning operations for partman (udeb)
Closes: 815916
Changes:
 partman-partitioning (114) unstable; urgency=medium
 .
   [ Viktor Mihajlovski ]
   * In case a disk is identified as type=dasd, make sure to preserve
     this in the disk label. (Closes: #815916)
     Requires partman-base 190.
Checksums-Sha1:
 55b1f28ed758b2c23cabb1fdac3a5ef50d842c85 1680 partman-partitioning_114.dsc
 6de42f2519d84f8e7908d2ebc67dbe44d310c78a 175972 partman-partitioning_114.tar.xz
 a215a5e150ea4c13585e5357d3fdc2f486efecca 4596 partman-partitioning_114_20161116T074137z-f219f2d0.buildinfo
 d0befd640b7c59586f6cd6533643a3a4576d2830 189420 partman-partitioning_114_i386.udeb
Checksums-Sha256:
 79dfaef08d79375adcf254c8b2d22fe453896e5220d37fbb64c5a202a14233c7 1680 partman-partitioning_114.dsc
 adc6428127b8d6f8485a7a6e265a4ff2298b851d4fd0ffb805d804441e630cb8 175972 partman-partitioning_114.tar.xz
 3d31f1ff3760835e63a05e921e08350c53fc08cb87e6a9cfb702e14aa1a3a208 4596 partman-partitioning_114_20161116T074137z-f219f2d0.buildinfo
 7dd8ef3a9a07898d43c7d5611166b942fcb4110af02011c0d1a2021123b63314 189420 partman-partitioning_114_i386.udeb
Files:
 72fa9d67caa5123e99be6f04aebdf0f3 1680 debian-installer optional partman-partitioning_114.dsc
 c20eef15df5d4e32dd75558b61870d80 175972 debian-installer optional partman-partitioning_114.tar.xz
 f219f2d0f2681a32f8b077b9ddf214e5 4596 debian-installer optional partman-partitioning_114_20161116T074137z-f219f2d0.buildinfo
 a6c2a21068b6af95688fa635d2ee91ff 189420 debian-installer optional partman-partitioning_114_i386.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJYLA8uAAoJEIcvcCxNbiWob9MQAIcknJsicHwxO1+Nn+D0NlhR
2U/Gj0eNfgx0CacfNyAWB2o5vLCULi60ZU5vE9ao1C4Zg1TXhBKvHi3fEAdoknky
47dE2KtYePiQp7RXDeFmNsN7TpvYx4XopVKhLSZ6t5fjnP1R1C7YzmVKui+Z72sU
8y2CPU+hFD1ta8Ubywpd2yAZwhiNpDAgNYSvH4Bhg7Jng32i3Na5gZ0CCA9YxKSm
tcrYE9AA7wvmRBNH8Yy+LYF40tffJ0UCcOcKrLSCNnGyRAGkSP2NafTIORlybJPG
e5C5fKkr2Mo0q0sfyDebw6X5a7F/AGLejndyEle77HZq9UuEx1TG+wlC6ShapcQx
LIOsFh3PbZi01yy3s+MHr7hzo9cZnk4oazCzWHfsMhdtvW41B6i9KPD/ZD1vxJxK
XyH+4m2reD//84PDuULS928NgqBRXGvo/GOoubvBACr9rla5AQ1ro0PW3gAQDxy+
+FlBht75vKKeYtYh68LVhIhztTiobcBvZCtP5i2jZtzCSg/dBdyk9PgVewBSgYFI
0v3fVzftroYBR2+CPDVAqd0KZDBcEzSbuCnBeGUY0K346mAy/nsnqdwRjOrxy35P
u9OiWz7MhWJsm8Mv0dRtnoLRuFdhFAdmtBYHd51Wt4IOXRJyOLJ/S5CxI5Q5h9TB
VaY5sPl/W9IZcQIAHVq9
=wo8c
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.