Debian Bug report logs - #815620
addsubstvar fails if there are utf characters in the substvar file

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Joachim Breitner <nomeata@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: addsubstvar fails if there are utf characters in the substvar file

Date: Tue, 23 Feb 2016 00:35:11 +0100

Package: debhelper
Version: 9.20160115
Severity: important

Hi,

A few (Haskell) packages fail to build because addsubstvar in Dh_Lib.pm,
which uses grep, falls over unicode characters in existing substvar
lines. It makes lines like
Binary file debian/libghc-gitit-doc.substvars matches
appear in the substvar file, which obviously breaks.

The fix is simple: In Dh_Lib.pm, replace calls to "grep -s -v" with
"grep -a -s -v".

Greetings,
Joachim


-- System Information:
Debian Release: stretch/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.3.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages debhelper depends on:
ii  autotools-dev            20150820.1
ii  binutils                 2.26-4
ii  dh-strip-nondeterminism  0.015-1
ii  dpkg                     1.18.4
ii  dpkg-dev                 1.18.4
ii  file                     1:5.25-2
ii  libdpkg-perl             1.18.4
ii  man-db                   2.7.5-1
ii  perl                     5.22.1-7
ii  po-debconf               1.0.19

debhelper recommends no packages.

Versions of packages debhelper suggests:
pn  dh-make  <none>

-- no debconf information

Message #14 received at 815620@bugs.debian.org (full text, mbox, reply):

From: Joachim Breitner <nomeata@debian.org>

To: 815620@bugs.debian.org

Subject: Re: addsubstvar fails if there are utf characters in the substvar file

Date: Tue, 23 Feb 2016 10:25:11 +0100

[Message part 1 (text/plain, inline)]

Control: tags -1 + patch

Hi,

as this prevents a number of packages from building, I’d like to speed
up the fix by providing a patch...

Test suite passes.

Greetings,
Joachim

-- 
-- 
Joachim “nomeata” Breitner
Debian Developer
  nomeata@debian.org • https://people.debian.org/~nomeata
  XMPP: nomeata@joachim-breitner.de • GPG-Key: 0xF0FBF51F
  https://www.joachim-breitner.de/

[0001-addsubstvar-Pass-a-to-grep-to-handle-substvars-with-.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 815620-close@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 815620-close@bugs.debian.org

Subject: Bug#815620: fixed in debhelper 9.20160306

Date: Sun, 06 Mar 2016 13:34:02 +0000

Source: debhelper
Source-Version: 9.20160306

We believe that the bug you reported is fixed in the latest version of
debhelper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 815620@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated debhelper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 06 Mar 2016 13:14:43 +0000
Source: debhelper
Binary: debhelper
Architecture: source
Version: 9.20160306
Distribution: unstable
Urgency: medium
Maintainer: Debhelper Maintainers <debhelper-devel@lists.alioth.debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
 debhelper  - helper programs for debian/rules
Closes: 615854 744380 798648 802274 803341 812136 812790 812879 814761 815401 815620
Changes:
 debhelper (9.20160306) unstable; urgency=medium
 .
   [ Niels Thykier ]
   * Remove dh_suidregister and related autoscripts.  No package
     (that can be built in unstable) invokes this tool.
   * dh: Do not create stamp files when running with --no-act.
   * dh_strip/dh_gencontrol: Move "is_udeb" guard to dh_strip.
     This should avoid adding build-ids to udebs without having
     the actual debug symbols available.  Thanks to Jérémy Bobbio
     for reporting the issue.  (Closes: #812879)
   * dh_makeshlibs: Do not claim to be using maintainer scripts
     for invoking ldconfig.  Thanks to Eugene V. Lyubimkin for
     the report.  (Closes: #815401)
   * Remove dh_scrollkeeper.  It is no longer used in unstable.
   * autoconf.pm: Apply patch from Gergely Nagy to set "VERBOSE=1"
     when running tests to make sure that the build logs are
     dumped on error with automake.  (Closes: #798648, #744380)
   * dh_installdeb: In compat 10, properly shell escape lines
     from the maintscript config file.  This will *not* be fixed
     retroactively since people have begun to rely on the bug
     in previous versions (e.g. by quoting the file names).
     Thanks to Jakub Wilk for reporting the issue.
     (Closes: #803341)
   * dh_installdeb: In compat 10, avoid adding two comments per line
     in the maintscript file.  Thanks to Didier Raboud for
     reporting the bug.  (Closes: #615854)
   * cmake.pm: Apply patch from Helmut Grohne to correct the
     name of the default cross compilers.  (Closes: #812136)
   * dh_installdeb: Clarify what goes in the "maintscript" config
     files.  Thanks to Julian Andres Klode for the report.
     (Closes: #814761)
   * dh_compress: Correct and warn if given a path with a package
     tmp dir prefix (e.g. "debian/<pkg>/path/to/file").
   * dh_compress: Handle file resolution failures more gracefully.
     Thanks to Daniel Leidert for reporting this issue.
     (Closes: #802274)
   * dh_installinit: Make --restart-after-upgrade the default in
     compat 10.  Packages can undo this by using the new
     --no-restart-after-upgrade parameter.
   * d/control: Update Vcs links.
   * d/control: Bump Standards-Version to 3.9.7 - no changes
     required.
   * Import newer German translations from Chris Leick.
     (Closes: #812790)
 .
   [ Joachim Breitner ]
   * addsubstvar: Pass -a to grep to handle substvars with unicode content
     gracefully (Closes: #815620)
Checksums-Sha1:
 1b5ed1effefb78a0025c56da4413201ea1cb43cd 1708 debhelper_9.20160306.dsc
 10a780fc3937648bed5a2316b4ab8fdab657d96f 335912 debhelper_9.20160306.tar.xz
Checksums-Sha256:
 9214c332373205b85583b48a49015a2941f68f956b1619846f1fd0a2cb5ed217 1708 debhelper_9.20160306.dsc
 ca3c95bc413cf8a0ce6252373f558e1b2fd6504217845297f231f9baefd4b290 335912 debhelper_9.20160306.tar.xz
Files:
 e1065115c5a2271ca403beef3eab4545 1708 devel optional debhelper_9.20160306.dsc
 13b988ed3625a7ae49088898ce4b2db8 335912 devel optional debhelper_9.20160306.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJW3C4oAAoJEAVLu599gGRCogYP/jhuFFzMX8XDkLxmzViYK5Ox
1+pbTiIYiG5Q2Ud2LTwThXi9CZgZbJVIcs3NMeIm5iAEyy9iy2BTtwtQttRposuo
ZRoA9yKKbSab2pVdbYpfrvK/RixOQlnzfGR2XB+oApHjGCp/4UxNxprKTl1n6zsr
5cR/MTCDfk6xWNrdRkgMDhkRKhWs53+oDoCrtk9kpsXpf6ZA+yXI6OmN4RQoVP5t
Kz9ko+CGYPeUzOda5It6biihvvatIPL4KnDigB7pUJhAQkrsI5Pdkenx2biihmG7
ovJ/LNL55J8c30KmAsZ0oefNw8n/lwA9G+8w5hXwVmTIaFjy7foBlxDobvlUIxdH
p5MPxOUxqKB4HlEJA2AExczSoP4T50HOguG8rM8RpX0JHuh7coGFg0ewENsHQRVl
6hEG9q0bFFy9uNwOW/ggbWl7P6HGL1ZeoSVz0RDoVFxcaZRR4CMrrT8Zqj1bbWB2
AHSc2d3A/hyfoVF8usegKl+EoB/LeSGw2kQEF9quQe4Q167M8LBzC9X/txJo2caX
y4EqHoA7HjODkArIUUT/xXT8aOwsHU+cyKQ+zx3nyUYmxqx44vi9Z4K9CAJ2j3xN
8G/E8QpfNkfcrkkqVO2Dvy9fAcgaDSb5DXCi+cvLd5iwXSX+lSswkmXxEmyBb7Od
k2gbeifHS3GKsflr8t2h
=w9fg
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.