Debian Bug report logs - #814622
python3-pytest: modifies shipped files: /usr/bin/py.test-3.[45]

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <anbe@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: python3-pytest: modifies shipped files: /usr/bin/py.test-3.[45]

Date: Sat, 13 Feb 2016 15:19:27 +0100

[Message part 1 (text/plain, inline)]

Package: python3-pytest
Version: 2.8.7-2
Severity: serious
User: debian-qa@lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package modifies files it
ships in /usr. This is so wrong, I'm not even bothered to look
up the part of policy this violates ;-P

>From the attached log (scroll to the bottom...):

1m4.6s ERROR: FAIL: debsums reports modifications inside the chroot:
  /usr/bin/py.test-3.4
  /usr/bin/py.test-3.5


cheers,

Andreas

[python3-pytest_2.8.7-2.log.gz (application/gzip, attachment)]

Message #10 received at 814622@bugs.debian.org (full text, mbox, reply):

From: Brian May <bam@debian.org>

To: Andreas Beckmann <anbe@debian.org>, 814622@bugs.debian.org

Subject: Re: [Python-modules-team] Bug#814622: python3-pytest: modifies shipped files: /usr/bin/py.test-3.[45]

Date: Sun, 14 Feb 2016 10:10:31 +1100

Andreas Beckmann <anbe@debian.org> writes:

> during a test with piuparts I noticed your package modifies files it
> ships in /usr. This is so wrong, I'm not even bothered to look
> up the part of policy this violates ;-P

From python3-pytest.postinst:

case "$1" in
    configure|abort-upgrade|abort-remove|abort-deconfigure)
        # Just in case, recreate all scripts
        for version in `py3versions -vi`; do
            if [ $version ]; then
                cp /usr/bin/py.test-3 /usr/bin/py.test-$version
                sed -i "s,#! */usr/bin/python3,#!/usr/bin/python$version," "/usr/bin/py.test-$version"
            fi
        done
    ;;

This should be done at build time in debian/rules, not at install time.
-- 
Brian May <bam@debian.org>

Message #15 received at 814622@bugs.debian.org (full text, mbox, reply):

From: Sebastian Ramacher <sramacher@debian.org>

To: Brian May <bam@debian.org>, 814622@bugs.debian.org

Subject: Re: [Python-modules-team] Bug#814622: Bug#814622: python3-pytest: modifies shipped files: /usr/bin/py.test-3.[45]

Date: Sun, 14 Feb 2016 16:29:02 +0100

[Message part 1 (text/plain, inline)]

On 2016-02-14 10:10:31, Brian May wrote:
> Andreas Beckmann <anbe@debian.org> writes:
> 
> > during a test with piuparts I noticed your package modifies files it
> > ships in /usr. This is so wrong, I'm not even bothered to look
> > up the part of policy this violates ;-P
> 
> From python3-pytest.postinst:
> 
> case "$1" in
>     configure|abort-upgrade|abort-remove|abort-deconfigure)
>         # Just in case, recreate all scripts
>         for version in `py3versions -vi`; do
>             if [ $version ]; then
>                 cp /usr/bin/py.test-3 /usr/bin/py.test-$version
>                 sed -i "s,#! */usr/bin/python3,#!/usr/bin/python$version," "/usr/bin/py.test-$version"
>             fi
>         done
>     ;;
> 
> This should be done at build time in debian/rules, not at install time.

This cannot be done at build time. This would create unnecessary forced
dependencies on all supported Python 3 version. py.test-3.X is created for each
*installed* Python 3 version and updated using rtupdate scripts.

Including py.test-3.X in the package is the bug.

Cheers
-- 
Sebastian Ramacher

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 814622-submitter@bugs.debian.org (full text, mbox, reply):

From: Sebastian Ramacher <sramacher@debian.org>

To: 814622-submitter@bugs.debian.org

Subject: Bug#814622 marked as pending

Date: Sun, 14 Feb 2016 15:44:49 +0000

tag 814622 pending
thanks

Hello,

Bug #814622 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:

    http://git.debian.org/?p=python-modules/packages/pytest.git;a=commitdiff;h=a9bdd1d

---
commit a9bdd1d37edccb064306087c5ac4c45651aca9af
Author: Sebastian Ramacher <sramacher@debian.org>
Date:   Sun Feb 14 16:38:53 2016 +0100

    Finalize changelog

diff --git a/debian/changelog b/debian/changelog
index 30e28c6..18939db 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+pytest (2.8.7-3) unstable; urgency=medium
+
+  * Team upload.
+  * Revert changes from 2.8.7-2 that included /usr/bin/pytest-3.X in the
+    package (Closes: #814622)
+
+ -- Sebastian Ramacher <sramacher@debian.org>  Sun, 14 Feb 2016 16:36:55 +0100
+
 pytest (2.8.7-2) unstable; urgency=medium
 
   * Team upload.

Message #25 received at 814622-close@bugs.debian.org (full text, mbox, reply):

From: Sebastian Ramacher <sramacher@debian.org>

To: 814622-close@bugs.debian.org

Subject: Bug#814622: fixed in pytest 2.8.7-3

Date: Sun, 14 Feb 2016 16:34:08 +0000

Source: pytest
Source-Version: 2.8.7-3

We believe that the bug you reported is fixed in the latest version of
pytest, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 814622@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sebastian Ramacher <sramacher@debian.org> (supplier of updated pytest package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 14 Feb 2016 16:36:55 +0100
Source: pytest
Binary: python-pytest python3-pytest python-pytest-doc
Architecture: source all
Version: 2.8.7-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>
Changed-By: Sebastian Ramacher <sramacher@debian.org>
Description:
 python-pytest - Simple, powerful testing in Python
 python-pytest-doc - Simple, powerful testing in Python - Documentation
 python3-pytest - Simple, powerful testing in Python3
Closes: 814622
Changes:
 pytest (2.8.7-3) unstable; urgency=medium
 .
   * Team upload.
   * Revert changes from 2.8.7-2 that included /usr/bin/pytest-3.X in the
     package (Closes: #814622)
Checksums-Sha1:
 f0c051ea7b01eb55d26dce3d4d35c0dda1fecfdf 2411 pytest_2.8.7-3.dsc
 b140fdd034c438414a588e1872899c31924b9325 7716 pytest_2.8.7-3.debian.tar.xz
 9aa87523f382827e25502141b545849b6fa2cd91 492330 python-pytest-doc_2.8.7-3_all.deb
 22e625acdeb3cb17a42e44942ecc5d3c3c22b8d6 155662 python-pytest_2.8.7-3_all.deb
 6fc1c294179987ecb5e4d667f1f4bf35621462b9 156716 python3-pytest_2.8.7-3_all.deb
Checksums-Sha256:
 9f8c407cc16ecf27a2a16b5805d054881eaa64ac79e9ecd7e9af29dbd4114b9a 2411 pytest_2.8.7-3.dsc
 e253893c04107635d6efec5ebfb49e954cee7fc41abce9911c6887bc8b8925fc 7716 pytest_2.8.7-3.debian.tar.xz
 a75e726f83de0cfe81affab797d8a4641cf7c24068d5ed037c29e22733f1bf4c 492330 python-pytest-doc_2.8.7-3_all.deb
 c1b1479b2ded30b43e40ef667056c386dd2fb40ee1628fbfe42d53eeada370dc 155662 python-pytest_2.8.7-3_all.deb
 a5abd4a1a0651f926982a1f05edb96540ae88f9345b407059e035c71afa79492 156716 python3-pytest_2.8.7-3_all.deb
Files:
 a86d410c3d9ad475e1e340aa8a28a5fd 2411 python optional pytest_2.8.7-3.dsc
 186f565b11e0d502004f215ebbfa3cbf 7716 python optional pytest_2.8.7-3.debian.tar.xz
 b5fd28cc9c2646e2410f4e0ff8841930 492330 doc optional python-pytest-doc_2.8.7-3_all.deb
 1f8c875d243fb26f1415db2f98a6d5b5 155662 python optional python-pytest_2.8.7-3_all.deb
 e5fed6ead8c4c0d851a279589885d965 156716 python optional python3-pytest_2.8.7-3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWwKDOAAoJEGny/FFupxmTPFIQAMTZ793NEswlWG+XC0FaYkPu
TD1tVirNSo7UuzMV2nbzL9Xk9FbB6s/qOV88LXdhBvlyEBmI8PWuV5B9ttiyMahW
0JvD9a1IdjFo6oMQAIq60m/S3BdnMaJ1Lh+pTrzBUO6hGGxiXdwoiBkSZqTMM5FD
M+nWN5wi3IU/hPibxjoO6D2V3RBCfRO6m2dUeo/r+goUrdR6j0s8eN/RT35pkS35
3ioCFOERN5e7vBYTyEwVeYg9ZkSS8RS44trjsQ15YrKNxiBDaB661v85rUgdWnEJ
Tk1oL657DoIE2589E75VBSD1PKOURH/lEEnaFiKM4mEUhmhgUc7JNOP0LI0DYQbt
MNz8YyIG1mrNwFL8KDsyzc88wzzEYizxkGlbi4b6Bfd/JyNDZ8lWJKSlwINJYEfb
OxmeACCqiTSj2J5iIbwYMIpwMWlKQjvV/WwCPWBUoOYK+7IhU6fslnuqjT3HXQgH
km46CELrZXSm8OARntoXg8jcoIkzr6kNFMYUsTNNAkd0mLA2/0fGtYTqPCQK0XfH
G2ZZNw2iL2Bhj7YTDWpRBOSaAjl2QI64af9xW1F88mcMx/Rs3BehqQ9C6cld7YIz
9Am96rmLR2Fp4GyFrXT9pLJRvyOb/kbdGE6y8+JDFzQjq0ooGhr0Qbi+nBc8no7f
bS8/Q2xt3srbSs77c6SF
=lkYz
-----END PGP SIGNATURE-----

Message #34 received at 814622@bugs.debian.org (full text, mbox, reply):

From: Barry Warsaw <barry@debian.org>

To: 814622@bugs.debian.org

Date: Mon, 15 Feb 2016 13:50:22 -0500

The reversion of 2.8.7-2 is not correct.  It breaks the DEP-8 tests in Ubuntu
where there is only Python 3.5 (and will break Debian as soon as Python 3.4 is
dropped).

By reverting this, you find that there is no Python 3 module in python3-pytest
and `python3.5 -m pytest` fails.  Please restore the change from 2.8.7-2 and
find another way to fix the problem.

Personally, I don't think we should have any Python version specific /usr/bin
scripts, but I suppose we need /usr/bin/py.test and /usr/bin/py.test-3 for
backward compatibility.  Better that people get in the habit of invoking such
tools via -m.

Message #39 received at 814622-done@bugs.debian.org (full text, mbox, reply):

From: Sebastian Ramacher <sramacher@debian.org>

To: Barry Warsaw <barry@debian.org>, 814622-done@bugs.debian.org

Subject: Re: [Python-modules-team] Bug#814622: (no subject)

Date: Mon, 15 Feb 2016 20:06:19 +0100

[Message part 1 (text/plain, inline)]

Version: 2.8.7-3

On 2016-02-15 13:50:22, Barry Warsaw wrote:
> The reversion of 2.8.7-2 is not correct.  It breaks the DEP-8 tests in Ubuntu
> where there is only Python 3.5 (and will break Debian as soon as Python 3.4 is
> dropped).

Then please file a new bug for that.

> By reverting this, you find that there is no Python 3 module in python3-pytest
> and `python3.5 -m pytest` fails.  Please restore the change from 2.8.7-2 and
> find another way to fix the problem.

This is just not true. python3.m5 -m pytest works just fine. If not, please file
a proper bug report.

Cheers
-- 
Sebastian Ramacher

[signature.asc (application/pgp-signature, inline)]

Message #44 received at 814622@bugs.debian.org (full text, mbox, reply):

From: Barry Warsaw <barry@debian.org>

Cc: 814622@bugs.debian.org

Subject: Re: [Python-modules-team] Bug#814622: (no subject)

Date: Mon, 15 Feb 2016 14:11:16 -0500

[Message part 1 (text/plain, inline)]

On Feb 15, 2016, at 08:06 PM, Sebastian Ramacher wrote:

>This is just not true. python3.m5 -m pytest works just fine. If not, please
>file a proper bug report.

The fix you uploaded introduces a regression, albeit in Ubuntu only right now,
but it will show up in Debian once Python 3.4 is dropped.  Uploading a change
that fixes one thing but regresses another is not a proper fix.  Thus, this
bug is not resolved.

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.