Debian Bug report logs - #813674
zoom-player: fails with "X Error of failed request: BadMatch (invalid parameter attributes)"

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Alexandre Detiste <alexandre.detiste@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: zoom-player: fails with "X Error of failed request: BadMatch (invalid parameter attributes)"

Date: Thu, 04 Feb 2016 10:15:49 +0100

Package: zoom-player
Version: 1.1.5~dfsg-1
Severity: important

Hi,

I was planning to add zoom-player support to G-D-P;
but the game immediatly crashes.

Here are my steps:

$ innoextract /home/.../setup_zork_zero_2.1.0.16.exe
(remove GOG DOSBox & stuff)
$ ls
manual.pdf ZORK0.CG1 ZORK0.EG1 ZORK0.MG1 ZORK0.ZIP ZORKZERO.EXE
$ md5sum ZORK0.ZIP
d83c343d71ac4c03661488148876b370  ZORK0.ZIP
$ file ZORK0.ZIP
ZORK0.ZIP: data
$ unzip -l ZORK0.ZIP
Archive:  ZORK0.ZIP
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, ....

--> defenitively not a Zip archive

$ zoom ZORK0.ZIP
(yellowish screen with copyright stuff,
with blue "Press any key to begin" prompt)
(pressing Enter)
X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  73 (X_GetImage)
  Serial number of failed request:  263
  Current serial number in output stream:  263

$ cp ZORK0.ZIP zork0.z6
$ zoom zork0.z6
-> same result

$ zoom /etc/passwd
INTERPRETER PANIC - Not a ZCode file (PC = #ffffffff)


At least zoom player seems to recognize this as a Z-code game;
but then immediatly crashes.
The game can't possibly bad because InnoSetup archives
embed md5/sha1 for every single file.

Desktop: LXQT on Radeon

zoom /usr/share/games/zork/zork[1|2|3].dat does work.

Where should I start to debug this ?



-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing'), (450, 'unstable'), (400, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.3.0-1-amd64 (SMP w/6 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages zoom-player depends on:
ii  libc6           2.21-7
ii  libfontconfig1  2.11.0-6.3
ii  libice6         2:1.0.9-1+b1
ii  libpng12-0      1.2.54-1
ii  libsm6          2:1.2.2-1+b1
ii  libx11-6        2:1.6.3-1
ii  libxext6        2:1.3.3-1
ii  libxft2         2.3.2-1
ii  libxrender1     1:0.9.9-2
ii  zlib1g          1:1.2.8.dfsg-2+b1

zoom-player recommends no packages.

zoom-player suggests no packages.

-- no debconf information

Message #10 received at 813674@bugs.debian.org (full text, mbox, reply):

From: Alexandre Detiste <alexandre.detiste@gmail.com>

To: 813674@bugs.debian.org

Subject: Re: Bug#813674: Acknowledgement (zoom-player: fails with "X Error of failed request: BadMatch (invalid parameter attributes)")

Date: Thu, 4 Feb 2016 11:47:51 +0100

PS:

This happens exactly in the second call to  display_get_pix_colour(int
x, int y).

Having this function return a dummy value early make it working
past the first screen.

Well, this is not the right fix obviously.

diff --git a/src/xdisplay.c b/src/xdisplay.c
index 0eff1c2..f55c79e 100644
--- a/src/xdisplay.c
+++ b/src/xdisplay.c
@@ -2971,7 +2971,8 @@ int display_get_pix_colour(int x, int y)
   XColor out;

   int res;
-
+  return 100;
+  printf("HERE\n");
   teeny = XGetImage(x_display, x_pixmap, x, y, 1, 1, AllPlanes, XYPixmap);
   px = XGetPixel(teeny, 0, 0);
   XDestroyImage(teeny);
@@ -2979,6 +2980,7 @@ int display_get_pix_colour(int x, int y)
   out.pixel = px;
   XQueryColor(x_display, DefaultColormap(x_display, x_screen),
              &out);
+  printf("HERE2\n");

Message #15 received at 813674@bugs.debian.org (full text, mbox, reply):

From: Alexandre Detiste <alexandre.detiste@gmail.com>

To: 813674@bugs.debian.org

Subject: zoom-player: fails with "X Error of failed request: BadMatch"

Date: Fri, 05 Feb 2016 11:13:25 +0100

control: severity: normal

Moreover this bug doesn't happen when zork0.blb is present
in the same directory as zork0.z6; so it should never happen
with the G-D-P provided zork0-data package.

Thus lowering severity.

Message #22 received at 813674@bugs.debian.org (full text, mbox, reply):

From: Stephen Kitt <skitt@debian.org>

To: Alexandre Detiste <alexandre.detiste@gmail.com>, 813674@bugs.debian.org

Subject: Re: Bug#813674: zoom-player: fails with "X Error of failed request: BadMatch (invalid parameter attributes)"

Date: Fri, 5 Feb 2016 22:51:34 +0100

[Message part 1 (text/plain, inline)]

Hi Alexandre,

On Thu, 04 Feb 2016 10:15:49 +0100, Alexandre Detiste
<alexandre.detiste@gmail.com> wrote:
> I was planning to add zoom-player support to G-D-P;
> but the game immediatly crashes.
> 
> Here are my steps:
[...]

> $ zoom ZORK0.ZIP
> (yellowish screen with copyright stuff,
> with blue "Press any key to begin" prompt)
> (pressing Enter)
> X Error of failed request:  BadMatch (invalid parameter attributes)
>   Major opcode of failed request:  73 (X_GetImage)
>   Serial number of failed request:  263
>   Current serial number in output stream:  263

Zork Zero needs its graphical resources, unlike some Z6 games. You need the
blorb file alongside the Z6 file...

Regards,

Stephen

[Message part 2 (application/pgp-signature, inline)]

Message #27 received at 813674@bugs.debian.org (full text, mbox, reply):

From: Stephen Kitt <skitt@debian.org>

To: Alexandre Detiste <alexandre.detiste@gmail.com>, 813674@bugs.debian.org

Subject: Re: Bug#813674: zoom-player: fails with "X Error of failed request: BadMatch (invalid parameter attributes)"

Date: Fri, 5 Feb 2016 22:54:54 +0100

[Message part 1 (text/plain, inline)]

On Fri, 5 Feb 2016 22:51:34 +0100, Stephen Kitt <skitt@debian.org> wrote:
> Zork Zero needs its graphical resources, unlike some Z6 games. You need the
> blorb file alongside the Z6 file...

... and you'd figured that out already!

Regards,

Stephen

[Message part 2 (application/pgp-signature, inline)]

Message #32 received at 813674@bugs.debian.org (full text, mbox, reply):

From: Alexandre Detiste <alexandre.detiste@gmail.com>

To: Stephen Kitt <skitt@debian.org>

Cc: 813674@bugs.debian.org

Subject: Re: Bug#813674: zoom-player: fails with "X Error of failed request: BadMatch (invalid parameter attributes)"

Date: Sat, 06 Feb 2016 10:30:15 +0100

[Message part 1 (text/plain, inline)]

Le vendredi 5 février 2016, 22:51:34 Stephen Kitt a écrit :
> > $ zoom ZORK0.ZIP
> > ...
> > X Error of failed request:  BadMatch (invalid parameter attributes)
> >   Major opcode of failed request:  73 (X_GetImage)
> >   Serial number of failed request:  263
> >   Current serial number in output stream:  263
> 
> Zork Zero needs its graphical resources, unlike some Z6 games. You need the
> blorb file alongside the Z6 file...

> ... and you'd figured that out already!

I wish I had started with Arthur instead of Zork Zero... 
this was documented in your .yaml file.

I still think the engine shouldn't crash _that_ hard
with a not at all obvious error message
when then blorb file is missing.

With this patch it will start like Gargoyle if the blorb file is missing, instead
of immediatly errorring out.
(without a dialog box even when launched from a desktop environment)

It's easier to google for "missing graphics for Zork Zero with zoom"
(with the answer "just use game-data-packager, duh")
than for "X_GetImage BadMatch" that unearthens a lot
of old unrelated stuff.

This patch ensure that X_GetImage is never called with negative values.

git diff -U10 src/v6display.c
diff --git a/src/v6display.c b/src/v6display.c
index 780bf9c..19ae91f 100644
--- a/src/v6display.c
+++ b/src/v6display.c
@@ -491,23 +491,23 @@ void v6_erase_line(int val)
 void v6_set_colours(int fg, int bg)
 {
 #ifdef DEBUG
   printf_debug("V6: set colours: %i, %i (window %i)\n", fg, bg, active_win);
 #endif
 
   if (fg == -2)
     fg = ACTWIN.fore;
   if (bg == -2)
     bg = ACTWIN.back;
-  if (fg == -1)
+  if (fg == -1 || ACTWIN.curx < 0 || ACTWIN.cury < 0)
     fg = DEFAULT_FORE;
-  if (bg == -1)
+  if (bg == -1 || ACTWIN.curx < 0 || ACTWIN.cury < 0)
     bg = DEFAULT_BACK;
 
   if (bg == -3)
     bg = display_get_pix_colour(ACTWIN.curx, ACTWIN.cury);
   if (fg == -3)
     fg = display_get_pix_colour(ACTWIN.curx, ACTWIN.cury);
 
   ACTWIN.fore = fg;
   ACTWIN.back = bg;
 }

[signature.asc (application/pgp-signature, inline)]

Message #39 received at 813674-close@bugs.debian.org (full text, mbox, reply):

From: Stephen Kitt <skitt@debian.org>

To: 813674-close@bugs.debian.org

Subject: Bug#813674: fixed in zoom-player 1.1.5~dfsg-2

Date: Sat, 06 Feb 2016 16:35:00 +0000

Source: zoom-player
Source-Version: 1.1.5~dfsg-2

We believe that the bug you reported is fixed in the latest version of
zoom-player, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 813674@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stephen Kitt <skitt@debian.org> (supplier of updated zoom-player package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 06 Feb 2016 17:22:52 +0100
Source: zoom-player
Binary: zoom-player
Architecture: source
Version: 1.1.5~dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Stephen Kitt <skitt@debian.org>
Description:
 zoom-player - player for Z-Code stories or games
Closes: 813674 813715
Changes:
 zoom-player (1.1.5~dfsg-2) unstable; urgency=medium
 .
   [ Alexandre Detiste ]
   * Revert to a version 3 watch file.
   * Avoid crashing on invalid coordinates when setting colours in V6 games
     (Zork Zero in particular). Closes: #813674.
 .
   [ Stephen Kitt ]
   * Switch to https: VCS URIs (see #810378).
   * Enable anti-aliasing by default and recommend the appropriate X font
     packages. Closes: #813715.
   * Enable all hardening options.
Checksums-Sha1:
 76c8d1a10cab3fb49f6431513b68dea4f7861f55 2102 zoom-player_1.1.5~dfsg-2.dsc
 d03a3d4ee1eec7a15dfefbbff3402c9a92d5ceea 5932 zoom-player_1.1.5~dfsg-2.debian.tar.xz
Checksums-Sha256:
 0eef5a9d8d3aa2ef17129e08a21a58ec121efc0d673382f2c89216eec6856ef2 2102 zoom-player_1.1.5~dfsg-2.dsc
 b7f0fd434351782aa9c1fc030286b6db20d74f99ac0e0f6ebce1bcf58e9def08 5932 zoom-player_1.1.5~dfsg-2.debian.tar.xz
Files:
 8cb9ed7f09f360b1ce27b9eb850d6ac0 2102 games optional zoom-player_1.1.5~dfsg-2.dsc
 6fa3d5f41142f922f54b7e494b18fdf2 5932 games optional zoom-player_1.1.5~dfsg-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJWth4DAAoJEIDTAvWIbYOcEMMP/izsFP7WjknErt6JDyAIZyAo
SQ5exeeHh1BetkSyF4mGjsQWhe5+Jk7vimX9j/VUaoSFJUI+sOJ728qNp+sY7/mZ
j59+qGafzAlo0/nSYtStfG/QXP059omz1hpQ2BwoXKYPG3ukTaKSqTJRz9WGjbTT
illOA60zxp2FElGRlmhN2LyB/agc+X2BBmDHQ6a0z64Pg3Xdsu3X6hMaUcMiuxrt
CaYeKcU3LbhAfMr8YmIMU3hdj4THuYc716Vj3iRuzxi70vFr90opW0nUk9VfW58C
CwigQVpkePgMublNHMhj5jB/CIPrZdt97AcDSb/7vUITC5u8c1Ina/esnil31t8i
L4VphR5RusBFzXF9useM7KWDoWJ9XXMu438SrazRjIonqgXkybCZ4wBKNeklQdWE
2TmW0aBMg+Nc2liiN95NT2OriU2Wxw/ZgfZ6uljJuL6I3h+ImHvLErzlXBTvoFRw
0liyqxIdg210/zzisamqQq5Dzg5C+cSDUP3/bBTUWO4OI3vljf+59xDuF05m7x0N
o1VZtQVibfx3jN63oeJfgL/4W/R9xLAvnc3AXYaDJYOLXI6il5feWiLJn8pgfBWV
3PmsJdbBRrKTB3qMSPe5zUQRnXOOZojfpmFPotfIdoUfC+IHydJhRiHOo5yAgO7F
tPCg1rte3ea6T1tSzTHo
=AbTi
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.