Debian Bug report logs - #812115
helo_argument IP should be encapsulated in []'s

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Chris Knadle <Chris.Knadle@coredump.us>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: helo_argument IP should be encapsulated in []'s

Date: Wed, 20 Jan 2016 18:12:22 +0000

[Message part 1 (text/plain, inline)]

Package: xul-ext-torbirdy
Version: 0.1.4-1
Severity: normal
Tags: patch

Torbirdy sets mail.smtpserver.default.hello_argument = "127.0.0.1" which is
nonconformant with RFC 5821 §4.1.3:

   https://tools.ietf.org/html/rfc5321#section-4.1.3

I'm attaching a patch which fixes this.

The issue that this is causing is that I have mail servers I run close
connections that use raw IP addresses in the HELO/EHLO, and that happens
prior to any SMTP AUTH.  I was having to reset this setting on every Icedove
startup until I found where it was being set.

Thanks

  -- Chris

-- 
Chris Knadle
Chris.Knadle@coredump.us

[encapsulate-helo-ip (text/plain, attachment)]

Message #10 received at submit@bugs.debian.org (full text, mbox, reply):

From: u <u@451f.org>

To: Chris Knadle <Chris.Knadle@coredump.us>, 812115@bugs.debian.org, Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Re: Bug#812115: helo_argument IP should be encapsulated in []'s

Date: Wed, 20 Jan 2016 20:14:08 +0000

[Message part 1 (text/plain, inline)]

Hi Chris,

Chris Knadle:
> Package: xul-ext-torbirdy
> Version: 0.1.4-1
> Severity: normal
> Tags: patch
> 
> Torbirdy sets mail.smtpserver.default.hello_argument = "127.0.0.1" which is
> nonconformant with RFC 5821 §4.1.3:
> 
>    https://tools.ietf.org/html/rfc5321#section-4.1.3
> 
> I'm attaching a patch which fixes this.
> 
> The issue that this is causing is that I have mail servers I run close
> connections that use raw IP addresses in the HELO/EHLO, and that happens
> prior to any SMTP AUTH.  I was having to reset this setting on every Icedove
> startup until I found where it was being set.

thank you very much.

I'll forward this bug & patch upstream. I think it belongs there -
unless you want to do that yourself? In that case, please go ahead :)

Cheers!
u.

[signature.asc (application/pgp-signature, attachment)]

Message #20 received at 812115@bugs.debian.org (full text, mbox, reply):

From: Chris Knadle <Chris.Knadle@coredump.us>

To: u <u@451f.org>, 812115@bugs.debian.org

Subject: Re: Bug#812115: helo_argument IP should be encapsulated in []'s

Date: Wed, 20 Jan 2016 22:13:21 +0000

[Message part 1 (text/plain, inline)]

u:
> Hi Chris,

Hey, u.  ;-)

> Chris Knadle:
>> Package: xul-ext-torbirdy
>> Version: 0.1.4-1
>> Severity: normal
>> Tags: patch
>>
>> Torbirdy sets mail.smtpserver.default.hello_argument = "127.0.0.1" which is
>> nonconformant with RFC 5821 §4.1.3:
>>
>>    https://tools.ietf.org/html/rfc5321#section-4.1.3
>>
>> I'm attaching a patch which fixes this.
>>
>> The issue that this is causing is that I have mail servers I run close
>> connections that use raw IP addresses in the HELO/EHLO, and that happens
>> prior to any SMTP AUTH.  I was having to reset this setting on every Icedove
>> startup until I found where it was being set.
> 
> thank you very much.
> 
> I'll forward this bug & patch upstream. I think it belongs there

Yep I agree.

> unless you want to do that yourself? In that case, please go ahead :)

It looks like there's a ticket open on an aspect of this issue already, but
the discussion instead (of being about the lack of IP encapsulation) is
about the choice of EHLO identifier, but this still seems like it might be
the right place to talk about this bug?

   https://trac.torproject.org/projects/tor/ticket/13006

   -- Chris

-- 
Chris Knadle
Chris.Knadle@coredump.us

[signature.asc (application/pgp-signature, attachment)]

Message #27 received at 812115@bugs.debian.org (full text, mbox, reply):

From: u <u@451f.org>

To: Chris Knadle <Chris.Knadle@coredump.us>, 812115@bugs.debian.org

Subject: Re: [Pkg-privacy-maintainers] Bug#812115: helo_argument IP should be encapsulated in []'s

Date: Thu, 21 Jan 2016 12:24:44 +0000

Hi,

Chris Knadle:
> u:
>> Hi Chris,
> 
> Hey, u.  ;-)
> 
>> Chris Knadle:
>>> Package: xul-ext-torbirdy
>>> Version: 0.1.4-1
>>> Severity: normal
>>> Tags: patch
>>>
>>> Torbirdy sets mail.smtpserver.default.hello_argument = "127.0.0.1" which is
>>> nonconformant with RFC 5821 §4.1.3:
>>>
>>>    https://tools.ietf.org/html/rfc5321#section-4.1.3
>>>
>>> I'm attaching a patch which fixes this.
>>>
>>> The issue that this is causing is that I have mail servers I run close
>>> connections that use raw IP addresses in the HELO/EHLO, and that happens
>>> prior to any SMTP AUTH.  I was having to reset this setting on every Icedove
>>> startup until I found where it was being set.
>>
>> thank you very much.
>>
>> I'll forward this bug & patch upstream. I think it belongs there
> 
> Yep I agree.
> 
>> unless you want to do that yourself? In that case, please go ahead :)
> 
> It looks like there's a ticket open on an aspect of this issue already, but
> the discussion instead (of being about the lack of IP encapsulation) is
> about the choice of EHLO identifier, but this still seems like it might be
> the right place to talk about this bug?
> 
>    https://trac.torproject.org/projects/tor/ticket/13006

I've created a pull request for this:
https://github.com/ioerror/torbirdy/pull/27

I'll need to test possible leaks on the EHLO anyway and will report back.

Cheers!

Message #32 received at 812115@bugs.debian.org (full text, mbox, reply):

From: Chris Knadle <Chris.Knadle@coredump.us>

To: u <u@451f.org>, 812115@bugs.debian.org

Subject: Re: [Pkg-privacy-maintainers] Bug#812115: helo_argument IP should be encapsulated in []'s

Date: Thu, 21 Jan 2016 18:37:31 +0000

u:
[...]
> I've created a pull request for this:
> https://github.com/ioerror/torbirdy/pull/27

Looks great.

> I'll need to test possible leaks on the EHLO anyway and will report back.

Cool.  Thanks much.

   -- Chris

-- 
Chris Knadle
Chris.Knadle@coredump.us

Message #37 received at 812115@bugs.debian.org (full text, mbox, reply):

From: Chris Knadle <Chris.Knadle@coredump.us>

To: u <u@451f.org>, 812115@bugs.debian.org

Subject: Re: [Pkg-privacy-maintainers] Bug#812115: helo_argument IP should be encapsulated in []'s

Date: Thu, 21 Jan 2016 18:54:34 +0000

Chris Knadle:
> u:
> [...]
>> I've created a pull request for this:
>> https://github.com/ioerror/torbirdy/pull/27
> 
> Looks great.

Oops: one small error to correct in the pull request that I missed at first:
the email address "chris@coredump.us" doesn't exist -- it's
"chris.knadle@coredump.us".

Thanks
   -- Chris

-- 
Chris Knadle
Chris.Knadle@coredump.us

Message #42 received at 812115@bugs.debian.org (full text, mbox, reply):

From: u <u@451f.org>

To: 812115@bugs.debian.org

Date: Fri, 5 Feb 2016 18:07:57 +0000

I've modified your email address and issued a new pull request.

Message #47 received at 812115@bugs.debian.org (full text, mbox, reply):

From: u <u@451f.org>

To: 812115@bugs.debian.org

Subject: Merged upstream

Date: Mon, 2 May 2016 17:05:35 +0000

This has been merged upstream today.

Message #52 received at 812115@bugs.debian.org (full text, mbox, reply):

From: intrigeri <intrigeri@debian.org>

To: 812115@bugs.debian.org

Subject: Re: [Pkg-privacy-maintainers] Bug#812115: Merged upstream

Date: Tue, 03 May 2016 13:03:24 +0200

Control: tag -1 + fixed-upstream

u wrote (02 May 2016 17:05:35 GMT) :
> This has been merged upstream today.

Excellent! Tagging accordingly :)

Message #59 received at 812115-close@bugs.debian.org (full text, mbox, reply):

From: Ulrike Uhlig <u@451f.org>

To: 812115-close@bugs.debian.org

Subject: Bug#812115: fixed in torbirdy 0.2.0-1

Date: Tue, 05 Jul 2016 22:54:35 +0000

Source: torbirdy
Source-Version: 0.2.0-1

We believe that the bug you reported is fixed in the latest version of
torbirdy, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 812115@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ulrike Uhlig <u@451f.org> (supplier of updated torbirdy package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 05 Jul 2016 20:17:01 +0200
Source: torbirdy
Binary: xul-ext-torbirdy
Architecture: source all
Version: 0.2.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Privacy Tools Maintainers <pkg-privacy-maintainers@lists.alioth.debian.org>
Changed-By: Ulrike Uhlig <u@451f.org>
Description:
 xul-ext-torbirdy - configures and enhances various Mozilla birds for anonymity use
Closes: 812115
Changes:
 torbirdy (0.2.0-1) unstable; urgency=medium
 .
   * New upstream version:
     - Prevent local timestamp disclosure via Date header
     - Prevent local timestamp disclosure via Message-ID header
     - Fix usage of wrong locale
     - Allow configuration of default email protocol
     - Add support for deterministic XPI generation
     - Fix non-standard EHLO argument (Closes: #812115).
     - Allow manual account configuration for Gmail with OAuth2
     - Add and audit support for RSS reader
     - Audit and update support for NNTP
     - Update Thunderbird UI to reflect TorBirdy's state
     - Set secure defaults for outgoing mail servers
   * debian/watch: use new Git repository.
   * debian/README.source: document current build process.
   * debian/copyright: use new upstream Git repository.
   * debian/patches:
     - update socks port change patches to use system tor.
     - add patches to specify a local IP address for no proxy.
Checksums-Sha1:
 23c8b222272899d6a4b6a70419fec86cedeb8926 1997 torbirdy_0.2.0-1.dsc
 86b7a3833b0678c2f6de2a99db40ca34348a6f23 111249 torbirdy_0.2.0.orig.tar.gz
 216f793842f3b31e19ddd103a6a55910a155e839 4444 torbirdy_0.2.0-1.debian.tar.xz
 887226782656816dc88a04bd41a78bd15737513e 108710 xul-ext-torbirdy_0.2.0-1_all.deb
Checksums-Sha256:
 90fc2a8effcbe74b03a7f5f5a907969456bc81408f5f346928e3931046cd048b 1997 torbirdy_0.2.0-1.dsc
 21ae9073fbe5b03bfeceb2b4cd8750849708e0e4a1a5fc47aca42cd4eeb03c11 111249 torbirdy_0.2.0.orig.tar.gz
 1062665cfcda71f3f9929178b141cdfacd288d1a34c3d547057e925ca8118182 4444 torbirdy_0.2.0-1.debian.tar.xz
 5f6083abeb162f67106a6dbb6e241ddb54cf9c7c381b83fdc27af2adf1ecc47a 108710 xul-ext-torbirdy_0.2.0-1_all.deb
Files:
 f5c3d0436e93d5710db63d2d87ea00f2 1997 web optional torbirdy_0.2.0-1.dsc
 6d49a56cb7701afaceaaa78c77194973 111249 web optional torbirdy_0.2.0.orig.tar.gz
 955fa65053e746e00d925fa0314a7338 4444 web optional torbirdy_0.2.0-1.debian.tar.xz
 4723f11e6d9fdd9dea02065414026f43 108710 web optional xul-ext-torbirdy_0.2.0-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJXfCOcAAoJEIYN7zuPZQt5o3cP/RLlbUZ1h+sBIfF4P2XtnfOx
kA0L7tQcSp3pAUh+2nvbPlcEYAgdENFGTjPrlVKa59XAuF1O4pM9RgheZFqTBeCH
mCwTp/b22B5AstRmqFJd/FL+maKew08txiQ5PoLXzbJPs4ONTm2bsqFc8528ljEv
PeDV0VptSn5NmHnb+xsV31ATVw4QBjeGWKm+hxICSzq5CkohvtxxhBo2SxkOZgps
oMn/CI/phRMxzzcHLvTGJSX/KFGb0tbsc+VPwl/0xyibB3ETdJe+JGgdq7tZ5M5Y
BA2AzNxQWKzsaM69TOGq823NbHiVVrPhybs4zrhZ541GyOZggpoR1GVJxzJLAP4Y
c9MnTpJ2Mu0Gqnf4CY8bwfdm15JIAm87r9gkipt+RQLGDKtpk9zdanEm/9BI8Fyr
fay/lDYKN9S6SZ0B9BbHDik0SK+r8cqnwFe47VkxTzmdp7rFFyFAZ+xPVn99yXbL
GKPn5aVq2+k4JYJEOKFwkfZf1UdNk7SCYjFkQgK72U2TE3QdxdynQINsczkTvYTB
eCOW2FlHYK6Bp+ggv8ZH5L4IxVHwURsXr9RrQ7ZSQb17ORBDP/FDdjGTO7ouGxF6
1EFXvJm2Xk5FqYSsPIgtwIGfSaIbplHJ1bmZqJRve7llmr/4sg9j2xfl3fYb74M3
3t7/XhWgx3/kj/3lqTuE
=tPvm
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.