Debian Bug report logs - #810702
Generate initiator name on install, not first boot

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <martin.pitt@ubuntu.com>

To: Debian BTS Submit <submit@bugs.debian.org>

Cc: James Page <james.page@ubuntu.com>

Subject: Generate initiator name on install, not first boot

Date: Mon, 11 Jan 2016 12:45:30 +0100

[Message part 1 (text/plain, inline)]

Package: open-iscsi
Version: 2.0.873+git0.3b4b4500-12
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch xenial

Hello,

In https://launchpad.net/bugs/1057635 it was reported that an
initramfs built during install does not contain a valid iscsi
initiator name. This is because /etc/iscsi/initiatorname.iscsi is
currently created by the init scripts, not the postinst. Thus if d-i
installs open-iscsi, or if you build an OS in a schroot, this will
never happen and the built initramfs will contain only the dummy
initiatorname.iscsi.

James Page fixed this a few years ago in Ubuntu, I adjusted the patch
to the current Debian version.

Disclaimer: I don't know much about open-iscsi, I'm just looking into
our delta and see what's still relevant and what would be beneficial
to Debian too.

Thanks for considering,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[open-iscsi.initiator-in-postinst.debdiff (text/plain, attachment)]

Message #10 received at 810702@bugs.debian.org (full text, mbox, reply):

From: Ritesh Raj Sarraf <rrs@researchut.com>

To: Martin Pitt <martin.pitt@ubuntu.com>, 810702@bugs.debian.org

Cc: James Page <james.page@ubuntu.com>

Subject: Re: Bug#810702: Generate initiator name on install, not first boot

Date: Tue, 12 Jan 2016 22:38:02 +0530

[Message part 1 (text/plain, inline)]

Hi Martin,

Thanks or the patch. One comment/question below.

On Mon, 2016-01-11 at 12:45 +0100, Martin Pitt wrote:
> Package: open-iscsi
> Version: 2.0.873+git0.3b4b4500-12
> Tags: patch
> User: ubuntu-devel@lists.ubuntu.com
> Usertags: origin-ubuntu ubuntu-patch xenial
> 
> Hello,
> 
> In https://launchpad.net/bugs/1057635 it was reported that an
> initramfs built during install does not contain a valid iscsi
> initiator name. This is because /etc/iscsi/initiatorname.iscsi is
> currently created by the init scripts, not the postinst. Thus if d-i
> installs open-iscsi, or if you build an OS in a schroot, this will
> never happen and the built initramfs will contain only the dummy
> initiatorname.iscsi.
> 
> James Page fixed this a few years ago in Ubuntu, I adjusted the patch
> to the current Debian version.
> 
> Disclaimer: I don't know much about open-iscsi, I'm just looking into
> our delta and see what's still relevant and what would be beneficial
> to Debian too.


This must have a similar installer component too ?
Is the Ubuntu installer different than Debian's ?


-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 810702@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: Ritesh Raj Sarraf <rrs@researchut.com>

Cc: 810702@bugs.debian.org, James Page <james.page@ubuntu.com>

Subject: Re: Bug#810702: Generate initiator name on install, not first boot

Date: Mon, 18 Jan 2016 09:52:28 +0100

[Message part 1 (text/plain, inline)]

Hello Ritesh,

Ritesh Raj Sarraf [2016-01-12 22:38 +0530]:
> This must have a similar installer component too ?
> Is the Ubuntu installer different than Debian's ?

I'm afraid I really don't know much about open-iscsi and the details
why this patch was introduced. James, would be great if you can
provide some background.

Ubuntu debian-installer does have some differences, but it's
generally the same. Does d-i really start services during
installation? I would have expected it to install a temporary
policy-rc.d, as presumably many services would fail in
the d-i environment still. Then calling update-initramfs would put the
dummy initiator config into the generated initrd which would fail to
boot.

But supposedly you tried to set up open-iscsi in the Debian installer.
Does that work, or maybe Debian's d-i does not even offer to set up
open-iscsi? Ubuntu's does, that might be the important difference
here.

Thanks,

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 810702@bugs.debian.org (full text, mbox, reply):

From: Ritesh Raj Sarraf <rrs@researchut.com>

To: Martin Pitt <mpitt@debian.org>

Cc: 810702@bugs.debian.org, James Page <james.page@ubuntu.com>

Subject: Re: Bug#810702: Generate initiator name on install, not first boot

Date: Mon, 18 Jan 2016 14:39:55 +0530

[Message part 1 (text/plain, inline)]

Hello Martin,

On Mon, 2016-01-18 at 09:52 +0100, Martin Pitt wrote:
> I'm afraid I really don't know much about open-iscsi and the details
> why this patch was introduced. James, would be great if you can
> provide some background.
> 

One reason to have support in the installer is to have your rootfs on a
SAN device. Anaconda has had it for years. So I'm sure these patches
must have the same intent for Ubuntu Enterprise LTS.

For Debian too, some time ago, I looked at the possibility. IIRC, one
of the components (scsi modules udeb) was unavailable on all
architectures in Debian.


> Ubuntu debian-installer does have some differences, but it's
> generally the same. Does d-i really start services during
> installation? I would have expected it to install a temporary
> policy-rc.d, as presumably many services would fail in
> the d-i environment still. Then calling update-initramfs would put
> the
> dummy initiator config into the generated initrd which would fail to
> boot.
> 
> But supposedly you tried to set up open-iscsi in the Debian
> installer.
> Does that work, or maybe Debian's d-i does not even offer to set up
> open-iscsi? Ubuntu's does, that might be the important difference
> here.

I think D-I currently does not have the support. There was a patch from
Ubuntu, some years ago, for an open-iscsi udeb, which is already part
of the packaging. But I never did see the relevant D-I part for the
installer.

So just thought of asking.


-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 810702@bugs.debian.org (full text, mbox, reply):

From: James Page <james.page@ubuntu.com>

To: rrs@researchut.com

Cc: Martin Pitt <mpitt@debian.org>, 810702@bugs.debian.org, James Page <james.page@ubuntu.com>

Subject: Re: Bug#810702: Generate initiator name on install, not first boot

Date: Mon, 18 Jan 2016 09:52:39 +0000

[Message part 1 (text/plain, inline)]

Hi Folks

On Mon, Jan 18, 2016 at 9:09 AM, Ritesh Raj Sarraf <rrs@researchut.com>
wrote:

> On Mon, 2016-01-18 at 09:52 +0100, Martin Pitt wrote:
> > I'm afraid I really don't know much about open-iscsi and the details
> > why this patch was introduced. James, would be great if you can
> > provide some background.
> >
>
> One reason to have support in the installer is to have your rootfs on a
> SAN device. Anaconda has had it for years. So I'm sure these patches
> must have the same intent for Ubuntu Enterprise LTS.
>

That is the case; I used todo most of the install to iSCSI target testing
at the time, and this got picked up during testing one release.


> > Ubuntu debian-installer does have some differences, but it's
> > generally the same. Does d-i really start services during
> > installation? I would have expected it to install a temporary
> > policy-rc.d, as presumably many services would fail in
> > the d-i environment still. Then calling update-initramfs would put
> > the
> > dummy initiator config into the generated initrd which would fail to
> > boot.
> >
> > But supposedly you tried to set up open-iscsi in the Debian
> > installer.
> > Does that work, or maybe Debian's d-i does not even offer to set up
> > open-iscsi? Ubuntu's does, that might be the important difference
> > here.
>
> I think D-I currently does not have the support. There was a patch from
> Ubuntu, some years ago, for an open-iscsi udeb, which is already part
> of the packaging. But I never did see the relevant D-I part for the
> installer.


Well I guess that if D-I in Debian does not support installing to iSCSI
targets, then this is not consumable, but I think the patch is still
applicable IMHO (just in case someone does do that enablement work - one
less thing to understand that's broken in test).

[Message part 2 (text/html, inline)]

Message #30 received at 810702@bugs.debian.org (full text, mbox, reply):

From: Ritesh Raj Sarraf <rrs@researchut.com>

To: James Page <james.page@ubuntu.com>

Cc: Martin Pitt <mpitt@debian.org>, 810702@bugs.debian.org

Subject: Re: Bug#810702: Generate initiator name on install, not first boot

Date: Mon, 18 Jan 2016 16:07:38 +0530

[Message part 1 (text/plain, inline)]

Hello James,

On Mon, 2016-01-18 at 09:52 +0000, James Page wrote:
> Well I guess that if D-I in Debian does not support installing to
> iSCSI targets, then this is not consumable, but I think the patch is
> still applicable IMHO (just in case someone does do that enablement
> work - one less thing to understand that's broken in test). 

Yes. The patch is fine to be included, and we will add it.

I was just checking to see if there was anything in queue for D-I.


-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 810702@bugs.debian.org (full text, mbox, reply):

From: Christian Seiler <christian@iwakd.de>

To: 810702@bugs.debian.org

Subject: Re: Generate initiator name on install, not first boot

Date: Sun, 31 Jan 2016 18:59:46 +0100

[Message part 1 (text/plain, inline)]

Control: tags -1 + confirmed pending

I've looked at what d-i does when installing on iSCSI and generating an
initiator name in postinst is mostly harmless. d-i generates its own
initiator name (see iscsi stuff in partman) and the hooks in the
open-iscsi-udeb will copy all the configuration to the host system at
the end of the install.

The thing that changes with this is now that a second iname will be
generated by postinst while installing the package, which will then be
overwritten by the open-iscsi-udeb. But since the initramfs was
generated beforehand, the initiator name in there will be the one
generated by the package installation (that isn't present on the system
anymore) and not the one used by d-i that is now the one on the system.
As soon as the initramfs is regenerated for the first time, the name
will then match the one d-i generated.

This shouldn't be more than a cosmetic issue in my eyes, but maybe we
should change the udeb to update the initramfs as well, just in case.

Regardless, I've committed the patch to git. There was one issue with
it, in that it left an obsolete conffile lying around, because
initiatorname.iscsi is not shipped by open-iscsi anymore. I've created
an additional commit that fixes this, so that there are no obsolete
conffile lying around, because administrators might delete those.

Commits that take care of conffile handling:
https://anonscm.debian.org/cgit/pkg-iscsi/open-iscsi.git/commit/?id=b12b4b9d2fa68bc88c9edfb375299f2636254b53
https://anonscm.debian.org/cgit/pkg-iscsi/open-iscsi.git/commit/?id=690a66e6c89a23bd69c6ec56d1954b207e107241

Anyway, should be part of the next upload.

Regards,
Christian

[signature.asc (application/pgp-signature, attachment)]

Message #42 received at 810702-close@bugs.debian.org (full text, mbox, reply):

From: Christian Seiler <christian@iwakd.de>

To: 810702-close@bugs.debian.org

Subject: Bug#810702: fixed in open-iscsi 2.0.873+git0.3b4b4500-13

Date: Thu, 11 Feb 2016 12:21:42 +0000

Source: open-iscsi
Source-Version: 2.0.873+git0.3b4b4500-13

We believe that the bug you reported is fixed in the latest version of
open-iscsi, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 810702@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Seiler <christian@iwakd.de> (supplier of updated open-iscsi package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 11 Feb 2016 16:35:07 +0530
Source: open-iscsi
Binary: open-iscsi open-iscsi-udeb
Architecture: source amd64
Version: 2.0.873+git0.3b4b4500-13
Distribution: unstable
Urgency: medium
Maintainer: Debian iSCSI Maintainers <pkg-iscsi-maintainers@lists.alioth.debian.org>
Changed-By: Christian Seiler <christian@iwakd.de>
Description:
 open-iscsi - iSCSI initiator tools
 open-iscsi-udeb - Configure iSCSI (udeb)
Closes: 804162 804591 809320 810276 810696 810702
Changes:
 open-iscsi (2.0.873+git0.3b4b4500-13) unstable; urgency=medium
 .
   [ Christian Seiler ]
   * [d95ccde] initramfs: fix initramfs creation bug
     (too many symbolic links)
   * [f6246a8] Use triggers instead of update-initramfs
   * [16283ac] Unconditionally add iSCSI to initramfs images
   * [5cf584f] Support RFC 4173 root=iscsi:... format (Closes: #804162)
   * [b12b4b9] Make sure initiatorname.iscsi isn't an obsolete conffile.
   * [06ce1d3] Don't consider iscsiadm exit code 15 to be an error
     (Partial-Fix-For: #809320)
   * [481cedd] Support network autoconfiguration if iscsi_auto is used
     (Closes: #804591)
   * [3b3fa00] Record network device that was configured for iSCSI
   * [508fcba] Handle the default route for iscsi_auto
   * [64b0f31] Fix handling of multiple kept sessions on shutdown
     (Closes: #809320)
   * [df7259e] Fix FTBR on armhf (reproducible builds)
 .
   [ Marco d'Itri ]
   * [d32c7c6] Create in postinst the /sbin/iscsi* compatibility symlinks.
     (Closes: #810276)
 .
   [ Martin Pitt ]
   * [db49787] Migrate from /var/run /run and from /var/lock to /run/lock.
     (Closes: #810696)
   * [1bca41d] Generate initiator name on install, not first boot.
     (Closes: #810702) (LP: #1057635)
Checksums-Sha1:
 b927fa6bb78620b312b4dc0a7c0bdbdc2db442d8 2326 open-iscsi_2.0.873+git0.3b4b4500-13.dsc
 7966c2d934314f998f4187ea936da8838c651451 46028 open-iscsi_2.0.873+git0.3b4b4500-13.debian.tar.xz
 c6887d751aa1a2822098e5e1c2b8e9a37490a636 1808052 open-iscsi-dbgsym_2.0.873+git0.3b4b4500-13_amd64.deb
 f561cffbbad5f1f80aa9706189e50d1288a22d3a 319398 open-iscsi-udeb_2.0.873+git0.3b4b4500-13_amd64.udeb
 ba057fbb95aed380e65a40c465a46ccd1ee771ff 338008 open-iscsi_2.0.873+git0.3b4b4500-13_amd64.deb
Checksums-Sha256:
 5af1af9861bd4b66edd1ebae7981f055c0296b509d4792d8120eb4cf83057610 2326 open-iscsi_2.0.873+git0.3b4b4500-13.dsc
 0036d85968fc0da56098097b7b12dc840ec842c249a1f98b622b06cdf2782ed0 46028 open-iscsi_2.0.873+git0.3b4b4500-13.debian.tar.xz
 e358f847bc4b326644137e76dc82a6a26d6d5316fa2d903319ccc6d072276070 1808052 open-iscsi-dbgsym_2.0.873+git0.3b4b4500-13_amd64.deb
 27c5c464e0e298ecb769d6df050e375d28ad6c2bb93a8b99b2a4cf592e6b98a2 319398 open-iscsi-udeb_2.0.873+git0.3b4b4500-13_amd64.udeb
 9c49016e8ed123cf19f0133c72e201890b72332944b944d7722975d1ed61b03e 338008 open-iscsi_2.0.873+git0.3b4b4500-13_amd64.deb
Files:
 d5184db0d104c72879f10a26d610a688 2326 net optional open-iscsi_2.0.873+git0.3b4b4500-13.dsc
 a69ca2199452cfa503e8760670faf173 46028 net optional open-iscsi_2.0.873+git0.3b4b4500-13.debian.tar.xz
 11667b840e65d3fe0e334d8f17b20061 1808052 debug extra open-iscsi-dbgsym_2.0.873+git0.3b4b4500-13_amd64.deb
 5e7fea5a05ef6a65b20708b7477a73ea 319398 debian-installer optional open-iscsi-udeb_2.0.873+git0.3b4b4500-13_amd64.udeb
 b3bb4f2d134d35be32f9529c9a04cedd 338008 net optional open-iscsi_2.0.873+git0.3b4b4500-13_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJWvHoFAAoJEKY6WKPy4XVpzUcP/jucnI77CgDs75PNn2G4zotn
cL4Xl4BLM9GEAhtx6GU/K0gHBfp1ISFa++st1AjrF5aTnp7GyACU5TrdNeZe7C4B
DXH5FmpWkeng2ArXg752FR0RFsfWUATW4k9YIrD5XcOTeUnPnelCX5Htvw9qc9Ex
8brRGNp9GEOnV9DVJpWUOk5E51gfig9+uNPGfl8oxnehl1epOylJ+66vN3LBfSx6
LakAS1ruQsa4MtYKxVqt+Y+zW/b+CYcvRvv5R0G3mPW3KsZqTWTm4ucoifBiYg1A
ky9yeG02EahN1uRcUsiN5/Rn4NOIxDCujJKTf8j253pJ2Wlhu3idc22xXnfZm3xJ
lUSpKdUlETQsGYhGCHLJvtJ7KFNQdn+kf4XwznskpyMWs0AAFUJKHsAShINuwU7+
4m17pjy5z++fmu7etDcOIb5EGUzNwJiZlMjuiD9bbd4/pGcckXb2OR1zBAFd+Et5
eVhmdZcE00Fxi/67gNgM+IKo+iL41cNNUl56tWERZKYeb3zHSOA3KI9++ik4S6Bi
EZYBxceVSRU0BmTYzXe+dm1d5DIgFO41K+FFh7z6xxLFuhKLsSshxLrm0E5cZT0E
YzM7fABVrP/ItijNmY8pwuaTvfT5589AaShBmW0BWm+/l1eI2Cqr2HWHs5YYeFw2
Bjp0ewTrBMwfwKltJJ0r
=yPIS
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.