Debian Bug report logs - #805955
pcp: FTBFS when built with dpkg-buildpackage -A (no binary artifacts)

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Santiago Vila <sanvila@debian.org>

To: Debian BTS <submit@bugs.debian.org>

Subject: pcp: FTBFS when built with dpkg-buildpackage -A (no binary artifacts)

Date: Tue, 24 Nov 2015 11:18:02 +0000

Package: src:pcp
Version: 3.10.8
User: sanvila@debian.org
Usertags: binary-indep
Severity: important

Dear maintainer:

I tried to build this package with "dpkg-buildpackage -A"
(i.e. only architecture-independent packages), and it failed:

--------------------------------------------------------------------------------
[...]
 fakeroot debian/rules binary-indep
make: Nothing to be done for 'binary-indep'.
 dpkg-genchanges -A >../pcp_3.10.8_all.changes
dpkg-genchanges: error: binary build with no binary artifacts found; cannot distribute
dpkg-buildpackage: error: dpkg-genchanges gave error exit status 2
--------------------------------------------------------------------------------

This usually happens because there is a binary-indep target in debian/rules
which is either empty or does not do anything useful.

If all the arch-independent packages are dummy transitional packages released with jessie,
the easy fix is to drop them now. If not, debian/rules should be modified so that the
binary-indep target generates the architecture independent packages (and only those).

After checking that both "dpkg-buildpackage -A" and "dpkg-buildpackage -B" work
properly, this package will be suitable to be uploaded in source-only form if you wish
(I recommend that you try it).

Thanks.

Message #10 received at 805955@bugs.debian.org (full text, mbox, reply):

From: Santiago Vila <sanvila@debian.org>

To: 805955@bugs.debian.org

Subject: pcp: FTBFS when built with dpkg-buildpackage -A (no binary artifacts)

Date: Thu, 14 Jul 2016 22:08:39 +0000

Greetings.

I have the ok from the Release Managers to consider this issue as RC
for stretch. I'm going to wait at least one week before raising
this to "serious".

If you need help to fix this bug, please tag it as "help".

Thanks.

Message #15 received at 805955@bugs.debian.org (full text, mbox, reply):

From: Nathan Scott <nathans@debian.org>

To: Santiago Vila <sanvila@debian.org>, 805955@bugs.debian.org

Subject: Re: [pcp] Bug#805955: pcp: FTBFS when built with dpkg-buildpackage -A (no binary artifacts)

Date: Thu, 14 Jul 2016 19:04:34 -0400 (EDT)

Hi Santiago,

----- Original Message -----
> Greetings.
> 
> I have the ok from the Release Managers to consider this issue as RC
> for stretch. I'm going to wait at least one week before raising
> this to "serious".
> 
> If you need help to fix this bug, please tag it as "help".
> 

I have a build with another pending fix to upload too, so will look into
this first and push both up this weekend.

cheers.

--
Nathan

Message #20 received at 805955@bugs.debian.org (full text, mbox, reply):

From: Nathan Scott <nathans@debian.org>

To: Santiago Vila <sanvila@debian.org>, 805955@bugs.debian.org

Subject: Re: [pcp] Bug#805955: pcp: FTBFS when built with dpkg-buildpackage -A (no binary artifacts)

Date: Tue, 19 Jul 2016 03:12:47 -0400 (EDT)

Tags: help

----- Original Message -----
> Greetings.
> 
> I have the ok from the Release Managers to consider this issue as RC
> for stretch. I'm going to wait at least one week before raising
> this to "serious".
> 
> If you need help to fix this bug, please tag it as "help".

Actually some advice would be great, having had an initial look into
this one now.  Patch below shows the basic split we'll need to make
the architecture independent packages generated separately, but I'm
not sure how to fit that split into the rest of the rules file (I get
the same sort of errors with a change like this in place no matter
what I try - maybe its obvious to someone more deb knowledgeable?).

Thanks!

--
Nathan


diff --git a/debian/rules b/debian/rules
index dccf619..44774a1 100755
--- a/debian/rules
+++ b/debian/rules
@@ -163,7 +163,20 @@ clean:
 	dh_autotools-dev_restoreconfig
 	dh_clean
 
-binary-indep:
+binary-indep: checkroot build-stamp
+	@echo "== dpkg-buildpackage: binary-indep" 1>&2
+	$(checkdir)
+	$(pkgpcp_import_sar) $(MAKE) -C src/sar2pcp install
+	$(pkgpcp_import_ganglia) $(MAKE) -C src/ganglia2pcp install
+	$(pkgpcp_import_mrtg) $(MAKE) -C src/mrtg2pcp install
+	$(pkgpcp_import_sheet) $(MAKE) -C src/sheet2pcp install
+	$(pkgpcp_import_iostat) $(MAKE) -C src/iostat2pcp install
+	dh_perl -p $(pcp_import_sar)
+	dh_perl -p $(pcp_import_ganglia)
+	dh_perl -p $(pcp_import_mrtg)
+	dh_perl -p $(pcp_import_sheet)
+	dh_perl -p $(pcp_import_iostat)
+	dh_installdeb
 
 binary-arch: checkroot build-stamp
 	@echo "== dpkg-buildpackage: binary-arch" 1>&2
@@ -177,11 +190,6 @@ binary-arch: checkroot build-stamp
 	$(pkglibpcp_pmda_perl) $(MAKE) -C src/perl/PMDA install_perl
 	$(pkglibpcp_import_perl) $(MAKE) -C src/perl/LogImport install_perl
 	$(pkgpcp_logsummary_perl) $(MAKE) -C src/perl/LogSummary install_perl
-	$(pkgpcp_import_sar) $(MAKE) -C src/sar2pcp install
-	$(pkgpcp_import_ganglia) $(MAKE) -C src/ganglia2pcp install
-	$(pkgpcp_import_mrtg) $(MAKE) -C src/mrtg2pcp install
-	$(pkgpcp_import_sheet) $(MAKE) -C src/sheet2pcp install
-	$(pkgpcp_import_iostat) $(MAKE) -C src/iostat2pcp install
 	$(pkgpcp_import_collectl) $(MAKE) -C src/collectl2pcp install
 	$(pkgpcp_export_graphite) $(MAKE) -C src/pcp2graphite install
 	$(pkgpcp_export_zabbix) $(MAKE) -C src/zabbix-agent install
@@ -237,11 +245,6 @@ binary-arch: checkroot build-stamp
 	dh_perl -p $(libpcp_pmda_perl)
 	dh_perl -p $(libpcp_import_perl)
 	dh_perl -p $(pcp_logsummary_perl)
-	dh_perl -p $(pcp_import_sar)
-	dh_perl -p $(pcp_import_ganglia)
-	dh_perl -p $(pcp_import_mrtg)
-	dh_perl -p $(pcp_import_sheet)
-	dh_perl -p $(pcp_import_iostat)
 	dh_installdeb
 	dh_shlibdeps 2>/dev/null	# qmake doesn't allow a library list
 	dh_gencontrol $(SUBSTVARS) 2>/dev/null	# squash the python:Versions warning

Message #25 received at 805955@bugs.debian.org (full text, mbox, reply):

From: Santiago Vila <sanvila@unex.es>

To: Nathan Scott <nathans@debian.org>

Cc: 805955@bugs.debian.org

Subject: Re: [pcp] Bug#805955: pcp: FTBFS when built with dpkg-buildpackage -A (no binary artifacts)

Date: Tue, 19 Jul 2016 10:44:16 +0200 (CEST)

> Actually some advice would be great, having had an initial look into
> this one now.  Patch below shows the basic split we'll need to make
> the architecture independent packages generated separately, but I'm
> not sure how to fit that split into the rest of the rules file (I get
> the same sort of errors with a change like this in place no matter
> what I try - maybe its obvious to someone more deb knowledgeable?).

I have not tested the patch but I see why it would not work.

Try putting "dh_builddeb" somewhere in binary-indep, otherwise the
actual .deb packages will not be created.

Thanks.

Message #30 received at 805955@bugs.debian.org (full text, mbox, reply):

From: Nathan Scott <nathans@debian.org>

To: Santiago Vila <sanvila@unex.es>

Cc: 805955@bugs.debian.org

Subject: Re: [pcp] Bug#805955: pcp: FTBFS when built with dpkg-buildpackage -A (no binary artifacts)

Date: Wed, 20 Jul 2016 19:38:32 -0400 (EDT)

----- Original Message -----
> > Actually some advice would be great, having had an initial look into
> > this one now.  Patch below shows the basic split we'll need to make
> > the architecture independent packages generated separately, but I'm
> > not sure how to fit that split into the rest of the rules file (I get
> > the same sort of errors with a change like this in place no matter
> > what I try - maybe its obvious to someone more deb knowledgeable?).
> 
> I have not tested the patch but I see why it would not work.
> 
> Try putting "dh_builddeb" somewhere in binary-indep, otherwise the
> actual .deb packages will not be created.
> 
> Thanks.
> 

Taa.  I see problems in the binary-indep target before the build reaches
that stage though.  The debian/rules uses dh_install(1) - in particular,
it relies on this behaviour from the man page...

    On the other hand, maybe you have a large package that builds
    multiple binary packages. You can use the upstream Makefile to
    install it all into debian/tmp, and then use dh_install to copy
    directories and files from there into the proper package build
    directories.

And dh_install fails when used by the binary-indep target - it requires
files from both binary-indep and binary-arch, I think.  Does that mean
dh_install can no longer be used for these targets as described above or
does that stage need to done elsewhere?  (before dh_builddeb I'm sure)

Thanks.

--
Nathan

Message #35 received at 805955@bugs.debian.org (full text, mbox, reply):

From: Santiago Vila <sanvila@unex.es>

To: Nathan Scott <nathans@debian.org>

Cc: 805955@bugs.debian.org

Subject: Re: [pcp] Bug#805955: pcp: FTBFS when built with dpkg-buildpackage -A (no binary artifacts)

Date: Thu, 21 Jul 2016 13:24:56 +0200 (CEST)

On Wed, 20 Jul 2016, Nathan Scott wrote:

> > > Actually some advice would be great, having had an initial look into
> > > this one now.  Patch below shows the basic split we'll need to make
> > > the architecture independent packages generated separately, but I'm
> > > not sure how to fit that split into the rest of the rules file (I get
> > > the same sort of errors with a change like this in place no matter
> > > what I try - maybe its obvious to someone more deb knowledgeable?).
> > 
> > I have not tested the patch but I see why it would not work.
> > 
> > Try putting "dh_builddeb" somewhere in binary-indep, otherwise the
> > actual .deb packages will not be created.
> > 
> > Thanks.
> > 
> 
> Taa.  I see problems in the binary-indep target before the build reaches
> that stage though.  The debian/rules uses dh_install(1) - in particular,
> it relies on this behaviour from the man page...
> 
>     On the other hand, maybe you have a large package that builds
>     multiple binary packages. You can use the upstream Makefile to
>     install it all into debian/tmp, and then use dh_install to copy
>     directories and files from there into the proper package build
>     directories.
> 
> And dh_install fails when used by the binary-indep target - it requires
> files from both binary-indep and binary-arch, I think.

That should not happen unless you are creating packages that have to
conflict at each other because they contain the same files.

> Does that mean dh_install can no longer be used for these targets
> as described above or does that stage need to done elsewhere?
> (before dh_builddeb I'm sure)

You can probably use dh_install here, but I see that you are using
dh_install with --sourcedir. While this is supported, I would
recommend that you do "make install" to debian/tmp first
(not to debian/firstpackage) and use the already existing
debian/*.install files to tell dh_install which files go to which
packages.

This usually makes debian/rules to be more simple and easier to
understand, and it also makes the future switch to "dh" easier.

Thanks.

Message #44 received at 805955@bugs.debian.org (full text, mbox, reply):

From: Daniel Baumann <daniel.baumann@progress-linux.org>

To: 805955@bugs.debian.org

Subject: Re: pcp: FTBFS when built with dpkg-buildpackage -A (no binary artifacts)

Date: Tue, 24 Oct 2017 16:03:36 +0200

tag 805955 + patch
thanks

Hi,

it would be nice if pcp eventually would make it into testing. Please
consider applying the following patch that we're using since a while:

https://sources.progress-linux.org/distributions/dschinn-backports/packages/pcp/commit/?id=f45bafca0091e539288fedc20d488a8414966328

Regards,
Daniel

Message #49 received at 805955@bugs.debian.org (full text, mbox, reply):

From: Ken McDonell <kenj@kenj.id.au>

To: 805955@bugs.debian.org

Subject: Re: pcp: FTBFS when built with dpkg-buildpackage -A (no binary artifacts)

Date: Tue, 7 Nov 2017 07:02:19 +1100

We have incorporated changes based on Daniel's proposed patch into PCP.

As of commit e7406b4 in the github PCP tree on 28 Oct 2017, we're making 
arch independent packages for dpkg builds.

$ dpkg-query -W -f '${Package} ${Architecture}\n' pcp\* | grep all
pcp-doc all
pcp-import-ganglia2pcp all
pcp-import-iostat2pcp all
pcp-import-mrtg2pcp all
pcp-import-sar2pcp all
pcp-import-sheet2pcp all

So I think this bug can be closed.

Message #54 received at 805955@bugs.debian.org (full text, mbox, reply):

From: Matthias Klose <doko@debian.org>

To: 805955@bugs.debian.org

Subject: Re: pcp: FTBFS when built with dpkg-buildpackage -A (no binary artifacts)

Date: Tue, 28 Nov 2017 06:45:48 +0100

> So I think this bug can be closed.

No.  3.2.2-1 still can't be built.

Send a report that this bug log contains spam.