Debian Bug report logs - #804436
mlmmj: tells user to add malformed entry to /etc/crontab

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Phil Reynolds <phil-debian@tinsleyviaduct.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: mlmmj: installs incorrectly formatted job to /etc/crontab when creating a list

Date: Sun, 08 Nov 2015 12:05:08 +0000

Package: mlmmj
Version: 1.2.18.1-1+b1
Severity: critical
Justification: breaks unrelated software

Dear Maintainer,

I recently moved all of my email setup to a new machine. I installed mlmmj,
and when I created a list, it added the following /line to /etc/crontab:

0 */2 * * * "/usr/bin/mlmmj-maintd -F -L /var/spool/mlmmj/tvcadmin/"

This led to another job failing to run - its crontab entry is:

1 0	* * *	root	/usr/local/bin/simplebackup

The mlmmj-maintd job ran, but the simplebackup job was never started. As for
the other jobs listed, I am unsure whether they ran or not.

When I amended the mlmmj-maintd job thus, the problem was resolved:

0 */2	* * *	root	/usr/bin/mlmmj-maintd -F -L /var/spool/mlmmj/tvcadmin/

The problem appears to be that mlmmj creates the crontab entry without
specifying the user name. It should either specify the user name or put the
entry in the user's crontab.

-- System Information:
Debian Release: 8.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/6 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages mlmmj depends on:
ii  debconf [debconf-2.0]                      1.5.56
ii  exim4                                      4.84-8
ii  exim4-daemon-heavy [mail-transport-agent]  4.84-8
ii  libc6                                      2.19-18+deb8u1

mlmmj recommends no packages.

Versions of packages mlmmj suggests:
pn  mlmmj-php-web        <none>
pn  mlmmj-php-web-admin  <none>

-- debconf-show failed

Message #10 received at 804436@bugs.debian.org (full text, mbox, reply):

From: Chris Knadle <Chris.Knadle@coredump.us>

To: 804436@bugs.debian.org, Phil Reynolds <phil-debian@tinsleyviaduct.com>, control@bugs.debian.org

Subject: mlmmj: installs incorrectly formatted job to /etc/crontab when creating a list

Date: Thu, 24 Mar 2016 05:51:20 +0000

severity 804436 important
retitle 804436 mlmmj: tells user to add malformed entry to /etc/crontab
thanks

> I recently moved all of my email setup to a new machine. I installed mlmmj,
> and when I created a list, it added the following /line to /etc/crontab:
> 
> 0 */2 * * * "/usr/bin/mlmmj-maintd -F -L /var/spool/mlmmj/tvcadmin/"
> 
> This led to another job failing to run - its crontab entry is:
> 
> 1 0	* * *	root	/usr/local/bin/simplebackup
> 
> The mlmmj-maintd job ran, but the simplebackup job was never started. As for
> the other jobs listed, I am unsure whether they ran or not.
> 
> When I amended the mlmmj-maintd job thus, the problem was resolved:
> 
> 0 */2	* * *	root	/usr/bin/mlmmj-maintd -F -L /var/spool/mlmmj/tvcadmin/
> 
> The problem appears to be that mlmmj creates the crontab entry without
> specifying the user name. It should either specify the user name or put the
> entry in the user's crontab.

I just found this bug the other day when I installed mlmmj on Sid to do some
testing and found the bug report by way of how-can-i-help... and I think
I've figured out what's going on.

mlmmj does not install anything to /etc/crontab -- instead it installs a
cronjob at /etc/cron.d/mlmmj that contains this (which works fine):

   0 */2 * * * root /usr/bin/test -x /usr/bin/mlmmj-maintd &&
/usr/bin/mlmmj-maintd -F -d /var/spool/mlmmj

This runs mlmmj-maintd every half hour for all mlmmj mailing lists that
reside under /var/spool/mlmmj -- meaning that adding separate mlmmj-maintd
entries to /etc/crontab is not necessary.



However after running '/usr/bin/mlmmj-make-ml -L testlist2 -s
/var/spool/mlmmj -a -c mlmmj' to create a mailing list it outputs the
following text:

   If you're not starting mlmmj-maintd in daemon mode,
   don't forget to add this to your crontab:
   0 */2 * * * "/usr/bin/mlmmj-maintd -F -L /var/spool/mlmmj/testlist2/"

and this is the bug: it tells the admin running the mailing list to modify
/etc/crontab when it's not necessary to do so, and in a way that will break
things.  It's not obvious that the cron job added in /etc/cron.d/mlmmj
exists and runs mlmmj-maintd on all mailing lists as this isn't mentioned in
the README.Debian.gz.  Furthermore because it's done as a cron job this
would not be considered "daemon mode" and thus even if the user found this
out they still may be misled into thinking that adding the malformed entry
into /etc/crontab is needed.



It seems like this package needs a patch to either modify the text output
concerning the crontab entry or remove it, and I'm not sure which is better.
 I'm considering making a patch an uploading it via a sponsored NMU.


Because of the RC bug severity and lack of response, mlmmj has been missing
from Testing for the last 3-1/2 months.  This seems to be an indication that
the maintainer is too busy for the package, so I'm considering filing an ITA
to adopt the package.  Thomas: this okay with you?

   -- Chris

-- 
Chris Knadle
Chris.Knadle@coredump.us

Message #19 received at 804436@bugs.debian.org (full text, mbox, reply):

From: Thomas Goirand <zigo@debian.org>

To: Chris Knadle <Chris.Knadle@coredump.us>, 804436@bugs.debian.org, Phil Reynolds <phil-debian@tinsleyviaduct.com>

Subject: Re: [Pkg-mlmmj-devel] Bug#804436: mlmmj: installs incorrectly formatted job to /etc/crontab when creating a list

Date: Thu, 24 Mar 2016 09:44:19 +0100

On 03/24/2016 06:51 AM, Chris Knadle wrote:
> It seems like this package needs a patch to either modify the text output
> concerning the crontab entry or remove it, and I'm not sure which is better.
>  I'm considering making a patch an uploading it via a sponsored NMU.
> 
> 
> Because of the RC bug severity and lack of response, mlmmj has been missing
> from Testing for the last 3-1/2 months.  This seems to be an indication that
> the maintainer is too busy for the package, so I'm considering filing an ITA
> to adopt the package.  Thomas: this okay with you?
> 
>    -- Chris

Hi Chris,

I'm busy with the packaging of OpenStack indeed, and couldn't take care
much of MLMMJ in time, I'm sorry for that.

Instead of just taking over the maintenance, wouldn't you like to join
the MLMMJ packaging group, and package it as a team, still with me? It's
often much better to do this way. If you need sponsored uploads, I can
do that too.

Your thoughts?

Cheers,

Thomas Goirand (zigo)

P.S: It'd be also nice to upgrade to the latest upstream release. They
also accept patch, so if you patch out the message, probably it'd be
better to have this as a build option or something...

Message #24 received at 804436@bugs.debian.org (full text, mbox, reply):

From: Phil Reynolds <phil-debian@tinsleyviaduct.com>

To: Chris Knadle <Chris.Knadle@coredump.us>

Cc: 804436@bugs.debian.org, control@bugs.debian.org

Subject: Re: mlmmj: installs incorrectly formatted job to /etc/crontab when creating a list

Date: Thu, 24 Mar 2016 12:39:35 +0000

On Thu, 24 Mar 2016 05:51:20 +0000
Chris Knadle <Chris.Knadle@coredump.us> wrote:

> severity 804436 important
> retitle 804436 mlmmj: tells user to add malformed entry
> to /etc/crontab thanks

Hmmm... as I explain below, in my case it merely went ahead and did it.

> However after running '/usr/bin/mlmmj-make-ml -L testlist2 -s
> /var/spool/mlmmj -a -c mlmmj' to create a mailing list it outputs the
> following text:
> 
>    If you're not starting mlmmj-maintd in daemon mode,
>    don't forget to add this to your crontab:
>    0 */2 * * * "/usr/bin/mlmmj-maintd -F
> -L /var/spool/mlmmj/testlist2/"
> 
> and this is the bug: it tells the admin running the mailing list to
> modify /etc/crontab when it's not necessary to do so, and in a way
> that will break things.  It's not obvious that the cron job added
> in /etc/cron.d/mlmmj exists and runs mlmmj-maintd on all mailing
> lists as this isn't mentioned in the README.Debian.gz.  Furthermore
> because it's done as a cron job this would not be considered "daemon
> mode" and thus even if the user found this out they still may be
> misled into thinking that adding the malformed entry
> into /etc/crontab is needed.
 
Just to clarify this, it did not tell me to add the entry, it just went
ahead and did it, on the wheezy setup I used... had it told me to do
it, I'd have spotted the error. The behaviour may have changed between
versions, perhaps. However, as you say, it seems to be unnecessary
anyway.

-- 
Phil Reynolds
mail: phil-debian@tinsleyviaduct.com
Web: http://phil.tinsleyviaduct.com/

Message #29 received at 804436@bugs.debian.org (full text, mbox, reply):

From: Chris Knadle <Chris.Knadle@coredump.us>

To: Phil Reynolds <phil-debian@tinsleyviaduct.com>, 804436@bugs.debian.org

Subject: Re: Bug#804436: mlmmj: installs incorrectly formatted job to /etc/crontab when creating a list

Date: Thu, 24 Mar 2016 17:38:36 +0000

Phil Reynolds:
> On Thu, 24 Mar 2016 05:51:20 +0000
> Chris Knadle <Chris.Knadle@coredump.us> wrote:
[...]
> Hmmm... as I explain below, in my case it merely went ahead and did it.

[...]
> Just to clarify this, it did not tell me to add the entry, it just went
> ahead and did it, on the wheezy setup I used... had it told me to do
> it, I'd have spotted the error. The behaviour may have changed between
> versions, perhaps. However, as you say, it seems to be unnecessary
> anyway.

The current version of mlmmj in Wheezy doesn't add an entry to /etc/crontab
on its own, and I've been running mlmmj for two years and don't ever recall
it doing this either.

If mlmmj did do it at some point it could be proven by examining old
versions uploaded to Debian via snapshots.debian.org:

   http://snapshot.debian.org/package/mlmmj/

The two versions of most interest would be the earliest version that shipped
with Wheezy, and the earliest version that shipped with Squeeze.  Looking at
the release dates of Debian vs mlmmj I think that would correspond with
1.2.18.0-2 for Wheezy, and 1.2.17-2 for Squeeze.

   -- Chris

-- 
Chris Knadle
Chris.Knadle@coredump.us

Message #34 received at 804436@bugs.debian.org (full text, mbox, reply):

From: Chris Knadle <Chris.Knadle@coredump.us>

To: Thomas Goirand <zigo@debian.org>, 804436@bugs.debian.org

Subject: Re: Bug#804436: [Pkg-mlmmj-devel] Bug#804436: mlmmj: installs incorrectly formatted job to /etc/crontab when creating a list

Date: Thu, 24 Mar 2016 17:47:33 +0000

Thomas Goirand:
> On 03/24/2016 06:51 AM, Chris Knadle wrote:
>> It seems like this package needs a patch to either modify the text output
>> concerning the crontab entry or remove it, and I'm not sure which is better.
>>  I'm considering making a patch an uploading it via a sponsored NMU.
>>
>>
>> Because of the RC bug severity and lack of response, mlmmj has been missing
>> from Testing for the last 3-1/2 months.  This seems to be an indication that
>> the maintainer is too busy for the package, so I'm considering filing an ITA
>> to adopt the package.  Thomas: this okay with you?
>>
>>    -- Chris
> 
> Hi Chris,
> 
> I'm busy with the packaging of OpenStack indeed, and couldn't take care
> much of MLMMJ in time, I'm sorry for that.

It happens.  Unfortunately I see this happening commonly, so I consider this
as part of "the life cycle of a Debian developer" -- and in the back of my
mind I'm wondering if/when it'll happen to me.

> Instead of just taking over the maintenance, wouldn't you like to join
> the MLMMJ packaging group, and package it as a team, still with me? It's
> often much better to do this way. If you need sponsored uploads, I can
> do that too.

A helping hand is always welcome.  Sure -- sounds good to me.  I'm guessing
this involves joining the [pkg-mlmmj] project on Alioth.  I'll send a
request to join the group.

I'm a DM, so after one or two uploads I'd appreciate it if you'd be willing
to flip the bit to allow me to upload directly so that I can upload and/or
fix issues during times you're too busy to do package review.  [We met at
DebConf14 + 15 BTW.]

> Cheers,
> 
> Thomas Goirand (zigo)
> 
> P.S: It'd be also nice to upgrade to the latest upstream release. They
> also accept patch, so if you patch out the message, probably it'd be
> better to have this as a build option or something...

Yes I've been on the [mlmmj] mailing list for a couple of years as well.
I'll notify them about the problem and can send them a patch once I have one
ready.

   -- Chris

-- 
Chris Knadle
Chris.Knadle@coredump.us

Message #39 received at 804436-close@bugs.debian.org (full text, mbox, reply):

From: Christopher Knadle <Chris.Knadle@coredump.us>

To: 804436-close@bugs.debian.org

Subject: Bug#804436: fixed in mlmmj 1.2.18.1-2

Date: Thu, 26 May 2016 07:49:13 +0000

Source: mlmmj
Source-Version: 1.2.18.1-2

We believe that the bug you reported is fixed in the latest version of
mlmmj, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 804436@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christopher Knadle <Chris.Knadle@coredump.us> (supplier of updated mlmmj package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 11 May 2016 22:46:20 -0400
Source: mlmmj
Binary: mlmmj mlmmj-php-web mlmmj-php-web-admin
Architecture: source amd64 all
Version: 1.2.18.1-2
Distribution: unstable
Urgency: medium
Maintainer: MLMMJ packaging team <pkg-mlmmj-devel@lists.alioth.debian.org>
Changed-By: Christopher Knadle <Chris.Knadle@coredump.us>
Description:
 mlmmj      - mail server independent mailing list manager
 mlmmj-php-web - web interface for mlmmj, written in php
 mlmmj-php-web-admin - administrative web interface for mlmmj, written in php
Closes: 804436 821532 821533
Changes:
 mlmmj (1.2.18.1-2) unstable; urgency=medium
 .
   * debian/control
     - Add myself to Uploaders
     - Depend on PHP 7 rather than PHP 5 (Closes: #821532, #821533)
     - Update Standards-Version to 3.9.8 (no changes needed)
     - Update Vcs-Browser and Vcs-Git links with https version
   * debian/copyright
     - Update from DEP5 to copyright 1.0 format
     - Update BSD keyword to BSD-4-clause
   * debian/docs:
     - Remove debian/README.source (file removed)
   * debian/patches:
     - Update 05_fix_displayed_full_paths.diff for line offset fuzz
     - Reorder series file to apply patches in numeric order
     - Add 06_fix-php-web-for-php7.diff to fix mlmmj web packages for PHP 7.0
     - Add 07_fix-crontab-suggestions.diff to fix the crontab instructions to
       include the user (root) to run the crontab entry, and inform the user
       that the Debian package already includes a crontab entry
       (Closes: #804436)
   * debian/rules:
     - Update to split up package building for arch and indep so that
       binary-arch doesn't produce "arch: all" packages which is supposed
       to happen only in the binary-indep target
   * debian/README.source:
     - Remove file as it is no longer necessary; stated that the package is
       using dpatch which isn't the case as of 1.2.17-4
Checksums-Sha1:
 da238e55575139190bc0572bc6df5ad332e0b74f 2077 mlmmj_1.2.18.1-2.dsc
 851d1596f97b594b65f73951efde8150a9df8724 23200 mlmmj_1.2.18.1-2.debian.tar.xz
 8f31914d8a2af67bc2874c18e3eaf1cd84078d8d 390592 mlmmj-dbgsym_1.2.18.1-2_amd64.deb
 ad7b179598910117dc3cebd84f806631d28e4cc4 37472 mlmmj-php-web-admin_1.2.18.1-2_all.deb
 9653baf09c32d95bb2144cacc5d63d3cea0d8af7 22450 mlmmj-php-web_1.2.18.1-2_all.deb
 22338a9d80e8c118a8666ffcdecb5466597ec0ff 185804 mlmmj_1.2.18.1-2_amd64.deb
Checksums-Sha256:
 a354d0cfa5d9a7a73e78cb822d864523987db0820595d7b4d18d20dfbe60be35 2077 mlmmj_1.2.18.1-2.dsc
 619b197760a68c211f02a5ddf8ce36945adfa269e43927c425268adf84733629 23200 mlmmj_1.2.18.1-2.debian.tar.xz
 8071679686381efabeac64da818275bef166fc5bb95f8677d8a2ccdc49e7c8a4 390592 mlmmj-dbgsym_1.2.18.1-2_amd64.deb
 4680a577ae90bd8ac52bf9b7bdd62a8b12b7d32022fdc420c703cf16746759b4 37472 mlmmj-php-web-admin_1.2.18.1-2_all.deb
 c4604705e373dd17b31b07561c8985f3db3f8d64ced92527d499a108e21736c0 22450 mlmmj-php-web_1.2.18.1-2_all.deb
 dd37a4fa2f2f3bdc467f36efa26b758f7155d1569eb746019d1a027a18f62725 185804 mlmmj_1.2.18.1-2_amd64.deb
Files:
 d9d976f1530ee0a491c7199dc46bd6d6 2077 mail optional mlmmj_1.2.18.1-2.dsc
 558c450e514ae09aa0e9b4cb07db3aae 23200 mail optional mlmmj_1.2.18.1-2.debian.tar.xz
 0c03076e877c35b65ba62a6c693cc222 390592 debug extra mlmmj-dbgsym_1.2.18.1-2_amd64.deb
 0da03dcd9f14690c79250fb3dbecea91 37472 mail optional mlmmj-php-web-admin_1.2.18.1-2_all.deb
 08ec2971248f6961cbd0299395f0aeee 22450 mail optional mlmmj-php-web_1.2.18.1-2_all.deb
 78eae3fff6351be2fd19207b03f19924 185804 mail optional mlmmj_1.2.18.1-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJXRqgEAAoJENQWrRWsa0P+LC4P+wWMxRcdJQEWj52i9BgDuW9F
o72BNBnkHMHeAiCWB+R1IIxrvfJWwQ+jt4AZHM8Vz+HEPN0xvay4/bsIox9eSWGz
agWhbwoEVzSeSROjVx09JQfH2v2yBqfwySaVxeTZkLrYaOax9K5hOnDPbTxXPQx1
JbSwYGoXVGnbwAxB3s8upXhSVFAlsVyuJDDKGPLdrS20bQpZ6HvcAc0sLQKq/6VH
qR7gq188wjzwk7vlZIUdCsGogEDo5+4WMRR5x8u8f8KQ+BrMKqykC/0EYaJV6IF7
bKMCLw0KQglS1uXtrvRp2bqhi2W3T6AeSntdSZQroUhg7c3pzgyd4B9t2nj5Tlj4
g/0T8/4Pgc3TNB9UXDTz3/c2uuyptORAd/JaMZMaeSCk7OcA5wqCrm+zLdJ5iuzr
O1LJ2KQbVG/4uvYj7li+WAu2Sc5x0kRdLqy/g8LPaZvvUOosPYuH0Pmj1GqJ/O9S
XO75inpISNlQ3iqBIVD9EOkcWLbinL1wcx9CKKQg2W4OQXdJ04Bm3rNvonSmFt2z
vEuSp4Lqc7RnORCywKGIAvJyFOVtM/5cbM7sA66o6Z3xvEW2z5PcCeqNVXIy8zWr
tRXx5CDrY+u2+S1QRL5i3+jv/cJeJQCvRPqZegy5QusnKE2V7R57jXweyvcVX1lv
JwG+Lhnzti0AQ7UPcTKM
=7fVM
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.