Debian Bug report logs - #804194
squashfs-tools: unsquashfs not preserving file capabilities

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Ivan Vilata i Balaguer <ivan@selidor.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: squashfs-tools: unsquashfs not preserving file capabilities

Date: Fri, 06 Nov 2015 00:47:47 +0100

Package: squashfs-tools
Version: 1:4.3-3
Severity: normal
Tags: upstream

``unsquashfs`` fails to properly apply capabilities to a file which has them
in the filesystem image:

    # mount -o loop test.squashfs /mnt
    # getcap /mnt/bin/ping
    /mnt/bin/ping = cap_net_raw+ep
    # unsquashfs -x test.squashfs
    # getcap squashfs-root/bin/ping
    #

This was already reported and a temptative patch sent by Prasad Koya on LKML a
few weeks ago: <https://lkml.org/lkml/2015/10/7/412>

Thanks!

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.2.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=ca_ES.UTF-8, LC_CTYPE=ca_ES.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages squashfs-tools depends on:
ii  libc6      2.19-22
ii  liblz4-1   0.0~r131-1
ii  liblzma5   5.1.1alpha+20120614-2.1
ii  liblzo2-2  2.08-1.2
ii  zlib1g     1:1.2.8.dfsg-2+b1

squashfs-tools recommends no packages.

squashfs-tools suggests no packages.

-- no debconf information

Message #12 received at 804194@bugs.debian.org (full text, mbox, reply):

From: Joost van Baal-Ilić <joostvb+debian-bugs-20151211-3@uvt.nl>

To: 804194@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: #804194: squashfs-tools: unsquashfs not preserving file capabilities

Date: Fri, 11 Dec 2015 16:36:54 +0100

[Message part 1 (text/plain, inline)]

tags 804194 patch
thanks

Hi,

Wessel Dankers <wsl-debian-804194@fruit.je> contributed attached patch.  It
fixes this reported bug.

Boils down to:

--- squashfs-tools-4.2+20130409.orig/unsquashfs.c
+++ squashfs-tools-4.2+20130409/unsquashfs.c
@@ -786,8 +786,6 @@ int set_attributes(char *pathname, int m
 {
        struct utimbuf times = { time, time };
 
-       write_xattr(pathname, xattr);
-
        if(utime(pathname, &times) == -1) {
                ERROR("set_attributes: failed to set time on %s, because %s\n",
                        pathname, strerror(errno));
@@ -810,6 +808,8 @@ int set_attributes(char *pathname, int m
                return FALSE;
        }
 
+       write_xattr(pathname, xattr);
+
        return TRUE;
 }
 

----------------------------------------------------------------

Thanks, Bye,

Joost

-- 
Joost van Baal-Ilić                       http://abramowitz.uvt.nl/
                                                 Tilburg University
mailto:joostvb.uvt.nl                               The Netherlands

[xattr.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 804194@bugs.debian.org (full text, mbox, reply):

From: Daniel Baumann <daniel.baumann@progress-linux.org>

To: 804194@bugs.debian.org

Subject: Re: squashfs-tools: unsquashfs not preserving file capabilities

Date: Mon, 17 Jul 2017 13:51:02 +0200

Hi Laszlo,

what's the status of this bug? It would be nice if you could cherry-pick
the patch, it makes building live systems way easier (less workarounds
needed).

Regards,
Daniel

Message #22 received at 804194@bugs.debian.org (full text, mbox, reply):

From: László Böszörményi (GCS) <gcs@debian.org>

To: Daniel Baumann <daniel.baumann@progress-linux.org>, 804194@bugs.debian.org

Subject: Re: Bug#804194: squashfs-tools: unsquashfs not preserving file capabilities

Date: Tue, 18 Jul 2017 11:25:24 +0200

Hi Daniel,

On Mon, Jul 17, 2017 at 1:51 PM, Daniel Baumann
<daniel.baumann@progress-linux.org> wrote:
> what's the status of this bug? It would be nice if you could cherry-pick
> the patch, it makes building live systems way easier (less workarounds
> needed).
 If I have the fixed package, can you help with testing it?

Thanks,
Laszlo/GCS

Message #27 received at 804194@bugs.debian.org (full text, mbox, reply):

From: Daniel Baumann <daniel.baumann@progress-linux.org>

To: László Böszörményi (GCS) <gcs@debian.org>

Cc: 804194@bugs.debian.org

Subject: Re: Bug#804194: squashfs-tools: unsquashfs not preserving file capabilities

Date: Tue, 18 Jul 2017 18:01:58 +0200

On 07/18/17 11:25, László Böszörményi (GCS) wrote:
>  If I have the fixed package, can you help with testing it?

sure, thanks.

Regards,
Daniel

Message #32 received at 804194@bugs.debian.org (full text, mbox, reply):

From: László Böszörményi (GCS) <gcs@debian.org>

To: Daniel Baumann <daniel.baumann@progress-linux.org>, 804194@bugs.debian.org

Subject: Re: Bug#804194: squashfs-tools: unsquashfs not preserving file capabilities

Date: Sun, 23 Jul 2017 14:10:45 +0200

Hi Daniel,

On Tue, Jul 18, 2017 at 6:01 PM, Daniel Baumann
<daniel.baumann@progress-linux.org> wrote:
> On 07/18/17 11:25, László Böszörményi (GCS) wrote:
>>  If I have the fixed package, can you help with testing it?
>
> sure, thanks.
 Please check the proposed update[1].

Thanks in advance,
Laszlo/GCS
[1] dget -x http://www.barcikacomp.hu/gcs/squashfs-tools_4.3-5.dsc

Message #37 received at 804194@bugs.debian.org (full text, mbox, reply):

From: Wessel Dankers <wsl-debian-804194@fruit.je>

To: László Böszörményi <gcs@debian.org>

Cc: Daniel Baumann <daniel.baumann@progress-linux.org>, 804194@bugs.debian.org

Subject: Re: Bug#804194: squashfs-tools: unsquashfs not preserving file capabilities

Date: Fri, 2 Mar 2018 15:04:54 +0100

[Message part 1 (text/plain, inline)]

Hi László,

On 2017‒07‒23 14:10:45+0200, László Böszörményi (GCS) wrote:
> On Tue, Jul 18, 2017 at 6:01 PM, Daniel Baumann <daniel.baumann@progress-linux.org> wrote:
>> On 07/18/17 11:25, László Böszörményi (GCS) wrote:
>>>  If I have the fixed package, can you help with testing it?
>>
>> sure, thanks.
>
> Please check the proposed update[1].
> [1] dget -x http://www.barcikacomp.hu/gcs/squashfs-tools_4.3-5.dsc

Sorry for the delay. Just finished testing it, it looks like this proposed
update does indeed fix #804194. Many thanks!

cheers,

-- 
Wessel Dankers

Sent from my general purpose computing device.

[signature.asc (application/pgp-signature, inline)]

Message #42 received at 804194-close@bugs.debian.org (full text, mbox, reply):

From: Laszlo Boszormenyi (GCS) <gcs@debian.org>

To: 804194-close@bugs.debian.org

Subject: Bug#804194: fixed in squashfs-tools 1:4.3-5

Date: Sun, 04 Mar 2018 20:53:49 +0000

Source: squashfs-tools
Source-Version: 1:4.3-5

We believe that the bug you reported is fixed in the latest version of
squashfs-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 804194@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Laszlo Boszormenyi (GCS) <gcs@debian.org> (supplier of updated squashfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 04 Mar 2018 19:36:55 +0000
Source: squashfs-tools
Binary: squashfs-tools
Architecture: source amd64
Version: 1:4.3-5
Distribution: unstable
Urgency: medium
Maintainer: Laszlo Boszormenyi (GCS) <gcs@debian.org>
Changed-By: Laszlo Boszormenyi (GCS) <gcs@debian.org>
Description:
 squashfs-tools - Tool to create and append to squashfs filesystems
Closes: 804194
Changes:
 squashfs-tools (1:4.3-5) unstable; urgency=medium
 .
   * Patch unsquashfs to preserve file capabilities (closes: #804194).
   * Update debhelper level to 11:
     - don't specify parallel to debhelper.
   * Update Standards-Version to 4.1.3:
     - remove squashfs-tools-dbg package and use the auto-generated one.
   * Sync with Ubuntu.
 .
   [ Tyler Hicks <tyhicks@canonical.com> ]
   * debian/patches/0005-add-fstime.patch: Fix -Wint-conversion warning by
     initializing the time_t variable with (time_t)-1 instead of NULL
   * debian/patches/0009-unsquashfs-preserve-symlink-times.patch: Preserve
     atime and mtime of symlink inodes in unsquashfs rather than using the
     current time (LP: #1555305)
Checksums-Sha1:
 85af11ec04d146e3ac0707fa8aadfc8dd021cff9 1935 squashfs-tools_4.3-5.dsc
 3e7aeccf9371e69671affeba7a1224848a227ff0 18976 squashfs-tools_4.3-5.debian.tar.xz
 1e4cb2d321889d373621add11802597116ec45f3 293840 squashfs-tools-dbgsym_4.3-5_amd64.deb
 ff346b94b442989fbf9bb12150035768b0bb5b36 6794 squashfs-tools_4.3-5_amd64.buildinfo
 c85298efb2a0cb96e8c2a435fb4978dc28f439b6 123080 squashfs-tools_4.3-5_amd64.deb
Checksums-Sha256:
 24523057e8c8d99f95a77d97b576c08c3d5628fa2200cba121a2fc7bf6063e3b 1935 squashfs-tools_4.3-5.dsc
 70309cd50eec3d22c3576c7b9fa24440e188ab9231fdc8e939e1ae674176f1e7 18976 squashfs-tools_4.3-5.debian.tar.xz
 0de9eb2805cb37ccacd446f9db4b4dfa96d801b9534f5dc2e3d603f106f8aac7 293840 squashfs-tools-dbgsym_4.3-5_amd64.deb
 0390ecab96cebf427bcfd47a66e8d72f51380589e49c775c31cd05c852a70667 6794 squashfs-tools_4.3-5_amd64.buildinfo
 692bdd9c867e4ca715aa71b006a135eb8f0ca4e1299572fe2c0f657d10806dc9 123080 squashfs-tools_4.3-5_amd64.deb
Files:
 1893b49e2a849a92e1e5fb0cb5dd5ba1 1935 kernel optional squashfs-tools_4.3-5.dsc
 5d555b636f9cb348edb8020e82909e3a 18976 kernel optional squashfs-tools_4.3-5.debian.tar.xz
 f6f37ecfed439de4405800657872096f 293840 debug optional squashfs-tools-dbgsym_4.3-5_amd64.deb
 06c1333d4bae3e5b804b3656061cfb57 6794 kernel optional squashfs-tools_4.3-5_amd64.buildinfo
 6c7fb3752881d2a729989452388bf13d 123080 kernel optional squashfs-tools_4.3-5_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEfYh9yLp7u6e4NeO63OMQ54ZMyL8FAlqcVzwACgkQ3OMQ54ZM
yL+QQQ//dkcfDLTpjpJuGaVnJST9q0L2UdNLqQ8LJZ7vbAqW/CmBQ3/Mn3EWyvAK
vxSSqXmzGITL8f+1/rvrBZJjU84eTDGIrGfupcZdTXhjiMUdMVgH/8Eg28vfY82/
MclambOqLdrwhqxLr/vMSCELEYkgbNyQ5bDv3W6N7Xb0PNAaALmG5IXNdmK6vpqb
bXR9d102DuAefAdD8ADQuuEZyp5tU3cAaUPjuCSbzD+RhRwZ/kaBbTRxZekRLqhy
wYmOUW4yq/hAXJAjk6YYjT7I7wdNMqlYdfL650vJ7HTU66V77/NX+fmS1dCPVUfV
qNhz1FU6s574WrCMTWJdl9l7SJylY1iLd3WYCmEWUuJloUE9PaKURFGiB+M4EhJp
JhHRZPTlUtNy4I48l57+dDVH2WwAIREKMeZeA2tYhSX72rlRnrvvP/MO9YbVL7ZH
wTrXbJiBRnASdw3k2mEf+ybTfN7QF/vb9OXrKAzxgHs11XeGItjIgEZq8TmzsNmt
nSf1daDJxEwKVvJvNa8maHAYzxN1KrLpLY0C36UMJRxGlWzMppvChO1bKc2i8b3I
qqYUNJwyExkK29MK7Y5geqfOAcS7ij7uVwHypx1NPHAPsG032femHyhH93fqS/ib
lLYpArRmvxOLJlp448IBCyko7ZHNOqelSC8N8Aqzhla8U8mpcNs=
=Jijn
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.