Debian Bug report logs - #804162
open-iscsi: support iscsi root by format in RFC 4173 (root=iscsi:server:prot:...)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Scott Moser <smoser@ubuntu.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: open-iscsi: support iscsi root by format in RFC 4173 (root=iscsi:server:prot:...)

Date: Thu, 05 Nov 2015 10:30:05 -0500

Package: open-iscsi
Version: 2.0.873-3ubuntu13
Severity: normal

Hi,

RFC 4173 (http://tools.ietf.org/html/rfc4173) documents a fairly compact
mechanism for an iscsi target definition.  Copied from
http://ipxe.org/sanuri:
 | fmt of an iSCSI SAN URI is defined by RFC 4173. The general syntax is:
 |    iscsi:<servername>:<protocol>:<port>:<LUN>:<targetname>

Examples:
  iscsi:10.0.4.1:::1:iqn.2010-04.org.ipxe.dolphin:storage
  iscsi:boot.ipxe.org::::iqn.2010-04.org.ipxe.boot:public
  iscsi:192.168.0.1::::iqn.1991-05.com.microsoft:msdos622-target
  iscsi:opensolaris.home::::iqn.1986-03.com.sun:02:e9abf4cd-714b-c6ec-d017-eea5a56252ed

For the first example there, the way that would be done in current
parameters would be:
  iscsi_target_name=iqn.2010-04.org.ipxe.dolphin:storage
  iscsi_target_ip=10.0.4.1 iscsi_target_group=1

It'd be nice if we could just:
  root=iscsi:10.0.4.1:::1:iqn.2010-04.org.ipxe.dolphin:storage

Note that RFC does not cover username and password, so that would have to
be done outside the spec if needed.


-- System Information:
Debian Release: jessie/sid
  APT prefers wily-updates
  APT policy: (500, 'wily-updates'), (500, 'wily-security'), (500, 'wily')
Architecture: amd64 (x86_64)

Kernel: Linux 4.2.0-16-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages open-iscsi depends on:
ii  libc6  2.21-0ubuntu4
ii  udev   225-1ubuntu9

open-iscsi recommends no packages.

open-iscsi suggests no packages.

-- no debconf information

Message #10 received at 804162@bugs.debian.org (full text, mbox, reply):

From: Christian Seiler <christian@iwakd.de>

To: Scott Moser <smoser@ubuntu.com>, 804162@bugs.debian.org

Subject: Re: Bug#804162: open-iscsi: support iscsi root by format in RFC 4173 (root=iscsi:server:prot:...)

Date: Thu, 05 Nov 2015 20:05:21 +0100

[Message part 1 (text/plain, inline)]

Control: tags -1 + confirmed
Control: severity -1 wishlist

On 11/05/2015 04:30 PM, Scott Moser wrote:
> RFC 4173 (http://tools.ietf.org/html/rfc4173) documents a fairly compact
> mechanism for an iscsi target definition.  Copied from
> http://ipxe.org/sanuri:
>  | fmt of an iSCSI SAN URI is defined by RFC 4173. The general syntax is:
>  |    iscsi:<servername>:<protocol>:<port>:<LUN>:<targetname>
> 
> Examples:
>   iscsi:10.0.4.1:::1:iqn.2010-04.org.ipxe.dolphin:storage
>   iscsi:boot.ipxe.org::::iqn.2010-04.org.ipxe.boot:public
>   iscsi:192.168.0.1::::iqn.1991-05.com.microsoft:msdos622-target
>   iscsi:opensolaris.home::::iqn.1986-03.com.sun:02:e9abf4cd-714b-c6ec-d017-eea5a56252ed
> 
> For the first example there, the way that would be done in current
> parameters would be:
>   iscsi_target_name=iqn.2010-04.org.ipxe.dolphin:storage
>   iscsi_target_ip=10.0.4.1 iscsi_target_group=1
> 
> It'd be nice if we could just:
>   root=iscsi:10.0.4.1:::1:iqn.2010-04.org.ipxe.dolphin:storage
> 
> Note that RFC does not cover username and password, so that would have to
> be done outside the spec if needed.

Yes, this seems like a good idea for something to support. I see a
minor implementation detail that might need some thinking to fix:
currently, open-iscsi only adds itself to the initramfs if
/etc/iscsi/initramfs.iscsi exists - and the information in there
would be replaced by the root= parameter. On the other hand,
unconditionally adding the iSCSI binaries to the initramfs might
also not be wanted behavior, because it makes the initramfs larger.
(iSCSI can also be used for non-root filesystems.)

I'll take a look at how to best do this in the next couple of days.
Any good suggestions in advance are of course always welcome. ;-)

Regards,
Christian

[signature.asc (application/pgp-signature, attachment)]

Message #23 received at 804162@bugs.debian.org (full text, mbox, reply):

From: Scott Moser <smoser@ubuntu.com>

To: Christian Seiler <christian@iwakd.de>

Cc: 804162@bugs.debian.org

Subject: Re: Bug#804162: open-iscsi: support iscsi root by format in RFC 4173 (root=iscsi:server:prot:...)

Date: Mon, 9 Nov 2015 15:07:23 -0500 (EST)

On Thu, 5 Nov 2015, Christian Seiler wrote:

> Yes, this seems like a good idea for something to support. I see a
> minor implementation detail that might need some thinking to fix:
> currently, open-iscsi only adds itself to the initramfs if
> /etc/iscsi/initramfs.iscsi exists - and the information in there
> would be replaced by the root= parameter. On the other hand,
> unconditionally adding the iSCSI binaries to the initramfs might
> also not be wanted behavior, because it makes the initramfs larger.
> (iSCSI can also be used for non-root filesystems.)

Other than size, iscsi is to my memory almost perfectly inert in the
initramfs if it doesnt find any cmdline that says for it to do something.
(iscsi_target_name= or iscsi_auto)

So my feeling is if the user installs open-iscsi, then they want it in the
initramfs.  Do that unless they turn it off.

Message #28 received at 804162@bugs.debian.org (full text, mbox, reply):

From: Christian Seiler <christian@iwakd.de>

To: 804162@bugs.debian.org

Subject: Re: Bug#804162: open-iscsi: support iscsi root by format in RFC 4173 (root=iscsi:server:prot:...)

Date: Sun, 31 Jan 2016 19:10:53 +0100

[Message part 1 (text/plain, inline)]

Control: tags -1 + confirmed pending

I've now implemented this in open-iscsi git. Since root=iscsi:... only
gives you a full hard disk, and you might want to partition it and/or
use LVM or whatnot, I've also implemented support for

root=iscsi:... root=UUID=...

so that the first parameter configures iSCSI and the second parameter
is then used by initramfs-tools to mount the partition (regularily).

On 11/05/2015 04:30 PM, Scott Moser wrote:
> Examples:
>   iscsi:10.0.4.1:::1:iqn.2010-04.org.ipxe.dolphin:storage
>   [...]
> For the first example there, the way that would be done in current
> parameters would be:
>   iscsi_target_name=iqn.2010-04.org.ipxe.dolphin:storage
>   iscsi_target_ip=10.0.4.1 iscsi_target_group=1

Note that the '1' before the target name is the LUN (identifying the
drive within the session) and not the target group (which isn't
specified at all in the RFC). But at least with a LIO target it
appears that if there's just 1 target group iscsistart doesn't really
care what you specify, it will pick out the right one.

Also, you can still specify the target group (default is 1 anyway,
btw.) directly via iscsi_target_group=42 in addition to root=

> Note that RFC does not cover username and password, so that would have to
> be done outside the spec if needed.

I've looked at what dracut does and implemented the same syntax:

TARGETSPEC=ip:proto:port:lun:targetname

root=iscsi:$TARGETSPEC
root=iscsi:user:password@$TARGETSPEC
root=iscsi:user:password:initiatoruser:initiatorpassword@$TARGETSPEC

(You can still set iscsi_* parameters for user etc.)

Additionally, open-iscsi is now added unconditionally to the
initramfs, unless you create /etc/initramfs-tools/conf.d/open-iscsi
and set NO_ISCSI_IN_INITRAMFS=yes there. (It's documented in
README.Debian.)

This is now in git and will be part of the next upload.

Regards,
Christian

[signature.asc (application/pgp-signature, attachment)]

Message #35 received at 804162-close@bugs.debian.org (full text, mbox, reply):

From: Christian Seiler <christian@iwakd.de>

To: 804162-close@bugs.debian.org

Subject: Bug#804162: fixed in open-iscsi 2.0.873+git0.3b4b4500-13

Date: Thu, 11 Feb 2016 12:21:42 +0000

Source: open-iscsi
Source-Version: 2.0.873+git0.3b4b4500-13

We believe that the bug you reported is fixed in the latest version of
open-iscsi, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 804162@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Seiler <christian@iwakd.de> (supplier of updated open-iscsi package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 11 Feb 2016 16:35:07 +0530
Source: open-iscsi
Binary: open-iscsi open-iscsi-udeb
Architecture: source amd64
Version: 2.0.873+git0.3b4b4500-13
Distribution: unstable
Urgency: medium
Maintainer: Debian iSCSI Maintainers <pkg-iscsi-maintainers@lists.alioth.debian.org>
Changed-By: Christian Seiler <christian@iwakd.de>
Description:
 open-iscsi - iSCSI initiator tools
 open-iscsi-udeb - Configure iSCSI (udeb)
Closes: 804162 804591 809320 810276 810696 810702
Changes:
 open-iscsi (2.0.873+git0.3b4b4500-13) unstable; urgency=medium
 .
   [ Christian Seiler ]
   * [d95ccde] initramfs: fix initramfs creation bug
     (too many symbolic links)
   * [f6246a8] Use triggers instead of update-initramfs
   * [16283ac] Unconditionally add iSCSI to initramfs images
   * [5cf584f] Support RFC 4173 root=iscsi:... format (Closes: #804162)
   * [b12b4b9] Make sure initiatorname.iscsi isn't an obsolete conffile.
   * [06ce1d3] Don't consider iscsiadm exit code 15 to be an error
     (Partial-Fix-For: #809320)
   * [481cedd] Support network autoconfiguration if iscsi_auto is used
     (Closes: #804591)
   * [3b3fa00] Record network device that was configured for iSCSI
   * [508fcba] Handle the default route for iscsi_auto
   * [64b0f31] Fix handling of multiple kept sessions on shutdown
     (Closes: #809320)
   * [df7259e] Fix FTBR on armhf (reproducible builds)
 .
   [ Marco d'Itri ]
   * [d32c7c6] Create in postinst the /sbin/iscsi* compatibility symlinks.
     (Closes: #810276)
 .
   [ Martin Pitt ]
   * [db49787] Migrate from /var/run /run and from /var/lock to /run/lock.
     (Closes: #810696)
   * [1bca41d] Generate initiator name on install, not first boot.
     (Closes: #810702) (LP: #1057635)
Checksums-Sha1:
 b927fa6bb78620b312b4dc0a7c0bdbdc2db442d8 2326 open-iscsi_2.0.873+git0.3b4b4500-13.dsc
 7966c2d934314f998f4187ea936da8838c651451 46028 open-iscsi_2.0.873+git0.3b4b4500-13.debian.tar.xz
 c6887d751aa1a2822098e5e1c2b8e9a37490a636 1808052 open-iscsi-dbgsym_2.0.873+git0.3b4b4500-13_amd64.deb
 f561cffbbad5f1f80aa9706189e50d1288a22d3a 319398 open-iscsi-udeb_2.0.873+git0.3b4b4500-13_amd64.udeb
 ba057fbb95aed380e65a40c465a46ccd1ee771ff 338008 open-iscsi_2.0.873+git0.3b4b4500-13_amd64.deb
Checksums-Sha256:
 5af1af9861bd4b66edd1ebae7981f055c0296b509d4792d8120eb4cf83057610 2326 open-iscsi_2.0.873+git0.3b4b4500-13.dsc
 0036d85968fc0da56098097b7b12dc840ec842c249a1f98b622b06cdf2782ed0 46028 open-iscsi_2.0.873+git0.3b4b4500-13.debian.tar.xz
 e358f847bc4b326644137e76dc82a6a26d6d5316fa2d903319ccc6d072276070 1808052 open-iscsi-dbgsym_2.0.873+git0.3b4b4500-13_amd64.deb
 27c5c464e0e298ecb769d6df050e375d28ad6c2bb93a8b99b2a4cf592e6b98a2 319398 open-iscsi-udeb_2.0.873+git0.3b4b4500-13_amd64.udeb
 9c49016e8ed123cf19f0133c72e201890b72332944b944d7722975d1ed61b03e 338008 open-iscsi_2.0.873+git0.3b4b4500-13_amd64.deb
Files:
 d5184db0d104c72879f10a26d610a688 2326 net optional open-iscsi_2.0.873+git0.3b4b4500-13.dsc
 a69ca2199452cfa503e8760670faf173 46028 net optional open-iscsi_2.0.873+git0.3b4b4500-13.debian.tar.xz
 11667b840e65d3fe0e334d8f17b20061 1808052 debug extra open-iscsi-dbgsym_2.0.873+git0.3b4b4500-13_amd64.deb
 5e7fea5a05ef6a65b20708b7477a73ea 319398 debian-installer optional open-iscsi-udeb_2.0.873+git0.3b4b4500-13_amd64.udeb
 b3bb4f2d134d35be32f9529c9a04cedd 338008 net optional open-iscsi_2.0.873+git0.3b4b4500-13_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJWvHoFAAoJEKY6WKPy4XVpzUcP/jucnI77CgDs75PNn2G4zotn
cL4Xl4BLM9GEAhtx6GU/K0gHBfp1ISFa++st1AjrF5aTnp7GyACU5TrdNeZe7C4B
DXH5FmpWkeng2ArXg752FR0RFsfWUATW4k9YIrD5XcOTeUnPnelCX5Htvw9qc9Ex
8brRGNp9GEOnV9DVJpWUOk5E51gfig9+uNPGfl8oxnehl1epOylJ+66vN3LBfSx6
LakAS1ruQsa4MtYKxVqt+Y+zW/b+CYcvRvv5R0G3mPW3KsZqTWTm4ucoifBiYg1A
ky9yeG02EahN1uRcUsiN5/Rn4NOIxDCujJKTf8j253pJ2Wlhu3idc22xXnfZm3xJ
lUSpKdUlETQsGYhGCHLJvtJ7KFNQdn+kf4XwznskpyMWs0AAFUJKHsAShINuwU7+
4m17pjy5z++fmu7etDcOIb5EGUzNwJiZlMjuiD9bbd4/pGcckXb2OR1zBAFd+Et5
eVhmdZcE00Fxi/67gNgM+IKo+iL41cNNUl56tWERZKYeb3zHSOA3KI9++ik4S6Bi
EZYBxceVSRU0BmTYzXe+dm1d5DIgFO41K+FFh7z6xxLFuhKLsSshxLrm0E5cZT0E
YzM7fABVrP/ItijNmY8pwuaTvfT5589AaShBmW0BWm+/l1eI2Cqr2HWHs5YYeFw2
Bjp0ewTrBMwfwKltJJ0r
=yPIS
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.