Debian Bug report logs - #799716
[procps] free considers 'cached' to include SUnreclaim

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: OmegaPhil <OmegaPhil@startmail.com>

To: submit@bugs.debian.org

Cc: parpandet@gmail.com

Subject: [procps] free considers 'cached' to include SUnreclaim

Date: Mon, 21 Sep 2015 20:04:54 +0100

[Message part 1 (text/plain, inline)]

Package: procps
Version: 2:3.3.10-2
Severity: normal

This appears to be a followon from '#565518: procps: free does not take
slab into account in used - buffers/cache' (I've CC'd you in Nico since
you'll probably be interested).

In proc/sysinfo.c:meminfo, kb_main_cached is calculated as the following:

kb_main_cached = kb_page_cache + kb_slab;

This is wrong as kb_slab includes SUnreclaim - presumably this should be
kb_slab_reclaimable?

Part of the conky investigation in
https://github.com/brndnmtthws/conky/issues/130

Thanks


--- System information. ---
Architecture: amd64
Kernel:       Linux 4.1.0-2-amd64

Debian Release: stretch/sid
  990 testing         www.deb-multimedia.org
  990 testing         10.1.0.3
  500 unstable        10.1.0.3
  500 quodlibet-unstable 10.1.0.3
    1 experimental    10.1.0.3

--- Package information. ---
Depends                  (Version) | Installed
==================================-+-==================
libc6                    (>= 2.15) |
libncurses5            (>= 5.5-5~) |
libncursesw5     (>= 5.6+20070908) |
libprocps3                         |
libtinfo5                          |
lsb-base               (>= 3.0-10) |
initscripts                        |


Recommends      (Version) | Installed
=========================-+-===========
psmisc                    | 22.21-2.1


Package's Suggests field is empty.

[signature.asc (application/pgp-signature, attachment)]

Message #10 received at 799716@bugs.debian.org (full text, mbox, reply):

From: Craig Small <csmall@debian.org>

To: OmegaPhil <OmegaPhil@startmail.com>, 799716@bugs.debian.org

Cc: parpandet@gmail.com

Subject: Re: Bug#799716: [procps] free considers 'cached' to include SUnreclaim

Date: Tue, 22 Sep 2015 22:15:09 +1000

On Mon, Sep 21, 2015 at 08:04:54PM +0100, OmegaPhil wrote:
> kb_main_cached = kb_page_cache + kb_slab;
> 
> This is wrong as kb_slab includes SUnreclaim - presumably this should be
> kb_slab_reclaimable?
Thanks for looking into this, my initial thought is that what you have
described here and on the conky issue looks right. I have forwarded the
report to the procps list as I wasn't the one that introduced this
change and so there might be a reason for it.

The change was done in 3.3.10 to fix a problem, I suspect it fixed that
and introduced another. Linux memory reporting is fiddly to say the
least.

 - Craig
-- 
Craig Small (@smallsees)   http://enc.com.au/       csmall at : enc.com.au
Debian GNU/Linux           http://www.debian.org/   csmall at : debian.org
GPG fingerprint:        5D2F B320 B825 D939 04D2  0519 3938 F96B DF50 FEA5

Message #15 received at 799716@bugs.debian.org (full text, mbox, reply):

From: OmegaPhil <OmegaPhil@startmail.com>

To: Craig Small <csmall@debian.org>, 799716@bugs.debian.org, parpandet@gmail.com

Subject: Re: Bug#799716: [procps] free considers 'cached' to include SUnreclaim

Date: Tue, 22 Sep 2015 17:11:26 +0100

[Message part 1 (text/plain, inline)]

On 22/09/15 13:15, Craig Small wrote:
> On Mon, Sep 21, 2015 at 08:04:54PM +0100, OmegaPhil wrote:
>> kb_main_cached = kb_page_cache + kb_slab;
>>
>> This is wrong as kb_slab includes SUnreclaim - presumably this should be
>> kb_slab_reclaimable?
> Thanks for looking into this, my initial thought is that what you have
> described here and on the conky issue looks right. I have forwarded the
> report to the procps list as I wasn't the one that introduced this
> change and so there might be a reason for it.
> 
> The change was done in 3.3.10 to fix a problem, I suspect it fixed that
> and introduced another. Linux memory reporting is fiddly to say the
> least.
> 
>  - Craig


Thanks, I've subscribed to that list. Sorry I thought you were also the
upstream maintainer since I noticed procps-ng
(https://gitlab.com/procps-ng/procps/).

[signature.asc (application/pgp-signature, attachment)]

Message #20 received at 799716@bugs.debian.org (full text, mbox, reply):

From: Craig Small <csmall@debian.org>

To: OmegaPhil <OmegaPhil@startmail.com>, 799716@bugs.debian.org

Cc: parpandet@gmail.com

Subject: Re: Bug#799716: [procps] free considers 'cached' to include SUnreclaim

Date: Wed, 23 Sep 2015 21:02:57 +1000

On Tue, Sep 22, 2015 at 05:11:26PM +0100, OmegaPhil wrote:
> Thanks, I've subscribed to that list. Sorry I thought you were also the
> upstream maintainer since I noticed procps-ng
> (https://gitlab.com/procps-ng/procps/).
I am, but I didn't introduce that change. Jaromir did and I have asked
him to look into it as he was looking at the memory stats previously.

 - Craig

-- 
Craig Small (@smallsees)   http://enc.com.au/       csmall at : enc.com.au
Debian GNU/Linux           http://www.debian.org/   csmall at : debian.org
GPG fingerprint:        5D2F B320 B825 D939 04D2  0519 3938 F96B DF50 FEA5

Message #25 received at 799716-close@bugs.debian.org (full text, mbox, reply):

From: Craig Small <csmall@debian.org>

To: 799716-close@bugs.debian.org

Subject: Bug#799716: fixed in procps 2:3.3.11-3

Date: Sun, 03 Jan 2016 06:34:13 +0000

Source: procps
Source-Version: 2:3.3.11-3

We believe that the bug you reported is fixed in the latest version of
procps, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 799716@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Craig Small <csmall@debian.org> (supplier of updated procps package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 03 Jan 2016 17:10:26 +1100
Source: procps
Binary: procps libprocps5 libprocps-dev
Architecture: source amd64
Version: 2:3.3.11-3
Distribution: unstable
Urgency: medium
Maintainer: Craig Small <csmall@debian.org>
Changed-By: Craig Small <csmall@debian.org>
Description:
 libprocps-dev - library for accessing process information from /proc
 libprocps5 - library for accessing process information from /proc
 procps     - /proc file system utilities
Closes: 183394 606284 694487 694691 694692 733758 736628 751297 762928 762947 763795 764590 768190 775624 786643 789322 790124 791896 794619 798438 799716 806704 808596
Changes:
 procps (2:3.3.11-3) unstable; urgency=medium
 .
   * New upstream source (from experimental)
     - pgrep: don't crash with -a -w flags Closes: #768190
     - pmap: print even with no smaps Closes: #775624
     - ps: sort by etimes Closes: #794619
     - w: work with smaller windows Closes: #183394
     - Use merged systemd library Closes: #791896
     - top: read rcfile Closes: #762928, #762947
     - vmstat: not crash if partition before disk
       Closes: #736628, #763795, #764590, #751297
     - free: -s without -c works Closes: #733758
     - pmap: fix integer overflow Closes: #789322
     - slabtop.1: Add space to NAME Closes: #786643
     - library: rename swap to slab for (un)reclaimable Closes: #694487
   * Add hardening flags Closes: #790124
   * Disable ps sched test Closes: #798438
   * Added mips64 and mips64el to numa-enabled arches Closes: #806704
   * Use slab reclaimable in main cached Closes: #799716
   * Fix typo in control Closes: #808596
   * Enable verbose build output for buildds
   * Remove wchan lookup in System.map Closes: #606284
   * Add commented out sysrq to sysctl.conf Closes: #694691
   * Add protectedhard/soft link to sysctl example Closes: #694692
Checksums-Sha1:
 46306d893bfb408735eb53e172663a1f05d24203 2136 procps_3.3.11-3.dsc
 8b1a37dc3425542982d11a3ee8a1fd7c7024337c 809940 procps_3.3.11.orig.tar.xz
 d0e603306bb976097690fe4a7bd643b1385535f5 26548 procps_3.3.11-3.debian.tar.xz
 382d86e1b7e14f04e64ac7ae6ef9bcb35693a809 68494 libprocps-dev_3.3.11-3_amd64.deb
 2fcfa7cc7bdfc777ba7e9a8c03bd20af7a82e8e3 70576 libprocps5-dbgsym_3.3.11-3_amd64.deb
 c9e5f3a5c5a38768fc8d2a0ec3672a7ba86efeb4 56500 libprocps5_3.3.11-3_amd64.deb
 ee9a60fa80383d993ea5470db0c44f2b0eb1ffb2 330094 procps-dbgsym_3.3.11-3_amd64.deb
 65175da9d7c8895a20fd55cdc381053eddaa219c 246774 procps_3.3.11-3_amd64.deb
Checksums-Sha256:
 716b9774e426fc0fd788ec68b0bbb43df0930ac1dd8510d6ab072f92fdbd6fed 2136 procps_3.3.11-3.dsc
 3e2c6eda9b79953339818d28a53ecd4e97436299bd4793e8cab7119bd9097dc8 809940 procps_3.3.11.orig.tar.xz
 50f0683eddc1581def5287d9ab3d5f4dc741744eb738e4222d4ca56dc61970b7 26548 procps_3.3.11-3.debian.tar.xz
 c2feac45eeb354389d1223341f53b25c7bb6b02f51dfc8375ed41c1d2a545829 68494 libprocps-dev_3.3.11-3_amd64.deb
 3dbe9f530ade2a95e4910c7e2ca1f243d5a77410fc874e6f1d5a9b63d26e2e53 70576 libprocps5-dbgsym_3.3.11-3_amd64.deb
 8b4bd7ce9eb90ce13e7935856faa5d74810937f9f808accae1b7f2f1a1e2d379 56500 libprocps5_3.3.11-3_amd64.deb
 22a39936b86243252ae7cf067fa2a7ee34edc9693dbb49e75aabea1c2026c6d6 330094 procps-dbgsym_3.3.11-3_amd64.deb
 21826396155ff0afbe49fb9f15caa2dc09de9feab5864b7000e7ef3448ae0e8d 246774 procps_3.3.11-3_amd64.deb
Files:
 e14d46254fb2de364d9a4f44d1786840 2136 admin important procps_3.3.11-3.dsc
 388d149265041dc9d38ad962c23c9ad8 809940 admin important procps_3.3.11.orig.tar.xz
 4cc2febfc97dfabbfa4dd284c31fe44b 26548 admin important procps_3.3.11-3.debian.tar.xz
 7cdaa77a67d53f9e15e35b90411d0a9e 68494 libdevel optional libprocps-dev_3.3.11-3_amd64.deb
 fda65b6a41794e364d004968f2c02518 70576 debug extra libprocps5-dbgsym_3.3.11-3_amd64.deb
 f6a8b38346ad3de2c13e13b238ab1345 56500 libs important libprocps5_3.3.11-3_amd64.deb
 b7d941f7e80c39622663f1499207906c 330094 debug extra procps-dbgsym_3.3.11-3_amd64.deb
 3a43cf8403d4faa147bd927c6ca28b12 246774 admin important procps_3.3.11-3_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJWiLxAAAoJEAIhZsD/PITjItkQAIHHsTcdF3Wq2qRemLq7v+a0
ZgZDKoBKRdd688yQz/LRhfO7pH82pVRUHLQJMmkfEqE4COJt0MmbjXfO6/RUOiAE
O4trAQ05aEJWt747NBKuxFmPvs/ycPUWUeqlVdtrmDQ0errqXiFYAHqXcROurgsq
IAftJvRJ49L+EdTWpxTwaB1WBsmBpfW49859vk/eFth9423Aqu+0d3YjyXCs+RiC
i21MKeEucPckqvZyrizXrZwNYB7tgzafudEjXsN9xB/G3nK9Y2ubrHMD2nNl16Ku
n+p9C7AEl9DAQ+3URKG/0bVWfyWYWRPLX3wWVGMzmwQNLodhzTKP0vEMuOpNOxNt
hCwzs4vWO5/rHeTNBlSapoARzY7Yqji49X130V+ozrbCNqb91B+7udUpE67GAiCg
WV186oLyBwypwN60gE8/UsEGdTM7Nyn7k5Vag/sw48l7+IPUFTwMoEDqHDAb6NVX
za+rCh6eYkBxSjWJoH9C5+NHxg/lO5aNbfRgdDLdaN2TRBMqPT5YNSroCfP+tr9I
zKLloF1V/dXQK/Ka4GECZ4xq5XKLY044zUoNlvqt8ZYtK5PcBVZDbXU96nU8gH/f
pE25fcjh8Wd6L7zBdjhnULq5wbBI5VmGKSW7jegBuLNj85a6gR5t8uuIqL2K3RBm
KRoU4bfMeVldmw2chXXW
=W9j7
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.