Debian Bug report logs - #797057
wget https://contributors.debian.org fails with "No data received."

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Enrico Zini <enrico@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: wget https://contributors.debian.org fails with "No data received."

Date: Thu, 27 Aug 2015 15:37:18 +0200

Package: wget
Version: 1.16.3-3
Severity: normal

Hello,

thank you for maintaining wget. A simple
wget https://contributors.debian.org currently fails:

  $ wget https://contributors.debian.org
  --2015-08-27 15:34:30--  https://contributors.debian.org/
  Resolving contributors.debian.org (contributors.debian.org)... 2607:f8f0:610:4000:216:36ff:fe40:3861, 206.12.19.123
  Connecting to contributors.debian.org (contributors.debian.org)|2607:f8f0:610:4000:216:36ff:fe40:3861|:443... connected.
  HTTP request sent, awaiting response... No data received.
  Retrying.
  
  --2015-08-27 15:34:31--  (try: 2)  https://contributors.debian.org/
  Connecting to contributors.debian.org (contributors.debian.org)|2607:f8f0:610:4000:216:36ff:fe40:3861|:443... connected.
  HTTP request sent, awaiting response... No data received.
  Retrying.
  
  --2015-08-27 15:34:34--  (try: 3)  https://contributors.debian.org/
  Connecting to contributors.debian.org (contributors.debian.org)|2607:f8f0:610:4000:216:36ff:fe40:3861|:443... connected.
  HTTP request sent, awaiting response... No data received.
  Retrying.

We currently added "SSLVerifyClient optional" to the server
configuration to support authentication with client certificates, but
client certificates are not required to connect. The relevant apache
configuration is here:

  https://wiki.debian.org/DebianSingleSignOn#Documentation_for_web_application_owners-1

curl can access the site.


Enrico


-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.1.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages wget depends on:
ii  libc6              2.19-19
ii  libgnutls-deb0-28  3.3.17-1
ii  libidn11           1.32-1
ii  libnettle6         3.1.1-4
ii  libpcre3           2:8.35-7
ii  libpsl0            0.7.1-1
ii  libuuid1           2.26.2-9
ii  zlib1g             1:1.2.8.dfsg-2+b1

Versions of packages wget recommends:
ii  ca-certificates  20150426

wget suggests no packages.

-- no debconf information

Message #10 received at 797057@bugs.debian.org (full text, mbox, reply):

From: NoëlKöthe <INVALID.NOREPLY@gnu.org>

To: NoëlKöthe <noel@debian.org>, 797057@bugs.debian.org, gscrivano@gnu.org, darnir@gmail.com, tim.ruehsen@gmx.de, bug-wget@gnu.org

Subject: [bug #46061] wget https://contributors.debian.org fails with "No data received."

Date: Sun, 27 Sep 2015 16:13:55 +0000

URL:
  <http://savannah.gnu.org/bugs/?46061>

                 Summary: wget https://contributors.debian.org fails with "No
data received."
                 Project: GNU Wget
            Submitted by: nok
            Submitted on: So 27 Sep 2015 18:13:54 CEST
                Category: Protocol Issue
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 1.16.3
        Operating System: GNU/Linux
         Reproducibility: Every Time
           Fixed Release: None
         Planned Release: None
              Regression: None
           Work Required: None
          Patch Included: No

    _______________________________________________________

Details:

Hello,

a forwarded bug from https://bugs.debian.org/797057

"We currently added "SSLVerifyClient optional" to the server configuration to
support authentication with client certificates, but client certificates are
not required to connect. The relevant apache configuration is here:

 
https://wiki.debian.org/DebianSingleSignOn#Documentation_for_web_application_owners-1

curl can access the site."

$ LC_ALL=C wget -d https://contributors.debian.org
DEBUG output created by Wget 1.16.3 on linux-gnu.

URI encoding = 'ANSI_X3.4-1968'
converted 'https://contributors.debian.org' (ANSI_X3.4-1968) ->
'https://contributors.debian.org' (UTF-8)
--2015-09-27 18:08:27--  https://contributors.debian.org/
Certificates loaded: 180
Resolving contributors.debian.org (contributors.debian.org)...
2607:f8f0:610:4000:216:36ff:fe40:3861, 206.12.19.123
Caching contributors.debian.org => 2607:f8f0:610:4000:216:36ff:fe40:3861
206.12.19.123
Connecting to contributors.debian.org
(contributors.debian.org)|2607:f8f0:610:4000:216:36ff:fe40:3861|:443...
connected.
Created socket 4.
Releasing 0x000055f91c3876f0 (new refcount 1).

---request begin---
GET / HTTP/1.1
User-Agent: Wget/1.16.3 (linux-gnu)
Accept: */*
Accept-Encoding: identity
Host: contributors.debian.org
Connection: Keep-Alive

---request end---
HTTP request sent, awaiting response... No data received.
Retrying.

--2015-09-27 18:08:29--  (try: 2)  https://contributors.debian.org/
Found contributors.debian.org in host_name_addresses_map (0x55f91c3876f0)
Connecting to contributors.debian.org
(contributors.debian.org)|2607:f8f0:610:4000:216:36ff:fe40:3861|:443...
connected.
Created socket 4.
Releasing 0x000055f91c3876f0 (new refcount 1).

---request begin---
GET / HTTP/1.1
User-Agent: Wget/1.16.3 (linux-gnu)
Accept: */*
Accept-Encoding: identity
Host: contributors.debian.org
Connection: Keep-Alive

---request end---
HTTP request sent, awaiting response... No data received.
Retrying.

^C
$  openssl s_client -connect contributors.debian.org:443
CONNECTED(00000003)
depth=3 C = SE, O = AddTrust AB, OU = AddTrust External TTP Network, CN =
AddTrust External CA Root
verify return:1
depth=2 C = US, ST = New Jersey, L = Jersey City, O = The USERTRUST Network,
CN = USERTrust RSA Certification Authority
verify return:1
depth=1 C = FR, ST = Paris, L = Paris, O = Gandi, CN = Gandi Standard SSL CA
2
verify return:1
depth=0 OU = Domain Control Validated, OU = Gandi Standard SSL, CN =
contributors.debian.org
verify return:1
---
Certificate chain
 0 s:/OU=Domain Control Validated/OU=Gandi Standard
SSL/CN=contributors.debian.org
   i:/C=FR/ST=Paris/L=Paris/O=Gandi/CN=Gandi Standard SSL CA 2
 1 s:/C=FR/ST=Paris/L=Paris/O=Gandi/CN=Gandi Standard SSL CA 2
   i:/C=US/ST=New Jersey/L=Jersey City/O=The USERTRUST Network/CN=USERTrust
RSA Certification Authority
 2 s:/C=US/ST=New Jersey/L=Jersey City/O=The USERTRUST Network/CN=USERTrust
RSA Certification Authority
   i:/C=SE/O=AddTrust AB/OU=AddTrust External TTP Network/CN=AddTrust External
CA Root
---
Server certificate
-----BEGIN CERTIFICATE-----
MIIFlDCCBHygAwIBAgIQMfAlgnw3Yfda6FqlD6XUlzANBgkqhkiG9w0BAQsFADBf
MQswCQYDVQQGEwJGUjEOMAwGA1UECBMFUGFyaXMxDjAMBgNVBAcTBVBhcmlzMQ4w
DAYDVQQKEwVHYW5kaTEgMB4GA1UEAxMXR2FuZGkgU3RhbmRhcmQgU1NMIENBIDIw
HhcNMTQxMjE3MDAwMDAwWhcNMTUxMjMxMjM1OTU5WjBiMSEwHwYDVQQLExhEb21h
aW4gQ29udHJvbCBWYWxpZGF0ZWQxGzAZBgNVBAsTEkdhbmRpIFN0YW5kYXJkIFNT
TDEgMB4GA1UEAxMXY29udHJpYnV0b3JzLmRlYmlhbi5vcmcwggGiMA0GCSqGSIb3
DQEBAQUAA4IBjwAwggGKAoIBgQDTUXqPGAz+wN+C/uGBpsJoGF16/fFufYMSBJp1
z6w8cgYP6KLeDLO+ApWEyvAUJXCrzGx6MwGZDBttMQb4w4/4hqAYApywbSUydPqZ
nx0W7//kI/EejBG/2NIN8cy4xVB7D4m8S3RZaF1SSEDvcofE1niSXbIjQGtSu6Ko
ZNPfiu4iV1ROLx45jmbMYphEUc9xxD3SnDYXDKcBLd0y37AeP7D878dqa+rZ4H+r
tAo9iaazyQECHNUeIE8Y5ASngspxArtfURyQswR36p5uARwjPtgUtYbrA35KMiUg
HgFSViocuMtHKW53QJUqTvHr6KtLSiL7J9ySx12DGBa97Lj0iV5zyyq4uRP0h1qy
rOiGnxiGeKf+9sRm+kZKO2/1tjNc9m9BDPJ9tH+cD1bkW+ZRVze/HPHsnzFVH84m
jYKImSvh9Ptpt282W1XPoHGPgg+WX4Q5b3cmLzQsivitjevXp9eaH0j4QAMa8Noa
GF72ZctDZcXXQjuXnDSI9k8g60kCAwEAAaOCAccwggHDMB8GA1UdIwQYMBaAFLOQ
p9jJr07NYTyffK1df0H9aTDqMB0GA1UdDgQWBBSu8itYsZ8cGTjya4lZxPGr4wli
dTAOBgNVHQ8BAf8EBAMCBaAwDAYDVR0TAQH/BAIwADAdBgNVHSUEFjAUBggrBgEF
BQcDAQYIKwYBBQUHAwIwSwYDVR0gBEQwQjA2BgsrBgEEAbIxAQICGjAnMCUGCCsG
AQUFBwIBFhlodHRwczovL2Nwcy51c2VydHJ1c3QuY29tMAgGBmeBDAECATBBBgNV
HR8EOjA4MDagNKAyhjBodHRwOi8vY3JsLnVzZXJ0cnVzdC5jb20vR2FuZGlTdGFu
ZGFyZFNTTENBMi5jcmwwcwYIKwYBBQUHAQEEZzBlMDwGCCsGAQUFBzAChjBodHRw
Oi8vY3J0LnVzZXJ0cnVzdC5jb20vR2FuZGlTdGFuZGFyZFNTTENBMi5jcnQwJQYI
KwYBBQUHMAGGGWh0dHA6Ly9vY3NwLnVzZXJ0cnVzdC5jb20wPwYDVR0RBDgwNoIX
Y29udHJpYnV0b3JzLmRlYmlhbi5vcmeCG3d3dy5jb250cmlidXRvcnMuZGViaWFu
Lm9yZzANBgkqhkiG9w0BAQsFAAOCAQEAXU77+xxyEFoKFyfb50Qg5j311zMLIfXW
T/Rn8Ffjiz7PQS+UwidXS3RY/D3Sx+zQhhzf0cWc00Ida9z5fYPNscWefpq5DJ0L
P4PfH8RS5kN94pQNoYLjsL9T8GYzpJdmYgs2uOswMYHZNy71Or5miNZQ+tE3xJZi
KlfjLC63nFILEkmVXF0PnTfuIHrw47edbLYewxR759hXHS3zA8rqgGnAkVCh8IzN
vqYgfhbio1fFDxSnsInPl48Z9ewHbBR5VEBrEjXVxwneodYZRwB7S1SCyccczwV2
3qfolqlrmg135rx7iCH5TpKhTnknQwJeWxUMQmqDKPoIIypnY0VyXw==
-----END CERTIFICATE-----
subject=/OU=Domain Control Validated/OU=Gandi Standard
SSL/CN=contributors.debian.org
issuer=/C=FR/ST=Paris/L=Paris/O=Gandi/CN=Gandi Standard SSL CA 2
---
No client certificate CA names sent
Peer signing digest: SHA512
Server Temp Key: ECDH, P-256, 256 bits
---
SSL handshake has read 5177 bytes and written 441 bytes
---
New, TLSv1/SSLv3, Cipher is ECDHE-RSA-AES256-GCM-SHA384
Server public key is 3072 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
No ALPN negotiated
SSL-Session:
    Protocol  : TLSv1.2
    Cipher    : ECDHE-RSA-AES256-GCM-SHA384
    Session-ID:
C294DC945A410D580AADFB9254CC0D33B6CB1220CCE2522E86559AF90F93B1A8
    Session-ID-ctx: 
    Master-Key:
BE0C2D1DCCB7F7FBCB6CC7A960456BC10F98CDD7C0AD9B154567D5C768DAA4D9137FC1F17F71D1186BA1825AB0DC19BB
    Key-Arg   : None
    PSK identity: None
    PSK identity hint: None
    SRP username: None
    TLS session ticket lifetime hint: 300 (seconds)
    TLS session ticket:
    0000 - 1a f3 8c 98 3a a9 fc 8c-be 32 c1 42 e9 b3 2c 61   ....:....2.B..,a
    0010 - 0b 0d f1 14 dc d5 3f 5d-4c 78 4e a3 d3 1f 5c 8e   ......?]LxN...\.
    0020 - bf f4 5e 25 61 0b 4d 4f-49 fb a1 5d 19 31 70 30   ..^%a.MOI..].1p0
    0030 - 98 37 1b fc 25 e2 88 51-0f c5 a8 3b 3d b5 6c e9   .7..%..Q...;=.l.
    0040 - 9c 0b 7d 18 d1 5d e0 9a-02 65 9d 79 42 41 3d b5   ..}..]...e.yBA=.
    0050 - b6 57 1d b5 7d 0f 2c 00-21 c0 5c da 52 92 15 16   .W..}.,.!.\.R...
    0060 - 46 f2 2b 54 6b 2c 99 08-e2 a3 cc fa 62 d8 28 8e   F.+Tk,......b.(.
    0070 - 7d 3f 2e 50 3e 63 91 6c-5a 99 39 04 2c 26 09 4d   }?.P>c.lZ.9.,&.M
    0080 - aa ae 9b 33 76 34 ea 39-e9 f5 f7 b2 4e 3f f0 b5   ...3v4.9....N?..
    0090 - 2c 75 96 b9 4c 68 47 56-e5 76 ea 50 13 1e 4f 5b   ,u..LhGV.v.P..O[
    00a0 - be cf 1f 8b 9a 4c c2 45-9c 72 a9 fa 70 81 44 9d   .....L.E.r..p.D.
    00b0 - 9c 04 b0 94 fb 72 e3 ea-a9 73 15 b6 ba fb 8c 98   .....r...s......

    Start Time: 1443370323
    Timeout   : 300 (sec)
    Verify return code: 0 (ok)
---





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46061>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/

Message #15 received at 797057@bugs.debian.org (full text, mbox, reply):

From: Noël Köthe <noel@debian.org>

To: Enrico Zini <enrico@debian.org>, 797057@bugs.debian.org

Subject: Re: Bug#797057: wget https://contributors.debian.org fails with "No data received."

Date: Sun, 27 Sep 2015 18:20:15 +0200

[Message part 1 (text/plain, inline)]

Control: tags -1 + upstream
Control: forwarded -1 https://savannah.gnu.org/bugs/?46061

Hello Enrico,

Am Donnerstag, den 27.08.2015, 15:37 +0200 schrieb Enrico Zini:

> thank you for maintaining wget. A simple
> wget https://contributors.debian.org currently fails:
>
>   $ wget https://contributors.debian.org
>   --2015-08-27 15:34:30--  https://contributors.debian.org/
...
>   HTTP request sent, awaiting response... No data received.
>   Retrying.
...
> We currently added "SSLVerifyClient optional" to the server
> configuration to support authentication with client certificates, but
> client certificates are not required to connect. The relevant apache
> configuration is here:
> 
>   https://wiki.debian.org/DebianSingleSignOn#Documentation_for_web_ap
> plication_owners-1
> 
> curl can access the site.

Thx for your report. I forwarded it to the upstream bugtracker.

Regards

	Noël

[signature.asc (application/pgp-signature, inline)]

Message #24 received at 797057@bugs.debian.org (full text, mbox, reply):

From: Ángel <INVALID.NOREPLY@gnu.org>

To: NoëlKöthe <noel@debian.org>, 797057@bugs.debian.org, Ángel <savannah@bugs.16bits.net>, gscrivano@gnu.org, darnir@gmail.com, tim.ruehsen@gmx.de, bug-wget@gnu.org

Subject: [bug #46061] wget https://contributors.debian.org fails with "No data received."

Date: Sun, 27 Sep 2015 18:44:39 +0000

Follow-up Comment #1, bug #46061 (project wget):

wget in debian is using gnutls. Compiling wget using --with-ssl=openssl
doesn't exhibit this bug. gnutls-cli contributors.debian.org works, though.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46061>

_______________________________________________
  Mensaje enviado vía/por Savannah
  http://savannah.gnu.org/

Message #29 received at 797057@bugs.debian.org (full text, mbox, reply):

From: Tim Ruehsen <INVALID.NOREPLY@gnu.org>

To: NoëlKöthe <noel@debian.org>, 797057@bugs.debian.org, Tim Ruehsen <tim.ruehsen@gmx.de>, Ángel <savannah@bugs.16bits.net>, gscrivano@gnu.org, darnir@gmail.com, bug-wget@gnu.org

Subject: [bug #46061] wget https://contributors.debian.org fails with "No data received."

Date: Sun, 27 Sep 2015 20:03:54 +0000

Follow-up Comment #2, bug #46061 (project wget):

Wget is not reacting on GNUTLS_E_REHANDSHAKE. Should be straight forward...


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46061>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/

Message #34 received at 797057@bugs.debian.org (full text, mbox, reply):

From: Tim Ruehsen <tim.ruehsen@gmx.de>

To: bug-wget@gnu.org

Cc: Tim Ruehsen <INVALID.NOREPLY@gnu.org>, NoëlKöthe <noel@debian.org>, 797057@bugs.debian.org, Ángel <savannah@bugs.16bits.net>, gscrivano@gnu.org, darnir@gmail.com

Subject: [PATCH] [bug #46061] wget https://contributors.debian.org fails with "No data received."

Date: Mon, 28 Sep 2015 12:14:04 +0200

[Message part 1 (text/plain, inline)]

Please review / test this patch.

BTW, I am not sure if contributors.debian.org is configured correctly.
The rehandshake occurs right after the HTTP request and it has a pretty heavy  
impact on download duration.

Regards, Tim

On Sunday 27 September 2015 20:03:54 Tim Ruehsen wrote:
> Follow-up Comment #2, bug #46061 (project wget):
> 
> Wget is not reacting on GNUTLS_E_REHANDSHAKE. Should be straight forward...
> 
> 
>     _______________________________________________________
> 
> Reply to this item at:
> 
>   <http://savannah.gnu.org/bugs/?46061>
> 
> _______________________________________________
>   Nachricht gesendet von/durch Savannah
>   http://savannah.gnu.org/

[0001-Handle-TLS-rehandshakes-in-GnuTLS-code.patch (text/x-patch, attachment)]

Message #39 received at 797057@bugs.debian.org (full text, mbox, reply):

From: Giuseppe Scrivano <INVALID.NOREPLY@gnu.org>

To: Giuseppe Scrivano <gscrivano@gnu.org>, NoëlKöthe <noel@debian.org>, 797057@bugs.debian.org, Tim Ruehsen <tim.ruehsen@gmx.de>, Ángel <savannah@bugs.16bits.net>, darnir@gmail.com, bug-wget@gnu.org

Subject: [bug #46061] wget https://contributors.debian.org fails with "No data received."

Date: Mon, 28 Sep 2015 11:11:30 +0000

Follow-up Comment #3, bug #46061 (project wget):

Good analysis Tim!  I have attacheda patch that solves the problem for me

(file #35002)
    _______________________________________________________

Additional Item Attachment:

File name: 0001-gnutls-honor-error-GNUTLS_E_REHANDSHAKE.patch Size:4 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46061>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

Message #44 received at 797057@bugs.debian.org (full text, mbox, reply):

From: Tim Ruehsen <INVALID.NOREPLY@gnu.org>

To: Giuseppe Scrivano <gscrivano@gnu.org>, NoëlKöthe <noel@debian.org>, 797057@bugs.debian.org, Tim Ruehsen <tim.ruehsen@gmx.de>, Ángel <savannah@bugs.16bits.net>, darnir@gmail.com, bug-wget@gnu.org

Subject: [bug #46061] wget https://contributors.debian.org fails with "No data received."

Date: Mon, 28 Sep 2015 12:17:17 +0000

Follow-up Comment #4, bug #46061 (project wget):

Sorry, my patch didn't make it to the bug tracker nor to the mailing list nor
to you !? Interesting, I saw it pop up on the Debian bug tracker (and I got an
automatic reply from there).
I attach it here for comparison with your patch.


(file #35003)
    _______________________________________________________

Additional Item Attachment:

File name: 0001-Handle-TLS-rehandshakes-in-GnuTLS-code.patch Size:6 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46061>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

Message #49 received at 797057@bugs.debian.org (full text, mbox, reply):

From: Giuseppe Scrivano <gscrivano@gnu.org>

To: Tim Ruehsen <tim.ruehsen@gmx.de>

Cc: bug-wget@gnu.org, NoëlKöthe <noel@debian.org>, 797057@bugs.debian.org, Ángel <savannah@bugs.16bits.net>, darnir@gmail.com

Subject: Re: [PATCH] [bug #46061] wget https://contributors.debian.org fails with "No data received."

Date: Mon, 28 Sep 2015 15:03:11 +0200

Tim Ruehsen <tim.ruehsen@gmx.de> writes:

> Please review / test this patch.

we basically wrote the same patch :)

It looks fine to me, just please add a space in the function calls:

"_do_handshake(" -> "_do_handshake ("

and feel free to push it.

Regards,
Giuseppe

Message #54 received at 797057@bugs.debian.org (full text, mbox, reply):

From: Giuseppe Scrivano <gscrivano@gnu.org>

To: Tim Ruehsen <tim.ruehsen@gmx.de>

Cc: bug-wget@gnu.org, NoëlKöthe <noel@debian.org>, 797057@bugs.debian.org, Ángel <savannah@bugs.16bits.net>, darnir@gmail.com

Subject: Re: [PATCH] [bug #46061] wget https://contributors.debian.org fails with "No data received."

Date: Mon, 28 Sep 2015 15:30:33 +0200

Tim Ruehsen <tim.ruehsen@gmx.de> writes:

> Please review / test this patch.
>
> BTW, I am not sure if contributors.debian.org is configured correctly.
> The rehandshake occurs right after the HTTP request and it has a pretty heavy  
> impact on download duration.
>
> Regards, Tim
>
> On Sunday 27 September 2015 20:03:54 Tim Ruehsen wrote:
>> Follow-up Comment #2, bug #46061 (project wget):
>> 
>> Wget is not reacting on GNUTLS_E_REHANDSHAKE. Should be straight forward...
>> 
>> 
>>     _______________________________________________________
>> 
>> Reply to this item at:
>> 
>>   <http://savannah.gnu.org/bugs/?46061>
>> 
>> _______________________________________________
>>   Nachricht gesendet von/durch Savannah
>>   http://savannah.gnu.org/
>
> From cbec5b0c780f9d1fc343fabf22e8ee7c7cb3222d Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Tim=20R=C3=BChsen?= <tim.ruehsen@gmx.de>
> Date: Mon, 28 Sep 2015 12:00:33 +0200
> Subject: [PATCH] Handle TLS rehandshakes in GnuTLS code
>
> * src/gnutls.c: New static function _do_handshake()
> * src/gnutls.c (wgnutls_read_timeout): Handle rehandshake
> * src/gnutls.c (wgnutls_write): Handle rehandshake
> * src/gnutls.c (ssl_connect_wget): Move handshake code into _do_handshake()
>
> Fixes #46061
> ---
>  src/gnutls.c | 179 ++++++++++++++++++++++++++++++++++-------------------------
>  1 file changed, 102 insertions(+), 77 deletions(-)
>
> diff --git a/src/gnutls.c b/src/gnutls.c
> index a38301a..2f53592 100644
> --- a/src/gnutls.c
> +++ b/src/gnutls.c
> @@ -57,6 +57,9 @@ as that of the covered work.  */
>  #include "host.h"
>  
>  static int
> +_do_handshake(gnutls_session_t session, int fd, double timeout);
> +
> +static int
>  key_type_to_gnutls_type (enum keyfile_type type)
>  {
>    switch (type)
> @@ -277,6 +280,12 @@ wgnutls_read_timeout (int fd, char *buf, int bufsize, void *arg, double timeout)
>          {
>            ret = gnutls_record_recv (ctx->session, buf, bufsize);
>            timed_out = timeout && ptimer_measure (timer) >= timeout;
> +          if (!timed_out && ret == GNUTLS_E_REHANDSHAKE)
> +            {
> +              DEBUGP (("GnuTLS: *** REHANDSHAKE while reading\n"));
> +              if ((ret = _do_handshake(ctx->session, fd, timeout)) == 0)
> +                ret = GNUTLS_E_AGAIN; /* restart reading */
> +            }
>          }
>      }
>    while (ret == GNUTLS_E_INTERRUPTED || (ret == GNUTLS_E_AGAIN && !timed_out));
> @@ -332,7 +341,15 @@ wgnutls_write (int fd _GL_UNUSED, char *buf, int bufsize, void *arg)
>    int ret;
>    struct wgnutls_transport_context *ctx = arg;
>    do
> -    ret = gnutls_record_send (ctx->session, buf, bufsize);
> +    {
> +      ret = gnutls_record_send (ctx->session, buf, bufsize);
> +      if (ret == GNUTLS_E_REHANDSHAKE)
> +        {
> +          DEBUGP (("GnuTLS: *** REHANDSHAKE while writing\n"));
> +          if ((ret = _do_handshake(ctx->session, fd, 0)) == 0)

one thing: timeout here should be the remaining time instead of 0?

Regards,
Giuseppe

Message #59 received at 797057@bugs.debian.org (full text, mbox, reply):

From: Tim Ruehsen <tim.ruehsen@gmx.de>

To: bug-wget@gnu.org

Cc: Giuseppe Scrivano <gscrivano@gnu.org>, NoëlKöthe <noel@debian.org>, 797057@bugs.debian.org, Ángel <savannah@bugs.16bits.net>, darnir@gmail.com

Subject: Re: [PATCH] [bug #46061] wget https://contributors.debian.org fails with "No data received."

Date: Mon, 28 Sep 2015 15:46:11 +0200

On Monday 28 September 2015 15:30:33 Giuseppe Scrivano wrote:
> Tim Ruehsen <tim.ruehsen@gmx.de> writes:
> > Please review / test this patch.
> > 
> > BTW, I am not sure if contributors.debian.org is configured correctly.
> > The rehandshake occurs right after the HTTP request and it has a pretty
> > heavy impact on download duration.
> > 
> > Regards, Tim
> > 
> > On Sunday 27 September 2015 20:03:54 Tim Ruehsen wrote:
> >> Follow-up Comment #2, bug #46061 (project wget):
> >> 
> >> Wget is not reacting on GNUTLS_E_REHANDSHAKE. Should be straight
> >> forward...
> >> 
> >>     _______________________________________________________
> >> 
> >> Reply to this item at:
> >>   <http://savannah.gnu.org/bugs/?46061>
> >> 
> >> _______________________________________________
> >> 
> >>   Nachricht gesendet von/durch Savannah
> >>   http://savannah.gnu.org/
> > 
> > From cbec5b0c780f9d1fc343fabf22e8ee7c7cb3222d Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Tim=20R=C3=BChsen?= <tim.ruehsen@gmx.de>
> > Date: Mon, 28 Sep 2015 12:00:33 +0200
> > Subject: [PATCH] Handle TLS rehandshakes in GnuTLS code
> > 
> > * src/gnutls.c: New static function _do_handshake()
> > * src/gnutls.c (wgnutls_read_timeout): Handle rehandshake
> > * src/gnutls.c (wgnutls_write): Handle rehandshake
> > * src/gnutls.c (ssl_connect_wget): Move handshake code into
> > _do_handshake()
> > 
> > Fixes #46061
> > ---
> > 
> >  src/gnutls.c | 179
> >  ++++++++++++++++++++++++++++++++++------------------------- 1 file
> >  changed, 102 insertions(+), 77 deletions(-)
> > 
> > diff --git a/src/gnutls.c b/src/gnutls.c
> > index a38301a..2f53592 100644
> > --- a/src/gnutls.c
> > +++ b/src/gnutls.c
> > @@ -57,6 +57,9 @@ as that of the covered work.  */
> > 
> >  #include "host.h"
> >  
> >  static int
> > 
> > +_do_handshake(gnutls_session_t session, int fd, double timeout);
> > +
> > +static int
> > 
> >  key_type_to_gnutls_type (enum keyfile_type type)
> >  {
> >  
> >    switch (type)
> > 
> > @@ -277,6 +280,12 @@ wgnutls_read_timeout (int fd, char *buf, int bufsize,
> > void *arg, double timeout)> 
> >          {
> >          
> >            ret = gnutls_record_recv (ctx->session, buf, bufsize);
> >            timed_out = timeout && ptimer_measure (timer) >= timeout;
> > 
> > +          if (!timed_out && ret == GNUTLS_E_REHANDSHAKE)
> > +            {
> > +              DEBUGP (("GnuTLS: *** REHANDSHAKE while reading\n"));
> > +              if ((ret = _do_handshake(ctx->session, fd, timeout)) == 0)
> > +                ret = GNUTLS_E_AGAIN; /* restart reading */
> > +            }
> > 
> >          }
> >      
> >      }
> >    
> >    while (ret == GNUTLS_E_INTERRUPTED || (ret == GNUTLS_E_AGAIN &&
> >    !timed_out));> 
> > @@ -332,7 +341,15 @@ wgnutls_write (int fd _GL_UNUSED, char *buf, int
> > bufsize, void *arg)> 
> >    int ret;
> >    struct wgnutls_transport_context *ctx = arg;
> >    do
> > 
> > -    ret = gnutls_record_send (ctx->session, buf, bufsize);
> > +    {
> > +      ret = gnutls_record_send (ctx->session, buf, bufsize);
> > +      if (ret == GNUTLS_E_REHANDSHAKE)
> > +        {
> > +          DEBUGP (("GnuTLS: *** REHANDSHAKE while writing\n"));
> > +          if ((ret = _do_handshake(ctx->session, fd, 0)) == 0)
> 
> one thing: timeout here should be the remaining time instead of 0?

wgnutls_write is called without timeout. So, what can we do here ?

But maybe we don't have to check for GNUTLS_E_REHANDSHAKE at this point at 
all. Regarding 
http://www.gnutls.org/manual/html_node/Re_002dauthentication.html, only 
gnutls_record_recv() returns GNUTLS_E_REHANDSHAKE.

If you don't mind, I'll remove the rehandshake code from wgnutls_write().

Tim

Message #64 received at 797057@bugs.debian.org (full text, mbox, reply):

From: Giuseppe Scrivano <gscrivano@gnu.org>

To: Tim Ruehsen <tim.ruehsen@gmx.de>

Cc: bug-wget@gnu.org, NoëlKöthe <noel@debian.org>, 797057@bugs.debian.org, Ángel <savannah@bugs.16bits.net>, darnir@gmail.com

Subject: Re: [PATCH] [bug #46061] wget https://contributors.debian.org fails with "No data received."

Date: Mon, 28 Sep 2015 16:05:39 +0200

Tim Ruehsen <tim.ruehsen@gmx.de> writes:

> wgnutls_write is called without timeout. So, what can we do here ?
>
> But maybe we don't have to check for GNUTLS_E_REHANDSHAKE at this point at 
> all. Regarding 
> http://www.gnutls.org/manual/html_node/Re_002dauthentication.html, only 
> gnutls_record_recv() returns GNUTLS_E_REHANDSHAKE.
>
> If you don't mind, I'll remove the rehandshake code from wgnutls_write().

yes, if it cannot return that error code, please drop the code that
checks for it.

Regards,
Giuseppe

Message #69 received at 797057@bugs.debian.org (full text, mbox, reply):

From: Tim Ruehsen <tim.ruehsen@gmx.de>

To: bug-wget@gnu.org

Cc: Giuseppe Scrivano <gscrivano@gnu.org>, NoëlKöthe <noel@debian.org>, 797057@bugs.debian.org, Ángel <savannah@bugs.16bits.net>, darnir@gmail.com

Subject: Re: [PATCH] [bug #46061] wget https://contributors.debian.org fails with "No data received."

Date: Mon, 28 Sep 2015 16:23:01 +0200

On Monday 28 September 2015 16:05:39 Giuseppe Scrivano wrote:
> Tim Ruehsen <tim.ruehsen@gmx.de> writes:
> > wgnutls_write is called without timeout. So, what can we do here ?
> > 
> > But maybe we don't have to check for GNUTLS_E_REHANDSHAKE at this point at
> > all. Regarding
> > http://www.gnutls.org/manual/html_node/Re_002dauthentication.html, only
> > gnutls_record_recv() returns GNUTLS_E_REHANDSHAKE.
> > 
> > If you don't mind, I'll remove the rehandshake code from wgnutls_write().
> 
> yes, if it cannot return that error code, please drop the code that
> checks for it.

At least it is not explicitly documented. I removed the code from 
wgnutls_write() and pushed the patch.

Regards, Tim

Message #74 received at 797057@bugs.debian.org (full text, mbox, reply):

From: Tim Ruehsen <INVALID.NOREPLY@gnu.org>

To: Giuseppe Scrivano <gscrivano@gnu.org>, NoëlKöthe <noel@debian.org>, 797057@bugs.debian.org, Tim Ruehsen <tim.ruehsen@gmx.de>, Ángel <savannah@bugs.16bits.net>, darnir@gmail.com, bug-wget@gnu.org

Subject: [bug #46061] wget https://contributors.debian.org fails with "No data received."

Date: Mon, 28 Sep 2015 14:24:17 +0000

Update of bug #46061 (project wget):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => Closed                 


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46061>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/

Message #81 received at 797057-close@bugs.debian.org (full text, mbox, reply):

From: Noël Köthe <noel@debian.org>

To: 797057-close@bugs.debian.org

Subject: Bug#797057: fixed in wget 1.17-1

Date: Tue, 17 Nov 2015 21:45:18 +0000

Source: wget
Source-Version: 1.17-1

We believe that the bug you reported is fixed in the latest version of
wget, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 797057@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Noël Köthe <noel@debian.org> (supplier of updated wget package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 17 Nov 2015 21:04:26 +0100
Source: wget
Binary: wget
Architecture: source amd64
Version: 1.17-1
Distribution: unstable
Urgency: medium
Maintainer: Noël Köthe <noel@debian.org>
Changed-By: Noël Köthe <noel@debian.org>
Description:
 wget       - retrieves files from the web
Closes: 633703 797057 799964
Changes:
 wget (1.17-1) unstable; urgency=medium
 .
   * new upstream relase from 2015-11-16
     - fixed IP address exposure in FTP code. closes: #799964
     - fixed not reacting on GNUTLS_E_REHANDSHAKE closes: #797057
     - make --convert-links messages more clear closes: #633703
Checksums-Sha1:
 1517d937adef0bd986230bb8b4c4153421106eff 1780 wget_1.17-1.dsc
 ebb8df8ee6a0c2d11be9e250cae55d8502bc1ee6 3779445 wget_1.17.orig.tar.gz
 821e9e9b203825408309fc92b0b5d03055d77eb3 19588 wget_1.17-1.debian.tar.xz
 6425fd5d249cc65b87d693e60cb6160308555bbe 773112 wget_1.17-1_amd64.deb
Checksums-Sha256:
 cb9ebcbb05df9872052dc6ed4e4449c1faec6a97ff594a0fb5f87a822e3d8a2b 1780 wget_1.17-1.dsc
 3e04ad027c5b6ebd67c616eec13e66fbedb3d4d8cbe19cc29dadde44b92bda55 3779445 wget_1.17.orig.tar.gz
 24b8b03d2ca1f68bd8769b73aebe2ef47570488d63cd535730cf1ce9fa0b10e8 19588 wget_1.17-1.debian.tar.xz
 ae24f347e25d70660309d67831c2318818e1580cda9715ee3e728d97101d61d0 773112 wget_1.17-1_amd64.deb
Files:
 b245329e778d179bfa8126a63372ccad 1780 web important wget_1.17-1.dsc
 c4c4727766f24ac716936275014a0536 3779445 web important wget_1.17.orig.tar.gz
 1df97a521654c1a03774846b8c7a0cc1 19588 web important wget_1.17-1.debian.tar.xz
 2a50d6acd3497860f12960277dee523c 773112 web important wget_1.17-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWS4qSAAoJEGjAeL6I+Aza+pUQAJ++KFcqQC+m/LamVtMhmZAE
z6IZ260jd/KUKO9lVMey7R19q7rLFgSj5oghoCwAm1BgS8QxJbCPdz2TBHxUFTH1
OXqwmG+vuiFLdVMznwNabCrPA8V1p5SOcAp7qxI8JMSXGlsAUEp8PmSOkU85GkSd
dMggyhSlGsbkwPu+OfOxeF6yJ6qeQU5D9NvxfF02Dw/olBngkE/6x1uKohGXg+oE
/NQa6G5w9plLPaWvEq5903XqStZb5TpVZ6wpfNukkOpvokFK8/Mz0u7003yRfygb
RlliryifNnwb0Hsb6zlzHkk8OkvihwqHD/uANv1dcnL2SPPdnKp+DTGZHEkAchE0
b4IMd6FkOaXLswaCztRIHN2gMMAnGErvY95ld0Jn12LTA1yA+NzLXicP8Qg/yMCl
x6x9FS1v00FClFY5V03rFymmGjwPhcR8wZkqFZVSkA0+grtHqCIUfaMexoWAIpCV
VnENqmOwKvg39lsLom5zVMIk1HaW15h/VEoT7aXF0EcMSzXImWXkCDNE7BrpVylE
M4HfH4Do0Xj5+gMWTVPU8GKJvMxhaZ5yxIz8AwHkuxDc6Sgb9b66D2RQgxaaT85u
ptFCXBl+/bldu2oVoR1PxuawZ7El7JBz2qlHlh5+iFvtchzparYAD0wF2B1H701R
EKff1nvaBpb5Br/qqRRN
=M0eM
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.