Debian Bug report logs - #796466
pepper: FTBFS: error: ‘svn_sort__hash’ was not declared in this scope

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris West (Faux)" <solo-debianbugs@goeswhere.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: pepper: FTBFS: error: ‘svn_sort__hash’ was not declared in this scope

Date: Fri, 21 Aug 2015 22:13:46 +0100

Source: pepper
Version: 0.3.2-3
Severity: serious
Justification: fails to build from source
Tags: sid
User: reproducible-builds@lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-CC: reproducible-builds@lists.alioth.debian.org

Dear Maintainer,

The package fails to build:

backends/subversion.cpp: In member function ‘virtual std::vector<Tag> SubversionBackend::tags()’:
backends/subversion.cpp:829:94: error: ‘svn_sort__hash’ was not declared in this scope
  apr_array_header_t *array = svn_sort__hash(dirents, &svn_sort_compare_items_lexically,  pool);
                                                                                              ^
In file included from /usr/include/subversion-1/svn_client.h:37:0,
                 from backends/subversion.cpp:22:
/usr/include/apr-1.0/apr_tables.h:141:59: error: invalid use of incomplete type ‘struct svn_sort__item_t’
 #define APR_ARRAY_IDX(ary,i,type) (((type *)(ary)->elts)[i])
                                                           ^
backends/subversion.cpp:831:29: note: in expansion of macro ‘APR_ARRAY_IDX’
   svn_sort__item_t *item = &APR_ARRAY_IDX(array, i, svn_sort__item_t);
                             ^
In file included from backends/subversion.cpp:28:0:
/usr/include/subversion-1/svn_sorts.h:55:16: note: forward declaration of ‘struct svn_sort__item_t’
 typedef struct svn_sort__item_t svn_sort__item_t;
                ^
backends/subversion.cpp:832:68: error: invalid use of incomplete type ‘svn_sort__item_t {aka struct svn_sort__item_t}’
   svn_dirent_t *dirent = (svn_dirent_t *)apr_hash_get(dirents, item->key, item->klen);
                                                                    ^
In file included from backends/subversion.cpp:28:0:
/usr/include/subversion-1/svn_sorts.h:55:16: note: forward declaration of ‘svn_sort__item_t {aka struct svn_sort__item_t}’
 typedef struct svn_sort__item_t svn_sort__item_t;
                ^

Full build log:
https://reproducible.debian.net/rb-pkg/unstable/amd64/pepper.html

-- System Information:
Debian Release: stretch/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.19.0-23-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Message #10 received at 796466@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>

To: "Chris West \(Faux\)" <solo-debianbugs@goeswhere.com>, 796466@bugs.debian.org

Cc: jonas.gehring@boolsoft.org

Subject: Re: Bug#796466: pepper: FTBFS: error: ‘svn_sort__hash’ was not declared in this scope

Date: Mon, 24 Aug 2015 14:11:43 -0400

Not sure how to fix this: it seems that pepper uses private declarations
that have been removed from libsvn in 1.9... We would need to report
this upstream, but their tracker is down:

http://sourceforge.net/tracker/?group_id=386093

I have therefore put the Pepper author in CC in the hope we will get
some help on this issue:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=796466

This seems to have affected other packages as well:

PySVN: http://svn.haxx.se/users/archive-2014-11/0018.shtml
kdevelop: http://permalink.gmane.org/gmane.comp.kde.devel.kdevelop/41364

The commit introducing the problem in libsvn is here:

http://svn.apache.org/viewvc?view=revision&revision=1555133

It indicates it could be enough to simply change the include to:
<private/svn_sorts_private.h>, but I haven't tested that.

Thanks for the bug report,

A.

-- 
Either you're with us or you're with the terrorist state.

Message #15 received at 796466@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>

To: "Chris West \(Faux\)" <solo-debianbugs@goeswhere.com>, 796466@bugs.debian.org

Cc: jonas.gehring@boolsoft.org, Jonas Gehring <jonas.gehring@kit.edu>

Subject: Re: Bug#796466: pepper: FTBFS: error: ‘svn_sort__hash’ was not declared in this scope

Date: Mon, 24 Aug 2015 22:09:16 -0400

This was fixed in pysvn by rewriting that code, which seems pretty
amazing, but could be considered a canonical way.

http://pysvn.tigris.org/source/browse/pysvn/trunk/pysvn/Extension/Source/pysvn_client_cmd_info.cpp?r1=1601&r2=1600&pathrev=1601

And I *think* this is how it was fixed in kdevelop:

https://git.reviewboard.kde.org/r/124783/diff/1#index_header

... according to this post:

http://article.gmane.org/gmane.comp.kde.devel.kdevelop/41420

Jonas, can you take a look at this? I think this is a little beyond what
I can do as the Debian package maintainer in the short term.. :)

(If this is not fixed, Pepper will be taken out of Debian stretch, the
next stable release, unfortunately.)

A.

-- 
Every one of us is, in the cosmic perspective, precious. If a human
disagrees with you, let him live. In a hundred billion galaxies, you
will not find another.  - Carl Sagan

Message #20 received at 796466@bugs.debian.org (full text, mbox, reply):

From: Jonas Gehring <jonas.gehring@boolsoft.org>

To: Antoine Beaupré <anarcat@debian.org>, "Chris West (Faux)" <solo-debianbugs@goeswhere.com>, 796466@bugs.debian.org

Cc: Jonas Gehring <jonas.gehring@kit.edu>

Subject: Re: Bug#796466: pepper: FTBFS: error: ‘svn_sort__hash’ was not declared in this scope

Date: Mon, 12 Oct 2015 22:32:38 -0700

Sorry for the huge delay here, and thanks for the report!. I could
reproduce the issue and fixed it by simply re-implementing the extract
keys + sort logic of svn_sort__hash()
(https://github.com/jgehring/pepper/commit/8b67dbf). I'll prepare a new
release soon.

Message #27 received at 796466-close@bugs.debian.org (full text, mbox, reply):

From: Antoine Beaupré <anarcat@debian.org>

To: 796466-close@bugs.debian.org

Subject: Bug#796466: fixed in pepper 0.3.3-1

Date: Tue, 15 Dec 2015 05:31:35 +0000

Source: pepper
Source-Version: 0.3.3-1

We believe that the bug you reported is fixed in the latest version of
pepper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 796466@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Antoine Beaupré <anarcat@debian.org> (supplier of updated pepper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 14 Dec 2015 21:39:58 -0500
Source: pepper
Binary: pepper
Architecture: source amd64
Version: 0.3.3-1
Distribution: unstable
Urgency: medium
Maintainer: Antoine Beaupré <anarcat@debian.org>
Changed-By: Antoine Beaupré <anarcat@debian.org>
Description:
 pepper     - Source code repository statistics and report tool
Closes: 796466
Changes:
 pepper (0.3.3-1) unstable; urgency=medium
 .
   * New upstream release (Closes: #796466)
   * Update standards version to 3.9.6, no change
   * Update watch and homepage URLs to follow upstream move to github
   * Drop ld --as-needed patch, integrated upstream
Checksums-Sha1:
 2f671184a202966463c986e8bb6c06e1ffe39860 1969 pepper_0.3.3-1.dsc
 a62447794801dbb4027943da5d1d7127a68bc677 189564 pepper_0.3.3.orig.tar.gz
 89c9f5e4b9adc0e3fe3d4767a233fd46baa58f7d 3368 pepper_0.3.3-1.debian.tar.xz
 1e43a73dc185cbdf9c18589c7dc702920c9fecb8 7494 pepper_0.3.3-1_amd64.deb
Checksums-Sha256:
 971bcfbdb5a2dab2979ec6141a679d33f41f4dccbe71ad4884f9ccb077f0e116 1969 pepper_0.3.3-1.dsc
 c236f63214d05bad06929f41c62e8a94cc884a6c37464c9091bd424a5169bc61 189564 pepper_0.3.3.orig.tar.gz
 11098558a626a9746030666d4e6db8ab267ab61939137800e1fd7fbc94f33b62 3368 pepper_0.3.3-1.debian.tar.xz
 e3903ae3ff9d856586eac7c6b387023fa5ebe1a04103f1430a380208e87e6e0c 7494 pepper_0.3.3-1_amd64.deb
Files:
 769b5af422a8f5a0efe2454f5ba5073e 1969 vcs optional pepper_0.3.3-1.dsc
 e7fd5611d16804fe328f03ef237644da 189564 vcs optional pepper_0.3.3.orig.tar.gz
 d93a142b92392a9557d1b1b948b032bc 3368 vcs optional pepper_0.3.3-1.debian.tar.xz
 ce5c2c0a6920633d499aa2e88f3f1b04 7494 vcs optional pepper_0.3.3-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWb5qsAAoJEHkhUlJ7dZIe1AwP/0QMSJzRtNUEYqncbRGUf3We
adspwH7YPB50LwUBOPz6r7qkcKchyRwJENL77E5/9UujbSi7+PPZrF6ff2tqjxRi
wN27+yS5z3pQ2n5Zjr6oTwtg1eNnCgXH/DVgk0zfbawfhH7s5De4HSfO1rmgJgyj
lS55L+y2cDvkcIsw9gBbBsZ+UCo7+R36r95+lDG9F210RQvGvd0rZciirAWFshpu
Kj70DdXGRUB4pIIne5Wc6AKFgvNQAuPNytmaKRtJB0ZlltAGo+YEfRMUY1yncPB5
oj082DUOQDP81jlp1y2FrdhTVx/dVvSmp64KMpBgy0DOD7sYmTJVi1+Ef6EWBqNh
C1Ba5yzvfuEEhP4+8zzi92+U+nGySHOfDmmbSIFexfym/J1NL+hJz97ATeJpnpbT
x94mB7mc+B1VlwNarq8pOPvqqgVxEfge9m9BafnTZPWr0N/73rqRBdpXzL2Zeurw
xAMz/ka7DoH/AKxGK31LF6QDXtdRhyJiQxoQYzWAha43u9tFDbNL4AOn9M9q31dq
YaU0HxEORXFhpIpFmQs9lVZgmGRBJz54r6TNJh9k6Z7avhcU/v4XS6dYUW7reZ+j
9FWPPEWNkpzNIC7C7k2o1NTNtGtYKzwNPGdewEdJEiFrxHg+LaKretzkmST9fcu3
NF1lOB7vZqxXDpEriVpu
=4C1e
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.